GNU bug report logs - #33046
pypi importer doesn't print the correct source

Previous Next

Package: guix;

Reported by: Julien Lepiller <julien <at> lepiller.eu>

Date: Mon, 15 Oct 2018 13:40:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33046 in the body.
You can then email your comments to 33046 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#33046; Package guix. (Mon, 15 Oct 2018 13:40:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Julien Lepiller <julien <at> lepiller.eu>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Mon, 15 Oct 2018 13:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: bug-guix <at> gnu.org
Subject: pypi importer doesn't print the correct source
Date: Mon, 15 Oct 2018 15:39:15 +0200
Hi, I tried to use the importer to refresh python-twisted, and got this 
source:

(uri (pypi-uri "twisted" version))

while the correct one should be

(uri (pypi-uri "Twisted" version ".tar.bz2"))




Information forwarded to bug-guix <at> gnu.org:
bug#33046; Package guix. (Sun, 31 Mar 2019 14:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 33046 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33046 <at> debbugs.gnu.org
Subject: Re: bug#33046: pypi importer doesn't print the correct source
Date: Sun, 31 Mar 2019 10:46:18 -0400
[Message part 1 (text/plain, inline)]
Hello!

Julien Lepiller <julien <at> lepiller.eu> writes:

> Hi, I tried to use the importer to refresh python-twisted, and got
> this source:
>
> (uri (pypi-uri "twisted" version))
>
> while the correct one should be
>
> (uri (pypi-uri "Twisted" version ".tar.bz2"))

I believe the attached patch fixes this :-). It's based on the patch set
attached to bug #24450 though, so that one should be reviewed/merged
first.

Here's the result, for a couple packages that were problematic in the
mixed case regards:

--8<---------------cut here---------------start------------->8---
./pre-inst-env guix import pypi Twisted

Starting download of /tmp/guix-file.BdpmRc
From https://files.pythonhosted.org/packages/5d/0e/a72d85a55761c2c3ff1cb968143a2fd5f360220779ed90e0fadf4106d4f2/Twisted-18.9.0.tar.bz2...
 …9.0.tar.bz2  2.9MiB                 1.5MiB/s 00:02 [##################] 100.0%
(package
  (name "python-twisted")
  (version "18.9.0")
  (source
    (origin
      (method url-fetch)
      (uri (pypi-uri "Twisted" version))
      (sha256
        (base32
          "15d3gmkrg8g27hyd6ihawv2y2dv5gnpyg67wy9npgbl4pz3f4jr9"))))
  (build-system python-build-system)
  (propagated-inputs
    `(("python-attrs" ,python-attrs)
      ("python-automat" ,python-automat)
      ("python-constantly" ,python-constantly)
      ("python-hyperlink" ,python-hyperlink)
      ("python-incremental" ,python-incremental)
      ("python-pyhamcrest" ,python-pyhamcrest)
      ("python-zope.interface" ,python-zope.interface)))
  (native-inputs
    `(("python-pydoctor" ,python-pydoctor)
      ("python-pyflakes" ,python-pyflakes)
      ("python-sphinx" ,python-sphinx)
      ("python-subunit" ,python-subunit)
      ("python-towncrier" ,python-towncrier)
      ("python-twisted-dev-tools"
       ,python-twisted-dev-tools)
      ("python-twistedchecker" ,python-twistedchecker)))
  (home-page "http://twistedmatrix.com/")
  (synopsis
    "An asynchronous networking framework written in Python")
  (description
    "An asynchronous networking framework written in Python")
  (license license:expat))
--8<---------------cut here---------------end--------------->8---


--8<---------------cut here---------------start------------->8---
./pre-inst-env guix import pypi uWSGI

Starting download of /tmp/guix-file.TNSMx7
From https://files.pythonhosted.org/packages/e7/1e/3dcca007f974fe4eb369bf1b8629d5e342bb3055e2001b2e5340aaefae7a/uwsgi-2.0.18.tar.gz...
 ….18.tar.gz  783KiB                  751KiB/s 00:01 [##################] 100.0%
guix import: warning: Cannot guess requirements from source archive: no requires.txt file found.
(package
  (name "python-uwsgi")
  (version "2.0.18")
  (source
    (origin
      (method url-fetch)
      (uri (pypi-uri "uwsgi" version))
      (sha256
        (base32
          "10zmk4npknigmbqcq1wmhd461dk93159px172112vyq0i19sqwj9"))))
  (build-system python-build-system)
  (home-page
    "https://uwsgi-docs.readthedocs.io/en/latest/")
  (synopsis "The uWSGI server")
  (description "The uWSGI server")
  (license #f))
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
./pre-inst-env guix import pypi Deprecated

Starting download of /tmp/guix-file.cHmIDG
From https://files.pythonhosted.org/packages/2c/6a/f7c9d1db90d758a9dc21daaa5660a01b3ab22ca56533f6a62b24c0d113e6/Deprecated-1.2.5.tar.gz...
 …1.2.5.tar.gz  4.8MiB                1.2MiB/s 00:04 [##################] 100.0%

Starting download of /tmp/guix-file.Yj88Cr
From https://files.pythonhosted.org/packages/9f/7a/003fa432f1e45625626549726c2fbb7a29baa764e9d1fdb2323a5d779f8a/Deprecated-1.2.5-py2.py3-none-any.whl...
 …y2.py3-none-any.whl  8KiB           2.1MiB/s 00:00 [##################] 100.0%
(package
  (name "python-deprecated")
  (version "1.2.5")
  (source
    (origin
      (method url-fetch)
      (uri (pypi-uri "Deprecated" version))
      (sha256
        (base32
          "0mw5hv0bci5lzzi7ip62vm1ivmxhqj7zwc557p7iyjz3xsq3wa9g"))))
  (build-system python-build-system)
  (propagated-inputs
    `(("python-wrapt" ,python-wrapt)))
  (native-inputs
    `(("python-bumpversion" ,python-bumpversion)
      ("python-pytest" ,python-pytest)
      ("python-pytest-cov" ,python-pytest-cov)
      ("python-sphinx" ,python-sphinx)
      ("python-tox" ,python-tox)))
  (home-page
    "https://github.com/tantale/deprecated")
  (synopsis
    "Python @deprecated decorator to deprecate old python classes, functions or methods.")
  (description
    "Python @deprecated decorator to deprecate old python classes, functions or methods.")
  (license license:expat))
--8<---------------cut here---------------end--------------->8---

[0001-import-pypi-Preserve-package-name-case-when-forming-.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
Maxim

Added tag(s) patch. Request was from Maxim Cournoyer <maxim.cournoyer <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 31 Mar 2019 14:47:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-guix <at> gnu.org:
bug#33046; Package guix. (Mon, 01 Apr 2019 00:15:02 GMT) Full text and rfc822 format available.

Message #13 received at 33046 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33046 <at> debbugs.gnu.org
Subject: [PATCH v2] bug#33046: pypi importer doesn't print the correct source
Date: Sun, 31 Mar 2019 20:14:46 -0400
[Message part 1 (text/plain, inline)]
Hello,

I just noticed that by changing the PyPI URL, the PyPI updater coverage
had gone from 15.3% to 0%!  Luckily, the fix was trivial and is included
in my v2 patch (attached).

[0001-v2-import-pypi-Preserve-package-name-case-when-forming-.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, inline)]

Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Tue, 02 Jul 2019 02:07:01 GMT) Full text and rfc822 format available.

Notification sent to Julien Lepiller <julien <at> lepiller.eu>:
bug acknowledged by developer. (Tue, 02 Jul 2019 02:07:02 GMT) Full text and rfc822 format available.

Message #18 received at 33046-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 33046-done <at> debbugs.gnu.org
Subject: Re: Status: pypi importer doesn't print the correct source
Date: Tue, 02 Jul 2019 11:06:35 +0900
Fixed per commit 4b60ab8c006964d026dee8cf5f1260eba0b2bb81. Closing.

Thanks!

Maxim




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 30 Jul 2019 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 243 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.