GNU bug report logs - #33117
26.1; Scheme mode: Support lacking for imenu and indentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33117 in the body.
You can then email your comments to 33117 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Scheme mode: Support lacking for imenu and indentation
Date: Mon, 22 Oct 2018 17:54:33 +0200

I've noticed that Scheme mode is lacking some important features.
For instance, `imenu-generic-expression' does not match `define-public'.

Alex Kost has compiled a bunch of fixes:

	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el

Should we merge those changes upstream?



In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2018-10-08 built on localhost
Windowing system distributor 'The X.Org Foundation', version 11.0.12001000
Recent messages:
Sending via mail...
Sending email 
Sending email done
Mark set
Saving file /home/ambrevar/.cache/mail/mail/Sent/cur/1540223386.95e9c43d8195d02d.mimimi:2,S...
Wrote /home/ambrevar/.cache/emacs/places
Wrote /home/ambrevar/.cache/mail/mail/Sent/cur/1540223386.95e9c43d8195d02d.mimimi:2,S
Sending...done
[mu4e] Message sent
[mu4e] Found 1 matching message

Configured using:
 'configure
 CONFIG_SHELL=/gnu/store/rbrandv7anzjxqkr40d7fkanzssslk4b-bash-minimal-4.4.19/bin/bash
 SHELL=/gnu/store/rbrandv7anzjxqkr40d7fkanzssslk4b-bash-minimal-4.4.19/bin/bash
 --prefix=/gnu/store/812qcxpnjz17nbc0l3lsscma5dkjb96m-emacs-26.1
 --enable-fast-install'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GSETTINGS NOTIFY ACL
GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 THREADS

Important settings:
  value of $LANG: en_US.utf8
  locale-coding-system: utf-8-unix

<#secure method=pgpmime mode=sign>

-- 
Pierre Neidhardt
https://ambrevar.xyz/

Message #10 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1; Scheme mode: Support lacking for imenu and
 indentation
Date: Wed, 09 Oct 2019 10:23:43 +0200

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> I've noticed that Scheme mode is lacking some important features.
> For instance, `imenu-generic-expression' does not match `define-public'.
>
> Alex Kost has compiled a bunch of fixes:
>
> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>
> Should we merge those changes upstream?

That sounds like a good idea.  Perhaps somebody could contact Kost and
ask whether these enhancements could be submitted as patches to scheme.el?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: Alex Kost <alezost <at> gmail.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1;
 Scheme mode: Support lacking for imenu and indentation
Date: Wed, 09 Oct 2019 10:32:52 +0200

[Message part 1 (text/plain, inline)]

>> I've noticed that Scheme mode is lacking some important features.
>> For instance, `imenu-generic-expression' does not match `define-public'.
>>
>> Alex Kost has compiled a bunch of fixes:
>>
>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>
>> Should we merge those changes upstream?
>
> That sounds like a good idea.  Perhaps somebody could contact Kost and
> ask whether these enhancements could be submitted as patches to scheme.el?

Alex, what do you think?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1;
 Scheme mode: Support lacking for imenu and indentation
Date: Wed, 09 Oct 2019 19:00:04 +0300

Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:

>>> I've noticed that Scheme mode is lacking some important features.
>>> For instance, `imenu-generic-expression' does not match `define-public'.
>>>
>>> Alex Kost has compiled a bunch of fixes:
>>>
>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>>
>>> Should we merge those changes upstream?
>>
>> That sounds like a good idea.  Perhaps somebody could contact Kost and
>> ask whether these enhancements could be submitted as patches to scheme.el?
>
> Alex, what do you think?

Sure, if you find that file useful, please take it, I don't mind of
course.

-- 
Alex

Message #19 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Kost <alezost <at> gmail.com>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1; Scheme mode: Support lacking for imenu and
 indentation
Date: Mon, 14 Oct 2019 08:32:44 +0200

Alex Kost <alezost <at> gmail.com> writes:

> Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:
>
>>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
>>>>
>>>> Should we merge those changes upstream?
>>>
>>> That sounds like a good idea.  Perhaps somebody could contact Kost and
>>> ask whether these enhancements could be submitted as patches to scheme.el?
>>
>> Alex, what do you think?
>
> Sure, if you find that file useful, please take it, I don't mind of
> course.

Great!  To include that much code, we would need copyright assignments
for the FSF.  Would you be willing to sign that?

We'd also need somebody to create a patch out of the changes to apply to
the Emacs code base.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: alezost <at> gmail.com, mail <at> ambrevar.xyz, 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1;
 Scheme mode: Support lacking for imenu and indentation
Date: Mon, 14 Oct 2019 10:36:59 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Mon, 14 Oct 2019 08:32:44 +0200
> Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, 33117 <at> debbugs.gnu.org
> 
> Alex Kost <alezost <at> gmail.com> writes:
> 
> > Pierre Neidhardt (2019-10-09 10:32 +0200) wrote:
> >
> >>>> 	https://gitlab.com/alezost-config/emacs/blob/master/utils/al-scheme.el
> >>>>
> >>>> Should we merge those changes upstream?
> >>>
> >>> That sounds like a good idea.  Perhaps somebody could contact Kost and
> >>> ask whether these enhancements could be submitted as patches to scheme.el?
> >>
> >> Alex, what do you think?
> >
> > Sure, if you find that file useful, please take it, I don't mind of
> > course.
> 
> Great!  To include that much code, we would need copyright assignments
> for the FSF.  Would you be willing to sign that?

Alex has an assignment on file, so that part is already taken care of.

Message #25 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Kost <alezost <at> gmail.com>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, 33117 <at> debbugs.gnu.org
Subject: Re: bug#33117: 26.1; Scheme mode: Support lacking for imenu and
 indentation
Date: Sun, 23 Jan 2022 14:13:03 +0100

Alex Kost <alezost <at> gmail.com> writes:

> Sure, if you find that file useful, please take it, I don't mind of
> course.

I've now updated scheme-imenu-generic-expression from Alex's version in
Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 33117 <at> debbugs.gnu.org
Subject: Re: master 0e833a1d5f: Improve scheme-imenu-generic-expression
Date: Sun, 23 Jan 2022 14:31:46 +0000

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> branch: master
> commit 0e833a1d5f93d3028ef1ea133174636b46bc64f1
> Author: Alex Kost <alezost <at> gmail.com>
> Commit: Lars Ingebrigtsen <larsi <at> gnus.org>
>
>     Improve scheme-imenu-generic-expression
>
>     * lisp/progmodes/scheme.el (scheme-imenu-generic-expression):
>     Improve so that we match `define-public' etc (bug#33117).

BTW, I think there were also these additions, commented out below in a
WIP patch of mine wallowing on a local branch:

  @@ -156,6 +197,8 @@ scheme-mode-variables
             nil t (("+-*/.<>=!?$%_&~^:" . "w") (?#. "w 14"))
             beginning-of-defun
             (font-lock-mark-block-function . mark-defun)))
  +  ;; (setq-local font-lock-syntactic-face-function
  +  ;;             'lisp-font-lock-syntactic-face-function)
     (setq-local prettify-symbols-alist lisp-prettify-symbols-alist)
     (setq-local lisp-doc-string-elt-property 'scheme-doc-string-elt))

  @@ -359,6 +402,12 @@ scheme-sexp-comment-syntax-table
          ;; The function is called with point right after "define".
          (forward-comment (point-max))
          (if (eq (char-after) ?\() 2 0)))
  +;; (put 'define* 'scheme-doc-string-elt 2)
  +;; (put 'lambda* 'scheme-doc-string-elt 2)
  +;; (put 'case-lambda 'scheme-doc-string-elt 1)
  +;; (put 'case-lambda* 'scheme-doc-string-elt 1)
  +;; (put 'define-syntax-rule 'scheme-doc-string-elt 2)
  +;; (put 'syntax-rules 'scheme-doc-string-elt 2)

   (defun scheme-syntax-propertize (beg end)
     (goto-char beg)

I think I got stuck with the `font-lock-syntactic-face-function' part,
because IIRC, someone (maybe Stefan Monnier? I forget) had removed those
lines in an earlier patch.  And then I got distracted...

But the doc-string parts should be easy enough to add.

I'm not sure if this is something you'd want to look into or not, but I
thought I'd let you know.

Message #33 received at 33117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 33117 <at> debbugs.gnu.org
Subject: Re: master 0e833a1d5f: Improve scheme-imenu-generic-expression
Date: Mon, 24 Jan 2022 10:10:52 +0100

Stefan Kangas <stefankangas <at> gmail.com> writes:

> BTW, I think there were also these additions, commented out below in a
> WIP patch of mine wallowing on a local branch:

I'm not quite sure I understand, but:

> But the doc-string parts should be easy enough to add.
>
> I'm not sure if this is something you'd want to look into or not, but I
> thought I'd let you know.

Please do go ahead and make any improvements here you want to.  😀

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.