GNU logs - #33181, boring messages

Message sent to bug-sed@HIDDEN:

Subject: bug#33181: sed --debug: fix two problems
Resent-From: Jim Meyering <jim@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Sat, 27 Oct 2018 23:01:01 +0000
Resent-Message-ID: <handler.33181.B.154068126122599 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 33181 <at> debbugs.gnu.org
From: Jim Meyering <jim@HIDDEN>
Date: Sat, 27 Oct 2018 16:00:40 -0700
Message-ID: <lubpf37ei3ro4n.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Assaf,

I built and ran tests on a Fedora 29 beta system
and noticed a failure in the new debug test because
I'd set MALLOC_PERTURB_=13 in my environment.
That exposed what looked like a UMR bug.  I confirmed it by
running under valgrind.  Fixed by the first patch below.

Initially, I didn't even reach the offending code because
that same system lacked perl's Data::Dump module.
That is addressed by the second patch.

Thanks,
Jim

>From 2bfa7984c84caaaedcfb26a13d8c190f490d7cd0 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@HIDDEN>
Date: Sat, 27 Oct 2018 15:47:41 -0700
Subject: [PATCH 1/2] sed: avoid UMR in --debug code path

* sed/debug.c (debug_print_function) [b, t, T]: For a b, t or T
command with no LABEL, do not access uninitialized memory.
I.e., print the label name only when there is one.
---
 sed/debug.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/sed/debug.c b/sed/debug.c
index 4eedd40..9ec37b6 100644
--- a/sed/debug.c
+++ b/sed/debug.c
@@ -302,9 +302,12 @@ debug_print_function (const struct vector *program, const struct sed_cmd *sc)
     case 't':
     case 'T':
       {
-        const char *label_name = program->v[sc->x.jump_index].x.label_name;
-        if (label_name)
-          printf (" %s", label_name);
+        if (sc->x.jump_index < program->v_length)
+          {
+            const char *label_name = program->v[sc->x.jump_index].x.label_name;
+            if (label_name)
+              printf (" %s", label_name);
+          }
       }
       break;

--
2.18.0


>From 1c0866b1d34c18cfba2cfd20cc915e70fa975cbd Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@HIDDEN>
Date: Sat, 27 Oct 2018 15:53:03 -0700
Subject: [PATCH 2/2] tests: avoid unnecessary dependency on Data::Dump

* testsuite/debug.pl: Don't use Data::Dump.  Unnecessary.
That package, perl-Data-Dump, appear not to be default-installed
on at least a Fedora 29 beta system.
---
 testsuite/debug.pl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testsuite/debug.pl b/testsuite/debug.pl
index 2e4235a..661c5ed 100644
--- a/testsuite/debug.pl
+++ b/testsuite/debug.pl
@@ -18,7 +18,6 @@

 use strict;
 use File::stat;
-use Data::Dump qw(dump);

 (my $program_name = $0) =~ s|.*/||;

--
2.18.0

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Jim Meyering <jim@HIDDEN>
Subject: bug#33181: Acknowledgement (sed --debug: fix two problems)
Message-ID: <handler.33181.B.154068126122599.ack <at> debbugs.gnu.org>
References: <lubpf37ei3ro4n.fsf@HIDDEN>
X-Gnu-PR-Message: ack 33181
X-Gnu-PR-Package: sed
Reply-To: 33181 <at> debbugs.gnu.org
Date: Sat, 27 Oct 2018 23:01:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-sed@HIDDEN

If you wish to submit further information on this problem, please
send it to 33181 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
33181: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33181
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-sed@HIDDEN:

Subject: bug#33181: sed --debug: fix two problems
Resent-From: Assaf Gordon <assafgordon@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-sed@HIDDEN
Resent-Date: Sun, 28 Oct 2018 05:57:02 +0000
Resent-Message-ID: <handler.33181.B33181.154070620530690 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Jim Meyering <jim@HIDDEN>, 33181 <at> debbugs.gnu.org
References: <lubpf37ei3ro4n.fsf@HIDDEN>
From: Assaf Gordon <assafgordon@HIDDEN>
Message-ID: <e3cbe891-a2b9-5d1d-c3bc-0f1dad7ca6c0@HIDDEN>
Date: Sat, 27 Oct 2018 23:56:34 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <lubpf37ei3ro4n.fsf@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 2018-10-27 5:00 p.m., Jim Meyering wrote:
> That exposed what looked like a UMR bug.  I confirmed it by
> running under valgrind.  Fixed by the first patch below.
[...]
> Initially, I didn't even reach the offending code because
> that same system lacked perl's Data::Dump module.
> That is addressed by the second patch.

Good catch!
I should have used the new "make build-asan" to test the new debug
feature, I now see it does report similar failures.

Thanks for the quick fix, looks good.

-assaf

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.