GNU bug report logs - #33182
26.1; Support for Suckless st(simple terminal)

Previous Next

Package: emacs;

Reported by: "D. Ebling" <d.ebling8 <at> gmail.com>

Date: Sat, 27 Oct 2018 23:32:02 UTC

Severity: normal

Tags: patch

Found in version 26.1

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33182 in the body.
You can then email your comments to 33182 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Sat, 27 Oct 2018 23:32:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to "D. Ebling" <d.ebling8 <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 27 Oct 2018 23:32:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "D. Ebling" <d.ebling8 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Support for Suckless st(simple terminal)
Date: Sat, 27 Oct 2018 20:15:26 -0300
[Message part 1 (text/plain, inline)]
       Emacs on st detects 8 colors support, and st supports 256 and
24-bits colors. Opening a file with "TERM=xterm-256colors emacs -q -nw
foo.bar" or using "(add-to-list 'term-file-aliases '("st-256color"
. "xterm"))" resolves the colors issue but introduces a 5 seconds delay
to load the file, if i open like this and after use only "emacs -q -nw
foo.bar" the 256 colors work and there's no delay to load the file, but
this only works if i used "TERM=xterm-256color" before.  st version is
0.8.1.


In GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30)
 of 2018-07-05 built on juergen
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
ESC M-x is undefined

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-modules
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 MODULES THREADS LIBSYSTEMD LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date elec-pair
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 95003 8111)
 (symbols 48 20342 2)
 (miscs 40 78 93)
 (strings 32 28097 1136)
 (string-bytes 1 735046)
 (vectors 16 12230)
 (vector-slots 8 450577 9328)
 (floats 8 49 319)
 (intervals 56 204 11)
 (buffers 992 12))
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Sat, 03 Nov 2018 08:54:01 GMT) Full text and rfc822 format available.

Message #8 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "D. Ebling" <d.ebling8 <at> gmail.com>
Cc: 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Sat, 03 Nov 2018 10:53:17 +0200
> From: "D. Ebling" <d.ebling8 <at> gmail.com>
> Date: Sat, 27 Oct 2018 20:15:26 -0300
> 
>        Emacs on st detects 8 colors support, and st supports 256 and
> 24-bits colors. Opening a file with "TERM=xterm-256colors emacs -q -nw
> foo.bar" or using "(add-to-list 'term-file-aliases '("st-256color"
> . "xterm"))" resolves the colors issue but introduces a 5 seconds delay
> to load the file, if i open like this and after use only "emacs -q -nw
> foo.bar" the 256 colors work and there's no delay to load the file, but
> this only works if i used "TERM=xterm-256color" before.  st version is 0.8.1.

I think this requires a new st.el file in the lisp/term/ directory,
which will tell Emacs that st handles 256 colors, but not the extended
xterm commands (whose queries I'm guessing are the reason for the
delay).

Patches welcome.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Thu, 03 Oct 2019 01:00:02 GMT) Full text and rfc822 format available.

Message #11 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Thu, 3 Oct 2019 02:59:33 +0200
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "D. Ebling" <d.ebling8 <at> gmail.com>
>> Date: Sat, 27 Oct 2018 20:15:26 -0300
>>
>>        Emacs on st detects 8 colors support, and st supports 256 and
>> 24-bits colors. Opening a file with "TERM=xterm-256colors emacs -q -nw
>> foo.bar" or using "(add-to-list 'term-file-aliases '("st-256color"
>> . "xterm"))" resolves the colors issue but introduces a 5 seconds delay
>> to load the file, if i open like this and after use only "emacs -q -nw
>> foo.bar" the 256 colors work and there's no delay to load the file, but
>> this only works if i used "TERM=xterm-256color" before.  st version is 0.8.1.
>
> I think this requires a new st.el file in the lisp/term/ directory,
> which will tell Emacs that st handles 256 colors, but not the extended
> xterm commands (whose queries I'm guessing are the reason for the
> delay).
>
> Patches welcome.

I couldn't reproduce the issue with the delay neither on st version
0.8.1 or 0.8.2.

In any case, I took a simplistic stab at this.  I can now run
"emacs -Q -nw" without specifying term and I get 256 colors as shown
by M-x list-colors-display.

Could you test it and see if it works for you?  You didn't mention
which version of Emacs you're using, but I would recommend to test
this on the current master branch (the development version 27.0.50).

Best regards,
Stefan Kangas
[0001-Add-term-st.el.patch (text/x-patch, attachment)]

Added tag(s) patch. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sat, 25 Jan 2020 01:57:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 12:11:02 GMT) Full text and rfc822 format available.

Message #16 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 14:10:03 +0200
Stefan Kangas <stefan <at> marxist.se> writes:

> In any case, I took a simplistic stab at this.  I can now run
> "emacs -Q -nw" without specifying term and I get 256 colors as shown
> by M-x list-colors-display.
>
> Could you test it and see if it works for you?  You didn't mention
> which version of Emacs you're using, but I would recommend to test
> this on the current master branch (the development version 27.0.50).

This was almost a year ago, so I think you should just go ahead and
apply the patch:

> This is a copy of term/konsole.el with konsole -> st.
> * lisp/term/st.el: New file.
> ---
>  lisp/term/st.el | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 lisp/term/st.el

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 12:34:01 GMT) Full text and rfc822 format available.

Message #19 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 05:33:39 -0700
close 33182 28.1
thanks

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> This was almost a year ago, so I think you should just go ahead and
> apply the patch:

Done, and closing.  Thanks for taking a look.

Best regards,
Stefan Kangas




bug marked as fixed in version 28.1, send any further explanations to 33182 <at> debbugs.gnu.org and "D. Ebling" <d.ebling8 <at> gmail.com> Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Mon, 10 Aug 2020 12:34:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 12:36:02 GMT) Full text and rfc822 format available.

Message #24 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 14:35:18 +0200
Stefan Kangas <stefan <at> marxist.se> writes:

>> This was almost a year ago, so I think you should just go ahead and
>> apply the patch:
>
> Done, and closing.  Thanks for taking a look.

Perhaps this is NEWS-worthy?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 12:46:02 GMT) Full text and rfc822 format available.

Message #27 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 05:45:06 -0700
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Perhaps this is NEWS-worthy?

Sure, I didn't consider that.  How about this?

diff --git a/etc/NEWS b/etc/NEWS
index e3d7ff0bef..a10d9f9dd5 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -98,6 +98,10 @@ dimension.
 Added a new Mozhi scheme.  The inapplicable ITRANS scheme is now
 deprecated.  Errors in the Inscript method were corrected.

+---
+** Rudimentary support for the 'st' terminal emulator.
+Emacs now supports 256 color display on the 'st' terminal emulator.
+




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 13:05:02 GMT) Full text and rfc822 format available.

Message #30 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 15:04:45 +0200
Stefan Kangas <stefan <at> marxist.se> writes:

> Sure, I didn't consider that.  How about this?

Looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33182; Package emacs. (Mon, 10 Aug 2020 13:29:02 GMT) Full text and rfc822 format available.

Message #33 received at 33182 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: "D. Ebling" <d.ebling8 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 33182 <at> debbugs.gnu.org
Subject: Re: bug#33182: 26.1; Support for Suckless st(simple terminal)
Date: Mon, 10 Aug 2020 15:28:05 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Looks good to me.

Thanks; pushed.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 08 Sep 2020 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 3 years and 229 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.