GNU bug report logs - #33197
26.1; cc-mode enum indentation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33197 in the body.
You can then email your comments to 33197 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Ota, Takaaki" <Takaaki.Ota <at> sony.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 26.1; cc-mode enum indentation
Date: Mon, 29 Oct 2018 14:03:58 -0700

The enum indentation in cc-mode used to look like this.

	  enum {
	    pDlen = sizeof pD - 1,
	    pIlen = sizeof pI - 1,
	    pMlen = sizeof pMd - 2
	  };
	  enum {
	    no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

This is a portion of doprnt.c in the current 26.1 source code.  But
now the 26.1 cc-mode indents like this

	  enum {
                pDlen = sizeof pD - 1,
                pIlen = sizeof pI - 1,
                pMlen = sizeof pMd - 2
	  };
	  enum {
                no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

If the enum has a long name before the open brace it looks even worse
by wasting a lot of unnecessary spaces.

	  enum some_long_enum_type_name {
                                         pDlen = sizeof pD - 1,
                                         pIlen = sizeof pI - 1,
                                         pMlen = sizeof pMd - 2
	  };
	  enum another_long_enum_type_name {
                                            no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

Please consider bringing it back to how it used to be.

-Tak

Message #8 received at 33197 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Ota, Takaaki" <Takaaki.Ota <at> sony.com>
Cc: 33197 <at> debbugs.gnu.org
Subject: Re: bug#33197: 26.1; cc-mode enum indentation
Date: Thu, 26 Nov 2020 14:00:14 +0100

"Ota, Takaaki" <Takaaki.Ota <at> sony.com> writes:

> The enum indentation in cc-mode used to look like this.
>
> 	  enum {
> 	    pDlen = sizeof pD - 1,
> 	    pIlen = sizeof pI - 1,
> 	    pMlen = sizeof pMd - 2
> 	  };
> 	  enum {
> 	    no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
> 	  } length_modifier = no_modifier;
>
> This is a portion of doprnt.c in the current 26.1 source code.  But
> now the 26.1 cc-mode indents like this
>
> 	  enum {
>                 pDlen = sizeof pD - 1,
>                 pIlen = sizeof pI - 1,
>                 pMlen = sizeof pMd - 2
> 	  };

I tested this in Emacs 27.1 and Emacs 28, and they both indent this code
like in the first example.

Are you still seeing this issue in Emacs 27?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 33197 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Ota, Takaaki" <Takaaki.Ota <at> sony.com>
Cc: 33197 <at> debbugs.gnu.org
Subject: Re: bug#33197: 26.1; cc-mode enum indentation
Date: Thu, 26 Nov 2020 14:14:24 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I tested this in Emacs 27.1 and Emacs 28, and they both indent this code
> like in the first example.

I build Emacs 26.1 and tested there, and I could indeed see the bug you
describe.

So it looks like it's been fixed in Emacs 27, and I'm closing this bug
report.  If it's still an issue, please respond to the debbugs address
and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.