GNU bug report logs - #33213
python-3/fixed and python-minimal test_socket.py

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33213 in the body.
You can then email your comments to 33213 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nam Nguyen <namn <at> berkeley.edu>
To: bug-guix <at> gnu.org
Cc: mbakke <at> fastmail.com
Subject: python-3/fixed and python-minimal test_socket.py
Date: Tue, 30 Oct 2018 22:24:21 -0700

Hi,

python has a memory leak in the test for test_socket.py, and it was
fixed in commit 90aeaee861845142843a0f988fa4ff016c723cdb.

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=90aeaee861845142843a0f988fa4ff016c723cdb

More information from IRC:
----8<------------------------------------------------------------
<mbakke> There is a bug in Python 3 which causes the test suite to run
    out of memory on recent kernels:
    https://bugs.python.org/issue34587
<mbakke> Unfortunately the only workaround I can think of is removing
    "/tmp/guix-build-python-3.6.5.drv-0/Lib/test/test_socket.py" some
    time during the build (but before the check phase).
----8<------------------------------------------------------------

However, python-minimal still runs test_socket, causing a memory
leak. Is it possible to change python-minimal so it uses python-3/fixed?
I was able to successfully build python-minimal by appending the fix to
python-minimal, as below. I do not know how (replacement python-3/fixed)
interacts with python-minimal.

----8<------------------------------------------------------------
(define-public python-minimal
  (package/inherit python
    (name "python-minimal")
    (outputs '("out"))

    ;; Build fails due to missing ctypes without libffi.
    ;; OpenSSL is a mandatory dependency of Python 3.x, for urllib;
    ;; zlib is required by 'zipimport', used by pip.
    (inputs `(("libffi" ,libffi)
              ("openssl" ,openssl)
              ("zlib" ,zlib)))
    (arguments
     (substitute-keyword-arguments (package-arguments python-3)
       ((#:phases phases)
        `(modify-phases ,phases
           (add-after 'unpack 'delete-broken-test
             (lambda _
               ;; Delete test which fails on recent kernels:
               ;; <https://bugs.python.org/issue34587>.
               (delete-file "Lib/test/test_socket.py")
               #t))))))))
----8<------------------------------------------------------------

Message #10 received at 33213-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Nam Nguyen <namn <at> berkeley.edu>
Cc: mbakke <at> fastmail.com, 33213-done <at> debbugs.gnu.org
Subject: Re: bug#33213: python-3/fixed and python-minimal test_socket.py
Date: Wed, 13 Jan 2021 10:38:32 -0500

Hello,

Nam Nguyen <namn <at> berkeley.edu> writes:

> Hi,
>
> python has a memory leak in the test for test_socket.py, and it was
> fixed in commit 90aeaee861845142843a0f988fa4ff016c723cdb.
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=90aeaee861845142843a0f988fa4ff016c723cdb
>
> More information from IRC:
> ----8<------------------------------------------------------------
> <mbakke> There is a bug in Python 3 which causes the test suite to run
>     out of memory on recent kernels:
>     https://bugs.python.org/issue34587
> <mbakke> Unfortunately the only workaround I can think of is removing
>     "/tmp/guix-build-python-3.6.5.drv-0/Lib/test/test_socket.py" some
>     time during the build (but before the check phase).

This problem was supposed to be fixed upstream [0], but I tried and it
still hangs.  Oh well.

At any rate, the test is disabled in Guix.

Closing,

Thanks for the report!

Maxim


[0]  https://bugs.python.org/issue34587

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.