GNU bug report logs - #33218
Updated dfa.c: unused function charclass_context

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33218 in the body.
You can then email your comments to 33218 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arnold Robbins <arnold <at> skeeve.com>
To: bug-grep <at> gnu.org
Subject: Updated dfa.c: unused function charclass_context
Date: Wed, 31 Oct 2018 21:53:29 +0200

Hi.

I have merged the latest dfa.c into gawk.  When I compile it, I get the
following warning:

dfa.c:2352:1: warning: 'charclass_context' defined but not used [-Wunused-function]

And indeed, the function isn't used. So I have removed it.

Thanks,

Arnold
----------------------
diff --git a/support/dfa.c b/support/dfa.c
index 71c350e..0f0a661 100644
--- a/support/dfa.c
+++ b/support/dfa.c
@@ -2345,27 +2345,6 @@ epsclosure (struct dfa const *d)
   free (tmp.elems);
 }
 
-/* Returns the set of contexts for which there is at least one
-   character included in C.  */
-
-static int
-charclass_context (struct dfa const *dfa, charclass const *c)
-{
-  int context = 0;
-
-  for (unsigned int j = 0; j < CHARCLASS_WORDS; ++j)
-    {
-      if (c->w[j] & dfa->syntax.newline.w[j])
-        context |= CTX_NEWLINE;
-      if (c->w[j] & dfa->syntax.letters.w[j])
-        context |= CTX_LETTER;
-      if (c->w[j] & ~(dfa->syntax.letters.w[j] | dfa->syntax.newline.w[j]))
-        context |= CTX_NONE;
-    }
-
-  return context;
-}
-
 /* Returns the contexts on which the position set S depends.  Each context
    in the set of returned contexts (let's call it SC) may have a different
    follow set than other contexts in SC, and also different from the

Message #10 received at 33218-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Arnold Robbins <arnold <at> skeeve.com>
Cc: 33218-done <at> debbugs.gnu.org
Subject: Re: Updated dfa.c: unused function charclass_context
Date: Wed, 1 Jan 2020 17:27:18 -0800

Bug#33218 dated 2018-10-31 seems to have been fixed by Jim Meyering in Gnulib commit 95cd86dd7aa4425037b9c710f88fd59e38601ff1 (2018-12-15 18:09:35 UTC) and then fixed in a different way since then, so I'm closing this old bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.