GNU bug report logs - #33237
26.1, 7.3 emacs-mac: <fnum> list order in C-h b

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33237 in the body.
You can then email your comments to 33237 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Van L <van <at> scratch.space>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Fri, 2 Nov 2018 15:47:48 +1100

Hello,

This is a suggestion. 

The ordering on the f-number keys listed in the help buffer looks to me to be improvable.

The numsort as applied after f but before the greater-thang(>) will look nicer.

<f1>		help-command
<f10>		menu-bar-open
<f11>		toggle-frame-fullscreen
<f16>		clipboard-kill-ring-save
<f18>		clipboard-yank
<f2>		2C-command
<f20>		clipboard-kill-region
<f3>		kmacro-start-macro-or-insert-counter
<f4>		kmacro-end-or-call-macro

Message #8 received at 33237 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Van L <van <at> scratch.space>
Cc: 33237 <at> debbugs.gnu.org
Subject: Re: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Wed, 10 Jul 2019 15:36:53 +0200

Van L <van <at> scratch.space> writes:

> This is a suggestion. 
>
> The ordering on the f-number keys listed in the help buffer looks to
> me to be improvable.
>
> The numsort as applied after f but before the greater-thang(>) will look nicer.
>
> <f1>		help-command
> <f10>		menu-bar-open
> <f11>		toggle-frame-fullscreen
> <f16>		clipboard-kill-ring-save
> <f18>		clipboard-yank
> <f2>		2C-command
> <f20>		clipboard-kill-region
> <f3>		kmacro-start-macro-or-insert-counter
> <f4>		kmacro-end-or-call-macro

With the patch below, I get:

<f1>		help-command
<f2>		2C-command
<f3>		kmacro-start-macro-or-insert-counter
<f4>		kmacro-end-or-call-macro
<f10>		menu-bar-open
<f11>		toggle-frame-fullscreen
<f16>		clipboard-kill-ring-save
<f18>		clipboard-yank
<f20>		clipboard-kill-region

Looks nicer to me.  Does anybody object to this change?

diff --git a/src/keymap.c b/src/keymap.c
index 2ac3d33460..8c2c209e64 100644
--- a/src/keymap.c
+++ b/src/keymap.c
@@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb)
   if (FIXNUMP (a->event) && !FIXNUMP (b->event))
     return -1;
   if (SYMBOLP (a->event) && SYMBOLP (b->event))
-    return (!NILP (Fstring_lessp (a->event, b->event)) ? -1
-	    : !NILP (Fstring_lessp (b->event, a->event)) ? 1
+    return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1
+	    : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1
 	    : 0);
   return 0;
 }


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 33237 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: van <at> scratch.space, 33237 <at> debbugs.gnu.org
Subject: Re: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Wed, 10 Jul 2019 18:02:36 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Date: Wed, 10 Jul 2019 15:36:53 +0200
> Cc: 33237 <at> debbugs.gnu.org
> 
> <f1>		help-command
> <f2>		2C-command
> <f3>		kmacro-start-macro-or-insert-counter
> <f4>		kmacro-end-or-call-macro
> <f10>		menu-bar-open
> <f11>		toggle-frame-fullscreen
> <f16>		clipboard-kill-ring-save
> <f18>		clipboard-yank
> <f20>		clipboard-kill-region
> 
> Looks nicer to me.  Does anybody object to this change?
> 
> diff --git a/src/keymap.c b/src/keymap.c
> index 2ac3d33460..8c2c209e64 100644
> --- a/src/keymap.c
> +++ b/src/keymap.c
> @@ -3098,8 +3098,8 @@ describe_map_compare (const void *aa, const void *bb)
>    if (FIXNUMP (a->event) && !FIXNUMP (b->event))
>      return -1;
>    if (SYMBOLP (a->event) && SYMBOLP (b->event))
> -    return (!NILP (Fstring_lessp (a->event, b->event)) ? -1
> -	    : !NILP (Fstring_lessp (b->event, a->event)) ? 1
> +    return (!NILP (Fstring_version_lessp (a->event, b->event)) ? -1
> +	    : !NILP (Fstring_version_lessp (b->event, a->event)) ? 1
>  	    : 0);
>    return 0;
>  }

It sounds very strange to use string-version-lessp here, so I think
this must have a comment explaining why.

Btw, did you try string-collate-lessp instead?

Message #14 received at 33237 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: van <at> scratch.space, 33237 <at> debbugs.gnu.org
Subject: Re: bug#33237: 26.1, 7.3 emacs-mac: <fnum> list order in C-h b
Date: Thu, 11 Jul 2019 16:50:22 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> It sounds very strange to use string-version-lessp here, so I think
> this must have a comment explaining why.

Yup.  I mean, it's a function with a strange name, but what it does is
nice (i.e., sort stretches of digits as a number).  In other
environments the function is often called something like "natural sort".

> Btw, did you try string-collate-lessp instead?

Yes, I tried it first, and it didn't do what I thought it would do:

(sort '("1" "2" "11") 'string-collate-lessp)
=> ("1" "11" "2")

Which isn't what we want...

I'll go ahead and apply the patch (with a comment) and we can see how we
like the result.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.