GNU logs - #33247, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#33247: makefile mode comment color
Resent-From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 03 Nov 2018 03:41:02 +0000
Resent-Message-ID: <handler.33247.B.154121641231894 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 33247 <at> debbugs.gnu.org
From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Date: Sat, 03 Nov 2018 11:39:40 +0800
Message-ID: <877ehuhls3.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Makefile-mode should show comment color for both of
xxx:# yyyy
xxx: #zzzz
not just the last.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Subject: bug#33247: Acknowledgement (makefile mode comment color)
Message-ID: <handler.33247.B.154121641231894.ack <at> debbugs.gnu.org>
References: <877ehuhls3.fsf@HIDDEN>
X-Gnu-PR-Message: ack 33247
X-Gnu-PR-Package: emacs
Reply-To: 33247 <at> debbugs.gnu.org
Date: Sat, 03 Nov 2018 03:41:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 33247 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
33247: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D33247
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 3 Nov 2018 16:14:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 03 12:14:30 2018
Received: from localhost ([127.0.0.1]:33109 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gIyZC-0007Y1-6j
	for submit <at> debbugs.gnu.org; Sat, 03 Nov 2018 12:14:30 -0400
Received: from eggs.gnu.org ([208.118.235.92]:57940)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <rgm@HIDDEN>) id 1gIyZA-0007Xp-N6
 for control <at> debbugs.gnu.org; Sat, 03 Nov 2018 12:14:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <rgm@HIDDEN>) id 1gIyYw-0006Tr-Br
 for control <at> debbugs.gnu.org; Sat, 03 Nov 2018 12:14:17 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41752)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@HIDDEN>)
 id 1gIyYq-0006BZ-Tk
 for control <at> debbugs.gnu.org; Sat, 03 Nov 2018 12:14:09 -0400
Received: from rgm by fencepost.gnu.org with local (Exim 4.82)
 (envelope-from <rgm@HIDDEN>) id 1gIyYq-00038v-Pn
 for control <at> debbugs.gnu.org; Sat, 03 Nov 2018 12:14:08 -0400
Subject: control message for bug 33247
To: <control <at> debbugs.gnu.org>
X-Mailer: mail (GNU Mailutils 2.99.98)
Message-Id: <E1gIyYq-00038v-Pn@HIDDEN>
From: Glenn Morris <rgm@HIDDEN>
Date: Sat, 03 Nov 2018 12:14:08 -0400
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

merge 9407 33247

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#33247: makefile mode comment color
References: <877ehuhls3.fsf@HIDDEN>
Resent-From: Alan Mackenzie <acm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 06 Nov 2018 09:48:01 +0000
Resent-Message-ID: <handler.33247.B33247.154149764727009 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Cc: 33247 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
Date: 6 Nov 2018 09:47:21 -0000
Message-ID: <20181106094721.92934.qmail@HIDDEN>
From: Alan Mackenzie <acm@HIDDEN>
Organization: muc.de e.V.
In-Reply-To: <mailman.3320.1541216477.1284.bug-gnu-emacs@HIDDEN>
User-Agent: tin/2.4.2-20171224 ("Lochhead") (UNIX) (FreeBSD/11.2-RELEASE-p4
 (amd64))
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hello, Dan.

In article <mailman.3320.1541216477.1284.bug-gnu-emacs@HIDDEN> you wrote:
> Makefile-mode should show comment color for both of
> xxx:# yyyy
> xxx: #zzzz
> not just the last.

Yes.  In make-mode.el, at line 525, there's a syntax-propertize-function
setting which decommentises a # unless the previous character was one of
|, &, ;, <, > (, ), `, \, ", ', <space>, <tab>, <newline>.  : is not in
that list.

The comment to this setting:

   ;; From sh-script.el.
   ;; A `#' begins a comment in sh when it is unquoted and at the beginning
   ;; of a word.  In the shell, words are separated by metacharacters.
   ;; The list of special chars is taken from the single-unix spec of the
   ;; shell command language (under `quoting') but with `$' removed.

confirms that the setting was taken over from shell-script-mode, and it
is essentially unchanged.

Why do we have this setting for makefiles at all?  Are there any such
restrictions on comments in Makefiles?  Stefan?

As a quick fix, please try the following (based off of master, though
it'll probably work on released versions, too):

diff --git a/lisp/progmodes/make-mode.el b/lisp/progmodes/make-mode.el
index f67407f48e..27da624086 100644
--- a/lisp/progmodes/make-mode.el
+++ b/lisp/progmodes/make-mode.el
@@ -522,7 +522,7 @@ makefile-syntax-propertize-function
    ;; of a word.  In the shell, words are separated by metacharacters.
    ;; The list of special chars is taken from the single-unix spec of the
    ;; shell command language (under `quoting') but with `$' removed.
-   ("[^|&;<>()`\\\"' \t\n]\\(#+\\)" (1 "_"))
+   ;; ("[^|&;<>()`\\\"' \t\n]\\(#+\\)" (1 "_"))
    ;; Change the syntax of a quoted newline so that it does not end a comment.
    ("\\\\\n" (0 "."))))

-- 
Alan Mackenzie (Nuremberg, Germany).

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#33247: makefile mode comment color
In-Reply-To: <877ehuhls3.fsf@HIDDEN>
Resent-From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 06 Nov 2018 10:02:02 +0000
Resent-Message-ID: <handler.33247.B33247.154149851928379 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 33247
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Alan Mackenzie <acm@HIDDEN>
Cc: 33247 <at> debbugs.gnu.org, Stefan Monnier <monnier@HIDDEN>
Received: via spool by 33247-submit <at> debbugs.gnu.org id=B33247.154149851928379
          (code B ref 33247); Tue, 06 Nov 2018 10:02:02 +0000
Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 10:01:59 +0000
Received: from localhost ([127.0.0.1]:36014 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gJyBL-0007Nf-8X
	for submit <at> debbugs.gnu.org; Tue, 06 Nov 2018 05:01:59 -0500
Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:4685)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jidanni@HIDDEN>) id 1gJyBI-0007NU-NU
 for 33247 <at> debbugs.gnu.org; Tue, 06 Nov 2018 05:01:57 -0500
X-Sender-Id: dreamhost|x-authsender|jidanni@HIDDEN
Received: from relay.mailchannels.net (localhost [127.0.0.1])
 by relay.mailchannels.net (Postfix) with ESMTP id D7F4768304B;
 Tue,  6 Nov 2018 10:01:51 +0000 (UTC)
Received: from pdx1-sub0-mail-a29.g.dreamhost.com (unknown [100.96.30.62])
 (Authenticated sender: dreamhost)
 by relay.mailchannels.net (Postfix) with ESMTPA id 9F61D682704;
 Tue,  6 Nov 2018 10:01:51 +0000 (UTC)
X-Sender-Id: dreamhost|x-authsender|jidanni@HIDDEN
Received: from pdx1-sub0-mail-a29.g.dreamhost.com (pop.dreamhost.com
 [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)
 by 0.0.0.0:2500 (trex/5.16.2); Tue, 06 Nov 2018 10:01:51 +0000
X-MC-Relay: Neutral
X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@HIDDEN
X-MailChannels-Auth-Id: dreamhost
X-Chemical-Macabre: 4591709668369d57_1541498511738_1245095370
X-MC-Loop-Signature: 1541498511738:4087031524
X-MC-Ingress-Time: 1541498511737
Received: from pdx1-sub0-mail-a29.g.dreamhost.com (localhost [127.0.0.1])
 by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTP id 5B9ED80A01;
 Tue,  6 Nov 2018 02:01:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc
 :subject:references:date:message-id:mime-version:content-type;
 s=jidanni.org; bh=6PYKE6Tya6PrceiUyfsjkCoyHMI=; b=Trd5djY4m3uDF
 g9PnvNQjSnKzEpQnC4PsOHFQwUQaQPo0JMVtC3PmiHeA22hiEfflgkijZwRCTDXt
 tWOkuvmYYIVVnhxcsXIl3R+/DrkYGmOxAV5DCJ9C3Z/fQiKkV8AHQVLUe+nRv3XJ
 WSAZ3GjMg2kMcGMieg11VwIdwBzfu4=
Received: from jidanni.org (111-246-96-57.dynamic-ip.hinet.net [111.246.96.57])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: jidanni@HIDDEN)
 by pdx1-sub0-mail-a29.g.dreamhost.com (Postfix) with ESMTPSA id 9CFCC8086B;
 Tue,  6 Nov 2018 02:01:49 -0800 (PST)
X-DH-BACKEND: pdx1-sub0-mail-a29
From: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
References: <20181106094721.92934.qmail@HIDDEN>
Date: Tue, 06 Nov 2018 18:01:46 +0800
Message-ID: <877ehqcynp.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-VR-OUT-STATUS: OK
X-VR-OUT-SCORE: -100
X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrjeejgdduudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufhffkfggtgesthdtredttddtjeenucfhrhhomhepnjjnnjcuffgrnhculfgrtghosghsohhnuceojhhiuggrnhhnihesjhhiuggrnhhnihdrohhrgheqnecukfhppeduuddurddvgeeirdeliedrheejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehjihgurghnnhhirdhorhhgpdhinhgvthepudduuddrvdegiedrleeirdehjedprhgvthhurhhnqdhprghthheppeeruhhtfhdqkeerueerheeimhfphefnihehhegsveekreepucffrghnucflrggtohgsshhonhcuoehjihgurghnnhhisehjihgurghnnhhirdhorhhgqedpmhgrihhlfhhrohhmpehjihgurghnnhhisehjihgurghnnhhirdhorhhgpdhnrhgtphhtthhopehmohhnnhhivghrsehirhhordhumhhonhhtrhgvrghlrdgtrgenucevlhhushhtvghrufhiiigvpedt
X-Spam-Score: 0.1 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.9 (/)

Glad you found the bug.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#33247: makefile mode comment color
Resent-From: Stefan Monnier <monnier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 06 Nov 2018 13:26:02 +0000
Resent-Message-ID: <handler.33247.B33247.154151074523124 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 33247
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: 
To: Alan Mackenzie <acm@HIDDEN>
Cc: 33247 <at> debbugs.gnu.org, =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson <jidanni@HIDDEN>
Received: via spool by 33247-submit <at> debbugs.gnu.org id=B33247.154151074523124
          (code B ref 33247); Tue, 06 Nov 2018 13:26:02 +0000
Received: (at 33247) by debbugs.gnu.org; 6 Nov 2018 13:25:45 +0000
Received: from localhost ([127.0.0.1]:36129 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gK1MX-00060u-Ib
	for submit <at> debbugs.gnu.org; Tue, 06 Nov 2018 08:25:45 -0500
Received: from pruche.dit.umontreal.ca ([132.204.246.22]:33339)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <monnier@HIDDEN>) id 1gK1MV-00060m-2P
 for 33247 <at> debbugs.gnu.org; Tue, 06 Nov 2018 08:25:43 -0500
Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242])
 by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id wA6DPecD006712;
 Tue, 6 Nov 2018 08:25:41 -0500
Received: by pastel.home (Postfix, from userid 20848)
 id 16D296A522; Tue,  6 Nov 2018 08:25:39 -0500 (EST)
From: Stefan Monnier <monnier@HIDDEN>
Message-ID: <jwvva5az6hz.fsf-monnier+emacsbugs@HIDDEN>
References: <20181106094721.92934.qmail@HIDDEN>
Date: Tue, 06 Nov 2018 08:25:39 -0500
In-Reply-To: <20181106094721.92934.qmail@HIDDEN> (Alan Mackenzie's
 message of "6 Nov 2018 09:47:21 -0000")
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-NAI-Spam-Flag: NO
X-NAI-Spam-Threshold: 5
X-NAI-Spam-Score: 0
X-NAI-Spam-Rules: 2 Rules triggered
	EDT_SA_DN_PASS=0, RV6412=0
X-NAI-Spam-Version: 2.3.0.9418 : core <6412> : inlines <6952> : streams
 <1803480> : uri <2745171>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> Why do we have this setting for makefiles at all?

That's to handle the /bin/sh comments on the command lines of rules,
where the code is run by /bin/sh and hence obeys the corresponding
rules.  E.g.

   foo.o: foo.c
   	echo This is#not a comment
   	$(CC) $(CFLAGS) -o $@ $<  #This is an sh comment

> Are there any such
> restrictions on comments in Makefiles?  Stefan?

Maybe we should conditionalize on the presence of a leading TAB at the
beginning of the line.

BTW, I recently saw that the above is wrong in cases like

   foo.o: foo.c
   	@#An sh comment not recognized by current makefile mode
   	$(CC) $(CFLAGS) -o $@ $<  #This is a comment

so if you can fix both of those while you're there, that'd be great!


-- Stefan

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.