GNU bug report logs - #33256
nxml-mode completion of attribute no longer adds =" after emacs 26

Previous Next

Package: emacs;

Reported by: Martin Fowler <martinfowlercom <at> gmail.com>

Date: Sun, 4 Nov 2018 17:22:02 UTC

Severity: normal

Tags: unreproducible

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33256 in the body.
You can then email your comments to 33256 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-coreutils <at> gnu.org:
bug#33256; Package coreutils. (Sun, 04 Nov 2018 17:22:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Martin Fowler <martinfowlercom <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-coreutils <at> gnu.org. (Sun, 04 Nov 2018 17:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Fowler <martinfowlercom <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: nxml-mode completion of attribute no longer adds =" after emacs 26
Date: Sun, 4 Nov 2018 09:47:48 -0500

If this is the wrong list to send this to, my apologies, please let me know where to go.

I've used nxml-mode for a long time. When typing in an xml attribute and using completion, emacs would respond by completing the attribute and also adding =" to allow me to immediately type the value of the xml attribute. I recently upgraded to emacs 26, and it now only completes the attribute hame. The original completion behavior (adding =") is described in the manual at <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html> .

To replicate

- open an html file in nxml mode
- ensure it's tied to the html schema file 
- type "<html xmln"
- trigger completion (C-M-i, or whatever calls completion-at-point)

expected behavior (pre emacs 26)

line shows:

    <html xmlns="

actual behavior, line shows

   <html xmlns

Martin Fowler
http://martinfowler.com
Information forwarded to bug-coreutils <at> gnu.org:
bug#33256; Package coreutils. (Tue, 06 Nov 2018 18:28:02 GMT) Full text and rfc822 format available.

Message #8 received at 33256 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Martin Fowler <martinfowlercom <at> gmail.com>, 33256 <at> debbugs.gnu.org
Subject: Re: bug#33256: nxml-mode completion of attribute no longer adds ="
 after emacs 26
Date: Tue, 6 Nov 2018 11:27:27 -0700

reassign 33256 emacs
stop

On 2018-11-04 7:47 a.m., Martin Fowler wrote:
> If this is the wrong list to send this to, my apologies, please let me know where to go.
> 
> I've used nxml-mode for a long time. When typing in an xml attribute and using completion, emacs would respond by completing the attribute and also adding =" to allow me to immediately type the value of the xml attribute. I recently upgraded to emacs 26, and it now only completes the attribute hame. The original completion behavior (adding =") is described in the manual at <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html> .

I believe you want the emacs mailing list (this was bug-coreutils <at> gnu.org).
Reassigning to emacs.

-assaf
bug reassigned from package 'coreutils' to 'emacs'. Request was from Assaf Gordon <assafgordon <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 06 Nov 2018 18:28:03 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33256; Package emacs. (Thu, 04 Apr 2019 03:49:01 GMT) Full text and rfc822 format available.

Message #13 received at 33256 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Martin Fowler <martinfowlercom <at> gmail.com>
Cc: 33256 <at> debbugs.gnu.org
Subject: Re: bug#33256: nxml-mode completion of attribute no longer adds ="
 after emacs 26
Date: Wed, 03 Apr 2019 23:48:45 -0400

tags 33256 + unreproducible
quit

Martin Fowler <martinfowlercom <at> gmail.com> writes:

> I've used nxml-mode for a long time. When typing in an xml attribute
> and using completion, emacs would respond by completing the attribute
> and also adding =" to allow me to immediately type the value of the
> xml attribute. I recently upgraded to emacs 26, and it now only
> completes the attribute hame. The original completion behavior (adding
> =") is described in the manual at
> <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html>
> .
>
> To replicate
>
> - open an html file in nxml mode
> - ensure it's tied to the html schema file 
> - type "<html xmln"
> - trigger completion (C-M-i, or whatever calls completion-at-point)
>
> expected behavior (pre emacs 26)
>
> line shows:
>
>     <html xmlns="
>
> actual behavior, line shows
>
>    <html xmlns

I can't reproduce this exactly, with 26.1 and later I get

     <html xmlns="-!-"

(where -!- represents point).  While the doc does say there should only
be an opening quote added, this is arguably an improvement, so...
Added tag(s) unreproducible. Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 04 Apr 2019 03:49:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33256; Package emacs. (Thu, 04 Apr 2019 23:39:01 GMT) Full text and rfc822 format available.

Message #18 received at 33256 <at> debbugs.gnu.org (full text, mbox):

From: Martin Fowler <martinfowlercom <at> gmail.com>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 33256 <at> debbugs.gnu.org
Subject: Re: bug#33256: nxml-mode completion of attribute no longer adds ="
 after emacs 26
Date: Thu, 4 Apr 2019 19:38:48 -0400

My apologies on this, I think I neglected to test this bug with no initialization file. I tried it with `emacs -q` and got the behavior you describe (which I agree is reasonable). I got the behavior I mentioned with all my inits loaded, so I expect it's some interaction between nxml-mode and one of those. That will be a fun exercise to try and figure out ;-)

Again my apologies for not having tested this properly before raising the bug.

Martin Fowler
http://martinfowler.com





> On Apr 3, 2019, at 23:48, Noam Postavsky <npostavs <at> gmail.com> wrote:
> 
> tags 33256 + unreproducible
> quit
> 
> Martin Fowler <martinfowlercom <at> gmail.com> writes:
> 
>> I've used nxml-mode for a long time. When typing in an xml attribute
>> and using completion, emacs would respond by completing the attribute
>> and also adding =" to allow me to immediately type the value of the
>> xml attribute. I recently upgraded to emacs 26, and it now only
>> completes the attribute hame. The original completion behavior (adding
>> =") is described in the manual at
>> <https://www.gnu.org/software/emacs/manual/html_node/nxml-mode/Completion.html>
>> .
>> 
>> To replicate
>> 
>> - open an html file in nxml mode
>> - ensure it's tied to the html schema file 
>> - type "<html xmln"
>> - trigger completion (C-M-i, or whatever calls completion-at-point)
>> 
>> expected behavior (pre emacs 26)
>> 
>> line shows:
>> 
>>    <html xmlns="
>> 
>> actual behavior, line shows
>> 
>>   <html xmlns
> 
> I can't reproduce this exactly, with 26.1 and later I get
> 
>     <html xmlns="-!-"
> 
> (where -!- represents point).  While the doc does say there should only
> be an opening quote added, this is arguably an improvement, so...
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33256; Package emacs. (Wed, 10 Apr 2019 23:42:01 GMT) Full text and rfc822 format available.

Message #21 received at 33256 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Martin Fowler <martinfowlercom <at> gmail.com>
Cc: 33256 <at> debbugs.gnu.org
Subject: Re: bug#33256: nxml-mode completion of attribute no longer adds ="
 after emacs 26
Date: Wed, 10 Apr 2019 19:41:06 -0400

close 33256
quit

Martin Fowler <martinfowlercom <at> gmail.com> writes:

> My apologies on this, I think I neglected to test this bug with no
> initialization file.

No worries, it happens. :)

> I tried it with `emacs -q` and got the behavior
> you describe (which I agree is reasonable).

I've meanwhile tracked down where the change happened [1: d7896a6f77],
and updated the manual to reflect the slightly different new behaviour
[2: cb5a340823], so I'm closing the bug.

[1: d7896a6f77]: 2016-01-16 14:03:29 -0500
  * lisp/nxml: Use standard completion; it also works for company-mode
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d7896a6f773dc4ae4e1b56c34b6708fe2bc5610a
  
[2: cb5a340823]: 2019-04-10 19:33:21 -0400
  Update nxml-mode.texi: completion now gives xmlns="-!-"
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb5a34082342695676f2db11e1465bd28347e9de
bug closed, send any further explanations to 33256 <at> debbugs.gnu.org and Martin Fowler <martinfowlercom <at> gmail.com> Request was from Noam Postavsky <npostavs <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 10 Apr 2019 23:42:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 09 May 2019 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 351 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.