Received: (at 33266) by debbugs.gnu.org; 22 Jan 2019 22:09:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 22 17:09:12 2019 Received: from localhost ([127.0.0.1]:41704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gm4EK-0002gk-FK for submit <at> debbugs.gnu.org; Tue, 22 Jan 2019 17:09:12 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:50886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1gm4EI-0002gb-Fr for 33266 <at> debbugs.gnu.org; Tue, 22 Jan 2019 17:09:10 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 671864F13; Tue, 22 Jan 2019 23:09:09 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sskwcurosmH2; Tue, 22 Jan 2019 23:09:08 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C9FCE4F11; Tue, 22 Jan 2019 23:09:07 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config References: <87a7mo5de4.fsf@HIDDEN> <87o9b21ehv.fsf@HIDDEN> <871s7u53ej.fsf@HIDDEN> Date: Tue, 22 Jan 2019 23:09:07 +0100 In-Reply-To: <871s7u53ej.fsf@HIDDEN> (Maxim Cournoyer's message of "Thu, 08 Nov 2018 22:35:32 -0500") Message-ID: <874la0jqf0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 33266 Cc: 33266 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hi Maxim, Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis: > ludo@HIDDEN (Ludovic Court=C3=A8s) writes: > > [...] > >> This looks good, and indeed it=E2=80=99s an unintended consequence of co= mmit >> cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9. >> >> However, the log of commit cc1dfc had this: >> >> Failing to do that, "%p" would be "0" when using "ProxyCommand" >> in ~/.ssh/config. > > Yeah, I had seen this message, but was doubting if it was still > valid. Helas, it seems so: [...] >> This is arguably a defect in either Guile-SSH or (more likely) libssh, >> and it would be nice to report it. >> >> Would you like to report it upstream? > > It has to be in libssh. I'll try to come up with a repro in C, and > submit the issue to them. With the recent upgrade to libssh 0.8.6, is the issue still present? Ludo=E2=80=99.
bug-guix@HIDDEN:bug#33266; Package guix.
Full text available.
Received: (at 33266) by debbugs.gnu.org; 9 Nov 2018 03:35:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 22:35:44 2018
Received: from localhost ([127.0.0.1]:42104 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gKxaC-0000nj-L7
for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 22:35:44 -0500
Received: from mail-it1-f175.google.com ([209.85.166.175]:54231)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1gKxa8-0000nS-Sf
for 33266 <at> debbugs.gnu.org; Thu, 08 Nov 2018 22:35:41 -0500
Received: by mail-it1-f175.google.com with SMTP id r12-v6so1315855ita.3
for <33266 <at> debbugs.gnu.org>; Thu, 08 Nov 2018 19:35:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:references:date:in-reply-to:message-id
:user-agent:mime-version:content-transfer-encoding;
bh=OtnXL0r/o6tm8uk9GTGDanxuP9mFlu1RoGfsGvUlPq4=;
b=EwnwZ5RkPPmjQOZMk7Wh2SgBwBjSFm8I04kkAuo7YGKl5RessDfbyDZUrj8wUGB330
vDO9cFCQQQS2zxwu0oXjc+P/+3l3QSulOEVpoLvCoKwQ3WHcxSbvBWuB0dgXkN2CdDjd
MEcm3nxY4IQgHkivOjqNIyJGYGBsawHv9JN+Ii17mbsgf/LDFudfR//L67gBCBrKB2rj
ErG7Xzjc40b+Ezgy+rSINhjKl+lTLVLitFKQThd099WUxFJ4Bkpcc88N4HCLHUiKAQ2k
vnCoozjKKIOZQ68YXmVOvPIbvR0ThtaA+1Xfw5Rkj1atXtWhEVOOk1krrwTddlEcYh0u
48TA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
:message-id:user-agent:mime-version:content-transfer-encoding;
bh=OtnXL0r/o6tm8uk9GTGDanxuP9mFlu1RoGfsGvUlPq4=;
b=M0/176WZ/3h1E4lW66ufnvwh47k7ttDRl5G64+KRS5fMwXD/3NfkdD8Ayk3dIYJHC/
p7b7BCO5qOzeChl+ymYkai6emC82eJcE0lyWeluJ1ne31OtDOFlkdCeGh8Ak1W10+W7L
ClV7LNGN8pii/NFlw1pL/kNKFb9BbDbWsyvg2d16+z3bObnF7Py75nz8j3A4UZXJzirz
YMZgH8zCZysNQaeC9LXKgSkNQwlIiK5Urlu2gOIwU7ec7Zn8uBzPsKNQ8Zy4nJRHRC22
EElqrwXfUsmJx+WEwdLV2AvNhGEfhYr71gsJ4cw4bU6Jw703U10gNaYxn+VvKixDrlUF
fZuQ==
X-Gm-Message-State: AGRZ1gKAFzTMeppZWCApVg2PhZZ2b40emg68WH7b317ajgoBzYzHafdM
d4qw+NAbca1v9twD1IQdJmBwf9Mz
X-Google-Smtp-Source: AJdET5cCvGgLZU37MKlbgJart5AwVDkOlvdjkpAj/dXlYd35tuxnn6+aCw3920S7ub4vnSSr83u5eQ==
X-Received: by 2002:a24:c647:: with SMTP id
j68-v6mr908834itg.118.1541734534777;
Thu, 08 Nov 2018 19:35:34 -0800 (PST)
Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126])
by smtp.gmail.com with ESMTPSA id j18sm161568itl.20.2018.11.08.19.35.33
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Thu, 08 Nov 2018 19:35:33 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: bug#33266: guix-copy: Honor the SSH port of a host when defined
in ~/.ssh/config
References: <87a7mo5de4.fsf@HIDDEN> <87o9b21ehv.fsf@HIDDEN>
Date: Thu, 08 Nov 2018 22:35:32 -0500
In-Reply-To: <87o9b21ehv.fsf@HIDDEN> ("Ludovic
\=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\=
\=\?utf-8\?Q\?s\?\= message of "Tue, 06 Nov 2018 15:12:44 +0100")
Message-ID: <871s7u53ej.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 33266
Cc: 33266 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello!
ludo@HIDDEN (Ludovic Court=C3=A8s) writes:
[...]
> This looks good, and indeed it=E2=80=99s an unintended consequence of com=
mit
> cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9.
>
> However, the log of commit cc1dfc had this:
>
> Failing to do that, "%p" would be "0" when using "ProxyCommand"
> in ~/.ssh/config.
Yeah, I had seen this message, but was doubting if it was still
valid. Helas, it seems so:
Given the ~/.ssh/config snippet (and configured machines):
--8<---------------cut here---------------start------------->8---
Host vm-host
HostName 10.5.5.5
User someuser
=20=20=20=20=20
Host some-guest
IdentityFile ~/.ssh/vm-host/id_rsa
HostName some-guest
User guest
ProxyCommand ssh vm-host nc %h %p
--8<---------------cut here---------------end--------------->8---
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use (ssh session)
scheme@(guile-user)> (make-session #:host "some-guest")
$1 =3D #<session #<undefined>@some-guest:22 (disconnected) 11dffe0>
scheme@(guile-user)> (session-get $1 'host)
$2 =3D "some-guest"
scheme@(guile-user)> (session-get $1 'port)
$3 =3D 22
scheme@(guile-user)> (session-parse-config! $1 "~/.ssh/config")
$4 =3D #<undefined>
scheme@(guile-user)> (session-get $1 'port)
$5 =3D 22
scheme@(guile-user)> (connect! $1)
$6 =3D error
scheme@(guile-user)> (make-session #:host "some-guest" #:port 22)
$7 =3D #<session #<undefined>@some-guest:22 (disconnected) 11dffc0>
scheme@(guile-user)> (session-parse-config! $7 "~/.ssh/config")
$8 =3D #<undefined>
scheme@(guile-user)> (session-get $7 'port)
$9 =3D 22
scheme@(guile-user)> (connect! $7)
$10 =3D ok
--8<---------------cut here---------------end--------------->8---
> This is arguably a defect in either Guile-SSH or (more likely) libssh,
> and it would be nice to report it.
>
> Would you like to report it upstream?
It has to be in libssh. I'll try to come up with a repro in C, and
submit the issue to them.
When it's done, I'll add a note in the code.
To be continued... Thanks for looking :)
Maxim
bug-guix@HIDDEN:bug#33266; Package guix.
Full text available.Received: (at 33266) by debbugs.gnu.org; 6 Nov 2018 14:13:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 06 09:13:01 2018 Received: from localhost ([127.0.0.1]:36174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gK26H-0007I6-0P for submit <at> debbugs.gnu.org; Tue, 06 Nov 2018 09:13:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1gK26D-0007Hs-VP for 33266 <at> debbugs.gnu.org; Tue, 06 Nov 2018 09:12:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1gK262-0000ek-9h for 33266 <at> debbugs.gnu.org; Tue, 06 Nov 2018 09:12:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1gK262-0000eI-6h; Tue, 06 Nov 2018 09:12:46 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=33226 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1gK261-0006tY-UU; Tue, 06 Nov 2018 09:12:46 -0500 From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: bug#33266: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config References: <87a7mo5de4.fsf@HIDDEN> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 Brumaire an 227 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 06 Nov 2018 15:12:44 +0100 In-Reply-To: <87a7mo5de4.fsf@HIDDEN> (Maxim Cournoyer's message of "Sun, 04 Nov 2018 23:58:27 -0500") Message-ID: <87o9b21ehv.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 33266 Cc: 33266 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -6.0 (------) Hello, Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis: > From 942eb8cabef5b7c8b4425c765b6ee2ac9f529ad8 Mon Sep 17 00:00:00 2001 > From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> > Date: Sun, 4 Nov 2018 23:35:16 -0500 > Subject: [PATCH] Revert "copy: Default to port 22." > > This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9. Specifying= a > default port had the undesirable effect of disregarding a port specificat= ion > for a given host in the ~/.ssh/config that would otherwise have been hono= red > at the time `open-ssh-session' calls the `session-parse-config!' method. > > In any case, `make-session' will default the port value of the created se= ssion > to 22 if left unspecified. This looks good, and indeed it=E2=80=99s an unintended consequence of commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9. However, the log of commit cc1dfc had this: Failing to do that, "%p" would be "0" when using "ProxyCommand" in ~/.ssh/config. This is arguably a defect in either Guile-SSH or (more likely) libssh, and it would be nice to report it. Would you like to report it upstream? Thanks, Ludo=E2=80=99.
bug-guix@HIDDEN:bug#33266; Package guix.
Full text available.
Received: (at submit) by debbugs.gnu.org; 5 Nov 2018 04:58:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 04 23:58:55 2018
Received: from localhost ([127.0.0.1]:34501 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gJWyU-00030Z-SJ
for submit <at> debbugs.gnu.org; Sun, 04 Nov 2018 23:58:55 -0500
Received: from eggs.gnu.org ([208.118.235.92]:46013)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1gJWyS-00030K-I2
for submit <at> debbugs.gnu.org; Sun, 04 Nov 2018 23:58:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1gJWyK-0007UF-Tx
for submit <at> debbugs.gnu.org; Sun, 04 Nov 2018 23:58:46 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM
autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:34401)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1gJWyK-0007Tz-PL
for submit <at> debbugs.gnu.org; Sun, 04 Nov 2018 23:58:44 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55603)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1gJWyI-0003hw-Gl
for bug-guix@HIDDEN; Sun, 04 Nov 2018 23:58:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <maxim.cournoyer@HIDDEN>) id 1gJWyC-0007HL-Sa
for bug-guix@HIDDEN; Sun, 04 Nov 2018 23:58:40 -0500
Received: from mail-it1-x135.google.com ([2607:f8b0:4864:20::135]:34312)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from <maxim.cournoyer@HIDDEN>)
id 1gJWyB-00075b-1d
for bug-guix@HIDDEN; Sun, 04 Nov 2018 23:58:36 -0500
Received: by mail-it1-x135.google.com with SMTP id t189-v6so6752768itf.1
for <bug-guix@HIDDEN>; Sun, 04 Nov 2018 20:58:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:subject:date:message-id:user-agent:mime-version;
bh=9W2vp8oRn8gd4+ADQZz2qHRH+MCm2vWp5d92eX7AmRY=;
b=ijFqi2x5RyPojg1hvRXhZbZKaFUeJj9yEJxQtc1lniYKfGvzgznHT2fEe9iFi6u6M7
FqzgUlf/0niuimmhqHHeetBXNmQ+BERKHhjPhJKasT3wa5c+8l/uJYHEh+cdJpkxccNd
enmZ0gyX9jDCf2WVW3WDiusthPlkNrqeu1YM84wB4rTeWpEwqqT10B/ggA5vx6fOolny
3PeX5AtXEFWowcj4XTRjvjXP3IT3ZbvOfa1WsDzs/TQ4MmCzH+tZFxl7hdb2HpSJ6Oyb
qXKbccQrbcDg0y4Fw9qYambSSFuB8BEw++kB4w8zitZ+zj8swgeB3IupZ3P6zPeRc1wh
YKxg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:user-agent
:mime-version;
bh=9W2vp8oRn8gd4+ADQZz2qHRH+MCm2vWp5d92eX7AmRY=;
b=e+9T5JT2M1dm3qg8q7es6nWdf+AGN64/UmaK58LQaR6pEHjq3LTHNjCj257ARk+7m+
iNGkOpdoFJKMq1bN0n5wb4lEVZ5nyOu10gdyuhzVhB8JwQF2QAFQbVyGKE5Ehocka1p9
32VmGQXgcr2jt3oOWZryySwLyA17HKwt31eW2veCTwbYG0sWUcaUd0v4PBCukifdm1dU
h2UHPdzsoSy5VyKVdWffFh8jauIoaj/VXtHavDTWvfLpVm0d6qoJnNMGCez3tTgdohkp
wvHa+a0BHIe9AUwbb445WtYQFsa1Tx2Mj1HJha3JsuLDbCDPriWlHSLpnQ3ZqOZIuoSr
6aiw==
X-Gm-Message-State: AGRZ1gLUXOdsHgP/qWx3tW4l3XxArkJyBF4sgwgVIHGxqPwAAol1As2n
eojsdQXmd2QsHfbwBQU6A34mW+i0
X-Google-Smtp-Source: AJdET5eq++0eJgzAJlbwrYW1aXvvMm52qtwVsUPprgQPB6lxnWK+fs5+fLGgwF0ox58Gxgp//Xt04w==
X-Received: by 2002:a24:7b11:: with SMTP id
q17-v6mr5542811itc.80.1541393910333;
Sun, 04 Nov 2018 20:58:30 -0800 (PST)
Received: from apteryx (76-10-140-126.dsl.teksavvy.com. [76.10.140.126])
by smtp.gmail.com with ESMTPSA id q131-v6sm3333366itb.5.2018.11.04.20.58.28
for <bug-guix@HIDDEN>
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Sun, 04 Nov 2018 20:58:29 -0800 (PST)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: bug-guix <bug-guix@HIDDEN>
Subject: guix-copy: Honor the SSH port of a host when defined in ~/.ssh/config
Date: Sun, 04 Nov 2018 23:58:27 -0500
Message-ID: <87a7mo5de4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)
--=-=-=
Content-Type: text/plain
Hello,
I recently stumbled on the bug where guix copy would the port 22 even
when I had specified a different one in my ~/.ssh/config file.
This bug is triggered when omitting the port in the --to= (or --from)
expression, such as in
guix copy --to=somehost bash
And where somehost exists in ~/.ssh/config, say:
Host somehost
User someuser
HostName someplace.somedns.net
Port 1234
Instead of using port 1234, the port 22 would be used. Commit
cc1dfc202f is the reason of this overriding; the attached patch
reverts it, with a detailed explanation.
Thank you,
Maxim
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
filename=0001-Revert-copy-Default-to-port-22.patch
From 942eb8cabef5b7c8b4425c765b6ee2ac9f529ad8 Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Date: Sun, 4 Nov 2018 23:35:16 -0500
Subject: [PATCH] Revert "copy: Default to port 22."
This reverts commit cc1dfc202f2fefb6c2eb9467d1fc90a9154550c9. Specifying a
default port had the undesirable effect of disregarding a port specification
for a given host in the ~/.ssh/config that would otherwise have been honored
at the time `open-ssh-session' calls the `session-parse-config!' method.
In any case, `make-session' will default the port value of the created session
to 22 if left unspecified.
---
guix/scripts/copy.scm | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/guix/scripts/copy.scm b/guix/scripts/copy.scm
index 4c8592985..d35eed74e 100644
--- a/guix/scripts/copy.scm
+++ b/guix/scripts/copy.scm
@@ -75,8 +75,7 @@ package names, build the underlying packages before sending them."
(and (or (assoc-ref opts 'dry-run?)
(build-derivations local drv))
- (let* ((session (open-ssh-session host #:user user
- #:port (or port 22)))
+ (let* ((session (open-ssh-session host #:user user #:port port))
(sent (send-files local items
(connect-to-remote-daemon session)
#:recursive? #t)))
@@ -89,7 +88,7 @@ package names, build the underlying packages before sending them."
(let*-values (((user host port)
(ssh-spec->user+host+port source))
((session)
- (open-ssh-session host #:user user #:port (or port 22)))
+ (open-ssh-session host #:user user #:port port))
((remote)
(connect-to-remote-daemon session)))
(set-build-options-from-command-line local opts)
--
2.19.0
--=-=-=--
Maxim Cournoyer <maxim.cournoyer@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#33266; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.