GNU bug report logs - #33282
ImageMagick delegates

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33282 in the body.
You can then email your comments to 33282 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: ImageMagick delegates
Date: Mon, 05 Nov 2018 22:52:47 +0200

WebP is an image format that is gaining popularity,
but currently can't be displayed by image-mode.

It's supported by ImageMagick after installing

  sudo apt-get install webp

The command `identify -list delegate` confirms that:

  webp => "dwebp' -pam '%i' -o '%o"

It's possible to work around its missing support by adding to ~/.emacs:

  (add-to-list 'imagemagick-enabled-types 'WEBP)

  (advice-add 'imagemagick-types :around
              (lambda (orig-fun &rest args)
                (append (apply orig-fun args) '(WEBP))))

  (imagemagick-register-types)

So the question is: should `imagemagick-types' return
the delegate list in addition to the current list
of non-delegate image types?

Message #8 received at 33282 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 33282 <at> debbugs.gnu.org
Subject: Re: bug#33282: ImageMagick delegates
Date: Tue, 06 Nov 2018 23:39:42 +0200

> WebP is an image format that is gaining popularity,
> but currently can't be displayed by image-mode.
>
> It's supported by ImageMagick after installing
>
>   sudo apt-get install webp
>
> The command `identify -list delegate` confirms that:
>
>   webp => "dwebp' -pam '%i' -o '%o"
>
> It's possible to work around its missing support by adding to ~/.emacs:
>
>   (add-to-list 'imagemagick-enabled-types 'WEBP)
>
>   (advice-add 'imagemagick-types :around
>               (lambda (orig-fun &rest args)
>                 (append (apply orig-fun args) '(WEBP))))
>
>   (imagemagick-register-types)
>
> So the question is: should `imagemagick-types' return
> the delegate list in addition to the current list
> of non-delegate image types?

I tried GetDelegateList, but it returned some delegates on whose
calling MagickRelinquishMemory caused a crash during bootstrapping.
There is no crash when calling MagickRelinquishMemory not during
bootstrapping, and I have no idea what is wrong.

Message #11 received at 33282 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 33282 <at> debbugs.gnu.org
Subject: Re: bug#33282: ImageMagick delegates
Date: Tue, 24 Sep 2019 18:47:17 +0200

Juri Linkov <juri <at> linkov.net> writes:

> WebP is an image format that is gaining popularity,
> but currently can't be displayed by image-mode.

I wonder -- do you think its popularity merits Emacs getting native
support for it?  I don't think I've seen too many sites that serve out
WebP only, but perhaps that'll change now what Chrome is the only web
browser people care about.

Juri Linkov <juri <at> linkov.net> writes:

> I tried GetDelegateList, but it returned some delegates on whose
> calling MagickRelinquishMemory caused a crash during bootstrapping.
> There is no crash when calling MagickRelinquishMemory not during
> bootstrapping, and I have no idea what is wrong.

Perhaps if you post the gdb backtrace, somebody here has an idea.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 33282 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 33282 <at> debbugs.gnu.org
Subject: Re: bug#33282: ImageMagick delegates
Date: Wed, 25 Sep 2019 23:07:30 +0300

>> WebP is an image format that is gaining popularity,
>> but currently can't be displayed by image-mode.
>
> I wonder -- do you think its popularity merits Emacs getting native
> support for it?  I don't think I've seen too many sites that serve out
> WebP only, but perhaps that'll change now what Chrome is the only web
> browser people care about.

I tried to open https://developers.google.com/speed/webp/gallery
in EWW and it displays images.  Then I clicked the right mouse button
to use the image context menu to open it in a new tab, but there is
no such menu in EWW yet (I could implement "Open image in new tab"
in EWW after merging the tabs branch).  But it seems the web server
returns PNG images when the web client doesn't support WebP format.

>> I tried GetDelegateList, but it returned some delegates on whose
>> calling MagickRelinquishMemory caused a crash during bootstrapping.
>> There is no crash when calling MagickRelinquishMemory not during
>> bootstrapping, and I have no idea what is wrong.
>
> Perhaps if you post the gdb backtrace, somebody here has an idea.

Since Emacs no longer defaults to using ImageMagick, there is no point
in trying to implement ImageMagick support for WebP anymore.  Regarding
native support, if web servers return more widespread formats as fallback
when WebP is not supported on client, then there is not much need in WebP.

Message #17 received at 33282 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 33282 <at> debbugs.gnu.org
Subject: Re: bug#33282: ImageMagick delegates
Date: Thu, 26 Sep 2019 15:52:42 +0200

Juri Linkov <juri <at> linkov.net> writes:

> I tried to open https://developers.google.com/speed/webp/gallery
> in EWW and it displays images.  Then I clicked the right mouse button
> to use the image context menu to open it in a new tab, but there is
> no such menu in EWW yet (I could implement "Open image in new tab"
> in EWW after merging the tabs branch).  But it seems the web server
> returns PNG images when the web client doesn't support WebP format.

It probably uses User-Agent sniffing, I guess...

> Since Emacs no longer defaults to using ImageMagick, there is no point
> in trying to implement ImageMagick support for WebP anymore.  Regarding
> native support, if web servers return more widespread formats as fallback
> when WebP is not supported on client, then there is not much need in WebP.

So I'm closing this bug report.  If ever WebP becomes important, then
we'll need to support it, and that should be done natively.  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.