GNU bug report logs - #33284
[PATCH] python: Honor '--cores=...' in tests.

Previous Next

Package: guix-patches;

Reported by: Eric Bavier <ericbavier <at> centurylink.net>

Date: Tue, 6 Nov 2018 02:27:01 UTC

Severity: normal

Tags: patch

Done: Eric Bavier <ericbavier <at> centurylink.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33284 in the body.
You can then email your comments to 33284 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Tue, 06 Nov 2018 02:27:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Eric Bavier <ericbavier <at> centurylink.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 06 Nov 2018 02:27:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] python: Honor '--cores=...' in tests.
Date: Mon, 5 Nov 2018 20:23:44 -0600
[Message part 1 (text/plain, inline)]
Hello Guix,

I noticed building 'python-minimal' that its tests seemed to have poor
memory performance, i.e. using *a lot* of RAM.  I thought maybe
dropping --cores=... would help, but it did not; the tests use all
available cores by default.  The attached patch fixes this issue,
though, the package still uses all cores while building some extension
libraries.

I suppose this patch would go to core-updates?

Cheers,
`~Eric
[0001-python-Honor-cores-.-in-tests.patch (text/x-patch, attachment)]
[Message part 3 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Tue, 06 Nov 2018 05:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 33284 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 33284 <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Tue, 6 Nov 2018 14:07:47 +0900
[Message part 1 (text/plain, inline)]
Hi Eric,

Your patch seems go to me, even if I think the root cause of your problem
is fixed by:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26

I think that both could be applied to core-updates.

Thanks,

Mathieu

Le mar. 6 nov. 2018 11:27, Eric Bavier <ericbavier <at> centurylink.net> a
écrit :

> Hello Guix,
>
> I noticed building 'python-minimal' that its tests seemed to have poor
> memory performance, i.e. using *a lot* of RAM.  I thought maybe
> dropping --cores=... would help, but it did not; the tests use all
> available cores by default.  The attached patch fixes this issue,
> though, the package still uses all cores while building some extension
> libraries.
>
> I suppose this patch would go to core-updates?
>
> Cheers,
> `~Eric
>
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Tue, 06 Nov 2018 14:53:01 GMT) Full text and rfc822 format available.

Message #11 received at 33284 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 33284 <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Tue, 6 Nov 2018 08:52:02 -0600
[Message part 1 (text/plain, inline)]
Hello Mathieu,

On Tue, 6 Nov 2018 14:07:47 +0900
Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:

> Hi Eric,
> 
> Your patch seems go to me, even if I think the root cause of your problem
> is fixed by:
> 
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26
> 
> I think that both could be applied to core-updates.

Thanks for the link; it looks like it should help.  But, yes, I think
both can be applied.

> 
> Le mar. 6 nov. 2018 11:27, Eric Bavier <ericbavier <at> centurylink.net> a
> écrit :
> 
> > Hello Guix,
> >
> > I noticed building 'python-minimal' that its tests seemed to have poor
> > memory performance, i.e. using *a lot* of RAM.  I thought maybe
> > dropping --cores=... would help, but it did not; the tests use all
> > available cores by default.  The attached patch fixes this issue,
> > though, the package still uses all cores while building some extension
> > libraries.
> >
> > I suppose this patch would go to core-updates?
> >
> > Cheers,
> > `~Eric
> >  

[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Tue, 06 Nov 2018 16:01:01 GMT) Full text and rfc822 format available.

Message #14 received at 33284 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Eric Bavier <ericbavier <at> centurylink.net>,
 Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 33284 <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Tue, 06 Nov 2018 17:00:01 +0100
[Message part 1 (text/plain, inline)]
Eric Bavier <ericbavier <at> centurylink.net> writes:

> Hello Mathieu,
>
> On Tue, 6 Nov 2018 14:07:47 +0900
> Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:
>
>> Hi Eric,
>> 
>> Your patch seems go to me, even if I think the root cause of your problem
>> is fixed by:
>> 
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26
>> 
>> I think that both could be applied to core-updates.
>
> Thanks for the link; it looks like it should help.  But, yes, I think
> both can be applied.

Note that the broken test has already been removed on 'core-updates'.

Eric: can you push a 'python-updates' branch?  I wonder if we have time
for a "half-rebuild" before the next 'core-updates' round; I've got some
other heavy-impact patches in my pipeline (Glib, Cairo, ++).

The patch LGTM.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Wed, 07 Nov 2018 01:23:02 GMT) Full text and rfc822 format available.

Message #17 received at 33284 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, 33284 <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Tue, 6 Nov 2018 19:22:37 -0600
[Message part 1 (text/plain, inline)]
On Tue, 06 Nov 2018 17:00:01 +0100
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Eric Bavier <ericbavier <at> centurylink.net> writes:
> 
> > Hello Mathieu,
> >
> > On Tue, 6 Nov 2018 14:07:47 +0900
> > Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:
> >  
> >> Hi Eric,
> >> 
> >> Your patch seems go to me, even if I think the root cause of your problem
> >> is fixed by:
> >> 
> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26
> >> 
> >> I think that both could be applied to core-updates.  
> >
> > Thanks for the link; it looks like it should help.  But, yes, I think
> > both can be applied.  
> 
> Note that the broken test has already been removed on 'core-updates'.
> 
> Eric: can you push a 'python-updates' branch?  I wonder if we have time
> for a "half-rebuild" before the next 'core-updates' round; I've got some
> other heavy-impact patches in my pipeline (Glib, Cairo, ++).
> 
> The patch LGTM.

Sure, I can push this to a new branch.  Thanks for the review.

`~Eric
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33284; Package guix-patches. (Wed, 07 Nov 2018 02:19:01 GMT) Full text and rfc822 format available.

Message #20 received at 33284 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 33284 <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Tue, 6 Nov 2018 20:18:22 -0600
[Message part 1 (text/plain, inline)]
On Tue, 6 Nov 2018 19:22:37 -0600
Eric Bavier <ericbavier <at> centurylink.net> wrote:

> On Tue, 06 Nov 2018 17:00:01 +0100
> Marius Bakke <mbakke <at> fastmail.com> wrote:
>
> > Eric: can you push a 'python-updates' branch?  I wonder if we have time
> > for a "half-rebuild" before the next 'core-updates' round; I've got some
> > other heavy-impact patches in my pipeline (Glib, Cairo, ++).
> > 
> > The patch LGTM.  
> 
> Sure, I can push this to a new branch.

Oops, there's already a 'python-updates' branch on savannah.  Should
that branch be deleted, or force-pushed? (sorry, haven't paid much
attention to our branch management...)

`~Eric
[Message part 2 (application/pgp-signature, inline)]

Reply sent to Eric Bavier <ericbavier <at> centurylink.net>:
You have taken responsibility. (Sat, 17 Nov 2018 06:46:02 GMT) Full text and rfc822 format available.

Notification sent to Eric Bavier <ericbavier <at> centurylink.net>:
bug acknowledged by developer. (Sat, 17 Nov 2018 06:46:02 GMT) Full text and rfc822 format available.

Message #25 received at 33284-close <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, 33284-close <at> debbugs.gnu.org
Subject: Re: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Sat, 17 Nov 2018 00:45:15 -0600
[Message part 1 (text/plain, inline)]
On Tue, 06 Nov 2018 17:00:01 +0100
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Eric Bavier <ericbavier <at> centurylink.net> writes:
> 
> > Hello Mathieu,
> >
> > On Tue, 6 Nov 2018 14:07:47 +0900
> > Mathieu Othacehe <m.othacehe <at> gmail.com> wrote:
> >  
> >> Hi Eric,
> >> 
> >> Your patch seems go to me, even if I think the root cause of your problem
> >> is fixed by:
> >> 
> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33186#26
> >> 
> >> I think that both could be applied to core-updates.  
> >
> > Thanks for the link; it looks like it should help.  But, yes, I think
> > both can be applied.  
> 
> Note that the broken test has already been removed on 'core-updates'.
> 
> Eric: can you push a 'python-updates' branch?  I wonder if we have time
> for a "half-rebuild" before the next 'core-updates' round; I've got some
> other heavy-impact patches in my pipeline (Glib, Cairo, ++).
> 
> The patch LGTM.

I've pushed this to the core-updates-next branch in commit
5b01b6034aeab32a5011c5757f18bd9772d3497d

`~Eric
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 15 Dec 2018 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 106 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.