Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 12:29:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 09 07:29:04 2018 Received: from localhost ([127.0.0.1]:42293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gL5uI-0001EO-QP for submit <at> debbugs.gnu.org; Fri, 09 Nov 2018 07:29:04 -0500 Received: from mail-it1-f177.google.com ([209.85.166.177]:34627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <npostavs@HIDDEN>) id 1gL5uG-0001Dp-W5 for 33301 <at> debbugs.gnu.org; Fri, 09 Nov 2018 07:29:01 -0500 Received: by mail-it1-f177.google.com with SMTP id t189-v6so4332862itf.1 for <33301 <at> debbugs.gnu.org>; Fri, 09 Nov 2018 04:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=h9QvRkOPRvA4ZRQrb0zyoEWZsv1bz/9Qyosofny8jZY=; b=NIqT7s/1c8/RdOxSdTxkwar3In1azWwYl0S0sfV+RdQK+hycanWRYyAgnBwFe/WW+n 2B7hQ1fkAT41a2Vs3raLswUlJz1G4T2lcxo/ukvXe7r7ZVCPt1Siwm87z6VxxF08Eng/ gh1zG27p9sxfcoZGcmQ/C45c0zHrmEP8ZAAidKfqTu+AZ2aJzg9o/X1XNxbF7klgyqa5 14IjJ1K+Q2CyDZyCJrMmmroH9B+LQWIaGvFnhHJ+M+XHkmnfCqL1A23rwxIvWJT4JmYH vO6gh9nU9lFsE/4od5QRC7KLgNd6VtPmqL+1C7YhPf2+prHXmlxJuu+l+iX15ppGYYwq AXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=h9QvRkOPRvA4ZRQrb0zyoEWZsv1bz/9Qyosofny8jZY=; b=NXqGmjIlsJgfTWDKnngy6boA8DLQi6uAW6VlNo/1SQoHUGhPwTWOnwpEHU73HXPsT4 TgSsAT7+2LIbzk0cVv8ILbxUBzn1SFiziT/nyQaFnD6JJ0MI3bafyqmZgZphwxP34BD3 qjebfMeAkM/3kmljz8enDMxIVayBZH+O2BdTtFjHS/boJW23/UfZw5IDDNTH58Heg2eR Z5qIOFxDs3yZkdyEuv9sUo6dQOqwtQrMDFFO5tFPvKKYS9xV+Iv3BxI26FFyJZql5gVA qTjHJRYHsXj/e5+FW2Z7SApdvtTCs0L+Q7SbhpkWCEASJukRaM2hgZ23tImq27to7SJH YsXg== X-Gm-Message-State: AGRZ1gJWQ4PNqVawzXm9OcO1Qm8UFFkEuTY0AjvX1jpxnj16FOye/OOy JzElsdV7bJho6JaRILNZ0eJhUUpy X-Google-Smtp-Source: AJdET5enXD1PwOlk8BVlAt8YQEgQ04JQhNVcnqa5GhLBBAZrej9MLJDkBNBXR0lqz50U2CKjrN5rOA== X-Received: by 2002:a02:9b46:: with SMTP id g6-v6mr7696275jal.60.1541766535284; Fri, 09 Nov 2018 04:28:55 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o69-v6sm644583itb.4.2018.11.09.04.28.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 04:28:54 -0800 (PST) From: Noam Postavsky <npostavs@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> <8736sbumzj.fsf@HIDDEN> <87a7mjqdym.fsf@HIDDEN> <877ehnowgy.fsf@HIDDEN> <875zx6r5a3.fsf@HIDDEN> <87efbumvd0.fsf@HIDDEN> Date: Fri, 09 Nov 2018 07:28:53 -0500 In-Reply-To: <87efbumvd0.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 09 Nov 2018 10:51:55 +0100") Message-ID: <87r2fuh1tm.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > >> OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere >> in that file. > > I think we could do that, but I don't feel qualified to decide. Maybe > Noam can help. I think it would be acceptable. > As far as the example in your bug report is concerned, I think it would > also be an improvement if elisp-mode wouldn't try be clever in such a > way when indenting branches in a cond or variable associations in a let. The problem is that we currently don't have any way of specifying indentation for subforms of macro arguments, which is also the core problem of the other bugs I mentioned about indentation of cl-flet and friends.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 09:52:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 09 04:52:05 2018 Received: from localhost ([127.0.0.1]:42234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gL3SP-0003hE-Ac for submit <at> debbugs.gnu.org; Fri, 09 Nov 2018 04:52:05 -0500 Received: from mout.web.de ([212.227.17.11]:55411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1gL3SN-0003gl-9f for 33301 <at> debbugs.gnu.org; Fri, 09 Nov 2018 04:52:03 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LeLKb-1fiQtt1CN3-00qB5L; Fri, 09 Nov 2018 10:51:56 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> <8736sbumzj.fsf@HIDDEN> <87a7mjqdym.fsf@HIDDEN> <877ehnowgy.fsf@HIDDEN> <875zx6r5a3.fsf@HIDDEN> Date: Fri, 09 Nov 2018 10:51:55 +0100 In-Reply-To: <875zx6r5a3.fsf@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 09:04:04 +0000") Message-ID: <87efbumvd0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bF1nlPksIdGY3G0kYVjVjIw0ghJQlq0xtaPGyg27HcAM12l1mQ1 zUTqQ5GsFUSyvjGwvJut5D4anpbZ5sBuK/kPnSrIZkhIUz8pvzHeOpyNH8BSOXNZugWzUQ8 UYkmUyA+KuSZ16cww6VoAs0j4ZjmC0mHtLGLB8EEXh0HRWmYfLmYRKTmaJ7Lj30saxgPhga zDxStJmCCLHdJA77/7Ygw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:bvKHy4ndAhQ=:dQk64Kl6UmaVHZnBCtamSC Nh7rFFVALYLC70HBqvmMJTenF8mgfhixmQhAgtr7VDt/2duV5FjBUPG3w2hKFKuKPKJY9ETpY 1xGWl8+WwpJdaMohSMwKmYspZiQDvVQ+9r7iCHJvdYwaDcnlKsNZPd/vg5sRINR24tP/CJjti Ys6LaiqWN3R9N+ZJ2bnKj/a99EK0zXHc2ogQMZI9OLqAtv3QM5H7thEgEboMThq2BJHZJcySt 3rp9/JAU7y9+9nHsMIN5cSp5uo2qJz19Ud8X8vLXrSy6VUz4+37bKKyO6qzckx3T3zdhMq0E5 xUzW3HR32Bj9nSnFDww9f8av63Gkc72IXwZte5RO4SkYkkOoA6/KqCLRFIOYFY0+DXklrSMtw DENW1O3PvvOFf1N+6MCKdcDwRZGCW374QvklT+5ifr/ngRY8YVfc9MJ1T2JqwUpY+T+zn5xJF anyBP8vzuII9BKQxDTm0sDcXuXWxoIBPH1f0zkj1MxJX9Vm3MBFlauOUjenI9ptsuPir1cemH iv5Fc2mvjpftQOVWiJykAhSY2CgrhJ4jrT63bNrJ6a9qhQFimopUjo7d6KCrnPpWxW7cBmByr 2y4OlrG2OYn62bjjIH6pwPG51YgHV2VkEX9uF9lSqX35UYeL+dm5TaP1O56PfzcEEFIoar2TP RtxlS+4zIpOUx7i3pCKR1t7iCpMHnf5OV43PyoOnaN35r9j1J9T1LA4vCfQG9MvZaYPjJ9I73 IG6lY4+XAn9blGo7BsmE0MQhhysXeaTDJP0JEa8/U91B4UG6naxE51nsfw+Opm+nzEelNCuHG tuZ8s5jdb/RDFjTIB982Z9ikKw0zekM97KsTAHZsvNzf+3fQi0OnFcyMtYJNB/1dtg5NzBGik 8HH48A1jM2+zCbDfsHrwu4CB2QNPzoNi+YFDnjUaDKhHUpFbjK0h91S61sYjuPMbC6fRANGKS EDW3FEPND1Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere > in that file. I think we could do that, but I don't feel qualified to decide. Maybe Noam can help. A quick search shows that the "\\`def" trick is also performed elsewhere, btw: `common-lisp-indent-function-1' does it in one place, and also `scheme-indent-function'. As far as the example in your bug report is concerned, I think it would also be an improvement if elisp-mode wouldn't try be clever in such a way when indenting branches in a cond or variable associations in a let. Michael.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 09:04:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 09 04:04:19 2018 Received: from localhost ([127.0.0.1]:42190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gL2iB-0002YL-1k for submit <at> debbugs.gnu.org; Fri, 09 Nov 2018 04:04:19 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:42639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1gL2i6-0002Y5-II for 33301 <at> debbugs.gnu.org; Fri, 09 Nov 2018 04:04:17 -0500 Received: by mail-wr1-f41.google.com with SMTP id y15-v6so1032694wru.9 for <33301 <at> debbugs.gnu.org>; Fri, 09 Nov 2018 01:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=iODe6YO8YQCYvEiDS4RztIEqmFqkIqgFim/NPkxsGZc=; b=JlmKqwWbWaYSZjuNU7pDSU1GBeu3RZgRLkzXzIf08YdOiN7o9jSCEIBadHzHhyLCVQ NZcSdiRjWJ/FCHsvHas/y8mDjUakVfEg9qzqo3dKgN+Fwld+qagbcuKTz1txqGATgfPs rLPY67Q1RyDUf9DSY7hlRyNUEhOIvYRgHouvOcW+3qnse1NFUHr2APWqNxav4tpAqMNj jeGyCqDSECqf5EZT063/zt/T2R2PXVaHscubfHgj4vENHxBtNzRzcsVYOjCa4SpceJdl 7/5Qkvib2dsgGbbqzN+uEEV4+KWkBpNUtj2f3qmyA8tjHBckxNxagq+pRSi7U+fLTkKs lWLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=iODe6YO8YQCYvEiDS4RztIEqmFqkIqgFim/NPkxsGZc=; b=TkR9dqc0NigqB9L5F3h5E/RzuRz0x/JGGb9357GpnjiXgxKmqP+hsTQftUTrCJdMap 1O6gwfZsCQKSCljLvP4tMiFferWqfl7YSIkD9/pmHQSQzFk+1eSmPtQnd/qAOIg5rbgm ot0kFwN+1LXyoadesURMuGT3WaZTcCUpU+Y3J07ElqwteOfXCM2V+5zg54au1mc9x7hn dp5vP2eB5CI12TeGlP15HnWFSfaPNPSV+mSu3f1Vdq2yGDASz6fDhI4Vi4Jqybw4vLci l5pYIuXuFjExQKp5AlaubKZX3L2qhuONndaf65OqL8MtIQduYN76r4VdN3bjMI9a1VrI zPnA== X-Gm-Message-State: AGRZ1gKljDlPqLAlcPxPIQCsmxPR9ndnTuCSMTJHCeGr0fGtTvrTDyOs RdXiWjzXohH52kAtz7mZ/q7Naz/J X-Google-Smtp-Source: AJdET5e/eiiH7DBn8hIivPxZUlQQb6KQOoppfK9DnYtR5p7OERNDp114MozTx1ieDaB1yz3fbwBujg== X-Received: by 2002:a5d:6105:: with SMTP id v5-v6mr7166505wrt.69.1541754247778; Fri, 09 Nov 2018 01:04:07 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id j40-v6sm4534928wre.48.2018.11.09.01.04.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 01:04:06 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> <8736sbumzj.fsf@HIDDEN> <87a7mjqdym.fsf@HIDDEN> <877ehnowgy.fsf@HIDDEN> Date: Fri, 09 Nov 2018 09:04:04 +0000 In-Reply-To: <877ehnowgy.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 09 Nov 2018 02:45:01 +0100") Message-ID: <875zx6r5a3.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.9 (/) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > >> This may explain the string-match hack in the first place. I don't know >> the exact motivation of the hack, but it's been there since the initial >> 2001 revision of the file. Possibly before declare/indent existed? > > But wait, this is in lisp-mode.el which I remember is used not only for > Elisp but also for other Lisps, right? Well it's lisp/emacs-lisp/... ;-) > So your patch could make things worse for editing Common Lisp, for > example. OK, just add (derived-mode-p 'emacs-lisp-mode), as is done elsewhere in that file. Or I would suggest (setq-local lisp-indent-function 'common-lisp-indent-function) in you hypothetical fancy-lisp-mode hook and has much better heuristics that don't cause the bug I've described. (But, as someone who writes CL for a living, if you're indenting CL with these heuristics, you've already lost. You should use SLY/SLIME which looks at the macroexpansion to understand what you're trying to indent.) > For Elisp the heuristic doesn't make much sense, though, if the edited > file is not loaded, it also prevents false negatives for macro uses of > macros defined in that file. I don't fully understand the "it also" part, but here's my take on this: If you're not loading the code, all things being equal, it's better to incorrectly re-indent existing "def"-macros (not defmacro) than to incorrectly indent new arbitrary "def"-forms anywhere in the AST. That's because it's a bad idea to re-indent code anyway, but indent new code happens all the time. Also, it's not a very good idea to indent without some form of evaluation anyway. Because of the indentation declaration, that ship has sailed long ago (and bon voyage). Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 01:45:12 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 20:45:12 2018 Received: from localhost ([127.0.0.1]:42078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKvrD-0006Sf-Ns for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 20:45:11 -0500 Received: from mout.web.de ([212.227.15.14]:52969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1gKvrB-0006SH-OO for 33301 <at> debbugs.gnu.org; Thu, 08 Nov 2018 20:45:10 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Ll30X-1fklgp1RTR-00annb; Fri, 09 Nov 2018 02:45:02 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> <8736sbumzj.fsf@HIDDEN> <87a7mjqdym.fsf@HIDDEN> Date: Fri, 09 Nov 2018 02:45:01 +0100 In-Reply-To: <87a7mjqdym.fsf@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Fri, 09 Nov 2018 00:41:53 +0000") Message-ID: <877ehnowgy.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:NOkoWN6GVUXWjHZO2FCrM65EuIJU/kLUS9Zc0J95kxunNTmuyhW ARF2JfxVqN0WxrZKBfQN4RDdj6Dth7FG6HIY0RNbshg/6vQ1DjQSrcjTkRGRdTVbVswFi9a Ulox/K1mASHALYUJDH1CDuWeuDx0/3Frm5poUI49iuoQV2rY5FjGVsxnhIOK2RcMmVVypeB R9U4xZvzIwtE6gjPOxyLA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:4APIT+bPORA=:sDkALJbDlA9MhzAp5XDs/Y gjNUTFpalzvrwsaYRZfxlYg/uEIPyEXO2DSx8kSVAn3NEf0xd1C734L8lHKjQ6zLm+nDrYBEU 69dZy04zLuACb6wokVsyM3PwW6LlyIvP3aX8S7iq4dSmC/j1Y4Dl9zOXFj6jk/Q67JTdGaBIG 44h8rzmKYKvbhN63JC69QgZXmvUtrU1MItdBQ1cH3dKg88kjFHkFYITFriCbwV+9PrOk0lIt3 XLGjoJd+PZJNBHKvz1SHKvitYXWZ5H240IQgsp78OSY7snpsB8PDAm+syO8wqL/R4oDz+lqb9 6pLQy5bCK+2ApTN+/+dj3i8wGFCWF7wfVBKrmqccbCJECyD1wCqQaklOrIYZnyr1sbRwt+I5/ f1pQZnLC2KglQ5epJSi4xFssqLH9Fa22XNMPGRBJH/q0vKwIN5bZZ3GriqDSB+1HheucXW0wx bGtDtQ2qThqdMSwPMz0uE29cBQ0acNoWSM4inn3nAGTV7F2C34RywI69r/0B6GAKVMAkmQ9/N xJvczY/qSV/8SfEHWFVu1gG6CkKgbza77HZRWGWXW4+d1Lpi6JeMBa+uyqFWHzMlyRLA4C9tL i3KLhTs19wMHcQv+WxzF3aO2tvEEcWliFQDoD4mozv4JYVtJgvWqiTqTBIVh2QyI0b4uUHA8l OmRzsfNOEHl+0BQralxMqbZs0tkuf51bZtkcALFKitgyZ+/Rf2EglsoyWbSxrmXEh8sjeiwjn QVQYXz+t+zgvKF+xhaN+C9ZJlj5mEkS4nGR0sfVXmV3mWZYx9p84FE1DMuWsmK7Ui5Rxw9u51 U8SVrWx2kZS2Z4r6LyQMLHlHjoptiiCSMRqDNCgp45nWJ/R58VtD/t/FtwSE/2w5cWrwqjFBp uhigF8f5S/HNHJRHOwZtHORdWmH0vLXae4ALQBTsBy1Uu4QD8xiio9nYRHQ0/lhFbjrNGSz5A TdLIvOpNprw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > This may explain the string-match hack in the first place. I don't know > the exact motivation of the hack, but it's been there since the initial > 2001 revision of the file. Possibly before declare/indent existed? But wait, this is in lisp-mode.el which I remember is used not only for Elisp but also for other Lisps, right? So your patch could make things worse for editing Common Lisp, for example. For Elisp the heuristic doesn't make much sense, though, if the edited file is not loaded, it also prevents false negatives for macro uses of macros defined in that file. Michael.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 00:42:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 19:42:06 2018 Received: from localhost ([127.0.0.1]:42041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKusA-0007Il-GQ for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 19:42:06 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:46339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1gKus8-0007IG-H5 for 33301 <at> debbugs.gnu.org; Thu, 08 Nov 2018 19:42:04 -0500 Received: by mail-wr1-f47.google.com with SMTP id 74-v6so107566wrb.13 for <33301 <at> debbugs.gnu.org>; Thu, 08 Nov 2018 16:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=8lAtZ31TdZi+ZLvCYLc3ufS+98v22j/dDkfQzeKWrb0=; b=FLe9fFs1Yz5FQzydqg2ScMNeJXFQB3dOd2UTCYZ65t1rXiRgmQUmgNtrQAseE/MSSE UVkCQMOV7iso7O5TLTHK7xf9Pyuc/8JLui7Bt/zNBnICl2n3yjrjloQ4asfDmZ3IuSWG Pt04m5YJ5O7lrZSISCS6hvy8ozr8d0wQ1R1P7GX2Y9qMd/YacE5eDsTCV+VVC/woztzr kK3z6h5KzZJs9ymvbe/tqS1eKSw2kO6S5qkna/42tyG+3HXwVR3eq6XV0Q3f/Xe1pFLy ipUp9E7NbJvxtBRKLvGSdoQfLRH3ktIPKZEVQ9172n3g/t94s0FX8qJBpdow8jDe7V3Y duZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=8lAtZ31TdZi+ZLvCYLc3ufS+98v22j/dDkfQzeKWrb0=; b=UGWDiLV45wWM2vItcbNYkE55xoXN4XxXa4rFHVOK5lt5pEC1KIhrV7FCXYil+aIAbN gH9g6OmLHZpvpXaNH6bIAqhOZ/mchD/Ie28VVH0PWEXTTyb+SZqMpiWylb7oUFhY5zXb /l2jpA8zZE5wG3vlDf8z/CvsDFb7EwdM/fFvv1SG2maj/pQtFpOD0Rs0mr+uifxuvXTP PuEkLjGAXewnvYOfNoWNKTJeoFOsddqAvV9VexrdohwUOlCxm6eEOjEQnu2vPLWtFcfc tzLl7NIhmZQ3Zw0aVlorw78YO8puKZijm1zSNbeYSn3mfTF3YgC4B3jfhzGCPIjW/J6/ 6ztg== X-Gm-Message-State: AGRZ1gIwQ4uNAHKn4TXOxsUVgrPeLK9hqzAA8qMDm243Xe+youqvzt56 hG3aKDm8eZgWLYEL+ojSvbqJjIEK X-Google-Smtp-Source: AJdET5dvGXE+8NOOECwY9sWTu1I736OBeEGG7heH/ucsuRDP3peuBNQ5XnEaZvFCkwSijwKoGydNIQ== X-Received: by 2002:adf:f589:: with SMTP id f9-v6mr6142549wro.281.1541724118296; Thu, 08 Nov 2018 16:41:58 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id r198-v6sm403336wmg.0.2018.11.08.16.41.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 16:41:57 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> <8736sbumzj.fsf@HIDDEN> Date: Fri, 09 Nov 2018 00:41:53 +0000 In-Reply-To: <8736sbumzj.fsf@HIDDEN> (Michael Heerdegen's message of "Fri, 09 Nov 2018 01:13:20 +0100") Message-ID: <87a7mjqdym.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.9 (/) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > >> Ah, that's unfortunate. Still, coundn't we improve the heuristic by >> asking if the "function" has a macro definition? Isn't that closer to >> the intended behaviour? >> >> diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el >> index afb7cbd1dd..e7373ece85 100644 >> --- a/lisp/emacs-lisp/lisp-mode.el >> +++ b/lisp/emacs-lisp/lisp-mode.el >> @@ -1104,7 +1104,8 @@ lisp-indent-function >> (cond ((or (eq method 'defun) >> (and (null method) >> (> (length function) 3) >> - (string-match "\\`def" function))) >> + (string-match "\\`def" function) >> + (macrop (intern function)))) >> (lisp-indent-defform state indent-point)) >> ((integerp method) >> (lisp-indent-specform method state > > If that macro is defined, shouldn't it already be indented correctly > without heuristics? I don't think so, not without an explicit indent declaration spec in the macro definition. This may explain the string-match hack in the first place. I don't know the exact motivation of the hack, but it's been there since the initial 2001 revision of the file. Possibly before declare/indent existed? If you're suggesting removing it entirely, I don't oppose it. There's the downside that indentation relying on it would start to fail, but diffs normally spot that and this would encourage users to add proper indent (and edebug) specs to their macros. Otherwise, I think my macrop tweak does a slightly better job at avoiding false positives. Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 9 Nov 2018 00:13:28 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 19:13:28 2018 Received: from localhost ([127.0.0.1]:42019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKuQS-0006YR-JN for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Received: from mout.web.de ([212.227.17.11]:44631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1gKuQR-0006YD-M7 for 33301 <at> debbugs.gnu.org; Thu, 08 Nov 2018 19:13:28 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M7KR8-1fXkJy45n4-00x15t; Fri, 09 Nov 2018 01:13:21 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> <87efbvrj4c.fsf@HIDDEN> Date: Fri, 09 Nov 2018 01:13:20 +0100 In-Reply-To: <87efbvrj4c.fsf@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vor?= =?utf-8?Q?a=22's?= message of "Thu, 08 Nov 2018 09:52:51 +0000") Message-ID: <8736sbumzj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:eUacmPoL4fjZYZBKiizXEFZNCJg62o/Rqls1CMGgXf+IR9S0JGk xOEPM5TGvhz6eXH9QikRFGZgm53S8yTQe1MuzXayxrYmbXa3vnJk8vDUlhIb4KQbNA1QzCv eR/secZ7maJkEw2aG0sKblNFPYZEquIEJoxyPuST0HCFWvysCujnn1+r+i/tKz4BpVvDaz3 y2NFZKHjT2bH5jOOo+pSw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:hbkYesMovjM=:hojo1F5nD0O/VelwKjzz0f 7QxztlesmaJFldetbhx/XOYqNXwYfblKp99PVY1WpykX6H5HiurTg+HwA5T8hqX4/oWH+/0+W U8a7LDiOlGNtcemeypAwBCx8a/MVKAI3tk0YgAollgk52lnYBh/RK2fpsheLWHK38OvgplHnk zA9Z7OHNqTCeClU8rpax81sPCZ2KIAKe19Bgoyu7yJVLMeEF1JnmmZQVzCgW9CkdUZzxpKydD 9Sh3y0LjNNyQGO70WvulDHrQcLaHysOXh5ZkjB5Jg2JPWbRtoDg5NNlMwNlm2uAIGzQCwLim8 BxeBvc0pJYkiqzd67FgFKOHR5MAlbL/JaUiBkZLjOp/7v09mlTC2BwNQj1UQtQBHydclFmse7 UiVWdAVpl13pTVgxxJJoyruRbWeHzF1Se7YpxtZ+gA9Gb4TubYMqWBRIAAgHtrkjPutdQAnNH GJvhXIlS6kbxUVYE8chmq5fqFKtqAAuoAbRUhzN9l7Ix0//oLFk8v74kuzTkMYm/T7wc24e9E YcHXOkclSH3gE3mspDsqKjFbiODxMCXwMp3vzKkrQXhAmKneSquEVqCEp4H0uy7sOTf5MOo+7 zktnglJaSwLM5s0YTcSyYNzyUBMDRsycu3L9hUSzPn51QRiz5OvgcaGs135BA5MXIqIvNYp9p 7WVkuyUXkXBQGUURH+ufsc5zZ7S4jUoIBdTvsVGk2WZUDYtTyETea5ZNXrnNjKeb0Pk6vQ9JY 0N2xE94CS7c/PFSf5CxfzMqmLdQhgM+QOHUzGUdxdRQWV3K7TsW/CpkDngI03PkZPSNCSnTej KU4U8IaU89oO87pyr8IcYCGsK28pTPusbZu4uGcuyuaeMgqELhjwr7NeoACGhgO7c+Fih+90V mSiJgaAlMdy6XouuPU/8j9MLeaH5SpUG4h+rmxA+WUMcSw6bkwIkrty6CjoHVEWHRVQKMRX7r eOZ0iEx86+w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > Ah, that's unfortunate. Still, coundn't we improve the heuristic by > asking if the "function" has a macro definition? Isn't that closer to > the intended behaviour? > > diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el > index afb7cbd1dd..e7373ece85 100644 > --- a/lisp/emacs-lisp/lisp-mode.el > +++ b/lisp/emacs-lisp/lisp-mode.el > @@ -1104,7 +1104,8 @@ lisp-indent-function > (cond ((or (eq method 'defun) > (and (null method) > (> (length function) 3) > - (string-match "\\`def" function))) > + (string-match "\\`def" function) > + (macrop (intern function)))) > (lisp-indent-defform state indent-point)) > ((integerp method) > (lisp-indent-specform method state If that macro is defined, shouldn't it already be indented correctly without heuristics? Michael.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 09:53:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 04:53:06 2018 Received: from localhost ([127.0.0.1]:40316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKgzn-0003ul-Tg for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:53:04 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <joaotavora@HIDDEN>) id 1gKgzm-0003uG-6S for 33301 <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:53:02 -0500 Received: by mail-wm1-f48.google.com with SMTP id b203-v6so549913wme.5 for <33301 <at> debbugs.gnu.org>; Thu, 08 Nov 2018 01:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=EgNHcQFpJ955i2TRHeETE7niGbIMtakSSqlGlbnaQxjBqCfi5xLPo+ru7CoKngOLjF S4Dm7CkH2EVjdjAo0dawjcCr/2wCRPBjvb/OPrk55jWf+DZ5uyv+tjhOqIJ42qyLTkos E75NPOhRgItKlN+VfBfA5OxjaZJ0EKz1z7NfcfhrCFAayPAB6JjbSLNlPxOwYFLOGKnU LWdaioit4CrNGQyEPGGCBarl8J3SjnAaMbIZ9/MwRbvi05e+WjXSauGGqu9DAXwkCQUT Tsbgu7fk8XAgOhxYI9Ra1EH3SR2Sa+L/QTwTFuhNksprZVik0Bd4ZI2WGZNTqX3X+iiK ccjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=qA40eBDyTuiGQrraD+zY4a9WtsFVyUeqYfei+msKoIg=; b=kd3br5xUIpS3GlrHWSJpnbpIHVkDdlzc7qATYvXt94SRhD96c9r7sS2EoKTy0y5R9V Av2zU1L8yaeNWWIBJwYVjAuTQ9dal0yK9y4veFdz2Swhc3w06x6evzWzGkQHNbyZXKEw CTQMf65RUmyL/YmBnZpt/nvPWAlPW3JHjg9yhTIAyUuOSZiU3fR4ve2C2mskRPyJSgo3 9LPb3XfdOpk4ESSWXAUk3+1y1KBPFEKZZQgOhpd1EpnEy3tUO3AvWpaT1oFwV0gqgKTg m9zn0RhDazbQ+F97NhfnT1uB5xC+MxL9krExsDaup8qO/DVD7pHOCowAdBGDQJj/ZgYF QMoA== X-Gm-Message-State: AGRZ1gJlV1udyt8bVHezbl8K/HtMY2RMCAqLzaJjnnPy0w+lBxzKyw3A 5v5BJEv0ng4c+ZRPpQIYHE96Jc4V X-Google-Smtp-Source: AJdET5cepb3kCJR+OAB+uWMQrAFdHzQ/6JWiBLrEqPYmx6/SKAYcIdI8+U4VZtfOifs0yw4Ka+HMLQ== X-Received: by 2002:a1c:6a09:: with SMTP id f9-v6mr618935wmc.78.1541670775163; Thu, 08 Nov 2018 01:52:55 -0800 (PST) Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id s195-v6sm2635604wmd.39.2018.11.08.01.52.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Nov 2018 01:52:54 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." In-Reply-To: <87tvksv21u.fsf@HIDDEN> (Michael Heerdegen's message of "Thu, 08 Nov 2018 01:35:41 +0100") References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> <87tvksv21u.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Thu, 08 Nov 2018 09:52:51 +0000 Message-ID: <87efbvrj4c.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, Noam Postavsky <npostavs@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.9 (/) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > Noam Postavsky <npostavs@HIDDEN> writes: > >> > (cond (bla >> > ok) >> > (defan >> > strange)) > > That's explicitly done in 'lisp-indent-function': > (and (null method) > (> (length function) 3) > (string-match "\\`def" function))) ;; <=3D=3D Ah, that's unfortunate. Still, coundn't we improve the heuristic by asking if the "function" has a macro definition? Isn't that closer to the intended behaviour? diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index afb7cbd1dd..e7373ece85 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -1104,7 +1104,8 @@ lisp-indent-function (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) - (string-match "\\`def" function))) + (string-match "\\`def" function) + (macrop (intern function)))) (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state Jo=C3=A3o
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 00:35:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 07 19:35:50 2018 Received: from localhost ([127.0.0.1]:40142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKYIY-0005HE-2C for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 19:35:50 -0500 Received: from mout.web.de ([217.72.192.78]:57637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1gKYIW-0005H0-TZ for 33301 <at> debbugs.gnu.org; Wed, 07 Nov 2018 19:35:49 -0500 Received: from drachen.dragon ([94.218.210.177]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LzKIP-1fP41v07qz-014RFf; Thu, 08 Nov 2018 01:35:42 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Noam Postavsky <npostavs@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> <87zhukh1ri.fsf@HIDDEN> Date: Thu, 08 Nov 2018 01:35:41 +0100 In-Reply-To: <87zhukh1ri.fsf@HIDDEN> (Noam Postavsky's message of "Wed, 07 Nov 2018 19:05:37 -0500") Message-ID: <87tvksv21u.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Hj/125RYC8aBc2nbOD2nmMlVvitY/VEy1pyERSUe1doRSHc2C/u eJzJE5GroWqfVvcxyrbhtFLn4d9CwkTJ0/jl37k3Gb4nLSf5KnOy/hv2okfmvw9bgZp8cV4 B5cfBcl3WslElwIzLnw+f/7hyxxoV8DaV+X7nVyP847maFTC4Nyq0PsYi4v1JSyG+DPSXQ6 HNcyMdoNpThx3PO3UOJbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V01:K0:oxUi+OaiUto=:fXPGxSzkjPTKoPD2MCQ9z0 JBWkn54vkMmFmK/k4FdfRVk9x25lnYJvfYSBM6XZsFIowsuDU6Z/JSsV/jpDQ6u+9uAbBZ2iq 1jJz+ztJ9/LVEo6PxeFcGvO/elZEHKIlXm+IdJQyzUTzR+i5qJ9ByAqLC6B8sB9yoH+e/PXj+ LlAsAQTnAuwjPqxQE0waA9bgDxPzg3CXK6/Jfc5+Dh6QS603ZF5U6ZQqxawwkFRz0kj70XgeL +STS01dE81qiw1fuKTeq9OrZkN7dalHChW9o0XtjeE1SknTg7ONg5/psiseFpfhFFYCRleBTe ik/Cxd50z7UaCn11phWHZpfGjkkJ+IDxQpo3t8s01uFsbxcZDXwZmfZiwu7pGWcClxW6old9l 0HfafhygzGji/yJtipFEXkjXn3TlcvLKETRqmXaG3aEnDkUCqhfXI+LlGGBCf0YWoarCEWDx5 kcZnNl9l3gZEe7px8MCNZbu5yGRpxhOWLcxl/bhJ24kEKUR73iwObrH6MmMZNTWlQ+ztAEeyg tSzMP47KgT2nHGqP/xNBnbTqWrWuRgb82cLRfAQZCxIPCEl8ASvaijtzKj3A7m+60YlyiVlGP stS7l8kkROuK0dpVn4VYEpaXIqtyf4fAY0ZJXppUjmKcRxUXn9d85NnJOQMysr6MLzH/6/YoY qwSkeHSn23RnXV5YxYxPsUYHr4FjtpJyng3wST4fEF+ML6LHMHNycBtK6OMfmfbNo4Xcuz0+Q tWL9oB9JXs36EuEVdh7hsWOZxg+hl2ksZpYc8j7IVYOVSOB/KyVv9h20tbStf3tKdnhE2qIne zC4ESz/BHCBvNjj76lR4UBCcrMvOewKwtD9g0JBwGv9rCzLWKthFtM5rhBsRbOs76i/MOgug4 xsSfmMivXL7kvD5/Ep6NhGzzSubHNQvp2MmrGya9/i/VBEYNrDviSw5ZL5ioeCevZCrOaQm3q k0FpUsFZBQg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Noam Postavsky <npostavs@HIDDEN> writes: > > (cond (bla > > ok) > > (defan > > strange)) That's explicitly done in 'lisp-indent-function': (cond ((or (eq method 'defun) (and (null method) (> (length function) 3) (string-match "\\`def" function))) ;; <== (lisp-indent-defform state indent-point)) ((integerp method) (lisp-indent-specform method state indent-point normal-indent)) (method (funcall method indent-point state))) Michael.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.Noam Postavsky <npostavs@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Noam Postavsky <npostavs@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 33301) by debbugs.gnu.org; 8 Nov 2018 00:05:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 07 19:05:46 2018 Received: from localhost ([127.0.0.1]:40133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gKXpS-0002SV-I0 for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 19:05:46 -0500 Received: from mail-it1-f176.google.com ([209.85.166.176]:35470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <npostavs@HIDDEN>) id 1gKXpQ-0002S3-KJ; Wed, 07 Nov 2018 19:05:44 -0500 Received: by mail-it1-f176.google.com with SMTP id v11so19431027itj.0; Wed, 07 Nov 2018 16:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9CnZ05ixbUsZ2hIyBf8zYZcA74k6ub1ePjDfmxC+tDk=; b=TomKQPHA6gBbDDm2yvwuoVXj91AcCj/lhNPZcIBUAyog6qMseXCI5xjod5HOfHC+nb nX2IdSrJqdCpp2PfbC7GF3D6YbBQ6SODe9cZKNn9LZ/Ohd4AS/e8F8MjiwHbGf0cz+yT HSLnxcgQLhxjiZwCq/D+JbNEpqryuqJ505pG8GRnUKT9z6thRzC5NqtedTMnMXx0Xejh fif7+AZY1tnZW/emiZGbVc1REeOgflPZvxIAISMlHcq56ype5I0BqdsmHvQpl5La0H8I 7Dfw2KhSmDgj9DGdMZmWGuBd8oZrnrQ+nweQ4vIfqR+OAfrld5D67MtzF/Iw6j/+N8g7 trpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9CnZ05ixbUsZ2hIyBf8zYZcA74k6ub1ePjDfmxC+tDk=; b=hKO61y1AsArI2EQd2Ppx97lnQIuotYSexuJ6wOpfcpfXtZDueLstn12og3FpvS93V/ j17wHUlS6ThK82ebeBQeJh+lyNGMJ4QaelMBPjxuWaauoiGmIKb6QxOGXP1RF4moekXN U7CQXy3qnX2ysn69/n1A4itcAgO8jH9rzbT6GN3H5FderM1o7zJ6mQhd1zMLNhbHm/le Q+fpyWzYMUeKPSQ2DRCweXg/PTbF3BDxIRLSFTWi498rZ+t6gfmfOhNEXkp8zQ3oTvP/ kVqVzD6Qcxag4LX0h2FAplBRfB31GrAY35SufsvYo17ss7M3rcE2xfKsUydJgX366W5u 0I4w== X-Gm-Message-State: AGRZ1gK5RoYjnIkyWLm5eMpKdLY8fFMCSAJKwTT/cqs6XaO0lLL0Lk24 gRyNgVq5dIXPaZMYCBhwHnvtLpgo X-Google-Smtp-Source: AJdET5cXSDX8T6UuBrYRuZ8R0u9SQ+eRMguaIFc1UnA31JC1HJl3F/ZPUjt3YxjbOliWSOJodTasPA== X-Received: by 2002:a02:3b12:: with SMTP id c18-v6mr2016935jaa.11.1541635538934; Wed, 07 Nov 2018 16:05:38 -0800 (PST) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w124-v6sm440507ita.0.2018.11.07.16.05.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Nov 2018 16:05:38 -0800 (PST) From: Noam Postavsky <npostavs@HIDDEN> To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= <joaotavora@HIDDEN> Subject: Re: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." References: <jjbwopp3twc.fsf@HIDDEN> Date: Wed, 07 Nov 2018 19:05:37 -0500 In-Reply-To: <jjbwopp3twc.fsf@HIDDEN> (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vo?= =?utf-8?Q?ra=22's?= message of "Wed, 07 Nov 2018 13:21:39 +0000") Message-ID: <87zhukh1ri.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33301 Cc: 33301 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) found 33301 24.3 tags 33301 + confirmed quit Jo=C3=A3o T=C3=A1vora <joaotavora@HIDDEN> writes: > This doesn't seem the correct indentation for the following elisp forms: > > (let ((bla > (ok)) > (defan > (strange)))) > > (cond (bla > ok) > (defan > strange)) > > ...but that's the way Emacs -Q does it. I'd be suprised if this weren't > a duplicate, but I thought I'd report it just in case. I can't find any duplicate, though it's certainly not new. Bug#9622 and Bug#23108 are sort of related.
bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 7 Nov 2018 13:21:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 07 08:21:59 2018
Received: from localhost ([127.0.0.1]:38237 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1gKNmR-0003HB-4X
for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 08:21:59 -0500
Received: from eggs.gnu.org ([208.118.235.92]:44411)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <joaotavora@HIDDEN>) id 1gKNmP-0003Gy-Cw
for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 08:21:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <joaotavora@HIDDEN>) id 1gKNmJ-00044e-Mz
for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 08:21:52 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM
autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:46085)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71) (envelope-from <joaotavora@HIDDEN>)
id 1gKNmJ-00044U-Ii
for submit <at> debbugs.gnu.org; Wed, 07 Nov 2018 08:21:51 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54001)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from <joaotavora@HIDDEN>) id 1gKNmI-00027D-Qr
for bug-gnu-emacs@HIDDEN; Wed, 07 Nov 2018 08:21:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <joaotavora@HIDDEN>) id 1gKNmD-00042O-UW
for bug-gnu-emacs@HIDDEN; Wed, 07 Nov 2018 08:21:50 -0500
Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:43300)
by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
(Exim 4.71) (envelope-from <joaotavora@HIDDEN>)
id 1gKNmD-000417-O4
for bug-gnu-emacs@HIDDEN; Wed, 07 Nov 2018 08:21:45 -0500
Received: by mail-wr1-x429.google.com with SMTP id y3-v6so17072485wrh.10
for <bug-gnu-emacs@HIDDEN>; Wed, 07 Nov 2018 05:21:44 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:subject:date:message-id:user-agent:mime-version
:content-transfer-encoding;
bh=g7wf7Qb1huWy/rCn5qlMzpSstg7RthddRGs0+QYT4k8=;
b=KjXCXzPvYIBEe5X/Yg+cw+oQ2ag0qA4cUBLmEvKI6zuVlIbHdiJxHSFmpXJKkdteXg
1DH/+EHalnr6mx/yM+plh5mA6SdywR+BKiwdm/lD8NLQ6fBtburjwqNUhAYqBJnDaUVh
fY6IhNaknaepkGog7WnS4wu7VOkHvya+10aME71MShUJNBB9M3z54IWCuZgnU4YtZ/Nw
wKnaYHuzU9Ns8MsLuvh4Hd2gppBNVsbip6f2OKU5GJxN7HXEC7MyMIbz9JK7Fwciq7GY
mRmKLVCWFjUXKfsP/gx+y/2uolKYZeKg97dCpa7LtsFj57i3uv4UBm1VxU4Y50kTpf4W
g8gw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:user-agent
:mime-version:content-transfer-encoding;
bh=g7wf7Qb1huWy/rCn5qlMzpSstg7RthddRGs0+QYT4k8=;
b=mqiYwoSeANvIM3s7UFGmpHRK49HvQmtRqHfJ6WzG3f9+HT02spmT38SMCKiMU8AGgS
23PEwLkOx4sZm30ryMYMdObFlVS3pTAR2gVcdDmTtyaaBlcO7OSpftMBv+ySw4AOsKFs
+hQZlzbOpU2KFgtH4CCW8jtWCMU71gZEOy5ssmKOARYmYb9+2sRW8fV/YLuyvLr9hjj/
9fi8PjAO8gUqloNnBzJPX6RCXzlMJ9eNeH8A4OVBxBKSCvgZLggQJLPrx32p9zh5X2k6
YU3k3glm1wj5wXEMteQCYpCt1k6HmlvSGt4h2dI6xj7NPBV1s1saRAwprd7+OyRz9njx
/fcg==
X-Gm-Message-State: AGRZ1gL0pdHniL7lkiB+erz8NdoQ01he4qcd1/cmgSFbV9W2nOtxBklD
siDg5rhcaDzaE7ZlftuhW1CJxQ/0
X-Google-Smtp-Source: AJdET5cNBZcjwHI5ch3l5hfA5e65JNqzBhCEsQF97z34eJJdhwgMbP5Wy4MyA2hYFZja5Mixpl0Z0A==
X-Received: by 2002:adf:8043:: with SMTP id 61-v6mr181109wrk.23.1541596903447;
Wed, 07 Nov 2018 05:21:43 -0800 (PST)
Received: from GONDOMAR.yourcompany.com (mail1.siscog.pt. [89.115.233.242])
by smtp.gmail.com with ESMTPSA id c24-v6sm854504wre.30.2018.11.07.05.21.42
for <bug-gnu-emacs@HIDDEN>
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Wed, 07 Nov 2018 05:21:42 -0800 (PST)
From: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= <joaotavora@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 27.0.50;
broken elisp indentation for non-definition symbols starting with
"def.."
Date: Wed, 07 Nov 2018 13:21:39 +0000
Message-ID: <jjbwopp3twc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Antivirus: AVG (VPS 181107-0, 07-11-2018), Outbound message
X-Antivirus-Status: Clean
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
recognized.
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)
Hi maintainers,
This doesn't seem the correct indentation for the following elisp forms:
(let ((bla
(ok))
(defan
(strange))))
(cond (bla
ok)
(defan
strange))
...but that's the way Emacs -Q does it. I'd be suprised if this weren't
a duplicate, but I thought I'd report it just in case.
Thanks,
Jo=E3o
João Távora <joaotavora@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#33301; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.