GNU bug report logs - #33308
[PATCH 0/2] Update mash and capnproto.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33308 in the body.
You can then email your comments to 33308 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Update mosh and capnproto.
Date: Wed, 07 Nov 2018 19:45:30 +0000

[Message part 1 (text/plain, inline)]

Update the mosh and capnproto packages. I want to update capnproto, and
I updated mosh along with it, as initially it failed to build with the
newer capnproto version.

Christopher Baines (2):
  gnu: mash: Update to 2.1.
  gnu: capnproto: Update to 0.7.0.

 gnu/packages/bioinformatics.scm | 14 +++++++++++---
 gnu/packages/serialization.scm  | 10 ++++++++--
 2 files changed, 19 insertions(+), 5 deletions(-)

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33308 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: capnproto: Update to 0.7.0.
Date: Wed,  7 Nov 2018 19:56:54 +0000

* gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
[source]: Update sha256 hash.
[arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
use /tmp for tempory files, as the default /var/tmp directory doesn't exist.
---
 gnu/packages/serialization.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 40b3d1bae0..77fd070bc7 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -314,7 +314,7 @@ it a convenient format to store user input files.")
 (define-public capnproto
   (package
     (name "capnproto")
-    (version "0.6.1")
+    (version "0.7.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -322,7 +322,7 @@ it a convenient format to store user input files.")
                     version ".tar.gz"))
               (sha256
                (base32
-                "010s9yhq4531wvdfrdf2477zswhck6cjfby79w73rff3v06090l0"))))
+                "0hfdnhlbskagzgvby8wy6lrxj53zfzpfqimbhga68c0ji2yw1969"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
@@ -332,6 +332,12 @@ it a convenient format to store user input files.")
              ;; Workaround for test that tries to resolve port name from
              ;; /etc/services, which is not present in build environment.
              (substitute* "src/kj/async-io-test.c++" ((":http") ":80"))
+             #t))
+         (add-before 'check 'use-tmp-for-tempory-files
+           (lambda _
+             (substitute* "src/kj/filesystem-disk-test.c++"
+               (("VAR\\_TMP \"/var/tmp\"")
+                "VAR_TMP \"/tmp\""))
              #t)))))
     (home-page "https://capnproto.org")
     (synopsis "Capability-based RPC and serialization system")
-- 
2.19.1

Message #11 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33308 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: mash: Update to 2.1.
Date: Wed,  7 Nov 2018 19:56:53 +0000

I'm looking to upgrade capnproto, and mash fails to build with 0.7. Therefore,
update it, and tweak the compilation to allow it to build with 0.7. The
package also builds with the current version of capnproto. I got the idea of
changing the c++ version from here [1].

1: https://github.com/marbl/Mash/issues/98

* gnu/packages/bioinformatics.scm (mash)[version]: Change to 2.1.
[source]: Update sha256 hash.
[arguments]: Add new use-c++14 phase, to patch source to build using c++14.
---
 gnu/packages/bioinformatics.scm | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 9f0b8025da..93503d82b8 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -3977,7 +3977,7 @@ sequences).")
 (define-public mash
   (package
     (name "mash")
-    (version "2.0")
+    (version "2.1")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -3986,7 +3986,7 @@ sequences).")
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "00fx14vpmgsijwxd1xql3if934l82v8ckqgjjyyhnr36qb9qrskv"))
+                "0d5m9wx1bspa5vwikazdbar4i0h6b20lzjjl1icfyl66sy1q9v9q"))
               (modules '((guix build utils)))
               (snippet
                '(begin
@@ -4012,7 +4012,15 @@ sequences).")
                (("^#include \"kseq\\.h\"")
                 "#include \"htslib/kseq.h\""))
              #t))
-         (add-after 'fix-includes 'autoconf
+         (add-after 'fix-includes 'use-c++14
+           (lambda _
+             ;; capnproto 0.7 requires c++14 to build
+             (substitute* "configure.ac"
+               (("c\\+\\+11") "c++14"))
+             (substitute* "Makefile.in"
+               (("c\\+\\+11") "c++14"))
+             #t))
+         (add-after 'use-c++14 'autoconf
            (lambda _ (zero? (system* "autoconf")))))))
     (native-inputs
      `(("autoconf" ,autoconf)
-- 
2.19.1

Message #14 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 0/2] Update mosh and capnproto.
Date: Wed, 7 Nov 2018 15:19:19 -0500

[Message part 1 (text/plain, inline)]

On Wed, Nov 07, 2018 at 07:45:30PM +0000, Christopher Baines wrote:
> Update the mosh and capnproto packages. I want to update capnproto, and
> I updated mosh along with it, as initially it failed to build with the
> newer capnproto version.

I got excited about a new release of mosh (the mobile shell). You mean
mash, right? :)

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 1/2] gnu: mash: Update to 2.1.
Date: Wed, 7 Nov 2018 21:23:27 -0600

[Message part 1 (text/plain, inline)]

On Wed,  7 Nov 2018 19:56:53 +0000
Christopher Baines <mail <at> cbaines.net> wrote:


> * gnu/packages/bioinformatics.scm (mash)[version]: Change to 2.1.
> [source]: Update sha256 hash.

I think here we typically just say "(mash)[source]: Upgrade to 2.1."

> [arguments]: Add new use-c++14 phase, to patch source to build using c++14.
> ---
>  gnu/packages/bioinformatics.scm | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
> index 9f0b8025da..93503d82b8 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -4012,7 +4012,15 @@ sequences).")
>                 (("^#include \"kseq\\.h\"")
>                  "#include \"htslib/kseq.h\""))
>               #t))
> -         (add-after 'fix-includes 'autoconf
> +         (add-after 'fix-includes 'use-c++14
> +           (lambda _
> +             ;; capnproto 0.7 requires c++14 to build
> +             (substitute* "configure.ac"
> +               (("c\\+\\+11") "c++14"))
> +             (substitute* "Makefile.in"
> +               (("c\\+\\+11") "c++14"))

I believe the configure.ac patch is sufficient for us here, since the
compile steps will pick up the CPPFLAGS set there.  Too bad the
configure.ac is written so poorly... :(  one should be able to just
pass "CPPFLAGS=-std=c++14" to `make`.

> +             #t))
> +         (add-after 'use-c++14 'autoconf
>             (lambda _ (zero? (system* "autoconf")))))))

Maybe you could also update this step to use 'invoke'.

Thanks,
`~Eric

[Message part 2 (application/pgp-signature, inline)]

Message #20 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 2/2] gnu: capnproto: Update to 0.7.0.
Date: Sat, 10 Nov 2018 23:22:06 +0100

Hello,

Christopher Baines <mail <at> cbaines.net> skribis:

> * gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
> [source]: Update sha256 hash.
> [arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
> use /tmp for tempory files, as the default /var/tmp directory doesn't exist.

I’d suggest moving the /var/tmp explanation in a comment but otherwise
LGTM, thanks!

Ludo’.

Message #23 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33308 <at> debbugs.gnu.org
Subject: [PATCH v2 2/2] gnu: capnproto: Update to 0.7.0.
Date: Mon, 26 Nov 2018 19:04:33 +0000

* gnu/packages/serialization.scm (capnproto): Update to 0.7.0.
[arguments]: Add new 'use-tmp-for-tempory-files phase.
---
 gnu/packages/serialization.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 2df0ce1364..2d61f7451b 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -306,7 +306,7 @@ it a convenient format to store user input files.")
 (define-public capnproto
   (package
     (name "capnproto")
-    (version "0.6.1")
+    (version "0.7.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -314,7 +314,7 @@ it a convenient format to store user input files.")
                     version ".tar.gz"))
               (sha256
                (base32
-                "010s9yhq4531wvdfrdf2477zswhck6cjfby79w73rff3v06090l0"))))
+                "0hfdnhlbskagzgvby8wy6lrxj53zfzpfqimbhga68c0ji2yw1969"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
@@ -324,6 +324,14 @@ it a convenient format to store user input files.")
              ;; Workaround for test that tries to resolve port name from
              ;; /etc/services, which is not present in build environment.
              (substitute* "src/kj/async-io-test.c++" ((":http") ":80"))
+             #t))
+         (add-before 'check 'use-tmp-for-tempory-files
+           (lambda _
+             ;; Use /tmp for tempory files, as the default /var/tmp directory
+             ;; doesn't exist.
+             (substitute* "src/kj/filesystem-disk-test.c++"
+               (("VAR\\_TMP \"/var/tmp\"")
+                "VAR_TMP \"/tmp\""))
              #t)))))
     (home-page "https://capnproto.org")
     (synopsis "Capability-based RPC and serialization system")
-- 
2.19.2

Message #26 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33308 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] gnu: mash: Fix build with capnproto 0.7.
Date: Mon, 26 Nov 2018 19:04:32 +0000

I'm looking to upgrade capnproto, and mash fails to build with 0.7. Therefore,
tweak the compilation to allow it to build with 0.7. The package also builds
with the current version of capnproto. I got the idea of changing the c++
version from here [1].

1: https://github.com/marbl/Mash/issues/98

* gnu/packages/bioinformatics.scm (mash)[arguments]: Add new use-c++14 phase.
---
 gnu/packages/bioinformatics.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
index 782af294e0..571d85aed7 100644
--- a/gnu/packages/bioinformatics.scm
+++ b/gnu/packages/bioinformatics.scm
@@ -4018,6 +4018,14 @@ sequences).")
                             "src/mash/CommandScreen.cpp")
                (("^#include \"kseq\\.h\"")
                 "#include \"htslib/kseq.h\""))
+             #t))
+         (add-after 'fix-includes 'use-c++14
+           (lambda _
+             ;; capnproto 0.7 requires c++14 to build
+             (substitute* "configure.ac"
+               (("c\\+\\+11") "c++14"))
+             (substitute* "Makefile.in"
+               (("c\\+\\+11") "c++14"))
              #t)))))
     (native-inputs
      `(("autoconf" ,autoconf)
-- 
2.19.2

Message #31 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 0/2] Update mosh and capnproto.
Date: Mon, 26 Nov 2018 19:25:56 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Nov 07, 2018 at 07:45:30PM +0000, Christopher Baines wrote:
>> Update the mosh and capnproto packages. I want to update capnproto, and
>> I updated mosh along with it, as initially it failed to build with the
>> newer capnproto version.
>
> I got excited about a new release of mosh (the mobile shell). You mean
> mash, right? :)

Yep, sorry about that, I've fixed the title of the bug now.

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 2/2] gnu: capnproto: Update to 0.7.0.
Date: Mon, 26 Nov 2018 19:27:23 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hello,
>
> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> * gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
>> [source]: Update sha256 hash.
>> [arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
>> use /tmp for tempory files, as the default /var/tmp directory doesn't exist.
>
> I’d suggest moving the /var/tmp explanation in a comment but otherwise
> LGTM, thanks!

Great, I've done this now, and sent some updated patches.

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 33308 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: 33308 <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH 1/2] gnu: mash: Update to 2.1.
Date: Mon, 26 Nov 2018 19:35:42 +0000

[Message part 1 (text/plain, inline)]

Eric Bavier <ericbavier <at> centurylink.net> writes:

> On Wed,  7 Nov 2018 19:56:53 +0000
> Christopher Baines <mail <at> cbaines.net> wrote:
>
>
>> * gnu/packages/bioinformatics.scm (mash)[version]: Change to 2.1.
>> [source]: Update sha256 hash.
>
> I think here we typically just say "(mash)[source]: Upgrade to 2.1."

Ok, I've sent a new set of patches now, and updated the commit messages.

>> [arguments]: Add new use-c++14 phase, to patch source to build using c++14.
>> ---
>>  gnu/packages/bioinformatics.scm | 14 +++++++++++---
>>  1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm
>> index 9f0b8025da..93503d82b8 100644
>> --- a/gnu/packages/bioinformatics.scm
>> +++ b/gnu/packages/bioinformatics.scm
>> @@ -4012,7 +4012,15 @@ sequences).")
>>                 (("^#include \"kseq\\.h\"")
>>                  "#include \"htslib/kseq.h\""))
>>               #t))
>> -         (add-after 'fix-includes 'autoconf
>> +         (add-after 'fix-includes 'use-c++14
>> +           (lambda _
>> +             ;; capnproto 0.7 requires c++14 to build
>> +             (substitute* "configure.ac"
>> +               (("c\\+\\+11") "c++14"))
>> +             (substitute* "Makefile.in"
>> +               (("c\\+\\+11") "c++14"))
>
> I believe the configure.ac patch is sufficient for us here, since the
> compile steps will pick up the CPPFLAGS set there.  Too bad the
> configure.ac is written so poorly... :(  one should be able to just
> pass "CPPFLAGS=-std=c++14" to `make`.

I tried removing the Makefile.in change, but it didn't work for some
reason.

>> +             #t))
>> +         (add-after 'use-c++14 'autoconf
>>             (lambda _ (zero? (system* "autoconf")))))))
>
> Maybe you could also update this step to use 'invoke'.

This patch has now turned in to just fixing the package for the newer
version of capnproto, as Ricardo did the upgrade a few weeks ago. This
particular stage was removed in
e35dce017090685d07aedf10c9899c0cdcc70d9e.

Thanks for your comments Eric :)

[signature.asc (application/pgp-signature, inline)]

Message #42 received at 33308-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 33308-done <at> debbugs.gnu.org
Subject: Re: [bug#33308] [PATCH v2 2/2] gnu: capnproto: Update to 0.7.0.
Date: Wed, 05 Dec 2018 20:34:26 +0000

[Message part 1 (text/plain, inline)]

I've now gone ahead and pushed these two patches [1]. Thanks for taking
a look :)

1: As 9c5f4b82bb0ed6a0447a68f9cb18c4da5f692acf and
9c5f4b82bb0ed6a0447a68f9cb18c4da5f692acf

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.