GNU bug report logs - #33310
Cuirass: Evaluations adding no new builds are displayed as "failing"

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Reported by: Clément Lassieur <clement@HIDDEN>; dated Thu, 8 Nov 2018 09:35:01 UTC; Maintainer for guix is bug-guix@HIDDEN.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 11 Nov 2018 13:37:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 11 08:37:17 2018
Received: from localhost ([127.0.0.1]:45392 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gLpvQ-0006RB-P4
	for submit <at> debbugs.gnu.org; Sun, 11 Nov 2018 08:37:17 -0500
Received: from eggs.gnu.org ([208.118.235.92]:40856)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1gLpvO-0006Qz-PU
 for submit <at> debbugs.gnu.org; Sun, 11 Nov 2018 08:37:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1gLpvJ-0001VM-08
 for submit <at> debbugs.gnu.org; Sun, 11 Nov 2018 08:37:09 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:51167)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ludo@HIDDEN>) id 1gLpvI-0001V9-T4
 for submit <at> debbugs.gnu.org; Sun, 11 Nov 2018 08:37:08 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50457)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1gLpvI-0008Dw-6K
 for bug-guix@HIDDEN; Sun, 11 Nov 2018 08:37:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1gLpvH-0001Ua-Ie
 for bug-guix@HIDDEN; Sun, 11 Nov 2018 08:37:08 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47431)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1gLpvH-0001UR-Cs; Sun, 11 Nov 2018 08:37:07 -0500
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=48026 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1gLpvH-0003MU-1e; Sun, 11 Nov 2018 08:37:07 -0500
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@HIDDEN>
Subject: Re: Cuirass: Evaluations adding no new builds are displayed as
 "failing"
References: <87y3a352w1.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 21 Brumaire an 227 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Sun, 11 Nov 2018 14:37:05 +0100
In-Reply-To: <87y3a352w1.fsf@HIDDEN> (=?utf-8?Q?=22Cl=C3=A9ment?=
 Lassieur"'s message of "Thu, 08 Nov 2018 10:34:22 +0100")
Message-ID: <87k1ljspku.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: submit
Cc: Bug Guix <bug-guix@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

Hello,

Cl=C3=A9ment Lassieur <clement@HIDDEN> skribis:

> Evaluations adding no new builds are displayed as "failing".  I know
> this was done on purpose, but I think the check should be done on the
> number of jobs returned by the evaluator, rather than on the number of
> builds registered in the database.

Indeed, that makes sense.  For the record the faulty code was added in
commit 0b40dca734468e8b12b3ff58e3e779679f17d38e.  As I wrote there, it
would be ideal to have a =E2=80=9Cfailed=E2=80=9D bit in the database, and,=
 even better,
to save the output of =E2=80=98evaluate=E2=80=99.

Thanks,
Ludo=E2=80=99.




Information forwarded to bug-guix@HIDDEN:
bug#33310; Package guix. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Nov 2018 09:34:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 08 04:34:52 2018
Received: from localhost ([127.0.0.1]:40307 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gKgiC-0003R1-2l
	for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:34:52 -0500
Received: from eggs.gnu.org ([208.118.235.92]:45617)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <clement@HIDDEN>) id 1gKgiA-0003Qp-KQ
 for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:34:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <clement@HIDDEN>) id 1gKgi1-0001In-OQ
 for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:34:44 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:38061)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <clement@HIDDEN>)
 id 1gKgi0-0001Go-VW
 for submit <at> debbugs.gnu.org; Thu, 08 Nov 2018 04:34:41 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55198)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <clement@HIDDEN>) id 1gKghz-0004be-TR
 for bug-guix@HIDDEN; Thu, 08 Nov 2018 04:34:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <clement@HIDDEN>) id 1gKghw-0001Bo-DE
 for bug-guix@HIDDEN; Thu, 08 Nov 2018 04:34:39 -0500
Received: from mail.lassieur.org ([83.152.10.219]:37156)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <clement@HIDDEN>)
 id 1gKghu-00012P-5P; Thu, 08 Nov 2018 04:34:35 -0500
Received: from newt (smtp.parrot.biz [62.23.167.188])
 by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 3e582c1b
 (TLSv1.2:ECDHE-RSA-CHACHA20-POLY1305:256:NO); 
 Thu, 8 Nov 2018 09:31:31 +0000 (UTC)
User-agent: mu4e 1.0; emacs 26.1
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@HIDDEN>
To: Bug Guix <bug-guix@HIDDEN>
Subject: Cuirass: Evaluations adding no new builds are displayed as "failing"
Date: Thu, 08 Nov 2018 10:34:22 +0100
Message-ID: <87y3a352w1.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.1 (----)
X-Debbugs-Envelope-To: submit
Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.1 (-----)

Hi,

Evaluations adding no new builds are displayed as "failing".  I know
this was done on purpose, but I think the check should be done on the
number of jobs returned by the evaluator, rather than on the number of
builds registered in the database.

There is a difference because derivations that are already in the
database won't be added again.

In my case (https://cuirass.lassieur.org/jobset/guix-manifest-clem), 70%
of the evaluations add no new builds, and none of them are failing.

--8<---------------cut here---------------start------------->8---
    (with-store store
      (let ((jobs (evaluate store spec eval-id checkouts)))
        (log-message "building ~a jobs for '~a'"
                     (length jobs) name)
        (build-packages store jobs eval-id)))
--8<---------------cut here---------------end--------------->8---

Thus if (zero? (length jobs)) here, we should mark the corresponding
evaluation as failing.

Thanks,
Cl=C3=A9ment




Acknowledgement sent to Clément Lassieur <clement@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#33310; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.