GNU bug report logs - #33310
Cuirass: Evaluations adding no new builds are displayed as "failing"

Previous Next

Package: guix;

Reported by: Clément Lassieur <clement <at> lassieur.org>

Date: Thu, 8 Nov 2018 09:35:01 UTC

Severity: normal

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33310 in the body.
You can then email your comments to 33310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#33310; Package guix. (Thu, 08 Nov 2018 09:35:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Clément Lassieur <clement <at> lassieur.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Thu, 08 Nov 2018 09:35:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Bug Guix <bug-guix <at> gnu.org>
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Cuirass: Evaluations adding no new builds are displayed as "failing"
Date: Thu, 08 Nov 2018 10:34:22 +0100
Hi,

Evaluations adding no new builds are displayed as "failing".  I know
this was done on purpose, but I think the check should be done on the
number of jobs returned by the evaluator, rather than on the number of
builds registered in the database.

There is a difference because derivations that are already in the
database won't be added again.

In my case (https://cuirass.lassieur.org/jobset/guix-manifest-clem), 70%
of the evaluations add no new builds, and none of them are failing.

--8<---------------cut here---------------start------------->8---
    (with-store store
      (let ((jobs (evaluate store spec eval-id checkouts)))
        (log-message "building ~a jobs for '~a'"
                     (length jobs) name)
        (build-packages store jobs eval-id)))
--8<---------------cut here---------------end--------------->8---

Thus if (zero? (length jobs)) here, we should mark the corresponding
evaluation as failing.

Thanks,
Clément




Information forwarded to bug-guix <at> gnu.org:
bug#33310; Package guix. (Sun, 11 Nov 2018 13:38:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Clément Lassieur <clement <at> lassieur.org>
Cc: Bug Guix <bug-guix <at> gnu.org>
Subject: Re: Cuirass: Evaluations adding no new builds are displayed as
 "failing"
Date: Sun, 11 Nov 2018 14:37:05 +0100
Hello,

Clément Lassieur <clement <at> lassieur.org> skribis:

> Evaluations adding no new builds are displayed as "failing".  I know
> this was done on purpose, but I think the check should be done on the
> number of jobs returned by the evaluator, rather than on the number of
> builds registered in the database.

Indeed, that makes sense.  For the record the faulty code was added in
commit 0b40dca734468e8b12b3ff58e3e779679f17d38e.  As I wrote there, it
would be ideal to have a “failed” bit in the database, and, even better,
to save the output of ‘evaluate’.

Thanks,
Ludo’.




Reply sent to Mathieu Othacehe <othacehe <at> gnu.org>:
You have taken responsibility. (Thu, 25 Mar 2021 12:55:01 GMT) Full text and rfc822 format available.

Notification sent to Clément Lassieur <clement <at> lassieur.org>:
bug acknowledged by developer. (Thu, 25 Mar 2021 12:55:02 GMT) Full text and rfc822 format available.

Message #13 received at 33310-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: 33310-done <at> debbugs.gnu.org
Subject: Re: bug#33310: Cuirass: Evaluations adding no new builds are
 displayed as "failing"
Date: Thu, 25 Mar 2021 13:54:10 +0100
Hello,

Closing as this is fixed on Cuirass master.

Thanks,

Mathieu




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 23 Apr 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 340 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.