GNU bug report logs - #33322
[PATCH] gnu: maxima: Fix tests on i686 and x86_64.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33322 in the body.
You can then email your comments to 33322 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Date: Thu,  8 Nov 2018 17:27:17 -0500

* gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
---
 gnu/packages/maths.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 808ab5345..389343051 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2716,6 +2716,18 @@ to BMP, JPEG or PNG image formats.")
            (lambda _
              (chmod "src/maxima" #o555)
              #t))
+         (replace 'check
+           (lambda _
+             ;; This is derived from the testing code in the "debian/rules" file
+             ;; of Debian's Maxima package.
+             ;; If Maxima can successfully run this, the binary to be installed
+             ;; should be fine.
+             (zero?
+              (system
+               (string-append "./maxima-local "
+                              "--lisp=gcl "
+                              "--batch-string=\"run_testsuite();\" "
+                              "| grep -q \"No unexpected errors found\"")))))
          ;; Make sure the doc and emacs files are found in the
          ;; standard location.  Also configure maxima to find gnuplot
          ;; without having it on the PATH.
-- 
2.19.1

Message #8 received at 33322 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 33322 <at> debbugs.gnu.org
Subject: Re: [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Date: Fri, 16 Nov 2018 22:44:50 +0100

Hello,

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.

[...]

> +             ;; This is derived from the testing code in the "debian/rules" file
> +             ;; of Debian's Maxima package.
> +             ;; If Maxima can successfully run this, the binary to be installed
> +             ;; should be fine.
> +             (zero?
> +              (system
> +               (string-append "./maxima-local "
> +                              "--lisp=gcl "
> +                              "--batch-string=\"run_testsuite();\" "
> +                              "| grep -q \"No unexpected errors found\"")))))

So the exit code without grep isn’t good enough, right?

If it has to be this way, so be it!

Thanks,
Ludo’.

Message #13 received at 33322-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 33322-done <at> debbugs.gnu.org
Subject: Re: [bug#33322] [PATCH] gnu: maxima: Fix tests on i686 and x86_64.
Date: Sun, 18 Nov 2018 12:03:16 -0500

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> * gnu/packages/maths.scm (maxima)[arguments]: Replace check phase.
>
> [...]
>
>> + ;; This is derived from the testing code in the "debian/rules"
>> file
>> +             ;; of Debian's Maxima package.
>> + ;; If Maxima can successfully run this, the binary to be installed
>> +             ;; should be fine.
>> +             (zero?
>> +              (system
>> +               (string-append "./maxima-local "
>> +                              "--lisp=gcl "
>> +                              "--batch-string=\"run_testsuite();\" "
>> +                              "| grep -q \"No unexpected errors found\"")))))
>
> So the exit code without grep isn’t good enough, right?
>
> If it has to be this way, so be it!
>

Yes, because I think that Maxima returns successfully as long as it
exits without the underlying Lisp implementation crashing.

> Thanks,
> Ludo’.

Thank you for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.