GNU bug report logs - #33329
[PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33329 in the body.
You can then email your comments to 33329 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org, Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH] gnu: Deprecate linux-module shpchp and tell user to remove it.
Date: Fri, 9 Nov 2018 23:47:34 +0100

[Message part 1 (text/plain, inline)]

Hi

Ricardo, you mentioned that this needs to be fixed.

I made a patch to fix this. I did not test the patch as I have no idea 
how to do that.

I have not run the indent script on it.

Se attachment


-------- Forwarded Message --------
Subject: 	Re: GuixSD system reconfigure error
Date: 	Thu, 30 Aug 2018 17:22:53 +0200
From: 	Ricardo Wurmus <rekado <at> elephly.net>
To: 	Hebi Li <lihebi.com <at> gmail.com>
CC: 	help-guix <at> gnu.org




Hi,

>      https://github.com/lihebi/dothebi/blob/master/config.scm

I see you use the “shpchp” kernel module. This no longer exists in the
latest version of the kernel Linux. That’s what this really bad error
message tries to tell you:

> Backtrace:
>             8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
> In ice-9/eval.scm:
>      619:8  7 (_ #f)
>     626:19  6 (_ #<directory (guile-user) 7cf140>)
>      159:9  5 (_ _)
> In gnu/build/linux-modules.scm:
>     184:47  4 (recursive-module-dependencies _ #:lookup-module _)
>      98:14  3 (module-dependencies _)
>      85:18  2 (modinfo-section-contents _)
> In ice-9/ports.scm:
>     439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
> In unknown file:
>             0 (open-file #f "r" #:encoding #f #:guess-encoding #f)
>
> ERROR: In procedure open-file:
> Wrong type (expecting string): #f
> builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1

(I only know this because I had the same problem.) Obviously, this
error message should be changed.

As a workaround you could switch to the LTS kernel where that module
still exists.

--
Ricardo

[Message part 2 (text/html, inline)]

[0001-gnu-Deprecate-linux-module-shpchp-and-tell-user-to-r.patch (text/x-patch, attachment)]

Message #8 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: 33329 <at> debbugs.gnu.org, rekado <at> elephly.net
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sat, 10 Nov 2018 13:03:29 +0100

[Message part 1 (text/plain, inline)]

Hi

Updated patch attached with a fix of parens and removed my changes to 
linux-modules.scm.

I look forward to the review.

Cheers

On 2018-11-09 23:47, swedebugia wrote:
>
> Hi
>
> Ricardo, you mentioned that this needs to be fixed.
>
> I made a patch to fix this. I did not test the patch as I have no idea 
> how to do that.
>
> I have not run the indent script on it.
>
> Se attachment
>
>
> -------- Forwarded Message --------
> Subject: 	Re: GuixSD system reconfigure error
> Date: 	Thu, 30 Aug 2018 17:22:53 +0200
> From: 	Ricardo Wurmus <rekado <at> elephly.net>
> To: 	Hebi Li <lihebi.com <at> gmail.com>
> CC: 	help-guix <at> gnu.org
>
>
>
>
> Hi,
>
>>      https://github.com/lihebi/dothebi/blob/master/config.scm
>
> I see you use the “shpchp” kernel module. This no longer exists in the
> latest version of the kernel Linux. That’s what this really bad error
> message tries to tell you:
>
>> Backtrace:
>>             8 (primitive-load "/gnu/store/vz7ci9rh483f2zps2cl174rd91b?")
>> In ice-9/eval.scm:
>>      619:8  7 (_ #f)
>>     626:19  6 (_ #<directory (guile-user) 7cf140>)
>>      159:9  5 (_ _)
>> In gnu/build/linux-modules.scm:
>>     184:47  4 (recursive-module-dependencies _ #:lookup-module _)
>>      98:14  3 (module-dependencies _)
>>      85:18  2 (modinfo-section-contents _)
>> In ice-9/ports.scm:
>>     439:11  1 (call-with-input-file #f #<procedure get-bytevector-al?> ?)
>> In unknown file:
>>             0 (open-file #f "r" #:encoding #f #:guess-encoding #f)
>>
>> ERROR: In procedure open-file:
>> Wrong type (expecting string): #f
>> builder for `/gnu/store/0ahsvp7wx52zzh1rywbdbq78llcwb7id-linux-modules.drv' failed with exit code 1
>
> (I only know this because I had the same problem.) Obviously, this
> error message should be changed.
>
> As a workaround you could switch to the LTS kernel where that module
> still exists.
>
> --
> Ricardo
>
>
-- 
Cheers
Swedebugia

[Message part 2 (text/html, inline)]

[0001-V2-gnu-Check-for-linux-module-shpchp-and-tell-user-t.patch (text/x-patch, attachment)]

Message #11 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia <at> riseup.net>
Cc: rekado <at> elephly.net, 33329 <at> debbugs.gnu.org
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sat, 10 Nov 2018 23:31:06 +0100

Hello,

swedebugia <swedebugia <at> riseup.net> skribis:

> From 4d70dda8c2f119fc6ff9d221eae6f060ff1fcd98 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia <at> riseup.net>
> Date: Fri, 9 Nov 2018 22:52:12 +0100
> Subject: [PATCH] [V2] gnu: Check for linux-module shpchp and tell user to
>  remove it.
>
>  * gnu/system/mapped-devices.scm (check-device-initrd-modules): New if
>  statement raising a condition if shpchp is found.

I don’t think we should hard-code things like this: they would
accumulate over the years and become unmanageable.

If anything, what should be improved IMO is the error message you get
when specifying a module that is unavailable.  That’s not easily done
though since that happens at build time.

Thoughts?

Ludo’.

Message #14 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: swedebugia <swedebugia <at> riseup.net>, rekado <at> elephly.net,
 33329 <at> debbugs.gnu.org
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sat, 10 Nov 2018 18:15:15 -0600

Ludovic Courtès writes:

> If anything, what should be improved IMO is the error message you get
> when specifying a module that is unavailable.  That’s not easily done
> though since that happens at build time.

I think Ludo is correct in this, an error message seems to be the only
option we have to ensure that maintainability and reproducibility are
respected. To add onto that, I was thinking that maybe it could be part
of the configuration process that we could modify to ensure that all of
the specified modules that are needed are available else it throws an
error?

Brett Gilio

Message #17 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Brett Gilio <brettg <at> posteo.net>, Ludovic Courtès
 <ludo <at> gnu.org>
Cc: rekado <at> elephly.net, 33329 <at> debbugs.gnu.org
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sun, 11 Nov 2018 08:27:59 +0100

On 2018-11-11 01:15, Brett Gilio wrote:
> 
> Ludovic Courtès writes:
> 
>> If anything, what should be improved IMO is the error message you get
>> when specifying a module that is unavailable.  That’s not easily done
>> though since that happens at build time.
> 
> I think Ludo is correct in this, an error message seems to be the only
> option we have to ensure that maintainability and reproducibility are
> respected. To add onto that, I was thinking that maybe it could be part
> of the configuration process that we could modify to ensure that all of
> the specified modules that are needed are available else it throws an
> error?

Ok. Would my patch have worked anyway?

So where would that error message be produced?
In gnu/build/linux-modules? load-linux-modules?

-- 
Cheers
Swedebugia

Message #20 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Brett Gilio <brettg <at> posteo.net>
Cc: swedebugia <swedebugia <at> riseup.net>, rekado <at> elephly.net,
 33329 <at> debbugs.gnu.org
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sun, 11 Nov 2018 12:27:22 +0100

Brett Gilio <brettg <at> posteo.net> skribis:

> Ludovic Courtès writes:
>
>> If anything, what should be improved IMO is the error message you get
>> when specifying a module that is unavailable.  That’s not easily done
>> though since that happens at build time.
>
> I think Ludo is correct in this, an error message seems to be the only
> option we have to ensure that maintainability and reproducibility are
> respected. To add onto that, I was thinking that maybe it could be part
> of the configuration process that we could modify to ensure that all of
> the specified modules that are needed are available else it throws an
> error?

That already happens, but the check cannot be 100% accurate because it
relies on information from the currently running kernel, which is why
there’s the ‘--skip-checks’ option.

Ludo’.

Message #23 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia <at> riseup.net>
Cc: rekado <at> elephly.net, 33329 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sun, 11 Nov 2018 12:32:35 +0100

swedebugia <swedebugia <at> riseup.net> skribis:

> On 2018-11-11 01:15, Brett Gilio wrote:
>>
>> Ludovic Courtès writes:
>>
>>> If anything, what should be improved IMO is the error message you get
>>> when specifying a module that is unavailable.  That’s not easily done
>>> though since that happens at build time.
>>
>> I think Ludo is correct in this, an error message seems to be the only
>> option we have to ensure that maintainability and reproducibility are
>> respected. To add onto that, I was thinking that maybe it could be part
>> of the configuration process that we could modify to ensure that all of
>> the specified modules that are needed are available else it throws an
>> error?
>
> Ok. Would my patch have worked anyway?

I spotted a typo: (eqv? (missing 'shpchp)) is wrong because ‘eqv?’
should take two arguments and ‘missing’ is not a procedure.

Apart from this the patch could have worked I guess.

> So where would that error message be produced?
> In gnu/build/linux-modules? load-linux-modules?

An error message is produced while building the initrd; see commit
4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.

For now, what about closing this issue and opening a new one when we
have an idea on how to improve on this?

Thanks,
Ludo’.

Message #26 received at 33329 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: rekado <at> elephly.net, 33329 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Sun, 11 Nov 2018 19:42:13 +0100

On 2018-11-11 12:32, Ludovic Courtès wrote:
>> swedebugia <swedebugia <at> riseup.net> skribis:

snip

>> Ok. Would my patch have worked anyway?
> 
> I spotted a typo: (eqv? (missing 'shpchp)) is wrong because ‘eqv?’
> should take two arguments and ‘missing’ is not a procedure.

Ok. Thanks for taking your time.

> 
> Apart from this the patch could have worked I guess.
> 
>> So where would that error message be produced?
>> In gnu/build/linux-modules? load-linux-modules?
> 
> An error message is produced while building the initrd; see commit
> 4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.

Good, I had not seen that.

> 
> For now, what about closing this issue and opening a new one when we
> have an idea on how to improve on this?

Fine with me :)

-- 
Cheers
Swedebugia

Message #31 received at 33329-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia <at> riseup.net>
Cc: rekado <at> elephly.net, 33329-done <at> debbugs.gnu.org,
 Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#33329] [PATCH] gnu: Deprecate linux-module shpchp and tell
 user to remove it.
Date: Mon, 12 Nov 2018 09:42:23 +0100

swedebugia <swedebugia <at> riseup.net> skribis:

> On 2018-11-11 12:32, Ludovic Courtès wrote:

[...]

>>> So where would that error message be produced?
>>> In gnu/build/linux-modules? load-linux-modules?
>>
>> An error message is produced while building the initrd; see commit
>> 4db7a9dc663c5b26e45ec35538bf68ff87acdf7b.
>
> Good, I had not seen that.
>
>>
>> For now, what about closing this issue and opening a new one when we
>> have an idea on how to improve on this?
>
> Fine with me :)

Alright, done!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.