GNU bug report logs -
#33359
On emacs-clang-format
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33359 in the body.
You can then email your comments to 33359 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-guix <at> gnu.org
:
bug#33359
; Package
guix
.
(Mon, 12 Nov 2018 21:41:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
:
New bug report received and forwarded. Copy sent to
bug-guix <at> gnu.org
.
(Mon, 12 Nov 2018 21:41:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
I noticed that someone packaged emacs-clang-format.
There are some problems with the current package definition:
- clang already distributes the same functionality (Maybe I am missing a
feature that clangs version does not have though).
- The package also includes integration for clang-rename.
- The package should probably have a more generic name and function as a
package for all emacs integration clang offers.
- The clang package is installing the same files under share/clang.
Maybe those should be removed.
- The license is incorrect. The version that is cloned from github
also seems to have some licensing issues (Missing full license...)
You'll find an example package definition attached.
This can probably be optimized a little bit more so that the full clang
tarball does not need to be extracted twice.
Tim.
[0001-gnu-Add-emacs-clang-tooling.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, attachment)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#33359
; Package
guix
.
(Wed, 14 Nov 2018 10:26:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 33359 <at> debbugs.gnu.org (full text, mbox):
Hi Tim,
Thanks for your feedback.
Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:
> I noticed that someone packaged emacs-clang-format.
> There are some problems with the current package definition:
>
> - clang already distributes the same functionality (Maybe I am missing a
> feature that clangs version does not have though).
> - The package also includes integration for clang-rename.
> - The package should probably have a more generic name and function as a
> package for all emacs integration clang offers.
> - The clang package is installing the same files under share/clang.
> Maybe those should be removed.
> - The license is incorrect. The version that is cloned from github
> also seems to have some licensing issues (Missing full license...)
>
> You'll find an example package definition attached.
> This can probably be optimized a little bit more so that the full clang
> tarball does not need to be extracted twice.
Pierre, WDYT?
Thanks in advance! :-)
Ludo’.
Information forwarded
to
bug-guix <at> gnu.org
:
bug#33359
; Package
guix
.
(Wed, 14 Nov 2018 10:49:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 33359 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
That's absolutely right, I didn't know clang packaged it already.
Here is the listing.
--8<---------------cut here---------------start------------->8---
> ls -1 /gnu/store/...-clang-6.0.1/share/clang
bash-autocomplete.sh
clang-format-bbedit.applescript
clang-format-diff.py
clang-format-sublime.py
clang-format.el
clang-format.py
clang-rename.el
clang-rename.py
--8<---------------cut here---------------end--------------->8---
Not should we fix the Emacs package, but also the Vim .py files, the
Sublime+bbedit extensions (which we can discard I guess) and the Bash
completion.
I see a few ways we can proceed:
- Deprecate emacs-clang-format.
- Use emacs-clang-tooling as suggested by Tim.
- Use clang as it is and fix the installation of the share folder.
- Use clang:emacs output and clang:vim output.
- Keep emacs-clang-format but use the Clang source (as per Tim suggestion), and
add emacs-clang-rename from the same source.
In all cases we need to fix the installation of the Bash completion file and
maybe to discard the Sublime+bbedit extensions.
> : - The license is incorrect. The version that is cloned from github
> : also seems to have some licensing issues (Missing full license...)
Which license?
--
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#33359
; Package
guix
.
(Wed, 14 Nov 2018 15:57:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 33359 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 14.11.2018 11:48, Pierre Neidhardt wrote:
>> : - The license is incorrect. The version that is cloned from github
>> : also seems to have some licensing issues (Missing full license...)
>
> Which license?
>
The emacs-clang-format package definition claims that the package is
licensed under the GPLv3+. The files in the repository are licensed
under the same license that clang is licensed under ( The headers of the
files actually say that they are from the LLVM project). This means the
package is licensed under University of Illinois/NCSA Open Source License.
So while it would probably be legal to distribute binaries and source
code under the terms of the GPL this should probably be fixed :)
Tim.
[signature.asc (application/pgp-signature, attachment)]
Information forwarded
to
bug-guix <at> gnu.org
:
bug#33359
; Package
guix
.
(Mon, 26 Nov 2018 13:55:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 33359 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
I went ahead and implemented the aforementioned approach:
> - Keep emacs-clang-format but use the Clang source (as per Tim suggestion), and
> add emacs-clang-rename from the same source.
--
Pierre Neidhardt
https://ambrevar.xyz/
[signature.asc (application/pgp-signature, inline)]
Added tag(s) fixed.
Request was from
Pierre Neidhardt <mail <at> ambrevar.xyz>
to
control <at> debbugs.gnu.org
.
(Mon, 26 Nov 2018 13:56:01 GMT)
Full text and
rfc822 format available.
bug closed, send any further explanations to
33359 <at> debbugs.gnu.org and Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Request was from
Pierre Neidhardt <mail <at> ambrevar.xyz>
to
control <at> debbugs.gnu.org
.
(Mon, 26 Nov 2018 13:56:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Tue, 25 Dec 2018 12:24:05 GMT)
Full text and
rfc822 format available.
This bug report was last modified 5 years and 117 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.