GNU bug report logs - #33387
[PATCH] doc: fix typo in connman config

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33387 in the body.
You can then email your comments to 33387 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Giovanni Biscuolo <g <at> xelera.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: fix typo in connman config
Date: Wed, 14 Nov 2018 22:30:46 +0100

[Message part 1 (text/plain, inline)]

Dear maintainers,

reading at the manual I found what it seems a typo to me, please have a
look at my tiny patch

best regards
Giovanni

[signature.asc (application/pgp-signature, inline)]

[0001-doc-fix-typo-in-connman-config.patch (text/x-diff, inline)]

From 8cf66fa64d495857a71bafffcd0c6cc56abf2eec Mon Sep 17 00:00:00 2001
From: Giovanni Biscuolo <g <at> xelera.eu>
Date: Wed, 14 Nov 2018 21:44:13 +0100
Subject: [PATCH] doc: fix typo in connman config

* doc/guix.texi (Networking Services): fix typo in connman config
  "disable-vpn?" parameter documentation, semantic is inverted
---
 doc/guix.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 0ba034e82..765261fc6 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -11832,7 +11832,7 @@ Data Type representing the configuration of connman.
 The connman package to use.
 
 @item @code{disable-vpn?} (default: @code{#f})
-When true, enable connman's vpn plugin.
+When true, disable connman's vpn plugin.
 @end table
 @end deftp
 
-- 
2.11.0

[Message part 4 (text/plain, inline)]

-- 
Giovanni Biscuolo

Xelera IT Infrastructures

Message #8 received at 33387 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Giovanni Biscuolo <g <at> xelera.eu>
Cc: 33387 <at> debbugs.gnu.org
Subject: Re: [bug#33387] [PATCH] doc: fix typo in connman config
Date: Thu, 15 Nov 2018 20:10:38 +0200

[Message part 1 (text/plain, inline)]

On Wed, Nov 14, 2018 at 10:30:46PM +0100, Giovanni Biscuolo wrote:
> Dear maintainers,
> 
> reading at the manual I found what it seems a typo to me, please have a
> look at my tiny patch
> 
> best regards
> Giovanni
> 

Here's the relevant code from gnu/services/networking.scm:

(define-record-type* <connman-configuration>
  connman-configuration make-connman-configuration
  connman-configuration?
  (connman      connman-configuration-connman
                (default connman))
  (disable-vpn? connman-configuration-disable-vpn?
                (default #f)))

(define (connman-activation config)
  (let ((disable-vpn? (connman-configuration-disable-vpn? config)))
    (with-imported-modules '((guix build utils))
      #~(begin
          (use-modules (guix build utils))
          (mkdir-p "/var/lib/connman/")
          (unless #$disable-vpn?
            (mkdir-p "/var/lib/connman-vpn/"))))))

So it looks like the documentation is wrong.


> From 8cf66fa64d495857a71bafffcd0c6cc56abf2eec Mon Sep 17 00:00:00 2001
> From: Giovanni Biscuolo <g <at> xelera.eu>
> Date: Wed, 14 Nov 2018 21:44:13 +0100
> Subject: [PATCH] doc: fix typo in connman config
> 
> * doc/guix.texi (Networking Services): fix typo in connman config
>   "disable-vpn?" parameter documentation, semantic is inverted
> ---
>  doc/guix.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 0ba034e82..765261fc6 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -11832,7 +11832,7 @@ Data Type representing the configuration of connman.
>  The connman package to use.
>  
>  @item @code{disable-vpn?} (default: @code{#f})
> -When true, enable connman's vpn plugin.
> +When true, disable connman's vpn plugin.
>  @end table
>  @end deftp
>  
> -- 
> 2.11.0
> 

> 
> -- 
> Giovanni Biscuolo
> 
> Xelera IT Infrastructures


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 33387-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Giovanni Biscuolo <g <at> xelera.eu>
Cc: 33387-done <at> debbugs.gnu.org
Subject: Re: [bug#33387] [PATCH] doc: fix typo in connman config
Date: Thu, 15 Nov 2018 20:12:57 +0200

[Message part 1 (text/plain, inline)]

Commit pushed as c61f36f368c563c48815de0abe625383909b0a8d

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.