GNU bug report logs - #33392
[PATCH 0/4] Add OpenShot

Previous Next

Package: guix-patches;

Reported by: ericbavier <at> centurylink.net

Date: Thu, 15 Nov 2018 04:18:03 UTC

Severity: normal

Tags: patch

Done: Eric Bavier <ericbavier <at> centurylink.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33392 in the body.
You can then email your comments to 33392 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33392; Package guix-patches. (Thu, 15 Nov 2018 04:18:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to ericbavier <at> centurylink.net:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 15 Nov 2018 04:18:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH 0/4] Add OpenShot
Date: Wed, 14 Nov 2018 22:17:11 -0600
From: Eric Bavier <bavier <at> member.fsf.org>

Hello Guix,

The following patches add a package for the video-editory "OpenShot".

The first patch fixes an issue in our qtwebkit package which makes `qmake`
unable to find the "webkit" component.  This caused, at least, our
python-pyqt package to not build its webkit bindings.  Once this is fixed
our qutebrowser package works once again :).

Eric Bavier (4):
  qtwebkit: Fix pri install directory.
  gnu: Add libopenshot-audio.
  gnu: Add libopenshot.
  gnu: Add OpenShot.

 gnu/packages/audio.scm |  36 +++++++++++++
 gnu/packages/qt.scm    |  11 +++-
 gnu/packages/video.scm | 111 ++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 156 insertions(+), 2 deletions(-)

-- 
2.19.1





Information forwarded to guix-patches <at> gnu.org:
bug#33392; Package guix-patches. (Thu, 15 Nov 2018 04:19:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH 2/4] gnu: Add libopenshot-audio.
Date: Wed, 14 Nov 2018 22:17:13 -0600
From: Eric Bavier <bavier <at> member.fsf.org>

* gnu/packages/audio.scm (libopenshot-audio): New variable.
---
 gnu/packages/audio.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index ee18b0022..16cb942a7 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2018 Clément Lassieur <clement <at> lassieur.org>
 ;;; Copyright © 2018 Brett Gilio <brettg <at> posteo.net>
 ;;; Copyright © 2018 Marius Bakke <mbakke <at> fastmail.com>
+;;; Copyright © 2017 Eric Bavier <bavier <at> member.fsf.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3515,3 +3516,38 @@ using ALSA, MPD, PulseAudio, or a FIFO buffer as its input.")
       (synopsis "Pro-quality GM soundfont")
       (description "Fluid-3 is Frank Wen's pro-quality GM soundfont.")
       (license license:expat))))
+
+(define-public libopenshot-audio
+  (package
+    (name "libopenshot-audio")
+    (version "0.1.7")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/OpenShot/libopenshot-audio")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "08a8wbi28kwrdz4h0rs1b9vsr28ldfi8g75q54rj676y1vwg3qys"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ;; The following are for JUCE GUI components:
+       ("libx11" ,libx11)
+       ("freetype" ,freetype)
+       ("libxrandr" ,libxrandr)
+       ("libxinerama" ,libxinerama)
+       ("libxcursor" ,libxcursor)))
+    (arguments
+     `(#:tests? #f                      ;there are no tests
+       #:configure-flags
+       (list (string-append "-DCMAKE_CXX_FLAGS=-I"
+                            (assoc-ref %build-inputs "freetype")
+                            "/include/freetype2"))))
+    (home-page "https://openshot.org")
+    (synopsis "Audio editing and playback for OpenShot")
+    (description "OpenShot Audio Library (libopenshot-audio) allows
+high-quality editing and playback of audio, and is based on the JUCE
+library.")
+    (license license:lgpl3+)))
--
2.19.1





Information forwarded to guix-patches <at> gnu.org:
bug#33392; Package guix-patches. (Thu, 15 Nov 2018 04:19:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ericbavier <at> centurylink.net
To: guix-patches <at> gnu.org
Cc: Eric Bavier <bavier <at> member.fsf.org>
Subject: [PATCH 3/4] gnu: Add libopenshot.
Date: Wed, 14 Nov 2018 22:17:14 -0600
From: Eric Bavier <bavier <at> member.fsf.org>

* gnu/packages/video.scm (libopenshot): New variable.
---
 gnu/packages/video.scm | 65 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 64 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index a482ef251..31684dd2f 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -12,7 +12,7 @@
 ;;; Copyright © 2016 Dmitry Nikolaev <cameltheman <at> gmail.com>
 ;;; Copyright © 2016 Andy Patterson <ajpatter <at> uwaterloo.ca>
 ;;; Copyright © 2016, 2017 Nils Gillmann <ng0 <at> n0.is>
-;;; Copyright © 2016 Eric Bavier <bavier <at> member.fsf.org>
+;;; Copyright © 2016, 2017 Eric Bavier <bavier <at> member.fsf.org>
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2017 Feng Shu <tumashu <at> 163.com>
 ;;; Copyright © 2017, 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
@@ -112,6 +112,7 @@
   #:use-module (gnu packages man)
   #:use-module (gnu packages mp3)
   #:use-module (gnu packages ncurses)
+  #:use-module (gnu packages networking)
   #:use-module (gnu packages ocr)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
@@ -128,6 +129,7 @@
   #:use-module (gnu packages serialization)
   #:use-module (gnu packages shells)
   #:use-module (gnu packages ssh)
+  #:use-module (gnu packages swig)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
@@ -3076,3 +3078,64 @@ as surfing, skiing, riding and walking while shooting videos are especially
 prone to erratic camera shakes.  Vidstab targets these video contents to help
 create smoother and stable videos.")
     (license license:gpl2+)))
+
+(define-public libopenshot
+  (package
+    (name "libopenshot")
+    (version "0.2.2")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/OpenShot/libopenshot")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1x4kv05pdq1pglb6y056aa7llc6iyibyhzg93k7zwj0q08cp5ixd"))
+              (modules '((guix build utils)))
+              (snippet '(begin
+                          ;; Allow overriding of the python installation dir
+                          (substitute* "src/bindings/python/CMakeLists.txt"
+                            (("(SET\\(PYTHON_MODULE_PATH.*)\\)" _ set)
+                             (string-append set " CACHE PATH "
+                                            "\"Python bindings directory\")")))
+                          #t))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("python" ,python)
+       ("swig" ,swig)
+       ("unittest++" ,unittest-cpp)))
+    (propagated-inputs                  ;all referenced in installed headers
+     `(("cppzmq" ,cppzmq)
+       ("ffmpeg" ,ffmpeg)
+       ("imagemagick" ,imagemagick)
+       ("jsoncpp" ,jsoncpp)
+       ("libopenshot-audio" ,libopenshot-audio)
+       ("qt" ,qt)       ;widgets, core, gui, multimedia, and multimediawidgets
+       ("zeromq" ,zeromq)))
+    (arguments
+     `(#:tests? #f     ;XXX: https://github.com/OpenShot/libopenshot/issues/175
+       #:configure-flags
+       (list (string-append "-DPYTHON_MODULE_PATH:PATH=" %output "/lib/python"
+                            ,(version-major+minor (package-version python))
+                            "/site-packages")
+             "-DUSE_SYSTEM_JSONCPP:BOOL=ON")
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'set-vars
+           (lambda* (#:key inputs #:allow-other-keys)
+             (setenv "LIBOPENSHOT_AUDIO_DIR"
+                     (assoc-ref inputs "libopenshot-audio"))
+             (setenv "ZMQDIR"
+                     (assoc-ref inputs "zeromq"))
+             (setenv "UNITTEST_DIR"
+                     (string-append (assoc-ref inputs "unittest++")
+                                    "/include/UnitTest++"))
+             #t)))))
+    (home-page "https://openshot.org")
+    (synopsis "Video-editing, animation, and playback library")
+    (description "OpenShot Library (libopenshot) is a powerful C++ video
+editing library with a multi-threaded and feature rich video editing
+API.  It includes bindings for Python, Ruby, and other languages.")
+    (license license:lgpl3+)))
--
2.19.1





Reply sent to Eric Bavier <ericbavier <at> centurylink.net>:
You have taken responsibility. (Tue, 27 Nov 2018 02:06:01 GMT) Full text and rfc822 format available.

Notification sent to ericbavier <at> centurylink.net:
bug acknowledged by developer. (Tue, 27 Nov 2018 02:06:02 GMT) Full text and rfc822 format available.

Message #16 received at 33392-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: 33392-done <at> debbugs.gnu.org
Subject: Re: [bug#33392] [PATCH 2/4] gnu: Add libopenshot-audio.
Date: Mon, 26 Nov 2018 20:05:26 -0600
[Message part 1 (text/plain, inline)]
On Wed, 14 Nov 2018 22:17:13 -0600
ericbavier <at> centurylink.net wrote:

> From: Eric Bavier <bavier <at> member.fsf.org>
> 
> * gnu/packages/audio.scm (libopenshot-audio): New variable.
> ---
>  gnu/packages/audio.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)

Pushed in ef8517f29d7412f78e6481b3df56fd81041e3e3a

`~Eric
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33392; Package guix-patches. (Tue, 27 Nov 2018 02:08:02 GMT) Full text and rfc822 format available.

Message #19 received at 33392-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: 33392-done <at> debbugs.gnu.org
Subject: Re: [bug#33392] [PATCH 3/4] gnu: Add libopenshot.
Date: Mon, 26 Nov 2018 20:07:00 -0600
[Message part 1 (text/plain, inline)]
On Wed, 14 Nov 2018 22:17:14 -0600
ericbavier <at> centurylink.net wrote:

> From: Eric Bavier <bavier <at> member.fsf.org>
> 
> * gnu/packages/video.scm (libopenshot): New variable.
> ---
>  gnu/packages/video.scm | 65 +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 64 insertions(+), 1 deletion(-)

I've pushed a slightly modified version of this patch in
579a9cdec7673d9007ef924bb345f42527aa0a72.  I was able to enable tests
with a small patch from an upstream pull request.

`~Eric
[Message part 2 (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33392; Package guix-patches. (Tue, 27 Nov 2018 02:10:02 GMT) Full text and rfc822 format available.

Message #22 received at 33392-close <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: 33392-close <at> debbugs.gnu.org
Subject: closing: [PATCH 0/4] Add OpenShot
Date: Mon, 26 Nov 2018 20:09:07 -0600
[Message part 1 (text/plain, inline)]
All patches applied.

`~Eric
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 25 Dec 2018 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 95 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.