GNU bug report logs - #33422
/etc/passwd on GuixSD can end up containing default home directories

Previous Next

Package: guix;

Reported by: ludo <at> gnu.org (Ludovic Courtès)

Date: Sun, 18 Nov 2018 22:06:01 UTC

Severity: normal

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33422 in the body.
You can then email your comments to 33422 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#33422; Package guix. (Sun, 18 Nov 2018 22:06:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to ludo <at> gnu.org (Ludovic Courtès):
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Sun, 18 Nov 2018 22:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Bug Guix <bug-guix <at> gnu.org>
Subject: /etc/passwd on GuixSD can end up containing default home directories
Date: Sun, 18 Nov 2018 23:05:26 +0100
Hello Guix,

On IRC, fps reported this issue: their user account was declared like
this:

26   (users (cons (user-account                              
27                 (name "fps")                              
28                 (comment "fps")                           
29                 (group "users")                           
30                 (supplementary-groups '("wheel" "netdev"  
31                                         "audio" "video")) 
32                 (home-directory "/home/bob"))    ;<--- notice “bob”!

… yet /etc/passwd would refer to /home/fps for user “fps” (this is on a
fresh GuixSD 0.15.0 install.)

This in turn would prevent logging in as “fps” because /home/fps didn’t
exist (meaning the ‘user-homes’ Shepherd service created /home/bob, not
/home/fps.)

Ludo’.




Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Sun, 18 Nov 2018 22:44:02 GMT) Full text and rfc822 format available.

Notification sent to ludo <at> gnu.org (Ludovic Courtès):
bug acknowledged by developer. (Sun, 18 Nov 2018 22:44:02 GMT) Full text and rfc822 format available.

Message #10 received at 33422-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: 33422-done <at> debbugs.gnu.org
Subject: Re: bug#33422: /etc/passwd on GuixSD can end up containing default
 home directories
Date: Sun, 18 Nov 2018 23:43:14 +0100
ludo <at> gnu.org (Ludovic Courtès) skribis:

> On IRC, fps reported this issue: their user account was declared like
> this:
>
> 26   (users (cons (user-account                              
> 27                 (name "fps")                              
> 28                 (comment "fps")                           
> 29                 (group "users")                           
> 30                 (supplementary-groups '("wheel" "netdev"  
> 31                                         "audio" "video")) 
> 32                 (home-directory "/home/bob"))    ;<--- notice “bob”!
>
> … yet /etc/passwd would refer to /home/fps for user “fps” (this is on a
> fresh GuixSD 0.15.0 install.)

Fixed in b297934437932de730432629b361fcb422accbb7.

Ludo'.




Information forwarded to bug-guix <at> gnu.org:
bug#33422; Package guix. (Sun, 18 Nov 2018 22:45:02 GMT) Full text and rfc822 format available.

Message #13 received at 33422 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33422 <at> debbugs.gnu.org
Subject: Re: bug#33422: /etc/passwd on GuixSD can end up containing default
 home directories
Date: Sun, 18 Nov 2018 17:44:48 -0500
[Message part 1 (text/plain, inline)]
On Sun, Nov 18, 2018 at 11:05:26PM +0100, Ludovic Courtès wrote:
> On IRC, fps reported this issue: their user account was declared like
> this:
> 
> 26   (users (cons (user-account                              
> 27                 (name "fps")                              
> 28                 (comment "fps")                           
> 29                 (group "users")                           
> 30                 (supplementary-groups '("wheel" "netdev"  
> 31                                         "audio" "video")) 
> 32                 (home-directory "/home/bob"))    ;<--- notice “bob”!
> 
> … yet /etc/passwd would refer to /home/fps for user “fps” (this is on a
> fresh GuixSD 0.15.0 install.)
> 
> This in turn would prevent logging in as “fps” because /home/fps didn’t
> exist (meaning the ‘user-homes’ Shepherd service created /home/bob, not
> /home/fps.)

It slightly obscures a part of config.scm that is otherwise
straightforward, but I do this:

(home-directory (string-append "/home/" name))

... which would have avoided the issue. Maybe the value of
home-directory should be implicit when unspecified.

But, that is missing the point, which I think is that home directories
are not being handled in a consistent and unified way.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to bug-guix <at> gnu.org:
bug#33422; Package guix. (Mon, 19 Nov 2018 16:20:02 GMT) Full text and rfc822 format available.

Message #16 received at 33422 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 33422 <at> debbugs.gnu.org
Subject: Re: bug#33422: /etc/passwd on GuixSD can end up containing default
 home directories
Date: Mon, 19 Nov 2018 17:19:24 +0100
Leo Famulari <leo <at> famulari.name> skribis:

> On Sun, Nov 18, 2018 at 11:05:26PM +0100, Ludovic Courtès wrote:
>> On IRC, fps reported this issue: their user account was declared like
>> this:
>> 
>> 26   (users (cons (user-account                              
>> 27                 (name "fps")                              
>> 28                 (comment "fps")                           
>> 29                 (group "users")                           
>> 30                 (supplementary-groups '("wheel" "netdev"  
>> 31                                         "audio" "video")) 
>> 32                 (home-directory "/home/bob"))    ;<--- notice “bob”!
>> 
>> … yet /etc/passwd would refer to /home/fps for user “fps” (this is on a
>> fresh GuixSD 0.15.0 install.)
>> 
>> This in turn would prevent logging in as “fps” because /home/fps didn’t
>> exist (meaning the ‘user-homes’ Shepherd service created /home/bob, not
>> /home/fps.)
>
> It slightly obscures a part of config.scm that is otherwise
> straightforward, but I do this:
>
> (home-directory (string-append "/home/" name))
>
> ... which would have avoided the issue. Maybe the value of
> home-directory should be implicit when unspecified.
>
> But, that is missing the point, which I think is that home directories
> are not being handled in a consistent and unified way.

Exactly, that home directory was a typo, but the point of this bug is
that non-default home directories were not correctly handled.

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 18 Dec 2018 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 125 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.