GNU bug report logs - #33436
[PATCH] gnu: Add python-warcio.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33436 in the body.
You can then email your comments to 33436 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-warcio.
Date: Mon, 19 Nov 2018 21:41:46 +0100

[Message part 1 (text/plain, inline)]

-- 
Cheers
Swedebugia

[0001-gnu-Add-python-warcio.patch (text/x-patch, attachment)]

Message #8 received at 33436 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: swedebugia <swedebugia <at> riseup.net>
Cc: 33436 <at> debbugs.gnu.org
Subject: Re: [bug#33436] [PATCH] gnu: Add python-warcio.
Date: Wed, 21 Nov 2018 11:21:06 +0100

Hello!

swedebugia <swedebugia <at> riseup.net> skribis:

>>From 537b2b111a464956bdec640ea5f84c4598ea66f9 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia <at> riseup.net>
> Date: Mon, 19 Nov 2018 21:37:46 +0100
> Subject: [PATCH] gnu: Add python-warcio.
>
> * gnu/packages/python.scm: New variable.
                           ^
Nitpick: You forgot the variable name here.  :-)

> +   (arguments
> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
> +    '(#:tests? #f))

Could you investigate a bit further?  What do the test logs show?

It would be good to see if these tests can be easily fixed, if they
should definitely be skipped (for instance because they rely on some
external service), or if it’s something else.

> +   (home-page "https://github.com/webrecorder/warcio")
> +   (synopsis "Streaming web archival archive (WARC) library")
> +   (description
> +    "warcio is designed for fast, low-level access to web archival
                 ^^
What about: “warcio is a Python library to read and write the WARC format
commonly used in Web archives.  It is designed for…”?

Thank you,
Ludo’.

Message #11 received at 33436 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: swedebugia <swedebugia <at> riseup.net>
Cc: 33436 <at> debbugs.gnu.org
Subject: Re: [bug#33436] [PATCH] gnu: Add python-warcio.
Date: Fri, 11 Jan 2019 09:29:14 +0100

Ping!

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Hello!
>
> swedebugia <swedebugia <at> riseup.net> skribis:
>
>>>>From 537b2b111a464956bdec640ea5f84c4598ea66f9 Mon Sep 17 00:00:00 2001
>> From: swedebugia <swedebugia <at> riseup.net>
>> Date: Mon, 19 Nov 2018 21:37:46 +0100
>> Subject: [PATCH] gnu: Add python-warcio.
>>
>> * gnu/packages/python.scm: New variable.
>                            ^
> Nitpick: You forgot the variable name here.  :-)
>
>> +   (arguments
>> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
>> +    '(#:tests? #f))
>
> Could you investigate a bit further?  What do the test logs show?
>
> It would be good to see if these tests can be easily fixed, if they
> should definitely be skipped (for instance because they rely on some
> external service), or if it’s something else.
>
>> +   (home-page "https://github.com/webrecorder/warcio")
>> +   (synopsis "Streaming web archival archive (WARC) library")
>> +   (description
>> +    "warcio is designed for fast, low-level access to web archival
>                  ^^
> What about: “warcio is a Python library to read and write the WARC format
> commonly used in Web archives.  It is designed for…”?
>
> Thank you,
> Ludo’.

Message #14 received at 33436 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: "33436 <at> debbugs.gnu.org" <33436 <at> debbugs.gnu.org>
Subject: Re: [bug#33436] [PATCH] gnu: Add python-warcio.
Date: Sun, 24 Feb 2019 03:01:29 +0100

[Message part 1 (text/plain, inline)]

On 2019-01-11 09:29, Ludovic Courtès wrote:
> Ping!
> 
> ludo <at> gnu.org (Ludovic Courtès) skribis:
> 
>> Hello!
>>
>> swedebugia <swedebugia <at> riseup.net> skribis:
>>
>>>> >From 537b2b111a464956bdec640ea5f84c4598ea66f9 Mon Sep 17 00:00:00 2001
>>> From: swedebugia <swedebugia <at> riseup.net>
>>> Date: Mon, 19 Nov 2018 21:37:46 +0100
>>> Subject: [PATCH] gnu: Add python-warcio.
>>>
>>> * gnu/packages/python.scm: New variable.
>>                            ^
>> Nitpick: You forgot the variable name here.  :-)
>>
>>> +   (arguments
>>> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
>>> +    '(#:tests? #f))
>>
>> Could you investigate a bit further?  What do the test logs show?
>>
>> It would be good to see if these tests can be easily fixed, if they
>> should definitely be skipped (for instance because they rely on some
>> external service), or if it’s something else.
>>
>>> +   (home-page "https://github.com/webrecorder/warcio")
>>> +   (synopsis "Streaming web archival archive (WARC) library")
>>> +   (description
>>> +    "warcio is designed for fast, low-level access to web archival
>>                  ^^
>> What about: “warcio is a Python library to read and write the WARC format
>> commonly used in Web archives.  It is designed for…”?
>>
>> Thank you,
>> Ludo’.
Here comes the log from the build.

I see a lot of "OSError: [Errno 9] Bad file descriptor" and a few
"FileNotFoundError"

Should I report upstream?

-- 
Cheers Swedebugia

[gwkz0zj2bqbw83nhh1ba1iq7lndryg-python-warcio-1.6.3.drv.bz2 (application/x-bzip, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 33436 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: swedebugia <swedebugia <at> riseup.net>
Cc: "33436 <at> debbugs.gnu.org" <33436 <at> debbugs.gnu.org>
Subject: Re: [bug#33436] [PATCH] gnu: Add python-warcio.
Date: Mon, 04 Mar 2019 14:43:33 +0100

Hello swedebugia,

swedebugia <swedebugia <at> riseup.net> skribis:

> On 2019-01-11 09:29, Ludovic Courtès wrote:

[...]

>>>> +   (arguments
>>>> +    ;; FIXME: Some tests require network access. 150 out of 1354 fail
>>>> +    '(#:tests? #f))
>>>
>>> Could you investigate a bit further?  What do the test logs show?

[...]

> Here comes the log from the build.
>
> I see a lot of "OSError: [Errno 9] Bad file descriptor" and a few
> "FileNotFoundError"
>
> Should I report upstream?

Yes, please.  Perhaps you need to investigate a little bit beforehand
(see <https://gnu.org/s/guix/manual/en/html_node/Debugging-Build-Failures.html>)
so you can provide them with just the information they need to reproduce
and understand the problem.

Thanks!

Ludo’.

Message #24 received at 33436-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: swedebugia <swedebugia <at> riseup.net>, 33436-done <at> debbugs.gnu.org
Subject: Re: bug#33436: [PATCH] gnu: Add python-warcio.
Date: Tue, 13 Jul 2021 11:23:18 -0400

Hello,

I've added the 'python-wsgiprox' and 'python-certauth' missing
dependencies as of warcio 1.7.4, managed to get the test suite to run
with only 2 disabled tests (due to networking requirements), and pushed
as 89bd7565e8.

Thanks to both of you!

Closing.

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.