GNU bug report logs - #3348
23.0.92.1; Ediff: Creating a multi-file patch

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: emacs; Severity: minor; Reported by: Jon Strait <jstrait@HIDDEN>; Keywords: confirmed; dated Fri, 22 May 2009 03:45:03 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 3348 <at> debbugs.gnu.org:


Received: (at 3348) by debbugs.gnu.org; 15 Oct 2023 11:17:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Oct 15 07:17:23 2023
Received: from localhost ([127.0.0.1]:51360 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qrz7b-00080D-Hd
	for submit <at> debbugs.gnu.org; Sun, 15 Oct 2023 07:17:23 -0400
Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:54569)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maurooaranda@HIDDEN>) id 1qrz7Z-0007xb-2w
 for 3348 <at> debbugs.gnu.org; Sun, 15 Oct 2023 07:17:21 -0400
Received: by mail-pf1-x436.google.com with SMTP id
 d2e1a72fcca58-6b497c8575aso1838934b3a.1
 for <3348 <at> debbugs.gnu.org>; Sun, 15 Oct 2023 04:16:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1697368610; x=1697973410; darn=debbugs.gnu.org;
 h=content-transfer-encoding:subject:from:cc:to:content-language
 :user-agent:mime-version:date:message-id:from:to:cc:subject:date
 :message-id:reply-to;
 bh=iE4ab6FcbLX3o51CB3Wr58of+u8hVtus6Sh+m/HX/pI=;
 b=Ha1U5Rott1IGwTx4zwVhNZMk6VYP1nOmFxsOa+f7xJ+S/Pnoq746tRg6xbJzsGRCL2
 qHIEROnnb7im/dGiz/o6TIczODNoR+U/4cja6zCBUGY3oaQ6EIt0LtkT4lwU6dlj3r2g
 BzT6QRyzcOQ0GJYDi9CPRgNy+jlQcWMfB/t6Buo90gsYjH0ehViXYdPGBVTCi8m5vM60
 eVrhbTRR+yh8fndLs40+1b8tD2matt3sJJJuJjgaQsPVWDRY2Sb68dT4ElK0XfDvq2N3
 m4/y0hBcPD9nImE2fPMsyKvJ2zZEIgWyb3ZnMttfOUpxiW/zBRY+tBvaYINYfJLQ0/j4
 i37g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1697368610; x=1697973410;
 h=content-transfer-encoding:subject:from:cc:to:content-language
 :user-agent:mime-version:date:message-id:x-gm-message-state:from:to
 :cc:subject:date:message-id:reply-to;
 bh=iE4ab6FcbLX3o51CB3Wr58of+u8hVtus6Sh+m/HX/pI=;
 b=a2qLB85xyHNN/lpizexfsuJ9tSeB7W0a/GAbxtUA0ata7AqbVjKIA4idkQI7bHlo6v
 ZUYSiNOvO3Xp54XeySOHMW7Al6Ql9rOYc+kuif3h+ZMUB0tGUrtd1gbJSOhXATWU/98t
 NWMXtflDUe877EzUX4t4M4XtV7889C1bJ6KqG/qOeDUrMRISss7w8DDmJk/TyMEJ5i7Z
 JyWbcV1ikcVSHJmNY8hhTB/y4j4GOpJ9GyF//aYsf6EnDdHQIUguUIg6hK8jYr3P185x
 oHPvx7AEk3iu8BVPfPgLzfRDtnYkJL1a3qo2Kv9sFUAHvBD2wvyLxwdr0NMxCkL/eEr0
 U9pQ==
X-Gm-Message-State: AOJu0YwJxW67LMO9SocP165yTtn95YLzJbOwyqYwic6hUyHMS8mmYpjA
 tiWzMqnRbNQA9zmH9sR1h22u6AHetyXLaMzS
X-Google-Smtp-Source: AGHT+IGRJJq5MHOaiGoe4e07J/CCECA7t/WfGIxUpjap2y2ozi+RXYnjoADNbyYJdjM93L5gq/LWdQ==
X-Received: by 2002:a05:6a21:6d88:b0:162:d056:9f52 with SMTP id
 wl8-20020a056a216d8800b00162d0569f52mr37858928pzb.14.1697368609997; 
 Sun, 15 Oct 2023 04:16:49 -0700 (PDT)
Received: from [192.168.0.234] ([152.168.142.156])
 by smtp.gmail.com with ESMTPSA id
 r6-20020a63b106000000b0056946623d7esm6024964pgf.55.2023.10.15.04.16.48
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 15 Oct 2023 04:16:49 -0700 (PDT)
Message-ID: <dcbfc6a1-d318-41c2-b6d1-83935e6b12bc@HIDDEN>
Date: Sun, 15 Oct 2023 08:16:46 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: 3348 <at> debbugs.gnu.org
From: Mauro Aranda <maurooaranda@HIDDEN>
Subject: Re: bug#3348: 23.0.92.1; Ediff: Creating a multi-file patch
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 3348
Cc: jstrait@HIDDEN, Noam Postavsky <npostavs@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Noam Postavsky <npostavs@HIDDEN> writes:

 > tag 3348 + confirmed
 > severity 3348 minor
 > found 3348 25.0.94
 > quit
 >
 > Confirmed this is still an issue. Here is an elisp script for easier
 > reproduction (run as emacs -Q -l bug-3348.el):
 >
 > (defconst bug-3348-test-dir
 >   (expand-file-name "bug-3348-testdir" temporary-file-directory))
 > (make-directory bug-3348-test-dir t)
 > (cd bug-3348-test-dir)
 >
 > (make-directory "dir-a" t)
 > (make-directory "dir-b" t)
 >
 > (with-temp-file "dir-a/file"
 >   (insert "aaa"))
 > (with-temp-file "dir-b/file"
 >   (insert "bbb"))
 >
 > (ediff-directories "dir-a" "dir-b" nil)
 > (switch-to-buffer "*Ediff Session Group Panel*")
 >
 > (ediff-next-meta-item 1)
 > (ediff-mark-for-operation-at-pos nil)
 > (ediff-collect-custom-diffs)
 >
 > (with-current-buffer "*Ediff Multifile Diffs*"
 >   (write-file "foo.patch"))
 >
 > (with-temp-file "dir-b/file"
 >   (insert "BBB"))
 >
 > (ediff-collect-custom-diffs)
 >
 > (switch-to-buffer "foo.patch")
 > (diff-buffer-with-file)
 > (message (concat "Observe foo.patch buffer is different from its file,\n"
 >                  "but is marked read-only, not modified"))

This still happens, but I'm not really sure if this should be called a
bug.  ediff-collect-custom-diffs explicitly marks this buffer as not
modified with (set-buffer-modified-p nil).  I can't find the reasons for
that, but that doesn't mean there isn't a good one.  And it is
consistent about doing that.

The first call to ediff-collect-custom-diffs creates the buffer
*Ediff Multifile Diffs* and also marks it as unmodified, even though it
is.  So, why is that not a problem? Why is the second time a problem?

Using write-file again is possible, so what are the expectations of the
second time of typing `P' (or calling ediff-collect-custom-diffs) and
why do they differ from the expectations for the 1st call?
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#3348; Package emacs. Full text available.
bug Marked as found in versions 25.0.94. Request was from Noam Postavsky <npostavs@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Severity set to 'minor' from 'normal' Request was from Noam Postavsky <npostavs@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Added tag(s) confirmed. Request was from Noam Postavsky <npostavs@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 3348 <at> debbugs.gnu.org:


Received: (at 3348) by debbugs.gnu.org; 3 Jun 2016 20:10:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jun 03 16:10:49 2016
Received: from localhost ([127.0.0.1]:53497 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1b8vQf-00007a-LN
	for submit <at> debbugs.gnu.org; Fri, 03 Jun 2016 16:10:49 -0400
Received: from mail-oi0-f45.google.com ([209.85.218.45]:33550)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <npostavs@HIDDEN>) id 1b8vQd-00007B-TY
 for 3348 <at> debbugs.gnu.org; Fri, 03 Jun 2016 16:10:48 -0400
Received: by mail-oi0-f45.google.com with SMTP id k23so144003755oih.0
 for <3348 <at> debbugs.gnu.org>; Fri, 03 Jun 2016 13:10:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:from:date:message-id:subject:to;
 bh=31sdiF+IUprb6HnBaa15yc+rNFeEK2f1mChT6BO/rro=;
 b=q8ykzCXMS4nI3Pfj27Wy3NwIgo1Rq4NNGfkqsoD6C2wPQXgnQoMaz08VA2kCi6kkkk
 piU4VtNGf7PMbptgRIPsqKKhPXJPa2/6JD+PZGSl8x4gi169NaUK7Cvq3zgSUYSaLtDu
 c45QgL1E0bVew0pVYQ6rsYOPiMkbdLFU+bJ+ZhKlnCgzbP/TDM9JSX81VdOXzRNyRFux
 jzYIhU4I/7+kVHy5A5umfLxVcu5rn7mT2WBxWlDePeDwOxGkLRMhrGvc3dnoP7bnP53/
 97ddxlk2cC11Hmj/0VLOWF3PDGbsEWRssJtd73gb0BECC7tjzKGGcktW3qaraWiAANpR
 WPng==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:from:date:message-id:subject
 :to; bh=31sdiF+IUprb6HnBaa15yc+rNFeEK2f1mChT6BO/rro=;
 b=aYfhv0V3Un58Vhs7Tidtiwu/rGkp574wauIk6wpmUu+nhm8wLY0X9i13Hp2LvKG9Np
 P5m5+ZsSCaTU981fAHC+y7t/Ip28Oa/l4y//ko53o1B712DQ1jwpSP9qnv+GqKVU0VpE
 ICLfGlKfI+q2ACGezDHaBY8I5J0MS35K+ErGn2glNF4PYLNcnSs7nt3Vz/xqpnMh3mw1
 kpJnI4nyThqJKPq3awa2Yls0x8BXllJNjXF/duZ+KDis7XsyOOu552GpNHVpoKjgjg1V
 a5PH5xLJEPNGE3m+M8voOQcPEexrRc7qCjMaJKWKKscn6ZkVc8qMkysrGpER+CU/3eeh
 H8Vw==
X-Gm-Message-State: ALyK8tI3xRFvmUKfFS5vBqshGtCmvmx11PewbYIrj6GLYQfNtYuS6K3UTTxM52IeawegsJYHXANA4a3jtB0r+A==
X-Received: by 10.157.1.165 with SMTP id e34mr3080852ote.35.1464984642341;
 Fri, 03 Jun 2016 13:10:42 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.157.34.169 with HTTP; Fri, 3 Jun 2016 13:10:41 -0700 (PDT)
From: Noam Postavsky <npostavs@HIDDEN>
Date: Fri, 3 Jun 2016 16:10:41 -0400
X-Google-Sender-Auth: Mu5NvNaVJQiTqq8MzHpQ3cxIUkY
Message-ID: <CAM-tV--4OodvFzFAL17j==fkP-EnTGfien_qjQ7dCi7U6N16aw@HIDDEN>
Subject: 23.0.92.1; Ediff: Creating a multi-file patch
To: 3348 <at> debbugs.gnu.org
Content-Type: text/plain; charset=UTF-8
X-Spam-Score: -0.5 (/)
X-Debbugs-Envelope-To: 3348
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

tag 3348 + confirmed
severity 3348 minor
found 3348 25.0.94
quit

Confirmed this is still an issue. Here is an elisp script for easier
reproduction (run as emacs -Q -l bug-3348.el):

(defconst bug-3348-test-dir
  (expand-file-name "bug-3348-testdir" temporary-file-directory))
(make-directory bug-3348-test-dir t)
(cd bug-3348-test-dir)

(make-directory "dir-a" t)
(make-directory "dir-b" t)

(with-temp-file "dir-a/file"
  (insert "aaa"))
(with-temp-file "dir-b/file"
  (insert "bbb"))

(ediff-directories "dir-a" "dir-b" nil)
(switch-to-buffer "*Ediff Session Group Panel*")

(ediff-next-meta-item 1)
(ediff-mark-for-operation-at-pos nil)
(ediff-collect-custom-diffs)

(with-current-buffer "*Ediff Multifile Diffs*"
  (write-file "foo.patch"))

(with-temp-file "dir-b/file"
  (insert "BBB"))

(ediff-collect-custom-diffs)

(switch-to-buffer "foo.patch")
(diff-buffer-with-file)
(message (concat "Observe foo.patch buffer is different from its file,\n"
                 "but is marked read-only, not modified"))
Information forwarded to bug-gnu-emacs@HIDDEN:
bug#3348; Package emacs. Full text available.

Message received at submit@HIDDEN:


Received: (at submit) by emacsbugs.donarmstrong.com; 22 May 2009 03:41:21 +0000
From jstrait@HIDDEN Thu May 21 20:41:21 2009
X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02
	(2008-06-10) on rzlab.ucr.edu
X-Spam-Level: 
X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available.
	hammytokens:Tokens not available.
X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8
	autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02
Received: from lists.gnu.org (lists.gnu.org [199.232.76.165])
	by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4M3fIoP022515
	for <submit@HIDDEN>; Thu, 21 May 2009 20:41:19 -0700
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1M7LdG-00079p-5z
	for bug-gnu-emacs@HIDDEN; Thu, 21 May 2009 23:41:18 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1M7LdA-00079d-CI
	for bug-gnu-emacs@HIDDEN; Thu, 21 May 2009 23:41:16 -0400
Received: from [199.232.76.173] (port=50977 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1M7LdA-00079a-6H
	for bug-gnu-emacs@HIDDEN; Thu, 21 May 2009 23:41:12 -0400
Received: from smtp.novuscom.net ([216.19.176.3]:39520 helo=novuscom.net)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jstrait@HIDDEN>)
	id 1M7Ld9-00067V-Qn
	for bug-gnu-emacs@HIDDEN; Thu, 21 May 2009 23:41:12 -0400
Received: (qmail 11114 invoked from network); 22 May 2009 03:40:58 -0000
Received: from 216-19-179-189.dyn.novuscom.net (HELO [192.168.0.101]) ([216.19.179.189])
          (envelope-sender <jstrait@HIDDEN>)
          by smtp.novuscom.net (qmail-ldap-1.03) with SMTP
          for <bug-gnu-emacs@HIDDEN>; 22 May 2009 03:40:58 -0000
Message-ID: <4A161D61.6010100@HIDDEN>
Date: Thu, 21 May 2009 20:34:57 -0700
From: Jon Strait <jstrait@HIDDEN>
User-Agent: Thunderbird 2.0.0.19 (X11/20090213)
MIME-Version: 1.0
To: bug-gnu-emacs@HIDDEN
Subject: 23.0.92.1; Ediff: Creating a multi-file patch
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4)

The modified flag is not being set on the patch results buffer when 
ediff-collect-custom-diffs is rerun.

1. Mark the sessions within an ediff-directories session.
2. Run ediff-collect-custom-diffs, which creates a multi-file     patch 
and displays the buffer with this patch.
3. Save this buffer to a file 'foo.patch' with write-file.
4. Change one of the files included in the session group.
5. Run ediff-collect-custom-diffs on the same session             group 
again.
6. The new patch will be displayed as the buffer 'foo.patch',     but 
the buffer's modified flag is not set.
Acknowledgement sent to Jon Strait <jstrait@HIDDEN>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs@HIDDEN>. Full text available.
Report forwarded to bug-submit-list@HIDDEN, Emacs Bugs <bug-gnu-emacs@HIDDEN>:
bug#3348; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sun, 15 Oct 2023 11:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.