GNU bug report logs - #33526
Utilities for emacs-irony-mode

Previous Next

Package: guix-patches;

Reported by: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>

Date: Tue, 27 Nov 2018 17:15:01 UTC

Severity: normal

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33526 in the body.
You can then email your comments to 33526 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33526; Package guix-patches. (Tue, 27 Nov 2018 17:15:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 27 Nov 2018 17:15:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: guix-patches <at> gnu.org
Subject: Utilities for emacs-irony-mode
Date: Tue, 27 Nov 2018 18:13:56 +0100
[Message part 1 (text/plain, inline)]
Hi,
I added some extra packages for using emacs-irony-mode and updated it
to fetch sources from git.
These packages should enhance integration of emacs-irony-mode into emacs.

Tim.
[0001-gnu-Add-emacs-company-irony.patch (text/x-patch, attachment)]
[0002-gnu-Add-emacs-flycheck-irony.patch (text/x-patch, attachment)]
[0003-gnu-Add-emacs-irony-eldoc.patch (text/x-patch, attachment)]
[0004-gnu-emacs-irony-mode-Fetch-source-using-git.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#33526; Package guix-patches. (Thu, 29 Nov 2018 08:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 33526 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 33526 <at> debbugs.gnu.org
Subject: Re: [bug#33526] Utilities for emacs-irony-mode
Date: Thu, 29 Nov 2018 09:48:20 +0100
Hello,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

> From be0733336aaf0047f92eaccb6cb360c86f941298 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Tue, 27 Nov 2018 17:56:33 +0100
> Subject: [PATCH 1/4] gnu: Add emacs-company-irony.
>
> * gnu/packages/emacs.scm (emacs-company-irony): New variable.

I fixed the tiny issues reported by ‘guix lint’, made the description a
full sentence (info "(guix) Synopses and Descriptions"), and committed.

> From bf04fa3e0892bd9461feb5bebb7454f478710282 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Tue, 27 Nov 2018 17:57:14 +0100
> Subject: [PATCH 2/4] gnu: Add emacs-flycheck-irony.
>
> * gnu/packages/emacs.scm (emacs-flycheck-irony): New variable.

[...]

> +	      (method git-fetch)
> +	      (uri (git-reference
> +		    (url "https://github.com/Sarcasm/flycheck-irony.git")
> +		    (commit version)))

The tag should be “v1.0.0”, not “1.0.0”, but then the hash is different
than the one here.

Also, ‘guix lint’ reports the same kind of issues as above.

Could you double-check and adjust the Git references and address the
issues that ‘guix lint’ reports in the remaining patches?

Thank you!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#33526; Package guix-patches. (Fri, 30 Nov 2018 11:06:01 GMT) Full text and rfc822 format available.

Message #11 received at 33526 <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33526 <at> debbugs.gnu.org
Subject: Re: [bug#33526] Utilities for emacs-irony-mode
Date: Fri, 30 Nov 2018 12:04:52 +0100
[Message part 1 (text/plain, inline)]
On 29.11.2018 09:48, Ludovic Courtès wrote:
> The tag should be “v1.0.0”, not “1.0.0”, but then the hash is different
> than the one here.
> 
> Also, ‘guix lint’ reports the same kind of issues as above.
> 
> Could you double-check and adjust the Git references and address the
> issues that ‘guix lint’ reports in the remaining patches?

Sorry for the bad patches.
I changed the following things:
- descriptions of the packages are now full sentences
- The source files now have proper names
- git references and hashs are updated so that the sources can be
  downloaded.

I hope that this resolves all issues.
The patches are attached.

Tim.
[0001-gnu-Add-emacs-flycheck-irony.patch (text/x-patch, attachment)]
[0002-gnu-Add-emacs-irony-eldoc.patch (text/x-patch, attachment)]
[signature.asc (application/pgp-signature, attachment)]

Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Fri, 30 Nov 2018 16:02:01 GMT) Full text and rfc822 format available.

Notification sent to Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>:
bug acknowledged by developer. (Fri, 30 Nov 2018 16:02:02 GMT) Full text and rfc822 format available.

Message #16 received at 33526-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 33526-done <at> debbugs.gnu.org
Subject: Re: [bug#33526] Utilities for emacs-irony-mode
Date: Fri, 30 Nov 2018 17:01:31 +0100
Hi Tim,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

> Sorry for the bad patches.
> I changed the following things:
> - descriptions of the packages are now full sentences
> - The source files now have proper names
> - git references and hashs are updated so that the sources can be
>   downloaded.
>
> I hope that this resolves all issues.

It does.  I applied both patches, thank you!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 29 Dec 2018 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.