GNU bug report logs - #33535
[PATCH] refresh: Account for overlapping updater coverage.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: ericbavier@HIDDEN; Keywords: patch; Done: Eric Bavier <ericbavier@HIDDEN>; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 33535-done <at> debbugs.gnu.org:


Received: (at 33535-done) by debbugs.gnu.org; 11 Dec 2018 04:59:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 10 23:59:51 2018
Received: from localhost ([127.0.0.1]:42621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gWa99-0007Wa-L5
	for submit <at> debbugs.gnu.org; Mon, 10 Dec 2018 23:59:51 -0500
Received: from mail.onyx.syn-alias.com ([206.152.134.66]:23155
 helo=smtp.centurylink.net)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ericbavier@HIDDEN>) id 1gWa98-0007WN-5G
 for 33535-done <at> debbugs.gnu.org; Mon, 10 Dec 2018 23:59:50 -0500
DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402;
 c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1544504384;
 h=From:Subject:Date:To:MIME-Version:Content-Type;
 bh=8Gygxoy+P43iDU8YefArIBhMtM8=;
 b=BMmXlT4DvQ9XVcTWQL9vsQ9EK4GXKVRyJIKDvPYq0tSljPu0zovLzWkg9vz0trRx
 QdDcJEQq/YbNd8fEx99VCoUF2YxFukBghByauNnXMT2NFfjoW/O590SDbY79lYMl
 4/YLwV89pfXFW6XiyTRSfSJLHWj0qUQXPYsS5WbdLpNJM0yvsy+oDJ9fOyqAFfZe
 L77Q4mvTJpVKRU+DPm9hOSmHf/OmW16DD/+J3JW81+cOo6kS3iRnnRqdhEawknIC
 hzwyCOCMtvyw1lE0ohyCzqgcHVGvKxPrTnASCELx5qjcHFWxpQA2XiR4m+wQsChJ
 Qlhy5kVJ/YFxhLF+dRTc7Q==;
X_CMAE_Category: , ,
X-CNFS-Analysis: v=2.3 cv=PeyBeRpd c=1 sm=1 tr=0
 a=cjJt/q+I1cGZQhdwTxhucA==:117 a=cjJt/q+I1cGZQhdwTxhucA==:17
 a=KGjhK52YXX0A:10 a=2ur7OfE09M0A:10 a=zSv6zi-ZgakA:10 a=mDV3o1hIAAAA:8
 a=I_5RNyk1AAAA:8 a=inoG4m36AAAA:8 a=bhYdU6-xQISyiFRcjUQA:9 a=QEXdDO2ut3YA:10
 a=ezCkN-Euj-BjBwW8nM8A:9 a=_FVE-zBwftR9WsbkzFJk:22 a=Eh9yxdLE6B1twWrs3SXz:22
 a=_Qgj-RFg6mImvLaOgLPg:22
X-CM-Score: 0
X-Scanned-by: Cloudmark Authority Engine
X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ=
Authentication-Results: smtp01.onyx.dfw.sync.lan
 smtp.user=ericbavier@HIDDEN; auth=pass (LOGIN)
Received: from [97.116.125.252] ([97.116.125.252:42194] helo=localhost)
 by smtp.centurylink.net (envelope-from <ericbavier@HIDDEN>)
 (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA
 (cipher=AES256-GCM-SHA384) 
 id 2D/19-16365-0444F0C5; Mon, 10 Dec 2018 23:59:44 -0500
Date: Mon, 10 Dec 2018 22:59:41 -0600
From: Eric Bavier <ericbavier@HIDDEN>
To: ludo@HIDDEN (Ludovic =?UTF-8?B?Q291cnTDqHM=?=)
Subject: Re: [bug#33535] [PATCH] refresh: Account for overlapping updater
 coverage.
Message-ID: <20181210225941.033fb854@HIDDEN>
In-Reply-To: <87bm67zsoh.fsf@HIDDEN>
References: <20181128022737.18091-1-ericbavier@HIDDEN>
 <87bm67zsoh.fsf@HIDDEN>
X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 boundary="Sig_/JkIZ+dWJFoyW8ZXhDQP5uXL"; protocol="application/pgp-signature"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 33535-done
Cc: 33535-done <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--Sig_/JkIZ+dWJFoyW8ZXhDQP5uXL
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, 29 Nov 2018 18:42:38 +0100
ludo@HIDDEN (Ludovic Court=C3=A8s) wrote:

> Hello!
>=20
> ericbavier@HIDDEN skribis:
>=20
> > From: Eric Bavier <bavier@HIDDEN>
> >
> > It seams mostly packages covered by both the "hackage" and "stackage"
> > updaters.  And Fribidi is a GNU package but hosted on github.
> >
> > Currently this leads to double-counting while computing total package
> > coverage and a too optimistic result (by about 5.4%).
> >
> > The below patch fixes it by tracking the (un)covered packages directly.=
 =20
>=20
> Oh, good catch.  LGTM!

Applied in cba7ddcf603455c6692eb50c8bbf203a6bf17ab1

>=20
> That also means we=E2=80=99ll have to work on our updaters=E2=80=A6  :-)
>=20

Yup. =20

I have a prototype for an "arch" importer that parses the Archlinux
PKGBUILD files (32% coverage even without any fancy package name
mapping).

I also have a patch to the github updater so that it can update
packages that use git-fetch.  This brings the coverage up to 15.9% from
9.6%.  I think this will be useful if we keep moving packages away from
github's generated tarballs.

`~Eric

--Sig_/JkIZ+dWJFoyW8ZXhDQP5uXL
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwPRD0ACgkQ/XPKxxnT
JWYEnBAAj+DY+IyomUNHLbzrK36UOHBCJCiSbq/O4reJx53s0Y3+eNxc0Se7S0MG
SxMB0Am/ZUNj70m1bZHOwPG8F/EX1qKwzwQDTONU3TF/vJsJRw2CI4ecq82266aY
7tKSWimf96QYvYdpIEHNwSThk1itkO6w24ffxyrTWwYum/AucDyrP6aWnNWdRP7V
2Kn5hHmRIj1NVS3SLbhJgBVSSYjjMO9llpcc0z3VIoNiDJOe6/H+EnjWGcRKsYqQ
hifhyBTEUEZcuUKTgtxBD0Oto0HNGakgGjlYlCdj8BWMPCwUM2uFG4nKUiGkiiB1
Y3U1rvIMI0evGkp2tSKNoK8SmbYz4BHXTi3cJz08KjIZV0j8FOkfU/g1238n7u0t
zCM0AMU4UAa0qMvvJd+wbjbnuv8hvTtIdli9Fg+tR0yXuiYy4J/22Ro0kmE0OMKC
lH3XLMzHLRVB7+/VP6gY65HmEuutzA/cLppxkJc3uhfC3Raoo87oRoxNlTv+HN11
zhLrR7NRceWGo4wZGLiTY+Fe/UMJdUpiqnuS2RyULDt7rIjStHbdCyQ9ESsdQoT8
ggME6uy297mE2vmQot8T0OCbneuFJzwYGPhck343SF103A90lYoHt5tzbkvFjXqP
FxfAR4V31aT8JcZhPDK2wP/3nGbkIevbTt/qJxRUXXAnkOWg7lo=
=PIYV
-----END PGP SIGNATURE-----

--Sig_/JkIZ+dWJFoyW8ZXhDQP5uXL--




Notification sent to ericbavier@HIDDEN:
bug acknowledged by developer. Full text available.
Reply sent to Eric Bavier <ericbavier@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 33535 <at> debbugs.gnu.org:


Received: (at 33535) by debbugs.gnu.org; 29 Nov 2018 17:42:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 29 12:42:51 2018
Received: from localhost ([127.0.0.1]:55072 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gSQKx-0006y0-7Z
	for submit <at> debbugs.gnu.org; Thu, 29 Nov 2018 12:42:51 -0500
Received: from eggs.gnu.org ([208.118.235.92]:45759)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1gSQKv-0006xn-50
 for 33535 <at> debbugs.gnu.org; Thu, 29 Nov 2018 12:42:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ludo@HIDDEN>) id 1gSQKp-00033U-A2
 for 33535 <at> debbugs.gnu.org; Thu, 29 Nov 2018 12:42:43 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55225)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@HIDDEN>)
 id 1gSQKn-00032E-Oa; Thu, 29 Nov 2018 12:42:41 -0500
Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=40322 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1gSQKn-00069o-Fd; Thu, 29 Nov 2018 12:42:41 -0500
From: ludo@HIDDEN (Ludovic =?utf-8?Q?Court=C3=A8s?=)
To: ericbavier@HIDDEN
Subject: Re: [bug#33535] [PATCH] refresh: Account for overlapping updater
 coverage.
References: <20181128022737.18091-1-ericbavier@HIDDEN>
Date: Thu, 29 Nov 2018 18:42:38 +0100
In-Reply-To: <20181128022737.18091-1-ericbavier@HIDDEN> (ericbavier's
 message of "Tue, 27 Nov 2018 20:27:37 -0600")
Message-ID: <87bm67zsoh.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-Spam-Score: -5.0 (-----)
X-Debbugs-Envelope-To: 33535
Cc: Eric Bavier <bavier@HIDDEN>, 33535 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -6.0 (------)

Hello!

ericbavier@HIDDEN skribis:

> From: Eric Bavier <bavier@HIDDEN>
>
> * guix/scripts/refresh.scm (list-updaters-and-exit): Do not assume updater
> predicates are disjoint.  Track covered packages directly.
> ---
> Hello Guix,
>
> Some of our packages are covered by more than one of our updaters:
>
> scheme@(guile-user)> ,use(gnu packages)(guix packages)(guix upstream)
> scheme@(guile-user)> ,use(srfi srfi-1)(srfi srfi-26)
> scheme@(guile-user)> (define updaters (force (@@ (guix upstream) %updater=
s)))
> scheme@(guile-user)> (define predicates (map upstream-updater-predicate u=
pdaters))
> scheme@(guile-user)> (define doubles
>   (fold-packages
>     (lambda (pkg result)
>       (if (> (count (cut <> pkg) predicates) 1)
>          (cons pkg result)
>        result))
>     '()))
> scheme@(guile-user)> (length doubles)
> $1 =3D 469
> scheme@(guile-user)> (map package-name doubles)
> $2 =3D ("agda" "emacs-agda2-mode" "fribidi" "raincat" "ghc-tasty-quickche=
ck" ... "ghc-hxt")
>
> It seams mostly packages covered by both the "hackage" and "stackage"
> updaters.  And Fribidi is a GNU package but hosted on github.
>
> Currently this leads to double-counting while computing total package
> coverage and a too optimistic result (by about 5.4%).
>
> The below patch fixes it by tracking the (un)covered packages directly.

Oh, good catch.  LGTM!

That also means we=E2=80=99ll have to work on our updaters=E2=80=A6  :-)

Thanks,
Ludo=E2=80=99.




Information forwarded to guix-patches@HIDDEN:
bug#33535; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Nov 2018 02:28:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Nov 27 21:28:20 2018
Received: from localhost ([127.0.0.1]:52699 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gRpaO-0000kl-20
	for submit <at> debbugs.gnu.org; Tue, 27 Nov 2018 21:28:20 -0500
Received: from eggs.gnu.org ([208.118.235.92]:39691)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ericbavier@HIDDEN>) id 1gRpaM-0000kZ-Vm
 for submit <at> debbugs.gnu.org; Tue, 27 Nov 2018 21:28:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ericbavier@HIDDEN>) id 1gRpaH-0000dt-08
 for submit <at> debbugs.gnu.org; Tue, 27 Nov 2018 21:28:13 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM
 autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:60668)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ericbavier@HIDDEN>)
 id 1gRpaG-0000do-Tk
 for submit <at> debbugs.gnu.org; Tue, 27 Nov 2018 21:28:12 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49288)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ericbavier@HIDDEN>) id 1gRpaF-0007ve-EY
 for guix-patches@HIDDEN; Tue, 27 Nov 2018 21:28:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ericbavier@HIDDEN>) id 1gRpaC-0000cN-Mb
 for guix-patches@HIDDEN; Tue, 27 Nov 2018 21:28:11 -0500
Received: from mail.onyx.syn-alias.com ([206.152.134.66]:26099
 helo=smtp.centurylink.net)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ericbavier@HIDDEN>)
 id 1gRpaC-0000br-G1
 for guix-patches@HIDDEN; Tue, 27 Nov 2018 21:28:08 -0500
DKIM-Signature: v=1; a=rsa-sha1; d=centurylink.net; s=ctl201402;
 c=relaxed/simple; q=dns/txt; i=@centurylink.net; t=1543372087;
 h=From:Subject:Date:To:MIME-Version;
 bh=9uPqpxXNlB6bXnN6TIF1ixgVKYE=;
 b=Za6/y254YAjyMUZDjJXYJE62Zpx7wsNIbZQxF9ZwoJUGqWwNmgIe30kc2H4MACtj
 0u/SvMbQ5vYyE1W8AROCSvcIKXktOz+rShf9GjaXzq3Y2BLENt1tv3UFIU/Hx0gj
 jYq8832i1e4LrM8nO0Ir7ghkw03JhhI87z6fNvlqJ3APDFKDQulkP0lJQfF21p1H
 4+azCVHDLnzrsX38Xc6fmi4ZUaKGSEAjitWtCN3XyPU9n9Nv4UclCJNkssAeGt13
 RVyYnBO9wCw7LJ48lp2dTr1TR28AqIDc5xpXLt4LDVVzVWozFr0uk/vLQAf4bu36
 INuqqRwZTfhztpdeNFcCuQ==;
X_CMAE_Category: , ,
X-CNFS-Analysis: v=2.2 cv=RqKHF2uK c=1 sm=1 tr=0
 a=PfFp8hmzMLas+YAS7JUBXg==:117 a=PfFp8hmzMLas+YAS7JUBXg==:17
 a=KGjhK52YXX0A:10 a=JHtHm7312UAA:10 a=zSv6zi-ZgakA:10 a=inoG4m36AAAA:8
 a=7Nk6JicNMJbZTrWe8JsA:9 a=93VgcTwNqkpEecET:21 a=qjMAKVMZgvMTGy5u:21
 a=_Qgj-RFg6mImvLaOgLPg:22
X-CM-Score: 0
X-Scanned-by: Cloudmark Authority Engine
X-Authed-Username: ZXJpY2JhdmllckBjZW50dXJ5bGluay5uZXQ=
Authentication-Results: smtp04.onyx.dfw.sync.lan
 smtp.user=ericbavier@HIDDEN; auth=pass (LOGIN)
Received: from [97.116.107.116] ([97.116.107.116:51300]
 helo=localhost.localdomain)
 by smtp.centurylink.net (envelope-from <ericbavier@HIDDEN>)
 (ecelerity 3.6.25.56547 r(Core:3.6.25.0)) with ESMTPSA
 (cipher=DHE-RSA-AES128-GCM-SHA256) 
 id 37/4A-19453-63DFDFB5; Tue, 27 Nov 2018 21:28:06 -0500
From: ericbavier@HIDDEN
To: guix-patches@HIDDEN
Subject: [PATCH] refresh: Account for overlapping updater coverage.
Date: Tue, 27 Nov 2018 20:27:37 -0600
Message-Id: <20181128022737.18091-1-ericbavier@HIDDEN>
X-Mailer: git-send-email 2.19.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: Eric Bavier <bavier@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

From: Eric Bavier <bavier@HIDDEN>

* guix/scripts/refresh.scm (list-updaters-and-exit): Do not assume updater
predicates are disjoint.  Track covered packages directly.
---
Hello Guix,

Some of our packages are covered by more than one of our updaters:

scheme@(guile-user)> ,use(gnu packages)(guix packages)(guix upstream)
scheme@(guile-user)> ,use(srfi srfi-1)(srfi srfi-26)
scheme@(guile-user)> (define updaters (force (@@ (guix upstream) %updaters)))
scheme@(guile-user)> (define predicates (map upstream-updater-predicate updaters))
scheme@(guile-user)> (define doubles
  (fold-packages
    (lambda (pkg result)
      (if (> (count (cut <> pkg) predicates) 1)
         (cons pkg result)
       result))
    '()))
scheme@(guile-user)> (length doubles)
$1 = 469
scheme@(guile-user)> (map package-name doubles)
$2 = ("agda" "emacs-agda2-mode" "fribidi" "raincat" "ghc-tasty-quickcheck" ... "ghc-hxt")

It seams mostly packages covered by both the "hackage" and "stackage"
updaters.  And Fribidi is a GNU package but hosted on github.

Currently this leads to double-counting while computing total package
coverage and a too optimistic result (by about 5.4%).

The below patch fixes it by tracking the (un)covered packages directly.


 guix/scripts/refresh.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 58fc64db1..f7d2cffb7 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -179,24 +179,24 @@ specified with `--select'.\n"))
 
   (let* ((packages (fold-packages cons '()))
          (total    (length packages)))
-    (define covered
-      (fold (lambda (updater covered)
-              (let ((matches (count (upstream-updater-predicate updater)
-                                    packages)))
+    (define uncovered
+      (fold (lambda (updater uncovered)
+              (let ((matches (filter (upstream-updater-predicate updater)
+                                     packages)))
                 ;; TRANSLATORS: The parenthetical expression here is rendered
                 ;; like "(42% coverage)" and denotes the fraction of packages
                 ;; covered by the given updater.
                 (format #t (G_ "  - ~a: ~a (~2,1f% coverage)~%")
                         (upstream-updater-name updater)
                         (G_ (upstream-updater-description updater))
-                        (* 100. (/ matches total)))
-                (+ covered matches)))
-            0
+                        (* 100. (/ (length matches) total)))
+                (lset-difference eq? uncovered matches)))
+            packages
             (force %updaters)))
 
     (newline)
     (format #t (G_ "~2,1f% of the packages are covered by these updaters.~%")
-            (* 100. (/ covered total))))
+            (* 100. (/ (- total (length uncovered)) total))))
   (exit 0))
 
 (define (warn-no-updater package)
-- 
2.19.1





Acknowledgement sent to ericbavier@HIDDEN:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#33535; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 11 Dec 2018 05:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.