GNU bug report logs - #33565
[PATCH] gnu: Add python-xmltodict.

Previous Next

Package: guix-patches;

Reported by: Oleg Pykhalov <go.wigust <at> gmail.com>

Date: Sat, 1 Dec 2018 20:20:02 UTC

Severity: normal

Tags: patch

Done: Oleg Pykhalov <go.wigust <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33565 in the body.
You can then email your comments to 33565 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33565; Package guix-patches. (Sat, 01 Dec 2018 20:20:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 01 Dec 2018 20:20:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add python-xmltodict.
Date: Sat,  1 Dec 2018 23:18:32 +0300
* gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
---
 gnu/packages/xml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 347ac878a3..1bb6ba48aa 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -39,6 +39,7 @@
 (define-module (gnu packages xml)
   #:use-module (gnu packages)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages gnupg)
@@ -2133,3 +2134,27 @@ It converts the procedure call into an XML document, sends it to a remote
 server using HTTP, and gets back the response as XML.  This library provides a
 modular implementation of XML-RPC for C and C++.")
     (license (list license:psfl license:expat))))
+
+(define-public python-xmltodict
+  (package
+    (name "python-xmltodict")
+    (version "0.11.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "xmltodict" version))
+        (sha256
+          (base32
+            "1pxh4yjhvmxi1h6f92skv41g4kbsws3ams57150kzn18m907v3cg"))))
+    (build-system python-build-system)
+    (native-inputs
+     `(("python-coverage" ,python-coverage)
+       ("python-nose" ,python-nose)))
+    (home-page "https://github.com/martinblech/xmltodict")
+    (synopsis "Work with XML like you are working with JSON")
+    (description "This package provides a Python library to work with XML like
+you are working with JSON")
+    (license license:expat)))
+
+(define-public python2-xmltodict
+  (package-with-python2 python-xmltodict))
-- 
2.19.1





Information forwarded to guix-patches <at> gnu.org:
bug#33565; Package guix-patches. (Mon, 03 Dec 2018 13:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 33565 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 33565 <at> debbugs.gnu.org
Subject: Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.
Date: Mon, 03 Dec 2018 14:32:59 +0100
Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> * gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.

[...]

> +    (home-page "https://github.com/martinblech/xmltodict")
> +    (synopsis "Work with XML like you are working with JSON")
> +    (description "This package provides a Python library to work with XML like
> +you are working with JSON")

Could you expound a bit on what this means (I’m curious!) and add a
period?

> +(define-public python2-xmltodict
> +  (package-with-python2 python-xmltodict))

Unless you really need it, you should omit the Python 2.x variant.

Otherwise LGTM, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#33565; Package guix-patches. (Tue, 04 Dec 2018 05:14:02 GMT) Full text and rfc822 format available.

Message #11 received at 33565 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 33565 <at> debbugs.gnu.org
Subject: Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.
Date: Tue, 04 Dec 2018 08:13:44 +0300
[Message part 1 (text/plain, inline)]
Hi Ludovic.

Thank you for review.

ludo <at> gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> * gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
>
> [...]
>
>> +    (home-page "https://github.com/martinblech/xmltodict")
>> +    (synopsis "Work with XML like you are working with JSON")
>> +    (description "This package provides a Python library to work with XML like
>> +you are working with JSON")
>
> Could you expound a bit on what this means (I’m curious!) and add a
> period?

It's a quote from the home page. :-) But in reality this Python library
converts input string which contains XML to an OrderedDict object which
looks like a JSON.  Queries for data inside OrderedDict feels (I guess)
like you're working with JSON.  Maybe we should change a description to
“This package provides a Python library to convert XML to OrderedDict.”,
WDYT?

>> +(define-public python2-xmltodict
>> +  (package-with-python2 python-xmltodict))
>
> Unless you really need it, you should omit the Python 2.x variant.

Sure, I'll omit.

Oleg.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33565; Package guix-patches. (Tue, 04 Dec 2018 08:48:01 GMT) Full text and rfc822 format available.

Message #14 received at 33565 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 33565 <at> debbugs.gnu.org
Subject: Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.
Date: Tue, 04 Dec 2018 09:47:16 +0100
Hi!

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>>
>>> * gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
>>
>> [...]
>>
>>> +    (home-page "https://github.com/martinblech/xmltodict")
>>> +    (synopsis "Work with XML like you are working with JSON")
>>> +    (description "This package provides a Python library to work with XML like
>>> +you are working with JSON")
>>
>> Could you expound a bit on what this means (I’m curious!) and add a
>> period?
>
> It's a quote from the home page. :-) But in reality this Python library
> converts input string which contains XML to an OrderedDict object which
> looks like a JSON.  Queries for data inside OrderedDict feels (I guess)
> like you're working with JSON.  Maybe we should change a description to
> “This package provides a Python library to convert XML to OrderedDict.”,

@code{OrderedDict} even.  :-)

LGTM with this change, thank you!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#33565; Package guix-patches. (Wed, 05 Dec 2018 00:46:02 GMT) Full text and rfc822 format available.

Message #17 received at 33565 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 33565-done <at> debbugs.gnu.org, 33565 <at> debbugs.gnu.org
Subject: Re: [bug#33565] [PATCH] gnu: Add python-xmltodict.
Date: Wed, 05 Dec 2018 03:45:25 +0300
[Message part 1 (text/plain, inline)]
ludo <at> gnu.org (Ludovic Courtès) writes:

> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>>
>>> Oleg Pykhalov <go.wigust <at> gmail.com> skribis:
>>>
>>>> * gnu/packages/xml.scm (python-xmltodict, python2-xmltodict): New variables.
>>>
>>> [...]
>>>
>>>> +    (home-page "https://github.com/martinblech/xmltodict")
>>>> +    (synopsis "Work with XML like you are working with JSON")
>>>> +    (description "This package provides a Python library to work with XML like
>>>> +you are working with JSON")
>>>
>>> Could you expound a bit on what this means (I’m curious!) and add a
>>> period?
>>
>> It's a quote from the home page. :-) But in reality this Python library
>> converts input string which contains XML to an OrderedDict object which
>> looks like a JSON.  Queries for data inside OrderedDict feels (I guess)
>> like you're working with JSON.  Maybe we should change a description to
>> “This package provides a Python library to convert XML to OrderedDict.”,
>
> @code{OrderedDict} even.  :-)
>
> LGTM with this change, thank you!

Pushed as 79a0eabd2a8765c294b3e2decf71a27cd1dd219d

Thanks,
Oleg.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
You have taken responsibility. (Wed, 05 Dec 2018 00:46:03 GMT) Full text and rfc822 format available.

Notification sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
bug acknowledged by developer. (Wed, 05 Dec 2018 00:46:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 02 Jan 2019 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.