GNU bug report logs - #33609
fortune-mod build (test) failure

Previous Next

Package: guix;

Reported by: Danny Milosavljevic <dannym <at> scratchpost.org>

Date: Tue, 4 Dec 2018 10:11:01 UTC

Severity: normal

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33609 in the body.
You can then email your comments to 33609 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-guix <at> gnu.org:
bug#33609; Package guix. (Tue, 04 Dec 2018 10:11:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Tue, 04 Dec 2018 10:11:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: <bug-guix <at> gnu.org>
Subject: fortune-mod build (test) failure
Date: Tue, 4 Dec 2018 11:10:33 +0100

[Message part 1 (text/plain, inline)]
Running [prove /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t]
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t ........... ok
(computers)
%
(cookie)
%
(politics)
%
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t .......... ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t ...... ok
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t .. ok
No fortunes found

#   Failed test 'fortune valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 15.
No fortunes found

#   Failed test 'fortune -f valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 25.
No fortunes found

#   Failed test 'fortune -m valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 35.
No fortunes found

#   Failed test 'fortune -i -m valgrind test'
#   at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t line 45.
# Looks like you failed 4 tests of 4.
/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t              (Wstat: 1024 Tests: 4 Failed: 4)
  Failed tests:  1-4
  Non-zero exit status: 4
Files=5, Tests=10, 22 wallclock secs ( 0.40 usr  0.05 sys + 14.69 cusr  6.35 csys = 21.49 CPU)
Result: FAIL
Running [prove /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/check-cookies.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-m.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/test-fortune-o-rot.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/trailing-space-and-CRs.t /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t] failed! at /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/run-tests.pl line 32.
make[3]: *** [CMakeFiles/check.dir/build.make:60: CMakeFiles/check] Error 1
make[3]: Leaving directory '/tmp/guix-build-fortune-mod-2.6.1.drv-0/source/build'


[Message part 2 (application/pgp-signature, inline)]
Information forwarded to bug-guix <at> gnu.org:
bug#33609; Package guix. (Tue, 04 Dec 2018 21:35:02 GMT) Full text and rfc822 format available.

Message #8 received at 33609 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 33609 <at> debbugs.gnu.org
Subject: Re: bug#33609: fortune-mod build (test) failure
Date: Tue, 4 Dec 2018 16:34:25 -0500

[Message part 1 (text/plain, inline)]
On Tue, Dec 04, 2018 at 11:10:33AM +0100, Danny Milosavljevic wrote:
> # Looks like you failed 4 tests of 4.
> /tmp/guix-build-fortune-mod-2.6.1.drv-0/source/fortune-mod/tests/t/valgrind.t              (Wstat: 1024 Tests: 4 Failed: 4)
>   Failed tests:  1-4
>   Non-zero exit status: 4
> Files=5, Tests=10, 22 wallclock secs ( 0.40 usr  0.05 sys + 14.69 cusr  6.35 csys = 21.49 CPU)
> Result: FAIL

I wonder, does this program really need a test suite that includes
Valgrind?

[signature.asc (application/pgp-signature, inline)]
Information forwarded to bug-guix <at> gnu.org:
bug#33609; Package guix. (Mon, 21 Jan 2019 22:11:02 GMT) Full text and rfc822 format available.

Message #11 received at 33609 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <mail <at> ambrevar.xyz>
To: 33609 <at> debbugs.gnu.org
Subject: bug#33609: fortune-mod build (test) failure
Date: Mon, 21 Jan 2019 23:09:58 +0100

[Message part 1 (text/plain, inline)]
I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
valgrind test.  This is not ideal but better than having a broken
package.

Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
could be related.

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[signature.asc (application/pgp-signature, inline)]
Information forwarded to bug-guix <at> gnu.org:
bug#33609; Package guix. (Tue, 14 Sep 2021 04:51:02 GMT) Full text and rfc822 format available.

Message #14 received at 33609 <at> debbugs.gnu.org (full text, mbox):

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: Pierre Neidhardt <mail <at> ambrevar.xyz>
Cc: 33609 <at> debbugs.gnu.org
Subject: Re: bug#33609: fortune-mod build (test) failure
Date: Mon, 13 Sep 2021 21:50:30 -0700

[Message part 1 (text/plain, inline)]
Hi,

Pierre Neidhardt <mail <at> ambrevar.xyz> writes:

> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
> valgrind test.  This is not ideal but better than having a broken
> package.
>
> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
> could be related.

This seems to be fixed now.  I've attached a patch below to reenable it.

It could probably do with an update, too.  It now vendors 'rinutils'
(which we already have as an input) so that would need to be removed.

--
Sarah


[0001-gnu-fortune-mod-Re-enable-test.patch (text/x-patch, inline)]
From 5aa332afa3f624ecab54ffd411026700b0d0dfb8 Mon Sep 17 00:00:00 2001
Message-Id: <5aa332afa3f624ecab54ffd411026700b0d0dfb8.1631594857.git.iskarian <at> mgsn.dev>
From: Sarah Morgensen <iskarian <at> mgsn.dev>
Date: Mon, 13 Sep 2021 21:40:43 -0700
Subject: [PATCH] gnu: fortune-mod: Re-enable test.

Re-enable the valgrind test, fixed in a previous version update.

* gnu/packages/games.scm (fortune-mod)[arguments]<#:phases>
{fix-build-env}: Re-enable test.
---
 gnu/packages/games.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index a2f756e3a7..4236560143 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -7633,11 +7633,7 @@ original.")
                (copy-file cmake-rules
                           (string-append "fortune-mod/cmake/"
                                          (strip-store-file-name cmake-rules)))
-               (chdir "fortune-mod")
-               ;; TODO: Valgrind tests fail for some reason.
-               ;; Similar issue: https://github.com/shlomif/fortune-mod/issues/21 (?)
-               (delete-file "tests/t/valgrind.t")
-               #t)))
+               (chdir "fortune-mod"))))
          (add-after 'install 'fix-install-directory
            (lambda* (#:key outputs #:allow-other-keys)
              ;; Move binary from "games/" to "bin/" and remove the latter.  This

base-commit: 72297993a174586ee0a23b95b6b9ee2f3db34cf1
-- 
2.33.0
Reply sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
You have taken responsibility. (Wed, 13 Jul 2022 15:07:02 GMT) Full text and rfc822 format available.
Notification sent to Danny Milosavljevic <dannym <at> scratchpost.org>:
bug acknowledged by developer. (Wed, 13 Jul 2022 15:07:02 GMT) Full text and rfc822 format available.

Message #19 received at 33609-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, 33609-done <at> debbugs.gnu.org
Subject: Re: bug#33609: fortune-mod build (test) failure
Date: Wed, 13 Jul 2022 11:06:08 -0400

Hi,

Sarah Morgensen <iskarian <at> mgsn.dev> writes:

> Hi,
>
> Pierre Neidhardt <mail <at> ambrevar.xyz> writes:
>
>> I've pushed 6185732390003ca36a730231bb6280b68c37ee8e which skips the
>> valgrind test.  This is not ideal but better than having a broken
>> package.
>>
>> Upstream has https://github.com/shlomif/fortune-mod/issues/21 which
>> could be related.
>
> This seems to be fixed now.  I've attached a patch below to reenable it.
>
> It could probably do with an update, too.  It now vendors 'rinutils'
> (which we already have as an input) so that would need to be removed.

Our fortune-mod package is now at version 3.14.0.  I haven't reviewed
bundling status, but if there are problem, we can open a new issue.

Closing for now,

Thanks!

Maxim
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 11 Aug 2022 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 258 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.