GNU bug report logs - #33646
[PATCH] doc: improve wording of the --kibibytes option description

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33646 in the body.
You can then email your comments to 33646 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] doc: improve wording of the --kibibytes option description
Date: Thu,  6 Dec 2018 14:32:49 +0100

Bug: https://bugzilla.redhat.com/1527391
---
 doc/coreutils.texi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index f8339d73f..e93fe71a0 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -7975,9 +7975,11 @@ Append @samp{*} for executable regular files, otherwise behave as for
 @opindex --kibibytes
 Set the default block size to its normal value of 1024 bytes,
 overriding any contrary specification in environment variables
-(@pxref{Block size}).  This option is in turn overridden by the
-@option{--block-size}, @option{-h} or @option{--human-readable}, and
-@option{--si} options.
+(@pxref{Block size}).  If @option{--block-size}, @option{-h},
+@option{--human-readable}, or @option{--si} options are used,
+they take precedence over @option{-k} or @option{--kibibytes}
+even if @option{-k} or @option{--kibibytes} is placed after
+the other options.
 
 The @option{-k} or @option{--kibibytes} option affects the
 per-directory block count written by the @option{-l} and similar
-- 
2.17.2

Message #8 received at 33646 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Kamil Dudka <kdudka <at> redhat.com>, 33646 <at> debbugs.gnu.org
Subject: Re: bug#33646: [PATCH] doc: improve wording of the --kibibytes option
 description
Date: Fri, 18 Jan 2019 00:26:18 -0700

Hello,

On 2018-12-06 6:32 a.m., Kamil Dudka wrote:
> Bug: https://bugzilla.redhat.com/1527391
> ---
>   doc/coreutils.texi | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> index f8339d73f..e93fe71a0 100644
> --- a/doc/coreutils.texi
> +++ b/doc/coreutils.texi
> @@ -7975,9 +7975,11 @@ Append @samp{*} for executable regular files, otherwise behave as for
>   @opindex --kibibytes
>   Set the default block size to its normal value of 1024 bytes,
>   overriding any contrary specification in environment variables
> -(@pxref{Block size}).  This option is in turn overridden by the
> -@option{--block-size}, @option{-h} or @option{--human-readable}, and
> -@option{--si} options.
> +(@pxref{Block size}).  If @option{--block-size}, @option{-h},
> +@option{--human-readable}, or @option{--si} options are used,
> +they take precedence over @option{-k} or @option{--kibibytes}
> +even if @option{-k} or @option{--kibibytes} is placed after
> +the other options.
>   
>   The @option{-k} or @option{--kibibytes} option affects the
>   per-directory block count written by the @option{-l} and similar
> 

I'm ok with this improvement - if there are no comments
I'll push in the next few days.

-assaf

Message #11 received at 33646 <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: 33646 <at> debbugs.gnu.org
Subject: Re: bug#33646: [PATCH] doc: improve wording of the --kibibytes option
 description
Date: Fri, 18 Jan 2019 14:18:31 +0100

On Friday, January 18, 2019 8:26:18 AM CET Assaf Gordon wrote:
> Hello,
> 
> On 2018-12-06 6:32 a.m., Kamil Dudka wrote:
> > Bug: https://bugzilla.redhat.com/1527391
> > ---
> > 
> >   doc/coreutils.texi | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> > index f8339d73f..e93fe71a0 100644
> > --- a/doc/coreutils.texi
> > +++ b/doc/coreutils.texi
> > @@ -7975,9 +7975,11 @@ Append @samp{*} for executable regular files,
> > otherwise behave as for> 
> >   @opindex --kibibytes
> >   Set the default block size to its normal value of 1024 bytes,
> >   overriding any contrary specification in environment variables
> > 
> > -(@pxref{Block size}).  This option is in turn overridden by the
> > -@option{--block-size}, @option{-h} or @option{--human-readable}, and
> > -@option{--si} options.
> > +(@pxref{Block size}).  If @option{--block-size}, @option{-h},
> > +@option{--human-readable}, or @option{--si} options are used,
> > +they take precedence over @option{-k} or @option{--kibibytes}
> > +even if @option{-k} or @option{--kibibytes} is placed after
> > +the other options.
> > 
> >   The @option{-k} or @option{--kibibytes} option affects the
> >   per-directory block count written by the @option{-l} and similar
> 
> I'm ok with this improvement - if there are no comments
> I'll push in the next few days.
> 
> -assaf

Sounds good.  Thank you for taking care of it!

Kamil

Message #14 received at 33646 <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: bug-coreutils <at> gnu.org, 33646 <at> debbugs.gnu.org
Subject: Re: bug#33646: [PATCH] doc: improve wording of the --kibibytes option
 description
Date: Fri, 15 Mar 2019 15:38:11 +0100

On Friday, January 18, 2019 8:26:18 AM CET Assaf Gordon wrote:
> Hello,
> 
> On 2018-12-06 6:32 a.m., Kamil Dudka wrote:
> > Bug: https://bugzilla.redhat.com/1527391
> > ---
> > 
> >   doc/coreutils.texi | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> > index f8339d73f..e93fe71a0 100644
> > --- a/doc/coreutils.texi
> > +++ b/doc/coreutils.texi
> > @@ -7975,9 +7975,11 @@ Append @samp{*} for executable regular files,
> > otherwise behave as for> 
> >   @opindex --kibibytes
> >   Set the default block size to its normal value of 1024 bytes,
> >   overriding any contrary specification in environment variables
> > 
> > -(@pxref{Block size}).  This option is in turn overridden by the
> > -@option{--block-size}, @option{-h} or @option{--human-readable}, and
> > -@option{--si} options.
> > +(@pxref{Block size}).  If @option{--block-size}, @option{-h},
> > +@option{--human-readable}, or @option{--si} options are used,
> > +they take precedence over @option{-k} or @option{--kibibytes}
> > +even if @option{-k} or @option{--kibibytes} is placed after
> > +the other options.
> > 
> >   The @option{-k} or @option{--kibibytes} option affects the
> >   per-directory block count written by the @option{-l} and similar
> 
> I'm ok with this improvement - if there are no comments
> I'll push in the next few days.
> 
> -assaf

I can see no more comments on this.  Could you please proceed to push it?

Kamil

Message #20 received at 33646 <at> debbugs.gnu.org (full text, mbox):

From: Assaf Gordon <assafgordon <at> gmail.com>
To: Kamil Dudka <kdudka <at> redhat.com>
Cc: 33646 <at> debbugs.gnu.org
Subject: Re: bug#33646: [PATCH] doc: improve wording of the --kibibytes option
 description
Date: Fri, 15 Mar 2019 12:30:55 -0600

tags 33646 fixed
close 33646
stop

On 2019-03-15 8:38 a.m., Kamil Dudka wrote:
>>> Bug: https://bugzilla.redhat.com/1527391
>>> ---
>>>
>>>    doc/coreutils.texi | 8 +++++---
> 
> I can see no more comments on this.  Could you please proceed to push it?
> 

Thanks for the reminder.

Pushed here:
https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=6bd78f27fdc2df89b1219921c6f5735885f15e37

-assaf

Message #27 received at 33646 <at> debbugs.gnu.org (full text, mbox):

From: Kamil Dudka <kdudka <at> redhat.com>
To: Assaf Gordon <assafgordon <at> gmail.com>
Cc: bug-coreutils <at> gnu.org, 33646 <at> debbugs.gnu.org
Subject: Re: bug#33646: [PATCH] doc: improve wording of the --kibibytes option
 description
Date: Fri, 15 Mar 2019 22:27:05 +0100

On Friday, March 15, 2019 7:30:55 PM CET Assaf Gordon wrote:
> Pushed here:
> https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=6bd78f27fdc2df89b
> 1219921c6f5735885f15e37
> 
> -assaf

Thanks!

Kamil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.