GNU bug report logs - #33679
Emacs uses APIs deprecated in WebKitGTK 2.21.1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33679 in the body.
You can then email your comments to 33679 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports <bug-gnu-emacs <at> gnu.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, Joakim Verona <joakim <at> verona.se>
Subject: Emacs uses APIs deprecated in WebKitGTK 2.21.1
Date: Sat, 8 Dec 2018 15:59:36 -0800

[Message part 1 (text/plain, inline)]

I hadn't built Emacs lately with xwidgets support. When I tried it on Fedora 29 
via './configure --with-xwidgets --enable-gcc-warnings' the build failed with 
the diagnostics at the end of this message. Apparently WebKitGTK has mutated and 
Emacs hasn't kept up. Although I plan to work around the immediate problem by 
installing the attached patch on master, could an xwidgets expert please fix 
this the "right" way by using the JavaScriptCore GLib API instead? Thanks.

  CC       xwidget.o
xwidget.c: In function ‘webkit_javascript_finished_cb’:
xwidget.c:393:2: error: ‘webkit_javascript_result_get_global_context’ is 
deprecated [-Werror=deprecated-declarations]
  context = webkit_javascript_result_get_global_context (js_result);
  ^~~~~~~
In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54,
                 from xwidget.c:30:
/usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:49:1: note: declared 
here
 webkit_javascript_result_get_global_context (WebKitJavascriptResult *js_result);
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xwidget.c:394:2: error: ‘webkit_javascript_result_get_value’ is deprecated: Use 
'webkit_javascript_result_get_js_value' instead [-Werror=deprecated-declarations]
  value = webkit_javascript_result_get_value (js_result);
  ^~~~~
In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54,
                 from xwidget.c:30:
/usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:52:1: note: declared 
here
 webkit_javascript_result_get_value          (WebKitJavascriptResult *js_result);
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:384: xwidget.o] Error 1
make[1]: Leaving directory '/home/eggert/src/gnu/emacs/master-tmp/src'
make: *** [Makefile:421: src] Error 2

[0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch (text/x-patch, attachment)]

Message #8 received at 33679 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 33679 <at> debbugs.gnu.org,
 Joakim Verona <joakim <at> verona.se>
Subject: Re: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1
Date: Fri, 21 Aug 2020 14:10:34 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

[...]

> Although I plan to work around the immediate problem by installing
> the attached patch on master, 

[...]

> +/* Suppress GCC deprecation warnings starting in WebKitGTK+ 2.21.1 for
> +   webkit_javascript_result_get_global_context and
> +   webkit_javascript_result_get_value.
> +   FIXME: Use the JavaScriptCore GLib API instead, and remove this hack.  */
> +#if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0)
> +# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
> +#endif

Paul, it looks like this patch was never applied?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #13 received at 33679-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Ricardo Wurmus <rekado <at> elephly.net>, 33679-done <at> debbugs.gnu.org,
 Joakim Verona <joakim <at> verona.se>
Subject: Re: bug#33679: Emacs uses APIs deprecated in WebKitGTK 2.21.1
Date: Fri, 21 Aug 2020 14:51:54 -0700

On 8/21/20 5:10 AM, Lars Ingebrigtsen wrote:
> Paul, it looks like this patch was never applied?

The patch was applied, but was later removed when Jimmy Aguilar Mena fixed the 
underlying problem in 2019-09-17T20:00:21Z!kratsbinovish <at> gmail.com. Closing the 
bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.