GNU bug report logs - #33679
Emacs uses APIs deprecated in WebKitGTK 2.21.1

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Paul Eggert <eggert@HIDDEN>; dated Sun, 9 Dec 2018 00:00:02 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 8 Dec 2018 23:59:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 08 18:59:55 2018
Received: from localhost ([127.0.0.1]:39012 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gVmVn-0000n5-0c
	for submit <at> debbugs.gnu.org; Sat, 08 Dec 2018 18:59:55 -0500
Received: from eggs.gnu.org ([208.118.235.92]:59214)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eggert@HIDDEN>) id 1gVmVk-0000mo-IX
 for submit <at> debbugs.gnu.org; Sat, 08 Dec 2018 18:59:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eggert@HIDDEN>) id 1gVmVe-00028l-C0
 for submit <at> debbugs.gnu.org; Sat, 08 Dec 2018 18:59:47 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:51704)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <eggert@HIDDEN>) id 1gVmVe-00028h-7p
 for submit <at> debbugs.gnu.org; Sat, 08 Dec 2018 18:59:46 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40589)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <eggert@HIDDEN>) id 1gVmVd-00044c-1s
 for bug-gnu-emacs@HIDDEN; Sat, 08 Dec 2018 18:59:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <eggert@HIDDEN>) id 1gVmVZ-00027p-1n
 for bug-gnu-emacs@HIDDEN; Sat, 08 Dec 2018 18:59:44 -0500
Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38428)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <eggert@HIDDEN>) id 1gVmVY-00027F-Mk
 for bug-gnu-emacs@HIDDEN; Sat, 08 Dec 2018 18:59:40 -0500
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1029A1605D7;
 Sat,  8 Dec 2018 15:59:39 -0800 (PST)
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032)
 with ESMTP id ALfiHWPjUjn7; Sat,  8 Dec 2018 15:59:37 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
 by zimbra.cs.ucla.edu (Postfix) with ESMTP id AB0EB1605CA;
 Sat,  8 Dec 2018 15:59:37 -0800 (PST)
X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu
Received: from zimbra.cs.ucla.edu ([127.0.0.1])
 by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026)
 with ESMTP id HcG7Tp8MSYZV; Sat,  8 Dec 2018 15:59:37 -0800 (PST)
Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com
 [23.242.74.103])
 by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6BE561604F6;
 Sat,  8 Dec 2018 15:59:37 -0800 (PST)
To: Emacs bug reports <bug-gnu-emacs@HIDDEN>
From: Paul Eggert <eggert@HIDDEN>
Subject: Emacs uses APIs deprecated in WebKitGTK 2.21.1
Organization: UCLA Computer Science Department
Message-ID: <65ba713b-68e0-02d2-7795-177a7f27a407@HIDDEN>
Date: Sat, 8 Dec 2018 15:59:36 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------FED6421367BBAB68D371E177"
Content-Language: en-US
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
Cc: Ricardo Wurmus <rekado@HIDDEN>, Joakim Verona <joakim@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

This is a multi-part message in MIME format.
--------------FED6421367BBAB68D371E177
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

I hadn't built Emacs lately with xwidgets support. When I tried it on Fed=
ora 29=20
via './configure --with-xwidgets --enable-gcc-warnings' the build failed =
with=20
the diagnostics at the end of this message. Apparently WebKitGTK has muta=
ted and=20
Emacs hasn't kept up. Although I plan to work around the immediate proble=
m by=20
installing the attached patch on master, could an xwidgets expert please =
fix=20
this the "right" way by using the JavaScriptCore GLib API instead? Thanks=
.

   CC       xwidget.o
xwidget.c: In function =E2=80=98webkit_javascript_finished_cb=E2=80=99:
xwidget.c:393:2: error: =E2=80=98webkit_javascript_result_get_global_cont=
ext=E2=80=99 is=20
deprecated [-Werror=3Ddeprecated-declarations]
   context =3D webkit_javascript_result_get_global_context (js_result);
   ^~~~~~~
In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54,
                  from xwidget.c:30:
/usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:49:1: note: d=
eclared=20
here
  webkit_javascript_result_get_global_context (WebKitJavascriptResult *js=
_result);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xwidget.c:394:2: error: =E2=80=98webkit_javascript_result_get_value=E2=80=
=99 is deprecated: Use=20
'webkit_javascript_result_get_js_value' instead [-Werror=3Ddeprecated-dec=
larations]
   value =3D webkit_javascript_result_get_value (js_result);
   ^~~~~
In file included from /usr/include/webkitgtk-4.0/webkit2/webkit2.h:54,
                  from xwidget.c:30:
/usr/include/webkitgtk-4.0/webkit2/WebKitJavascriptResult.h:52:1: note: d=
eclared=20
here
  webkit_javascript_result_get_value          (WebKitJavascriptResult *js=
_result);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:384: xwidget.o] Error 1
make[1]: Leaving directory '/home/eggert/src/gnu/emacs/master-tmp/src'
make: *** [Makefile:421: src] Error 2

--------------FED6421367BBAB68D371E177
Content-Type: text/x-patch;
 name="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="0001-Suppress-WebKitGTK-2.21.1-diagnostics.patch"

From bcdda254cb249950812a6b7122278a4d63761194 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@HIDDEN>
Date: Sat, 8 Dec 2018 15:29:07 -0800
Subject: [PATCH] Suppress WebKitGTK+ 2.21.1 diagnostics

* src/xwidget.c: Suppress deprecation warnings.
---
 src/xwidget.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/xwidget.c b/src/xwidget.c
index 6da7a0bb3f..24f7d39077 100644
--- a/src/xwidget.c
+++ b/src/xwidget.c
@@ -30,6 +30,14 @@ along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.  */
 #include <webkit2/webkit2.h>
 #include <JavaScriptCore/JavaScript.h>
 
+/* Suppress GCC deprecation warnings starting in WebKitGTK+ 2.21.1 for
+   webkit_javascript_result_get_global_context and
+   webkit_javascript_result_get_value.
+   FIXME: Use the JavaScriptCore GLib API instead, and remove this hack.  */
+#if WEBKIT_CHECK_VERSION (2, 21, 1) && GNUC_PREREQ (4, 2, 0)
+# pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
+
 static struct xwidget *
 allocate_xwidget (void)
 {
-- 
2.19.2


--------------FED6421367BBAB68D371E177--




Acknowledgement sent to Paul Eggert <eggert@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#33679; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.