GNU bug report logs - #33743
26.1; ada-mode 6.0.0 indentation of comments before "then"

Previous Next

Packages: ada-mode, emacs;

Reported by: Ludovic Brenta <ludovic <at> ludovic-brenta.org>

Date: Fri, 14 Dec 2018 15:40:02 UTC

Severity: minor

Found in version 26.1

Done: Stephen Leake <stephen_leake <at> stephe-leake.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33743 in the body.
You can then email your comments to 33743 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to ada-mode-users <at> nongnu.org, bug-gnu-emacs <at> gnu.org:
bug#33743; Package emacs, ada-mode. (Fri, 14 Dec 2018 15:40:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Ludovic Brenta <ludovic <at> ludovic-brenta.org>:
New bug report received and forwarded. Copy sent to ada-mode-users <at> nongnu.org, bug-gnu-emacs <at> gnu.org. (Fri, 14 Dec 2018 15:40:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Brenta <ludovic <at> ludovic-brenta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; ada-mode 6.0.0 indentation of comments before "then"
Date: Fri, 14 Dec 2018 16:39:09 +0100

Package: emacs, ada-mode
X-Debbugs-CC: ada-mode-users <at> nongnu.org

Hello,

With ada-mode 6.0.0, comments appearing on a line of their on before 
"then"
are indented like "then"; we think they should be indented one more 
level:

procedure Comment_Indentation is
begin
  if A
    -- This comment is indented correctly
    and then B
  -- This comment is indented incorrectly, should be as above
  then
    -- This comment is indented correctly
    null;
  elsif C
    -- This comment is indented correctly
    and then D
  -- This comment is indented incorrectly, should be as above
  then
    null;
  end if;
end Comment_Indentation;

This "incorrect" indentation is a change from ada-mode 5.2.1 which can
affect many lines in our large code base.  In 5.2.1, all comments are
indented in the same way.

I have browsed the ada-mode customization variables but did not see
which one, if any, allows us to customize this behavior.  (note: we
set ada-indent to 2).

--
Ludovic Brenta.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33743; Package emacs, ada-mode. (Mon, 25 Mar 2019 16:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 33743 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: 33743 <at> debbugs.gnu.org
Subject: update
Date: Mon, 25 Mar 2019 08:40:37 -0800

Fixed in ada-mode 6.1.0 in GNU ELPA.
-- 
-- Stephe
Reply sent to Stephen Leake <stephen_leake <at> stephe-leake.org>:
You have taken responsibility. (Mon, 25 Mar 2019 16:42:01 GMT) Full text and rfc822 format available.
Notification sent to Ludovic Brenta <ludovic <at> ludovic-brenta.org>:
bug acknowledged by developer. (Mon, 25 Mar 2019 16:42:02 GMT) Full text and rfc822 format available.

Message #13 received at 33743-close <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: 33743-close <at> debbugs.gnu.org
Subject: update
Date: Mon, 25 Mar 2019 08:40:58 -0800

-- 
-- Stephe
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 23 Apr 2019 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 359 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.