GNU bug report logs - #33785
df: don't suppress remote mounts

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: coreutils; Reported by: lzhong <lzhong@HIDDEN>; Keywords: notabug; Done: Assaf Gordon <assafgordon@HIDDEN>; Maintainer for coreutils is bug-coreutils@HIDDEN.
bug closed, send any further explanations to 33785 <at> debbugs.gnu.org and lzhong <lzhong@HIDDEN> Request was from Assaf Gordon <assafgordon@HIDDEN> to control <at> debbugs.gnu.org. Full text available.
Added tag(s) notabug. Request was from Assaf Gordon <assafgordon@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 33785 <at> debbugs.gnu.org:


Received: (at 33785) by debbugs.gnu.org; 18 Jan 2019 06:04:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 18 01:04:30 2019
Received: from localhost ([127.0.0.1]:35529 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gkNGY-0005H8-5p
	for submit <at> debbugs.gnu.org; Fri, 18 Jan 2019 01:04:30 -0500
Received: from mail-pl1-f178.google.com ([209.85.214.178]:43676)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <assafgordon@HIDDEN>)
 id 1gkNGV-0005Gm-Mc; Fri, 18 Jan 2019 01:04:28 -0500
Received: by mail-pl1-f178.google.com with SMTP id gn14so5856403plb.10;
 Thu, 17 Jan 2019 22:04:27 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:references:from:message-id:date:user-agent:mime-version
 :in-reply-to:content-language:content-transfer-encoding;
 bh=AVHEhvLAbWyL8+x91Uhh/2EUbHG3SKm286cg6+9aGT0=;
 b=YuKkhwuJwy0k/zGTfyacLtKgdsjabYbMypknkWEMFWi06lMOl1eFM6s0yNiIn05oLH
 JYOQ2/DZtXxiVSc9KAMOBUQs8MYJOqK74PkiML3MxLR4koqW8kkDYMu2Ys1lFbe/MNBD
 bpHiEuw3yYfESZx0Ov3Q4WHJg/GDaakNs0kEHajwXcRScVsN20ljHEsXc8qpayIInRwy
 YBhV3lc7Mph1quvuvqxNuIgAD98ynrpGluWG6wiG3U3xP26Zz/knwbLfHG357iLDR8I0
 wtuo2/QTQDY5J9HsUwb/gbAvlRKJ23Ng9TRkg2YTWpm5XOwYsS/qSlG52p8+hC5mtw1H
 6q2g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=AVHEhvLAbWyL8+x91Uhh/2EUbHG3SKm286cg6+9aGT0=;
 b=gzxLHdcGMvoHzhqCk3h4rD4/FNAc1E6EYNOJclOb5c901xPdYW67Q/fUScRAUj+mCB
 4f0KaWvrszRFJHIwQB2W+90DO2+CBzNHjiOQuuJ9BrJQMIXmQQ5z/6AP2p3lwACT8uZc
 4sHy9ba2G0FMzf/w0VgzKnV8WwuoYqFi81ia/ejw97P34WQHuDJuwfJZWQoDzWpwXFbP
 xCaUDcDlUgLFsOUDy0qWEoN6qY0/W1oLJ/bCu4l7C0g1sh6nt76EIScGKv4p9j36jkMk
 BJJGcn+0g8jzqMhyzVMooGm4VZ+6GjhUpr3NNYrdl4FFCcmlF8qTUDyMl5a6fLgZg5nV
 OlJA==
X-Gm-Message-State: AJcUukckK5rpeT+M52kSJnxwBPMzY39Y+k+qyFWvCECzGLY8lmij7zHK
 lgJtodMYnDUDLMqLL4F8SmHR6fXX
X-Google-Smtp-Source: ALg8bN4H7a6BwRj/BA98JAAufYy3MfNnSjlXx0sPOjO7WI9DfpQnelvYs64pvvhGT41zf0Fuu3REeA==
X-Received: by 2002:a17:902:bd0b:: with SMTP id
 p11mr18031798pls.259.1547791461331; 
 Thu, 17 Jan 2019 22:04:21 -0800 (PST)
Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38])
 by smtp.googlemail.com with ESMTPSA id
 184sm4823337pfe.106.2019.01.17.22.04.19
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 17 Jan 2019 22:04:19 -0800 (PST)
Subject: Re: bug#33785: df: don't suppress remote mounts
To: =?UTF-8?Q?P=c3=a1draig_Brady?= <P@HIDDEN>, 33785 <at> debbugs.gnu.org
References: <d027bcfc-8c14-de7b-b6da-761f70d239f6@HIDDEN>
 <61fe8ece-04d0-31cd-048c-af5105acfbb5@HIDDEN>
From: Assaf Gordon <assafgordon@HIDDEN>
Message-ID: <aa2c095f-65be-2088-cfad-574392b10772@HIDDEN>
Date: Thu, 17 Jan 2019 23:04:18 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <61fe8ece-04d0-31cd-048c-af5105acfbb5@HIDDEN>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 33785
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 33785 notabug
close 33785
stop


Hello,

On 2018-12-19 10:05 a.m., Pádraig Brady wrote:
> On 17/12/18 22:42, lzhong wrote:
>>
>> According to the following commit
>>
>> commit 2e81e62243409c5c574b899f52b08c000e4d99fd
>>       df: only suppress remote mounts of separate exports with --total
>>
[...]
>> The remote mounts should not be suppressed after this change. However,
>> it turns out
>>
>> it doesn't work as the message described. The remote mounts are still
>> suppressed. And here is
>>
> 
> The intent of the patch was not to suppress _separate_ exports on the server.
> I.E. nas.example.com:/Photos and nas.example.com:/Download would not
> be suppressed (even if they have the same device id).
> 
> If you want all nfs mounts you could `df -a -t nfs`

With no further comments, I'm closing this as "notabug".

Discussion can continue by replying to this thread.
   -assaf




Information forwarded to bug-coreutils@HIDDEN:
bug#33785; Package coreutils. Full text available.

Message received at 33785 <at> debbugs.gnu.org:


Received: (at 33785) by debbugs.gnu.org; 19 Dec 2018 17:05:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 19 12:05:08 2018
Received: from localhost ([127.0.0.1]:55037 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gZfHP-0005qc-Pi
	for submit <at> debbugs.gnu.org; Wed, 19 Dec 2018 12:05:08 -0500
Received: from mail.magicbluesmoke.com ([82.195.144.49]:34836)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <P@HIDDEN>) id 1gZfHO-0005qR-8B
 for 33785 <at> debbugs.gnu.org; Wed, 19 Dec 2018 12:05:06 -0500
Received: from localhost.localdomain (unknown [109.76.149.121])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.magicbluesmoke.com (Postfix) with ESMTPSA id E4B469962
 for <33785 <at> debbugs.gnu.org>; Wed, 19 Dec 2018 17:05:04 +0000 (GMT)
Subject: Re: bug#33785: df: don't suppress remote mounts
To: 33785 <at> debbugs.gnu.org
References: <d027bcfc-8c14-de7b-b6da-761f70d239f6@HIDDEN>
From: =?UTF-8?Q?P=c3=a1draig_Brady?= <P@HIDDEN>
Message-ID: <61fe8ece-04d0-31cd-048c-af5105acfbb5@HIDDEN>
Date: Wed, 19 Dec 2018 09:05:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <d027bcfc-8c14-de7b-b6da-761f70d239f6@HIDDEN>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 33785
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 17/12/18 22:42, lzhong wrote:
> Hi list,
> 
> According to the following commit
> 
> commit 2e81e62243409c5c574b899f52b08c000e4d99fd
> Author: Pádraig Brady <P@HIDDEN>
> Date:   Wed Oct 29 02:49:17 2014 +0000
> 
>      df: only suppress remote mounts of separate exports with --total
> 
> ...
> 
> diff --git a/NEWS b/NEWS
> index 5d3bc58bd..2c7e590e0 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -32,6 +32,11 @@ GNU coreutils NEWS                                    
> -*- outline -*-
> 
>   ** Changes in behavior
> 
> +  df no longer suppresses separate exports of the same remote device, as
> +  these are generally explicitly mounted.  The --total option does still
> +  suppress duplicate remote file systems.
> +  [suppression was introduced in coreutils-8.21]
> 
> The remote mounts should not be suppressed after this change. However, 
> it turns out
> 
> it doesn't work as the message described. The remote mounts are still 
> suppressed. And here is
> 
> my patch for this problem:
> 
>    1 From 72be959fc9f49420b07b4df5c5017821232cf498 Mon Sep 17 00:00:00 2001
>    2 From: Lidong Zhong <lzhong@HIDDEN>
>    3 Date: Tue, 18 Dec 2018 14:24:13 +0800
>    4 Subject: [PATCH] df: don't suppress remote mounts
>    5 MIME-Version: 1.0
>    6 Content-Type: text/plain; charset=UTF-8
>    7 Content-Transfer-Encoding: 8bit
>    8
>    9 This is the fix for the following commit.
>   10 commit 2e81e62243409c5c574b899f52b08c000e4d99fd
>   11 Author: Pádraig Brady <P@HIDDEN>
>   12 Date:   Wed Oct 29 02:49:17 2014 +0000
>   13
>   14     df: only suppress remote mounts of separate exports with --total
>   15
>   16 It doesn't work as the commit message described. The remote mounts
>   17 are also suppressed after this change.
>   18 ---
>   19  src/df.c | 2 +-
>   20  1 file changed, 1 insertion(+), 1 deletion(-)
>   21
>   22 diff --git a/src/df.c b/src/df.c
>   23 index 55532219f..0246e3df9 100644
>   24 --- a/src/df.c
>   25 +++ b/src/df.c
>   26 @@ -722,7 +722,7 @@ filter_mount_list (bool devices_only)
>   27                                             < strlen (me->me_mntroot));
>   28                if (! print_grand_total
>   29                    && me->me_remote && seen_dev->me->me_remote
>   30 -                  && ! STREQ (seen_dev->me->me_devname, 
> me->me_devname))
>   31 +                  && STREQ (seen_dev->me->me_devname, me->me_devname))
>   32                  {
>   33                    /* Don't discard remote entries with different 
> locations,
>   34                       as these are more likely to be explicitly 
> mounted.
> 
> Please share your opinion.

The intent of the patch was not to suppress _separate_ exports on the server.
I.E. nas.example.com:/Photos and nas.example.com:/Download would not
be suppressed (even if they have the same device id).

If you want all nfs mounts you could `df -a -t nfs`

cheers,
Pádraig




Information forwarded to bug-coreutils@HIDDEN:
bug#33785; Package coreutils. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 18 Dec 2018 07:02:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 18 02:02:00 2018
Received: from localhost ([127.0.0.1]:52522 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1gZ9OB-0003tS-K5
	for submit <at> debbugs.gnu.org; Tue, 18 Dec 2018 02:02:00 -0500
Received: from eggs.gnu.org ([208.118.235.92]:44497)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <lzhong@HIDDEN>) id 1gZ95T-0003O2-CG
 for submit <at> debbugs.gnu.org; Tue, 18 Dec 2018 01:42:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <lzhong@HIDDEN>) id 1gZ95N-00054s-6G
 for submit <at> debbugs.gnu.org; Tue, 18 Dec 2018 01:42:34 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:49165)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <lzhong@HIDDEN>) id 1gZ95N-00054j-1r
 for submit <at> debbugs.gnu.org; Tue, 18 Dec 2018 01:42:33 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54078)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <lzhong@HIDDEN>) id 1gZ95L-0003rp-Tn
 for bug-coreutils@HIDDEN; Tue, 18 Dec 2018 01:42:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <lzhong@HIDDEN>) id 1gZ95G-0004zg-U3
 for bug-coreutils@HIDDEN; Tue, 18 Dec 2018 01:42:31 -0500
Received: from smtp2.provo.novell.com ([137.65.250.81]:51715)
 by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <lzhong@HIDDEN>) id 1gZ95G-0004wq-Jj
 for bug-coreutils@HIDDEN; Tue, 18 Dec 2018 01:42:26 -0500
Received: from l3-laptop.suse (prv-ext-foundry1int.gns.novell.com
 [137.65.251.240])
 by smtp2.provo.novell.com with ESMTP (TLS encrypted);
 Mon, 17 Dec 2018 23:42:12 -0700
To: bug-coreutils@HIDDEN
From: lzhong <lzhong@HIDDEN>
Subject: df: don't suppress remote mounts
Message-ID: <d027bcfc-8c14-de7b-b6da-761f70d239f6@HIDDEN>
Date: Tue, 18 Dec 2018 14:42:06 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy]
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Tue, 18 Dec 2018 02:01:57 -0500
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Hi list,

According to the following commit

commit 2e81e62243409c5c574b899f52b08c000e4d99fd
Author: Pádraig Brady <P@HIDDEN>
Date:   Wed Oct 29 02:49:17 2014 +0000

     df: only suppress remote mounts of separate exports with --total

...

diff --git a/NEWS b/NEWS
index 5d3bc58bd..2c7e590e0 100644
--- a/NEWS
+++ b/NEWS
@@ -32,6 +32,11 @@ GNU coreutils NEWS                                    
-*- outline -*-

  ** Changes in behavior

+  df no longer suppresses separate exports of the same remote device, as
+  these are generally explicitly mounted.  The --total option does still
+  suppress duplicate remote file systems.
+  [suppression was introduced in coreutils-8.21]

The remote mounts should not be suppressed after this change. However, 
it turns out

it doesn't work as the message described. The remote mounts are still 
suppressed. And here is

my patch for this problem:

   1 From 72be959fc9f49420b07b4df5c5017821232cf498 Mon Sep 17 00:00:00 2001
   2 From: Lidong Zhong <lzhong@HIDDEN>
   3 Date: Tue, 18 Dec 2018 14:24:13 +0800
   4 Subject: [PATCH] df: don't suppress remote mounts
   5 MIME-Version: 1.0
   6 Content-Type: text/plain; charset=UTF-8
   7 Content-Transfer-Encoding: 8bit
   8
   9 This is the fix for the following commit.
  10 commit 2e81e62243409c5c574b899f52b08c000e4d99fd
  11 Author: Pádraig Brady <P@HIDDEN>
  12 Date:   Wed Oct 29 02:49:17 2014 +0000
  13
  14     df: only suppress remote mounts of separate exports with --total
  15
  16 It doesn't work as the commit message described. The remote mounts
  17 are also suppressed after this change.
  18 ---
  19  src/df.c | 2 +-
  20  1 file changed, 1 insertion(+), 1 deletion(-)
  21
  22 diff --git a/src/df.c b/src/df.c
  23 index 55532219f..0246e3df9 100644
  24 --- a/src/df.c
  25 +++ b/src/df.c
  26 @@ -722,7 +722,7 @@ filter_mount_list (bool devices_only)
  27                                             < strlen (me->me_mntroot));
  28                if (! print_grand_total
  29                    && me->me_remote && seen_dev->me->me_remote
  30 -                  && ! STREQ (seen_dev->me->me_devname, 
me->me_devname))
  31 +                  && STREQ (seen_dev->me->me_devname, me->me_devname))
  32                  {
  33                    /* Don't discard remote entries with different 
locations,
  34                       as these are more likely to be explicitly 
mounted.

Please share your opinion.


Regards,

Lidong





Acknowledgement sent to lzhong <lzhong@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-coreutils@HIDDEN. Full text available.
Report forwarded to bug-coreutils@HIDDEN:
bug#33785; Package coreutils. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 18 Jan 2019 06:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.