GNU bug report logs - #33830
27.0.50; help-xref-stack contains bad entries

Previous Next

Package: emacs;

Reported by: Alex Branham <alex.branham <at> gmail.com>

Date: Fri, 21 Dec 2018 16:57:02 UTC

Severity: normal

Tags: confirmed, moreinfo

Found in versions 27.0.50, 28.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33830 in the body.
You can then email your comments to 33830 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#33830; Package emacs. (Fri, 21 Dec 2018 16:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex Branham <alex.branham <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 21 Dec 2018 16:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; help-xref-stack contains bad entries
Date: Fri, 21 Dec 2018 10:55:59 -0600
Sometimes `help-xref-stack' contains "bad" entries, which makes
help-go-forward and help-go-back error in a strange way. To see what I
mean:

emacs -q

C-h f car RET
C-h k C-x t
C-h f cdr RET

Now that the *Help* buffer is displaying `cdr', if you try to go back
(with "l" or clicking the back button), you get "user-error C-x t is
undefined".

Alex




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33830; Package emacs. (Thu, 27 Dec 2018 22:40:02 GMT) Full text and rfc822 format available.

Message #8 received at 33830 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 33830 <at> debbugs.gnu.org
Subject: Re: bug#33830: 27.0.50; help-xref-stack contains bad entries
Date: Thu, 27 Dec 2018 19:38:59 -0300
Alex Branham <alex.branham <at> gmail.com> writes:

> Sometimes `help-xref-stack' contains "bad" entries, which makes
> help-go-forward and help-go-back error in a strange way. To see what I
> mean:
>
> emacs -q
>
> C-h f car RET
> C-h k C-x t
> C-h f cdr RET
>
> Now that the *Help* buffer is displaying `cdr', if you try to go back
> (with "l" or clicking the back button), you get "user-error C-x t is
> undefined".
>
> Alex

I've noticed that the `describe-key' and `describe-function' functions both
call `help-setup-xref' with key sequences and functions respectively,
even if said key sequences or functions are not valid (i.e. when the key
sequence isn't bound to anything and the function does not exist).

An example of this:

1) M-:: (describe-function 'hello) RET
2) C-h f car RET
3) On the *Help* buffer, press 'l'

The message 'Symbol’s function definition is void: hello' will be
displayed, and the *Help* buffer will contain "hello is ". Also, for
some reason, after pressing 'r', two [back] buttons will be shown.

Maybe `help-setup-xref' should only be called when it is certain that
the key sequence/function/etc. exists?

(tested on master branch)




Added tag(s) confirmed. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 13 Aug 2020 12:15:02 GMT) Full text and rfc822 format available.

bug Marked as found in versions 28.0.50. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Thu, 13 Aug 2020 12:15:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33830; Package emacs. (Wed, 23 Jun 2021 13:59:02 GMT) Full text and rfc822 format available.

Message #15 received at 33830 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 33830 <at> debbugs.gnu.org
Subject: Re: bug#33830: 27.0.50; help-xref-stack contains bad entries
Date: Wed, 23 Jun 2021 15:58:12 +0200
Alex Branham <alex.branham <at> gmail.com> writes:

> Sometimes `help-xref-stack' contains "bad" entries, which makes
> help-go-forward and help-go-back error in a strange way. To see what I
> mean:
>
> emacs -q
>
> C-h f car RET
> C-h k C-x t
> C-h f cdr RET
>
> Now that the *Help* buffer is displaying `cdr', if you try to go back
> (with "l" or clicking the back button), you get "user-error C-x t is
> undefined".

This doesn't exactly reproduce for me in Emacs 27.1, because `C-x t' is
bound there.  But this works:

C-h f car RET
C-h k C-x t t
C-h f cdr RET
C-x o
l

I do get the "is undefined" message, but then hitting `l' again takes me
back to `car'.

I guess it could make sense for `l'/`r' to skip these "invalid" entries,
but on the other hand, I can see how they'd be vaguely useful.

Does anybody have any opinions here?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




Added tag(s) moreinfo. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 23 Jun 2021 13:59:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#33830; Package emacs. (Thu, 22 Jul 2021 14:21:01 GMT) Full text and rfc822 format available.

Message #20 received at 33830 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 33830 <at> debbugs.gnu.org
Subject: Re: bug#33830: 27.0.50; help-xref-stack contains bad entries
Date: Thu, 22 Jul 2021 16:20:47 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I guess it could make sense for `l'/`r' to skip these "invalid" entries,
> but on the other hand, I can see how they'd be vaguely useful.
>
> Does anybody have any opinions here?

Nobody had, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




bug closed, send any further explanations to 33830 <at> debbugs.gnu.org and Alex Branham <alex.branham <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 22 Jul 2021 14:22:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 20 Aug 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 222 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.