GNU bug report logs - #33868
[PATCH] gnu: calibre: Fix PDF to EPUB conversion.

Previous Next

Package: guix-patches;

Reported by: Mathieu Othacehe <m.othacehe <at> gmail.com>

Date: Tue, 25 Dec 2018 11:45:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <m.othacehe <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33868 in the body.
You can then email your comments to 33868 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33868; Package guix-patches. (Tue, 25 Dec 2018 11:45:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 25 Dec 2018 11:45:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
Date: Tue, 25 Dec 2018 12:44:27 +0100
When trying to convert a PDF to EPUB, the following error occurs:

  File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
    _('Could not find pdftohtml, check it is in your PATH'))

Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.

* gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
[propagated-inputs]: ... to here.
---
 gnu/packages/ebook.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index e750c6cac..70434293a 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2017 Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
 ;;; Copyright © 2017 Roel Janssen <roel <at> gnu.org>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2018 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -121,7 +122,6 @@
        ("openssl" ,openssl)
        ("optipng" ,optipng)
        ("podofo" ,podofo)
-       ("poppler" ,poppler)
        ("python" ,python-2)
        ("python2-apsw" ,python2-apsw)
        ("python2-chardet" ,python2-chardet)
@@ -145,9 +145,9 @@
        ("python2-sip" ,python2-sip)
        ("python2-regex" ,python2-regex)
        ;; python2-unrardll is needed for decompressing RAR files.
-       ;; A program called 'pdf2html' is needed for reading PDF books
-       ;; in the web interface.
        ("sqlite" ,sqlite)))
+    (propagated-inputs
+     `(("poppler" ,poppler)))
     (arguments
      `(#:python ,python-2
        #:test-target "check"
-- 
2.20.1





Information forwarded to guix-patches <at> gnu.org:
bug#33868; Package guix-patches. (Sun, 06 Jan 2019 17:57:02 GMT) Full text and rfc822 format available.

Message #8 received at 33868 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 33868 <at> debbugs.gnu.org
Subject: Re: [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
Date: Sun, 06 Jan 2019 18:56:34 +0100
Hello,

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> When trying to convert a PDF to EPUB, the following error occurs:
>
>   File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
>     _('Could not find pdftohtml, check it is in your PATH'))
>
> Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
>
> * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> [propagated-inputs]: ... to here.

I haven’t tested it but I’m confident you can go ahead and push it.

Thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#33868; Package guix-patches. (Fri, 11 Jan 2019 23:21:01 GMT) Full text and rfc822 format available.

Message #11 received at 33868 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>, 33868 <at> debbugs.gnu.org
Subject: Re: [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
Date: Sat, 12 Jan 2019 00:19:54 +0100
[Message part 1 (text/plain, inline)]
Mathieu Othacehe <m.othacehe <at> gmail.com> writes:

> When trying to convert a PDF to EPUB, the following error occurs:
>
>   File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
>     _('Could not find pdftohtml, check it is in your PATH'))
>
> Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
>
> * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> [propagated-inputs]: ... to here.

An less intrusive solution would be to substitute the absolute path to
'pdf2html' in a build step.  I.e.:

(substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
  (("PDFTOHTML = \"pdftohtml\"")
   (string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
                  "/bin/pdftohtml\"")))

Either approach is fine by me, but please leave a comment about why
Poppler is propagated if you go that route :-)
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33868; Package guix-patches. (Sat, 12 Jan 2019 22:44:01 GMT) Full text and rfc822 format available.

Message #14 received at 33868 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>, 33868 <at> debbugs.gnu.org
Subject: Re: [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
Date: Sat, 12 Jan 2019 17:43:09 -0500
[Message part 1 (text/plain, inline)]
On Sat, Jan 12, 2019 at 12:19:54AM +0100, Marius Bakke wrote:
> Mathieu Othacehe <m.othacehe <at> gmail.com> writes:
> 
> > When trying to convert a PDF to EPUB, the following error occurs:
> >
> >   File "/gnu/store/kz6bgqw9z7akj11zh20wkx14cgq0s3n2-calibre-3.35.0/lib/calibre/calibre/ebooks/pdf/pdftohtml.py", line 76, in pdftohtml
> >     _('Could not find pdftohtml, check it is in your PATH'))
> >
> > Move poppler which provides pdftohtml from inputs to propagated-inputs to fix it.
> >
> > * gnu/packages/ebook.scm (calibre)[inputs]: Move poppler from here ...
> > [propagated-inputs]: ... to here.
> 
> An less intrusive solution would be to substitute the absolute path to
> 'pdf2html' in a build step.  I.e.:
> 
> (substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
>   (("PDFTOHTML = \"pdftohtml\"")
>    (string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
>                   "/bin/pdftohtml\"")))
> 
> Either approach is fine by me, but please leave a comment about why
> Poppler is propagated if you go that route :-)

I think this substitution is the better solution.
[signature.asc (application/pgp-signature, inline)]

Reply sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
You have taken responsibility. (Mon, 21 Jan 2019 09:58:02 GMT) Full text and rfc822 format available.

Notification sent to Mathieu Othacehe <m.othacehe <at> gmail.com>:
bug acknowledged by developer. (Mon, 21 Jan 2019 09:58:02 GMT) Full text and rfc822 format available.

Message #19 received at 33868-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Marius Bakke <mbakke <at> fastmail.com>, 33868-done <at> debbugs.gnu.org
Subject: Re: [bug#33868] [PATCH] gnu: calibre: Fix PDF to EPUB conversion.
Date: Mon, 21 Jan 2019 10:57:41 +0100
>> (substitute* "lib/calibre/calibre/ebooks/pdf/pdftohtml.py"
>>   (("PDFTOHTML = \"pdftohtml\"")
>>    (string-append "PDFTOHTML = \"" (assoc-ref inputs "poppler")
>>                   "/bin/pdftohtml\"")))

Pushed as b65b78ff using your substitute snippet.

Thanks,

Mathieu




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 18 Feb 2019 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 40 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.