GNU bug report logs - #33883
[PATCH] gnu: Add ocaml-yojson.

Previous Next

Package: guix-patches;

Reported by: Gabriel Hondet <gabrielhondet <at> gmail.com>

Date: Thu, 27 Dec 2018 06:54:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33883 in the body.
You can then email your comments to 33883 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33883; Package guix-patches. (Thu, 27 Dec 2018 06:54:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gabriel Hondet <gabrielhondet <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 27 Dec 2018 06:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add ocaml-yojson.
Date: Thu, 27 Dec 2018 07:25:12 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-yojson): New variable.
---
 gnu/packages/ocaml.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 4cfd203bd..6a16f0729 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5085,3 +5085,42 @@ functionality but allows implementations several times faster (4 times faster
 than yojson), with 25-35% space savings.")
    (license license:bsd-3)))
 
+(define-public ocaml-yojson
+  (package
+    (name "ocaml-yojson")
+    (version "1.4.1")
+    (home-page "https://github.com/ocaml-community/yojson")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0nwsfkmqpyfab4rxq76q8ff7giyanghw08094jyrp275v99zdjr9"))))
+    (build-system ocaml-build-system)
+    (inputs
+     `(("biniou" ,ocaml-biniou)
+       ("ocaml-easy-format" ,ocaml-easy-format)
+       ("cppo" ,ocaml-cppo)))
+    (native-inputs
+     `(("jbuilder" ,ocaml-jbuilder)))
+   (arguments
+    '(#:phases
+      (modify-phases %standard-phases
+        (delete 'configure)
+        (replace 'install
+          (lambda _
+            (invoke "jbuilder" "install"
+                    (string-append "--prefix="
+                                   (assoc-ref %outputs "out"))))))))
+    (synopsis "Low-level JSON library for OCaml")
+    (description "Yojson is an optimized parsing and printing library for the
+JSON format.  It addresses a few shortcomings of json-wheel including 2x
+speedup, polymorphic variants and optional syntax for tuples and variants.
+@code{ydump} is a pretty printing command-line program provided with the
+yojson package.  The program @code{atdgen} can be used to derive OCaml-JSON
+serializers and deserializers from type definitions.")
+    (license license:bsd-3)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33883; Package guix-patches. (Thu, 27 Dec 2018 08:54:02 GMT) Full text and rfc822 format available.

Message #8 received at 33883 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 33883 <at> debbugs.gnu.org
Subject: Re: [bug#33883] [PATCH] gnu: Add ocaml-yojson.
Date: Thu, 27 Dec 2018 09:53:47 +0100
[Message part 1 (text/plain, inline)]
Pushed as 2e951707f505db2d6e3a94a842b4319aa9b07e39, thank you!

I've modified the definition to use the dune-build-system, moved cppo
to native-inputs and modified the names of the inputs in that way:

("cppo" ,ocaml-cppo) -> ("ocaml-cppo" ,ocaml-cppo)

to correspond better to the way we usually declare dependencies. I know
the ocaml.scm file doesn't always respect this convention, but please
try to stick to it anyway :)
[Message part 2 (application/pgp-signature, inline)]

Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Thu, 27 Dec 2018 08:56:02 GMT) Full text and rfc822 format available.

Notification sent to Gabriel Hondet <gabrielhondet <at> gmail.com>:
bug acknowledged by developer. (Thu, 27 Dec 2018 08:56:02 GMT) Full text and rfc822 format available.

Message #13 received at 33883-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 33883-done <at> debbugs.gnu.org
Subject: Re: [bug#33883] [PATCH] gnu: Add ocaml-yojson.
Date: Thu, 27 Dec 2018 09:55:39 +0100
[Message part 1 (text/plain, inline)]
Le Thu, 27 Dec 2018 09:53:47 +0100,
Julien Lepiller <julien <at> lepiller.eu> a écrit :

> Pushed as 2e951707f505db2d6e3a94a842b4319aa9b07e39, thank you!
> 
> I've modified the definition to use the dune-build-system, moved cppo
> to native-inputs and modified the names of the inputs in that way:
> 
> ("cppo" ,ocaml-cppo) -> ("ocaml-cppo" ,ocaml-cppo)
> 
> to correspond better to the way we usually declare dependencies. I
> know the ocaml.scm file doesn't always respect this convention, but
> please try to stick to it anyway :)

closing.
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 24 Jan 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 66 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.