Sarah Morgensen <iskarian@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 33896) by debbugs.gnu.org; 25 Sep 2021 21:46:19 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 25 17:46:19 2021
Received: from localhost ([127.0.0.1]:34965 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mUFUw-0001TA-Ra
for submit <at> debbugs.gnu.org; Sat, 25 Sep 2021 17:46:19 -0400
Received: from out2.migadu.com ([188.165.223.204]:47003)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1mUFUu-0001T0-Rm
for 33896 <at> debbugs.gnu.org; Sat, 25 Sep 2021 17:46:17 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1632606374;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=bw84psMooIUX/ndOm0n3tyfw7++L11JzoFnYXXHjsvc=;
b=Te3XCnQ2zRk2YHGJ+PJ0jRA9Dicw4Uxg4f9il5PMOPu1+wdWZS8Af4pjFKvHMNTq7EBmvv
mBSHJZ42jjYn/FnuWi/Gsqc+GCp8bAT26Gnp5x9/wN5K+q0MyJny9pexTwaoTKwF0FwvVr
AvKHAHz9P/2S5Kb6VvW697hp3jlfYZg=
From: Sarah Morgensen <iskarian@HIDDEN>
To: 33896 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: libblockdev: Fix inputs.
Date: Sat, 25 Sep 2021 14:46:13 -0700
Message-Id: <ab306424d6b39f3a23445b0ee1c44d5060010ea8.1632604842.git.iskarian@HIDDEN>
In-Reply-To: <8a50a917c91792e8d5b9f69a31485a3909559ef5.1632604842.git.iskarian@HIDDEN>
References: <8a50a917c91792e8d5b9f69a31485a3909559ef5.1632604842.git.iskarian@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 33896
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Add missing inputs; make util-linux a regular input since libblockdev
retains references to it.
* gnu/packages/disk.scm (libblockdev):
[inputs]: Add bcache-tools, e2fsprogs, gptfdisk, multipath-tools, ntfs-3g,
util-linux, and xfsprogs.
[native-inputs]: Remove util-linux.
---
gnu/packages/disk.scm | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index f3a7eb7617..a233db9433 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -951,26 +951,30 @@ to create devices with respective mappings for the ATARAID sets discovered.")
(native-inputs
`(("gobject-introspection" ,gobject-introspection)
("pkg-config" ,pkg-config)
- ("python" ,python-wrapper)
- ("util-linux" ,util-linux)))
+ ("python" ,python-wrapper)))
(inputs
- `(("btrfs-progs" ,btrfs-progs)
+ `(("bcache-tools" ,bcache-tools)
+ ("btrfs-progs" ,btrfs-progs)
("cryptsetup" ,cryptsetup)
("dosfstools" ,dosfstools)
("dmraid" ,dmraid)
+ ("e2fsprogs" ,e2fsprogs)
("eudev" ,eudev)
("glib" ,glib)
+ ("gptfdisk" ,gptfdisk)
("kmod" ,kmod)
("libbytesize" ,libbytesize)
("libyaml" ,libyaml)
("lvm2" ,lvm2)
("mdadm" ,mdadm)
+ ("multipath-tools" ,multipath-tools)
("ndctl" ,ndctl)
("nss" ,nss)
+ ("ntfs-3g" ,ntfs-3g)
("parted" ,parted)
+ ("util-linux" ,util-linux)
("volume-key" ,volume-key)
- ;; ("xfsprogs" ,xfsprogs) ; TODO: Package?
- ))
+ ("xfsprogs" ,xfsprogs)))
(home-page "https://github.com/storaged-project/libblockdev")
(synopsis "Library for manipulating block devices")
(description
--
2.33.0
bug-guix@HIDDEN:bug#33896; Package guix.
Full text available.
Received: (at 33896) by debbugs.gnu.org; 25 Sep 2021 21:28:08 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Sep 25 17:28:08 2021
Received: from localhost ([127.0.0.1]:34945 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1mUFDM-00010Y-0h
for submit <at> debbugs.gnu.org; Sat, 25 Sep 2021 17:28:08 -0400
Received: from out0.migadu.com ([94.23.1.103]:13227)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <iskarian@HIDDEN>) id 1mUFDI-00010M-QT
for 33896 <at> debbugs.gnu.org; Sat, 25 Sep 2021 17:28:06 -0400
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1;
t=1632605283;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=wLqte5WARLkez7V6BmdPYlntD8v2YiMVkhXi4ZQLIAI=;
b=SDzkf2sBf6y1khGPL8I8jQqkN3LRXcmNotcIe6uxjWrIsl+WwIz/pdLmfsJwYftrGwKsCn
ICGIkJ1zv3I+6ElOrOeziPaoMnz3HIIuxthIseSPFGF64P4SQ5ohWkqh67csshIPoh1Pqj
5qMy3sKSzmm4Aj0/9VrpxhzRAdE4mzw=
From: Sarah Morgensen <iskarian@HIDDEN>
To: 33896 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: libblockdev: Embed executable paths.
Date: Sat, 25 Sep 2021 14:28:01 -0700
Message-Id: <8a50a917c91792e8d5b9f69a31485a3909559ef5.1632604842.git.iskarian@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: iskarian@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 33896
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Fixes <https://bugs.gnu.org/33896>.
* gnu/packages/disk.scm (libblockdev)[arguments]<#:phases>: Add
'patch-plugin-paths' phase.
---
gnu/packages/disk.scm | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 7d6f3811dd..f3a7eb7617 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -21,6 +21,7 @@
;;; Copyright © 2021 Michael Rohleder <mike@HIDDEN>
;;; Copyright © 2021 Mathieu Othacehe <othacehe@HIDDEN>
;;; Copyright © 2021 Brice Waegeneire <brice@HIDDEN>
+;;; Copyright © 2021 Sarah Morgensen <iskarian@HIDDEN>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -940,7 +941,13 @@ to create devices with respective mappings for the ATARAID sets discovered.")
(lambda* (#:key outputs #:allow-other-keys)
(let ((out (assoc-ref outputs "out")))
(substitute* "src/lib/blockdev.c"
- (("/etc/libblockdev/conf.d/" path) (string-append out path)))))))))
+ (("/etc/libblockdev/conf.d/" path) (string-append out path))))))
+ (add-after 'unpack 'patch-plugin-paths
+ (lambda* (#:key inputs #:allow-other-keys)
+ (substitute* (find-files "src/plugins" "\\.c$")
+ (("(gchar \\*arg.+\\{\")([^\"]+)" all start program)
+ ;; XXX: Use 'search-input-file' when available.
+ (string-append start (or (which program) program)))))))))
(native-inputs
`(("gobject-introspection" ,gobject-introspection)
("pkg-config" ,pkg-config)
base-commit: 69f37702dfcda776a190d5c40fad8518469ce3c4
--
2.33.0
bug-guix@HIDDEN:bug#33896; Package guix.
Full text available.Received: (at 33896) by debbugs.gnu.org; 5 Jan 2019 17:55:58 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 05 12:55:58 2019 Received: from localhost ([127.0.0.1]:48049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gfqAv-0005xf-RR for submit <at> debbugs.gnu.org; Sat, 05 Jan 2019 12:55:58 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:33078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ludo@HIDDEN>) id 1gfqAs-0005xW-RB for 33896 <at> debbugs.gnu.org; Sat, 05 Jan 2019 12:55:56 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4FFA7647; Sat, 5 Jan 2019 18:55:54 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NEn3Vn9smJFC; Sat, 5 Jan 2019 18:55:53 +0100 (CET) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 6EAB1538; Sat, 5 Jan 2019 18:55:53 +0100 (CET) From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN> To: Efraim Flashner <efraim@HIDDEN> Subject: Re: bug#33896: libblockdev inputs are not used correctly References: <20181228143255.78bf15b1@HIDDEN> <20181229185036.GV2581@macbook41> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 16 =?utf-8?Q?Niv=C3=B4se?= an 227 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 05 Jan 2019 18:55:52 +0100 In-Reply-To: <20181229185036.GV2581@macbook41> (Efraim Flashner's message of "Sat, 29 Dec 2018 20:50:36 +0200") Message-ID: <877efj2dlj.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 33896 Cc: 33896 <at> debbugs.gnu.org, Danny Milosavljevic <dannym@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.0 (/) Hello, Efraim Flashner <efraim@HIDDEN> skribis: > On Fri, Dec 28, 2018 at 02:32:55PM +0100, Danny Milosavljevic wrote: >> Currently, libblockdev has inputs which aren't used. >>=20 >> These SHOULD be used, but the source files are not patched >> so the executables in the inputs are not found or used. >>=20 >> Example: >>=20 >> * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would = use >> "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually re= fer >> to the inputs. >>=20 >> This problem is valid for everything in src/plugins/fs . >>=20 >> Do we proceed to patch it to use the inputs or do we move dosfstools etc >> to propagated-inputs ? >>=20 >> I'd suggest the former. > > Similar to the enlightenment package getting more 'substitute*'s to > improve functionality, I agree that patching libblockdev to actually > find all the inputs/executables is preferable. I agree; using =E2=80=98substitute*=E2=80=99 is more appropriate than propa= gation here. Thanks, Ludo=E2=80=99.
bug-guix@HIDDEN:bug#33896; Package guix.
Full text available.Received: (at 33896) by debbugs.gnu.org; 29 Dec 2018 18:50:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 29 13:50:46 2018 Received: from localhost ([127.0.0.1]:41652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gdJh7-0007KR-PC for submit <at> debbugs.gnu.org; Sat, 29 Dec 2018 13:50:45 -0500 Received: from flashner.co.il ([178.62.234.194]:34418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <efraim@HIDDEN>) id 1gdJh5-0007KC-RL for 33896 <at> debbugs.gnu.org; Sat, 29 Dec 2018 13:50:44 -0500 Received: from localhost (unknown [188.120.128.87]) by flashner.co.il (Postfix) with ESMTPSA id E28B740074; Sat, 29 Dec 2018 18:50:37 +0000 (UTC) Date: Sat, 29 Dec 2018 20:50:36 +0200 From: Efraim Flashner <efraim@HIDDEN> To: Danny Milosavljevic <dannym@HIDDEN> Subject: Re: bug#33896: libblockdev inputs are not used correctly Message-ID: <20181229185036.GV2581@macbook41> References: <20181228143255.78bf15b1@HIDDEN> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fq7EdiloNwzjWdQG" Content-Disposition: inline In-Reply-To: <20181228143255.78bf15b1@HIDDEN> User-Agent: Mutt/1.11.0 (2018-11-25) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 33896 Cc: 33896 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --Fq7EdiloNwzjWdQG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 28, 2018 at 02:32:55PM +0100, Danny Milosavljevic wrote: > Currently, libblockdev has inputs which aren't used. >=20 > These SHOULD be used, but the source files are not patched > so the executables in the inputs are not found or used. >=20 > Example: >=20 > * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would u= se > "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually ref= er > to the inputs. >=20 > This problem is valid for everything in src/plugins/fs . >=20 > Do we proceed to patch it to use the inputs or do we move dosfstools etc > to propagated-inputs ? >=20 > I'd suggest the former. Similar to the enlightenment package getting more 'substitute*'s to improve functionality, I agree that patching libblockdev to actually find all the inputs/executables is preferable. --=20 Efraim Flashner <efraim@HIDDEN> =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Fq7EdiloNwzjWdQG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAlwnwfkACgkQQarn3Mo9 g1GPdQ//dvh7pDkTle9SoyPTCH9iUEQ0E+uPbVQxqsuLySyWdK4PEj1WWYVd98Fq DhlK+egUUAkAsGGSPBgXdKZoJkY7t1dO4+X1YPgh1fEuKjhXCGdfb1DiUXk1GNJg egNTxhRa0BUMgeIg4rqeCSvqc2C2lsaf++sQedmskF8+VJvDc3bDu/T0n9E0P3vQ 9/qi9NWXLVLxaOMSV5oScArJeMTgOsQKQSUK457cJucy5N2YEtuwsoZbo6X9XdM9 Pmd8pkI09HOvfQiaBRr0vmsyM9WwIdajVt3r+ElReKoOWUnHVuIBRbu0l45OUAwv nmcnoOh4su8TTRGcZWEtB+36RC+v5IqigBWGdoEQkly2DfulARBexSGuTlRqv+t+ qrILuw2uL/RO6WtPJEoQZeZ70f65EEd/wNqyHFe6pQfEwsdXCB5Lr6f54UZ6i/LP QzXSf7DJqnVWavJxiTNXC0aXynCagrJIV7iOoZ4eOC8m4XjPLD4d6f1DN+HcMl0D wj9VIdZYoLT2zZDPwWUYeOYjOpdi4QqFMr1avBtGPOis+LgfW8+1kz2O5GQyPBou yoRjOK8jM27YPKXM5bUr/TB8GQ0aBuf0sHEXFp1lOo/FeGibekwV7WJVnlJ6uAkd Znup9KM+P0nwjJENwGFSglrmljdO85tExdhwC/lRLQvBBpzmKw8= =p5yZ -----END PGP SIGNATURE----- --Fq7EdiloNwzjWdQG--
bug-guix@HIDDEN:bug#33896; Package guix.
Full text available.Received: (at submit) by debbugs.gnu.org; 28 Dec 2018 13:46:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 28 08:46:33 2018 Received: from localhost ([127.0.0.1]:39775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gcsTA-00009T-OJ for submit <at> debbugs.gnu.org; Fri, 28 Dec 2018 08:46:33 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <dannym@HIDDEN>) id 1gcsT9-00009F-BJ for submit <at> debbugs.gnu.org; Fri, 28 Dec 2018 08:46:31 -0500 Received: from lists.gnu.org ([208.118.235.17]:57667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1gcsT1-0003h5-E4 for submit <at> debbugs.gnu.org; Fri, 28 Dec 2018 08:46:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1gcsSw-0000YS-9L for bug-guix@HIDDEN; Fri, 28 Dec 2018 08:46:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1gcsG7-0005lN-Kj for bug-guix@HIDDEN; Fri, 28 Dec 2018 08:33:20 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:57662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <dannym@HIDDEN>) id 1gcsG7-0005j2-8Q for bug-guix@HIDDEN; Fri, 28 Dec 2018 08:33:03 -0500 Received: from localhost (77.116.200.150.wireless.dyn.drei.com [77.116.200.150]) by dd26836.kasserver.com (Postfix) with ESMTPSA id E4EAF33616AA for <bug-guix@HIDDEN>; Fri, 28 Dec 2018 14:33:00 +0100 (CET) Date: Fri, 28 Dec 2018 14:32:55 +0100 From: Danny Milosavljevic <dannym@HIDDEN> To: <bug-guix@HIDDEN> Subject: libblockdev inputs are not used correctly Message-ID: <20181228143255.78bf15b1@HIDDEN> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/YTBicx2DFtoHadEsRAPDUzE"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 85.13.145.193 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -6.0 (------) --Sig_/YTBicx2DFtoHadEsRAPDUzE Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Currently, libblockdev has inputs which aren't used. These SHOULD be used, but the source files are not patched so the executables in the inputs are not found or used. Example: * libblockdev depends on dosfstools because src/plugins/fs/vfat.c would use "mkfs.vfat" etc, but src/plugins/fs/vfat.c is not patched to actually refer to the inputs. This problem is valid for everything in src/plugins/fs . Do we proceed to patch it to use the inputs or do we move dosfstools etc to propagated-inputs ? I'd suggest the former. --Sig_/YTBicx2DFtoHadEsRAPDUzE Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlwmJgcACgkQ5xo1VCww uqVhXQf+JpXrlHrXYvC7QWZjIFsgHiB7yg2McY78gp17cfL1Hp1zaKHaATXK9S1J Ib5hKfEEL+7khtJ1VahU889Eys6qqUOnTN3m5NPEx0nvr1+1jN/3hIfWqwqHVU+T Q4+0qcM0PaNnt3985SpvQjrmUNxzM7G6DT0z4fHKHGyzi3d2/bLkCOEYZQsDz7l/ KHTKmsFNLfje0yhyqj9xKUkLgw59n+cSTP3Rmxb1Ae4qn2mDCiEUVymfze6idWdj xRZ967pjBZWXqFBht3Km2mRcQsaiIkQQq4JeCZ63qpTiABVgJBbFHo7iLta6oJ/L VckWFXUJeYiNpYE93jj8uXeZHpA/wA== =Pgp2 -----END PGP SIGNATURE----- --Sig_/YTBicx2DFtoHadEsRAPDUzE--
Danny Milosavljevic <dannym@HIDDEN>:bug-guix@HIDDEN.
Full text available.bug-guix@HIDDEN:bug#33896; Package guix.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.