GNU bug report logs - #33930
26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse events

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33930 in the body.
You can then email your comments to 33930 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores
 mouse events
Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST)

[Message part 1 (text/plain, inline)]

If you have used the mouse at all during the last 300 events then `C-x
C-k l' (`kmacro-edit-lossage') is broken: it just raises an error,
rather than showing you your keyboard events as a keyboard macro and
letting you edit the macro.  That's not very helpful.

This happens because `edmacro-fix-menu-commands' just punts, not
bothering to try to handle mouse events the same way it handles events
such as help-echo and switch-frame events.

The attached patch fixes that.  It also makes the error message explicit
about any unsupported event, instead of assuming that every unsupported
event is necessarily a mouse event.

In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

[edmacro-2018-12-30a.patch (application/octet-stream, attachment)]

Message #10 received at 33930-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 33930-done <at> debbugs.gnu.org
Subject: Re: bug#33930: 26.1;
 [PATCH] Fix `C-x C-k l' (`kmacro-edit-lossage') so it ignores mouse
 events
Date: Sat, 05 Jan 2019 11:38:29 +0200

> Date: Sun, 30 Dec 2018 11:37:28 -0800 (PST)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> If you have used the mouse at all during the last 300 events then `C-x
> C-k l' (`kmacro-edit-lossage') is broken: it just raises an error,
> rather than showing you your keyboard events as a keyboard macro and
> letting you edit the macro.  That's not very helpful.
> 
> This happens because `edmacro-fix-menu-commands' just punts, not
> bothering to try to handle mouse events the same way it handles events
> such as help-echo and switch-frame events.
> 
> The attached patch fixes that.  It also makes the error message explicit
> about any unsupported event, instead of assuming that every unsupported
> event is necessarily a mouse event.

Thanks, installed on the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.