GNU bug report logs - #33932
Artanis fails to build - 0.3.1 is out

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33932 in the body.
You can then email your comments to 33932 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Report new Guix bug <bug-guix <at> gnu.org>
Subject: Artanis fails to build - 0.3.1 is out
Date: Sun, 30 Dec 2018 22:52:33 +0100

[Message part 1 (text/plain, inline)]

Hi

We should upgrade.

I earlier tried building 0.2.5 but failed, see def. below.

(define-public artanis
  (package
    (name "artanis")
    ;; The 0.2.5 tarball does not build. See upstream bugreport at
    ;; 
https://lists.gnu.org/archive/html/bug-artanis/2018-11/msg00000.html
    (version "0.2.5.af624e50")
    (source (origin
              (method git-fetch)
              (uri (git-reference
                    (url "https://git.savannah.gnu.org/git/artanis.git")
                    (commit "af624e508e9997bd2e20c8c7063d986694f11209")))
              (file-name (string-append name "-" version "-checkout"))
              (sha256
               (base32
"0y1rx09jljdx6g6nq6y635f8svm8kazib7n4bgivi3yiy2c5v7ck"))

-- 
Cheers Swedebugia

[Message part 2 (text/html, inline)]

Message #8 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: swedebugia <swedebugia <at> riseup.net>
Cc: 33932 <at> debbugs.gnu.org
Subject: Re: bug#33932: Artanis fails to build - 0.3.1 is out
Date: Mon, 31 Dec 2018 13:33:01 +0100

Hi swedebugia,

> We should upgrade.

Could you please send a patch?

-- 
Ricardo

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 "33932 <at> debbugs.gnu.org" <33932 <at> debbugs.gnu.org>
Subject: Re: bug#33932: Artanis fails to build - 0.3.1 is out
Date: Wed, 2 Jan 2019 22:50:13 +0100

On 2018-12-31 13:33, Ricardo Wurmus wrote:
> 
> Hi swedebugia,
> 
>> We should upgrade.
> 
> Could you please send a patch?
> 

Here it is :)

-- 
Cheers Swedebugia

Message #17 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: ricardo Wurmus <rekado <at> elephly.net>,
 "33932 <at> debbugs.gnu.org" <33932 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: artanis: Move to web.scm and update to 0.3.1. (was: Re:
 bug#33932: Artanis fails to build - 0.3.1 is out)
Date: Wed, 2 Jan 2019 23:50:24 +0100

[Message part 1 (text/plain, inline)]

On 2019-01-02 22:50, swedebugia wrote:
> On 2018-12-31 13:33, Ricardo Wurmus wrote:
>>
>> Hi swedebugia,
>>
>>> We should upgrade.
>>
>> Could you please send a patch?
>>
> 
> Here it is :)
> 


-- 
Cheers Swedebugia

[0001-gnu-artanis-Move-to-web.scm-and-update-to-0.3.1.patch (text/x-patch, attachment)]

Message #23 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
To: swedebugia <swedebugia <at> riseup.net>
Cc: "33932 <at> debbugs.gnu.org" <33932 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: artanis: Move to web.scm and update to 0.3.1. (was:
 Re: bug#33932: Artanis fails to build - 0.3.1 is out)
Date: Thu, 3 Jan 2019 12:39:15 +0100

Hi swedebugia,

> From a7f0c26705aad362acc35e632bed2dcc9e32d004 Mon Sep 17 00:00:00 2001
> From: swedebugia <swedebugia <at> riseup.net>
> Date: Wed, 2 Jan 2019 23:47:07 +0100
> Subject: [PATCH] gnu: artanis: Move to web.scm and update to 0.3.1.
>
> * gnu/packages/guile.scm (artanis): Move from here...
> * gnu/packages/web.scm (artanis): To here and Update to 0.3.1.

Thanks.

Unfortunately, this patch contains a lot of unrelated changes, as you
can see here:

>  gnu/packages/guile.scm | 360 +++++++++++++++++++++++++++++++----------
>  gnu/packages/web.scm   |  95 +++++++++++
>  2 files changed, 368 insertions(+), 87 deletions(-)

Please also split the upgrade from moving the package definition to
another file.

--
Ricardo

Message #26 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Ricardo Wurmus <ricardo.wurmus <at> mdc-berlin.de>
Cc: "33932 <at> debbugs.gnu.org" <33932 <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: artanis: Move to web.scm and update to 0.3.1.
Date: Thu, 3 Jan 2019 17:17:07 +0100

[Message part 1 (text/plain, inline)]

On 2019-01-03 12:39, Ricardo Wurmus wrote:
> 
> Hi swedebugia,
> 
>>  From a7f0c26705aad362acc35e632bed2dcc9e32d004 Mon Sep 17 00:00:00 2001
>> From: swedebugia <swedebugia <at> riseup.net>
>> Date: Wed, 2 Jan 2019 23:47:07 +0100
>> Subject: [PATCH] gnu: artanis: Move to web.scm and update to 0.3.1.
>>
>> * gnu/packages/guile.scm (artanis): Move from here...
>> * gnu/packages/web.scm (artanis): To here and Update to 0.3.1.
> 
> Thanks.
> 
> Unfortunately, this patch contains a lot of unrelated changes, as you
> can see here:
> 
>>   gnu/packages/guile.scm | 360 +++++++++++++++++++++++++++++++----------
>>   gnu/packages/web.scm   |  95 +++++++++++
>>   2 files changed, 368 insertions(+), 87 deletions(-)
> 
> Please also split the upgrade from moving the package definition to
> another file.

Done, see attached.

Is this acceptable? Or should I have made a new branch from master 
before moving?

-- 
Cheers Swedebugia

[0001-gnu-artanis-Update-to-0.3.1.patch (text/x-patch, attachment)]

[0002-gnu-artanis-Move-to-web.scm.patch (text/x-patch, attachment)]

Message #29 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: swedebugia <swedebugia <at> riseup.net>
Cc: 33932 <at> debbugs.gnu.org
Subject: Re: bug#33932: [PATCH] gnu: artanis: Move to web.scm and update to
 0.3.1. (was: Re: bug#33932: Artanis fails to build - 0.3.1 is out)
Date: Thu, 03 Jan 2019 19:19:58 +0000

[Message part 1 (text/plain, inline)]

swedebugia <swedebugia <at> riseup.net> writes:

> On 2019-01-02 22:50, swedebugia wrote:
>> On 2018-12-31 13:33, Ricardo Wurmus wrote:
>>>
>>> Hi swedebugia,
>>>
>>>> We should upgrade.
>>>
>>> Could you please send a patch?
>>>
>>
>> Here it is :)

I haven't looked too closely at the patch, but I think the newer version
of Artanis have bundled guile-redis (or something like that), so it
would be good to look at unbundling it, similar to how guile-json is
handled.

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33932 <at> debbugs.gnu.org
Subject: Re: bug#33932: [PATCH] gnu: artanis: Move to web.scm and update to
 0.3.1.
Date: Thu, 3 Jan 2019 22:39:48 +0100

On 2019-01-03 20:19, Christopher Baines wrote:
> 
> swedebugia <swedebugia <at> riseup.net> writes:
> 
>> On 2019-01-02 22:50, swedebugia wrote:
>>> On 2018-12-31 13:33, Ricardo Wurmus wrote:
>>>>
>>>> Hi swedebugia,
>>>>
>>>>> We should upgrade.
>>>>
>>>> Could you please send a patch?
>>>>
>>>
>>> Here it is :)
> 
> I haven't looked too closely at the patch, but I think the newer version
> of Artanis have bundled guile-redis (or something like that), so it
> would be good to look at unbundling it, similar to how guile-json is
> handled.
> 

Thanks for the review. :)

Correct. Redis is bundled an I did not unbundle it. Even guile-csv is 
bundled, but we have not packaged it yet.

I will try unbundling and send a new patch.

-- 
Cheers Swedebugia

Message #35 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <at> riseup.net
To: Christopher Baines <mail <at> cbaines.net>
Cc: 33932 <at> debbugs.gnu.org
Subject: Re: bug#33932: [PATCH] gnu: artanis: Move to web.scm and update to
 0.3.1.
Date: Fri, 04 Jan 2019 12:58:33 -0800

[Message part 1 (text/plain, inline)]

On 2019-01-03 22:39, swedebugia wrote:
> On 2019-01-03 20:19, Christopher Baines wrote:
>>
>> swedebugia <swedebugia <at> riseup.net> writes:
>>
>>> On 2019-01-02 22:50, swedebugia wrote:
>>>> On 2018-12-31 13:33, Ricardo Wurmus wrote:
>>>>>
>>>>> Hi swedebugia,
>>>>>
>>>>>> We should upgrade.
>>>>>
>>>>> Could you please send a patch?
>>>>>
>>>>
>>>> Here it is :)
>>
>> I haven't looked too closely at the patch, but I think the newer version
>> of Artanis have bundled guile-redis (or something like that), so it
>> would be good to look at unbundling it, similar to how guile-json is
>> handled.
>>
> 
> Thanks for the review. :)
> 
> Correct. Redis is bundled an I did not unbundle it. Even guile-csv is 
> bundled, but we have not packaged it yet.
> 
> I will try unbundling and send a new patch.

Done. Is this ready to merge? (I gave up on moving it. Maybe the
committer can do this?)

-- 
Cheers 
Swedebugia

[0001-gnu-artanis-Update-to-0.3.1.patch (text/x-diff, attachment)]

Message #38 received at 33932 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <at> riseup.net
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Christopher Baines <mail <at> cbaines.net>, 33932 <at> debbugs.gnu.org
Subject: Re: bug#33932: [PATCH] gnu: artanis: Move to web.scm and update to
 0.3.1.
Date: Sun, 06 Jan 2019 13:04:47 -0800

[Message part 1 (text/plain, inline)]

On 2019-01-04 22:38, Ricardo Wurmus wrote:
> Hi,
> 
>> From: swedebugia <swedebugia <at> riseup.net>
>> Date: Fri, 4 Jan 2019 21:20:46 +0100
>> Subject: [PATCH] gnu: artanis: Update to 0.3.1.
>>
>> * gnu/packages/guile.scm (artanis): Update it. Added note about
>>   guile-csv.
> 
> This should be
> 
> --8<---------------cut here---------------start------------->8---
> gnu: artanis: Update to 0.3.1.
> 
> * gnu/packages/guile.scm (artanis): Update to 0.3.1.
> [inputs]: Add guile-json and guile-redis.
> [source]: Unbundle guile-redis and guile-json in snippet.
> [arguments]: Delete strip phase.
> --8<---------------cut here---------------end--------------->8---
> 
>> +           (delete 'strip))))
> 
> Why is this needed?
> 
>> +      ;; native-search-paths are needed but left out because we propagate it
>> +      ;; from the installation of guile.
>> +      ;; On foreign distributions you have to set this manually no matter if
>> +      ;; you installed guile with guix or not. On GuixSD it should be set
>> +      ;; correctly automatically (Guile is always installed there)
> 
> I don’t know what this is trying to say, and it is pretty verbose.
> Should the guile-* inputs be propagated instead?  Please remove this
> comment.

Fixed. Is this OK?

-- 
Cheers 
Swedebugia

[0001-gnu-artanis-Update-to-0.3.1.patch (text/x-diff, attachment)]

Message #43 received at 33932-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: swedebugia <at> riseup.net
Cc: 33932-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: bug#33932: [PATCH] gnu: artanis: Move to web.scm and update to
 0.3.1.
Date: Mon, 28 Jan 2019 15:22:26 +0100

Hi swedebugia,

I made some minor changes to the commit message and reset the revision
to 0, adapted the patch after the guile.scm -> guile-xyz.scm split, and
pushed to the master branch.

Thanks!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.