GNU bug report logs - #33951
[PATCH] gnu: cmake-extra-modules: Fix QTPLUGINDIR.

Previous Next

Package: guix-patches;

Reported by: Meiyo Peng <meiyo.peng <at> gmail.com>

Date: Wed, 2 Jan 2019 10:00:02 UTC

Severity: normal

Tags: patch

Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33951 in the body.
You can then email your comments to 33951 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33951; Package guix-patches. (Wed, 02 Jan 2019 10:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Meiyo Peng <meiyo.peng <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Jan 2019 10:00:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo.peng <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: cmake-extra-modules: Fix QTPLUGINDIR.
Date: Wed, 02 Jan 2019 17:58:57 +0800
[Message part 1 (text/plain, inline)]
Hi,

This patch fixes the regular expression for QTPLUGINDIR.

The source code of "kde-modules/KDEInstallDirs.cmake" has been changed
by upstream in recent releases.  This regular expression bug caused
dependent packages install qt plugins into a wrong directory.

[0001-gnu-cmake-extra-modules-Fix-QTPLUGINDIR.patch (text/x-patch, inline)]
From a242fed166b0939365a6e6f3259c65471dc01db7 Mon Sep 17 00:00:00 2001
From: Meiyo Peng <meiyo.peng <at> gmail.com>
Date: Sat, 29 Dec 2018 00:06:00 +0800
Subject: [PATCH] gnu: cmake-extra-modules: Fix QTPLUGINDIR.

* gnu/packages/kde-frameworks.scm (cmake-extra-modules)[arguments]: Fix
  QTPLUGINDIR.
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 6c1854379..5c21a7fb7 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -5,6 +5,7 @@
 ;;; Copyright © 2016 David Craven <david <at> craven.ch>
 ;;; Copyright © 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2018 Meiyo Peng <meiyo.peng <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -98,7 +99,7 @@
                (("\"lib64\"") "\"lib\"")
                ;; TODO: Base the following on values taken from Qt
                ;; Install plugins into lib/qt5/plugins
-               (("_define_relative\\(QTPLUGINDIR LIBDIR \"plugins\"")
+               (("_define_relative\\(QTPLUGINDIR \"\\$\\{_pluginsDirParent\\}\" \"plugins\"")
                 "_define_relative(QTPLUGINDIR LIBDIR \"qt5/plugins\"")
                ;; Install imports into lib/qt5/imports
                (("_define_relative\\(QTQUICKIMPORTSDIR QTPLUGINDIR \"imports\"")
-- 
2.20.1

[Message part 3 (text/plain, inline)]
--
Meiyo Peng
https://www.pengmeiyu.com/

Information forwarded to guix-patches <at> gnu.org:
bug#33951; Package guix-patches. (Thu, 03 Jan 2019 19:41:02 GMT) Full text and rfc822 format available.

Message #8 received at 33951 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Meiyo Peng <meiyo.peng <at> gmail.com>, 33951 <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Thu, 3 Jan 2019 20:40:31 +0100
Hi Meiyo,
> Would you mind having a look at patch #33951: 

Thanks for pointing me to this.

This mainly is a duplicate of
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33812#5> which I files a
few days earlier.

The difference is that #33951 does not care about the Android
special-case, while #33812 tries to do and adds a respective comment. So
IMHO #33812 is to be preferred. WDYT?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |





Information forwarded to guix-patches <at> gnu.org:
bug#33951; Package guix-patches. (Fri, 04 Jan 2019 01:17:02 GMT) Full text and rfc822 format available.

Message #11 received at 33951 <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo.peng <at> gmail.com>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 33951 <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Fri, 04 Jan 2019 09:16:16 +0800
Hi Hartmut,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:

> Hi Meiyo,
>> Would you mind having a look at patch #33951:
>
> Thanks for pointing me to this.
>
> This mainly is a duplicate of
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33812#5> which I files a
> few days earlier.

Sorry, I didn't notice your patch.

> The difference is that #33951 does not care about the Android
> special-case, while #33812 tries to do and adds a respective comment. So
> IMHO #33812 is to be preferred. WDYT?

You are doing a great job. I agree to keep #33812 and drop #33951.

--
Meiyo Peng
https://www.pengmeiyu.com/




Reply sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
You have taken responsibility. (Fri, 04 Jan 2019 09:28:02 GMT) Full text and rfc822 format available.

Notification sent to Meiyo Peng <meiyo.peng <at> gmail.com>:
bug acknowledged by developer. (Fri, 04 Jan 2019 09:28:02 GMT) Full text and rfc822 format available.

Message #16 received at 33951-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Meiyo Peng <meiyo.peng <at> gmail.com>
Cc: 33951-close <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Fri, 4 Jan 2019 10:27:46 +0100
Am 04.01.19 um 02:16 schrieb Meiyo Peng:

> You are doing a great job.

Thanks :-)

> I agree to keep #33812 and drop #33951.

I applied #33812 as b824dbec5d331e79a50734fb543bbe064eb7fc17.


-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 01 Feb 2019 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.