GNU bug report logs - #33955
[PATCH 0/6] KDE: Enable more tests.

Previous Next

Package: guix-patches;

Reported by: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Date: Wed, 2 Jan 2019 18:46:01 UTC

Severity: normal

Tags: patch

Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33955 in the body.
You can then email your comments to 33955 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:46:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Jan 2019 18:46:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/6] KDE: Enable more tests.
Date: Wed,  2 Jan 2019 19:45:21 +0100
After applying patches from #33820:
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
pass. Activate them.

Hartmut Goebel (6):
  gnu: kcoreaddons: Enable test-suite.
  gnu: kirigami: Enable test-suite.
  gnu: kpackage: Enable test-suite.
  gnu: kemoticons: Enable test-suite.
  gnu: knewstuff: Enable test-suite.
  gnu: kwindowsystem: Enable test-suite.

 gnu/packages/kde-frameworks.scm | 91 ++++++++++++++++++++---------------------
 1 file changed, 45 insertions(+), 46 deletions(-)

-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 1/6] gnu: kcoreaddons: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:45 +0100
Enable running the tests and blacklist the one failing test.

* gnu/package/kde-frameworks.scm(kcoreaddons)[arguments]
  <#:tests?>: Remove. <#:phases>: Add phase 'blacklist-failing-test.
---
 gnu/packages/kde-frameworks.scm | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 5ab97c0b0..35e10015e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -566,9 +566,16 @@ propagate their changes to their respective configuration files.")
     (inputs
      `(("qtbase" ,qtbase)))
     (arguments
-     `(#:tests? #f ; FIXME: Test failure caused by stout/stderr being interleaved.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
+         (add-before 'check 'blacklist-failing-test
+           (lambda _
+             ;; Blacklist a failing test-function. FIXME: Make it pass.
+             ;; Test failure caused by stout/stderr being interleaved.
+             (with-output-to-file "autotests/BLACKLIST"
+               (lambda _
+                 (display "[test_channels]\n*\n")))
+             #t))
          (add-before 'check 'check-setup
            (lambda _
              (setenv "HOME" (getcwd))
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:47:02 GMT) Full text and rfc822 format available.

Message #11 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 2/6] gnu: kirigami: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:46 +0100
The error which inhibited running the tests no longer occurs
in 5.49.0, although now no tests are found at all.  Since no tests
are found now, the phase 'check-setup can be removed, too,
and thus the 'arguments' at all.

* gnu/packages/kde-frameworks.scm(kirigami)[arguments]: Remove.
---
 gnu/packages/kde-frameworks.scm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 35e10015e..62cf49c57 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -804,19 +804,6 @@ or user activity.")
        ("qtsvg" ,qtsvg)
        ;; Run-time dependency
        ("qtgraphicaleffects" ,qtgraphicaleffects)))
-    (arguments
-     `(#:tests? #f ;; FIXME: Test suite is broken,
-       ;; see https://bugs.kde.org/show_bug.cgi?id=386456
-       ;; Note for when enabling the tests: The test-suite is meant to be run
-       ;; without prior installation, see
-       ;; https://cgit.kde.org/kirigami.git/commit/?id=24ad2c9
-       #:phases
-       (modify-phases %standard-phases
-         (add-before 'check 'check-setup
-           (lambda* (#:key outputs #:allow-other-keys)
-             ;; make Qt render "offscreen", required for tests
-             (setenv "QT_QPA_PLATFORM" "offscreen")
-             #t)))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "QtQuick components for mobile user interfaces")
     (description "Kirigami is a set of high level QtQuick components looking
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:47:03 GMT) Full text and rfc822 format available.

Message #14 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 3/6] gnu: kpackage: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:47 +0100
* gnu/package/kde-frameworks.scm(kpackage)[arguments]
  <#:tests?>: Remove. <#:phases>: Add phase 'patch-tests.
---
 gnu/packages/kde-frameworks.scm | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 62cf49c57..07e30d4cf 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1834,8 +1834,7 @@ covers feedback and persistent events.")
        ("ki18n" ,ki18n)
        ("qtbase" ,qtbase)))
     (arguments
-     `(#:tests? #f ; FIXME: 3/9 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch
            (lambda _
@@ -1847,6 +1846,17 @@ covers feedback and persistent events.")
                (("^\\s*(QDirIterator it\\(.*, QDirIterator::Subdirectories)(\\);)" _ a b)
                 (string-append a " | QDirIterator::FollowSymlinks" b)))
              #t))
+         (add-after 'unpack 'patch-tests
+           (lambda _
+             ;; /bin/ls doesn't exist in the build-container use /etc/passwd
+             (substitute* "autotests/packagestructuretest.cpp"
+               (("(addDirectoryDefinition\\(\")bin(\".*\")bin(\".*\")bin\""
+                 _ a b c)
+                (string-append a "etc" b "etc" c "etc\""))
+               (("filePath\\(\"bin\", QStringLiteral\\(\"ls\"))")
+                "filePath(\"etc\", QStringLiteral(\"passwd\"))")
+               (("\"/bin/ls\"") "\"/etc/passwd\""))
+             #t))
          (add-before 'check 'check-setup
            (lambda _
              (setenv "HOME" (getcwd))
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:47:03 GMT) Full text and rfc822 format available.

Message #17 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 4/6] gnu: kemoticons: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:48 +0100
Without anything changed the test-suite now passes, thus can be enabled.

* gnu/package/kde-frameworks.scm(kemoticons)[arguments]<#:tests?>: Remove.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07e30d4cf..079a8a75e 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2423,8 +2423,7 @@ engine WebKit via QtWebKit.")
        ("kcoreaddons" ,kcoreaddons)
        ("qtbase" ,qtbase)))
     (arguments
-     `(#:tests? #f ; FIXME: 2/2 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
            (lambda _
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:47:03 GMT) Full text and rfc822 format available.

Message #20 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 5/6] gnu: knewstuff: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:49 +0100
Without anything changed the test-suite now passes, thus can be enabled.

* gnu/package/kde-frameworks.scm(knewstuff)[arguments]<#:tests?>: Remove.
---
 gnu/packages/kde-frameworks.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 079a8a75e..45580cb5f 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -2727,8 +2727,7 @@ KIO enabled infrastructure.")
        ("solid" ,solid)
        ("sonnet" ,sonnet)))
     (arguments
-     `(#:tests? #f ; FIXME: 1/3 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'check-setup
            (lambda _ ; XDG_DATA_DIRS isn't set
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Wed, 02 Jan 2019 18:48:02 GMT) Full text and rfc822 format available.

Message #23 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 33955 <at> debbugs.gnu.org
Subject: [PATCH 6/6] gnu: kwindowsystem: Enable test-suite.
Date: Wed,  2 Jan 2019 19:46:50 +0100
* gnu/package/kde-frameworks.scm(kwindowsystem)
  [inputs]: Add openbox.
  [arguments] <#:tests?> Remove.
  <#:phases> 'blacklist-failing-tests: New phase.
  <#:phases> 'check: Start openbox, don't set QT_PLUGIN_PATH, use invkove,
  simplify and cleanup code. No longer move 'check behind install.
---
 gnu/packages/kde-frameworks.scm | 47 +++++++++++++++++++----------------------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 45580cb5f..72fd8f20f 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1,7 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2015 Andreas Enge <andreas <at> enge.fr>
 ;;; Copyright © 2016 Efraim Flashner <efraim <at> flashner.co.il>
-;;; Copyright © 2016,2017,2018 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
+;;; Copyright © 2016-2019 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
 ;;; Copyright © 2016 David Craven <david <at> craven.ch>
 ;;; Copyright © 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
@@ -56,6 +56,7 @@
   #:use-module (gnu packages libreoffice)
   #:use-module (gnu packages linux)
   #:use-module (gnu packages mp3)
+  #:use-module (gnu packages openbox)
   #:use-module (gnu packages pdf)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages perl)
@@ -1093,6 +1094,7 @@ configuration pages, message boxes, and password requests.")
      `(("extra-cmake-modules" ,extra-cmake-modules)
        ("pkg-config" ,pkg-config)
        ("dbus" ,dbus) ; for the tests
+       ("openbox" ,openbox) ; for the tests
        ("qttools" ,qttools)
        ("xorg-server" ,xorg-server))) ; for the tests
     (inputs
@@ -1101,31 +1103,26 @@ configuration pages, message boxes, and password requests.")
        ("qtx11extras" ,qtx11extras)
        ("xcb-utils-keysyms" ,xcb-util-keysyms)))
     (arguments
-     `(#:tests? #f ; FIXME: 3/12 tests fail.
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
-         (delete 'check)
-         (add-after 'install 'check
-           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
-             ;; TODO: Simplify and use "common" phases when test-suite passes
-             (if tests?
-                 (begin
-                   (let ((out (assoc-ref outputs "out")))
-                     (setenv "QT_PLUGIN_PATH"
-                             (string-append out "/lib/qt5/plugins:"
-                                            (getenv "QT_PLUGIN_PATH"))))
-                   ;; The test suite requires a running X server, setting
-                   ;; QT_QPA_PLATFORM=offscreen does not suffice and even make
-                   ;; some tests fail.
-                   (system (string-append (assoc-ref inputs "xorg-server")
-                                          "/bin/Xvfb :1 -screen 0 640x480x24 &"))
-                   (setenv "DISPLAY" ":1")
-                   (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
-                   (setenv "DBUS_FATAL_WARNINGS" "0")
-                   (zero? (system* "dbus-launch" "ctest" ".")))
-                 (begin
-                   (format #t "test suite not run~%")
-                   #t)))))))
+         (add-before 'check 'blacklist-failing-tests
+           (lambda _
+             ;; Blacklist a failing test-functions. FIXME: Make it pass.
+             (with-output-to-file "autotests/BLACKLIST"
+               (lambda _
+                 (display "[testState]\n*\n")
+                 (display "[testSupported]\n*\n")))
+             #t))
+         (replace 'check
+           (lambda _
+             ;; The test suite requires a running window anager
+             (system "Xvfb :1 -ac -screen 0 640x480x24 &")
+             (setenv "DISPLAY" ":1")
+             (sleep 5) ;; Give Xvfb a few moments to get on it's feet
+             (system "openbox &")
+             (setenv "CTEST_OUTPUT_ON_FAILURE" "1")
+             (setenv "DBUS_FATAL_WARNINGS" "0")
+             (invoke "dbus-launch" "ctest" "."))))))
     (home-page "https://community.kde.org/Frameworks")
     (synopsis "KDE access to the windowing system")
     (description "KWindowSystem provides information about and allows
-- 
2.13.7





Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Thu, 03 Jan 2019 02:00:02 GMT) Full text and rfc822 format available.

Message #26 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Meiyo Peng <meiyo.peng <at> gmail.com>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 33955 <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Thu, 03 Jan 2019 09:59:40 +0800
Hi Hartmut,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:

> After applying patches from #33820:
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
> pass. Activate them.
>
> Hartmut Goebel (6):
>   gnu: kcoreaddons: Enable test-suite.
>   gnu: kirigami: Enable test-suite.
>   gnu: kpackage: Enable test-suite.
>   gnu: kemoticons: Enable test-suite.
>   gnu: knewstuff: Enable test-suite.
>   gnu: kwindowsystem: Enable test-suite.
>
>  gnu/packages/kde-frameworks.scm | 91 ++++++++++++++++++++---------------------
>  1 file changed, 45 insertions(+), 46 deletions(-)

Would you mind having a look at patch #33951:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33951

I found that bug while investigating kwindowsystem. That bug caused
kwindowsystem installed plugins into PREFIX/lib/plugins rather than
PREFIX/lib/qt5/plugins.

Thanks.

--
Meiyo Peng
https://www.pengmeiyu.com/




Information forwarded to guix-patches <at> gnu.org:
bug#33955; Package guix-patches. (Mon, 14 Jan 2019 21:51:01 GMT) Full text and rfc822 format available.

Message #29 received at 33955 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 33955 <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Mon, 14 Jan 2019 22:50:25 +0100
Hello Hartmut,

Hartmut Goebel <h.goebel <at> crazy-compilers.com> skribis:

> After applying patches from #33820:
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=33820> some more tests
> pass. Activate them.
>
> Hartmut Goebel (6):
>   gnu: kcoreaddons: Enable test-suite.
>   gnu: kirigami: Enable test-suite.
>   gnu: kpackage: Enable test-suite.
>   gnu: kemoticons: Enable test-suite.
>   gnu: knewstuff: Enable test-suite.
>   gnu: kwindowsystem: Enable test-suite.

The patches LGTM, and it’s a great initiative!

Thanks,
Ludo’.




Reply sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
You have taken responsibility. (Wed, 16 Jan 2019 23:22:02 GMT) Full text and rfc822 format available.

Notification sent to Hartmut Goebel <h.goebel <at> crazy-compilers.com>:
bug acknowledged by developer. (Wed, 16 Jan 2019 23:22:02 GMT) Full text and rfc822 format available.

Message #34 received at 33955-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33955-close <at> debbugs.gnu.org
Subject: Re: [bug#33955] [PATCH 0/6] KDE: Enable more tests.
Date: Thu, 17 Jan 2019 00:20:57 +0100
Applied as 2615ee95204fbd5cbc73d236ecbd24a4fbdc5de5
Thanks for the review.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 14 Feb 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 44 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.