GNU bug report logs - #33957
[PATCH] gnu: Add missing search-path definitions to guile libraries.

Previous Next

Package: guix-patches;

Reported by: swedebugia <swedebugia <at> riseup.net>

Date: Wed, 2 Jan 2019 22:53:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33957 in the body.
You can then email your comments to 33957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33957; Package guix-patches. (Wed, 02 Jan 2019 22:53:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to swedebugia <swedebugia <at> riseup.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 02 Jan 2019 22:53:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add missing search-path definitions to guile libraries.
Date: Wed, 2 Jan 2019 23:59:00 +0100
[Message part 1 (text/plain, inline)]
I added missing search-path definitions for guile 2.2.

-- 
Cheers Swedebugia
[0001-gnu-Add-missing-search-path-definitions-to-guile-lib.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#33957; Package guix-patches. (Thu, 03 Jan 2019 07:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 33957 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: swedebugia <swedebugia <at> riseup.net>,33957 <at> debbugs.gnu.org
Subject: Re: [bug#33957] [PATCH] gnu: Add missing search-path definitions to
 guile	libraries.
Date: Thu, 03 Jan 2019 10:43:07 +0300
Le 3 janvier 2019 01:59:00 GMT+03:00, swedebugia <swedebugia <at> riseup.net> a écrit :
>I added missing search-path definitions for guile 2.2.

Hi,

I don't think this is needed. As long as you install guile and its libraries in the same profile, guix will tell you what to do with the search-path.

I'm afraid it'll break on packages that use a different guile as they are defined from the guile2.2 definition.

What are you trying to fix exactly?




Information forwarded to guix-patches <at> gnu.org:
bug#33957; Package guix-patches. (Thu, 03 Jan 2019 16:24:02 GMT) Full text and rfc822 format available.

Message #11 received at 33957 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <swedebugia <at> riseup.net>
To: Julien Lepiller <julien <at> lepiller.eu>,
 "33957 <at> debbugs.gnu.org" <33957 <at> debbugs.gnu.org>
Subject: Re: [bug#33957] [PATCH] gnu: Add missing search-path definitions to
 guile libraries.
Date: Thu, 3 Jan 2019 17:29:41 +0100
On 2019-01-03 08:43, Julien Lepiller wrote:
> Le 3 janvier 2019 01:59:00 GMT+03:00, swedebugia <swedebugia <at> riseup.net> a écrit :
>> I added missing search-path definitions for guile 2.2.
> 
> Hi,
> 
> I don't think this is needed. As long as you install guile and its libraries in the same profile, guix will tell you what to do with the search-path.
> 
> I'm afraid it'll break on packages that use a different guile as they are defined from the guile2.2 definition.

I don't agree. We simply update the paths when we update guile.

> 
> What are you trying to fix exactly?
> 

In parabola. When I have guile from parabola installed and install 
guile-x and guile-y libraries from guix it does not inform about 
search-paths.
Neither does the output of guix package --search-paths.

Maybe we should write a section in the manual about why we choose to not 
include these search-paths if that is the outcome.

Thoughts?

-- 
Cheers Swedebugia




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 12 Jan 2019 13:47:02 GMT) Full text and rfc822 format available.

Notification sent to swedebugia <swedebugia <at> riseup.net>:
bug acknowledged by developer. (Sat, 12 Jan 2019 13:47:04 GMT) Full text and rfc822 format available.

Message #16 received at 33957-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: swedebugia <swedebugia <at> riseup.net>
Cc: "33957 <at> debbugs.gnu.org" <33957-done <at> debbugs.gnu.org>,
 Julien Lepiller <julien <at> lepiller.eu>
Subject: Re: [bug#33957] [PATCH] gnu: Add missing search-path definitions to
 guile libraries.
Date: Sat, 12 Jan 2019 14:46:08 +0100
Hello,

swedebugia <swedebugia <at> riseup.net> skribis:

> On 2019-01-03 08:43, Julien Lepiller wrote:
>> Le 3 janvier 2019 01:59:00 GMT+03:00, swedebugia <swedebugia <at> riseup.net> a écrit :
>>> I added missing search-path definitions for guile 2.2.
>>
>> Hi,
>>
>> I don't think this is needed. As long as you install guile and its libraries in the same profile, guix will tell you what to do with the search-path.

Indeed.  I’m closing the issue.

>> What are you trying to fix exactly?
>>
>
> In parabola. When I have guile from parabola installed and install
> guile-x and guile-y libraries from guix it does not inform about
> search-paths.
> Neither does the output of guix package --search-paths.

Could you paste a concrete example?  Here’s what I see:

--8<---------------cut here---------------start------------->8---
$ guix package -p foo -i guile guile-json
La jenaj pakoj estos instalataj:
    guile	2.2.4	/gnu/store/9alic3caqhay3h8mx4iihpmyj6ymqpcx-guile-2.2.4
   guile-json	1.2.0	/gnu/store/xz8q1jn7j9rz3fbr9rg326lml931936s-guile-json-1.2.0

substitute: updating substitutes from 'https://berlin.guixsd.org'... 100.0%
substitute: updating substitutes from 'https://mirror.hydra.gnu.org'... 100.0%
La jena derivo estos konstruata:
   /gnu/store/54pckxgg3nvlg53vqlcbrffdrar2rpgk-profile.drv
The following profile hooks will be built:
   /gnu/store/vgahfx593xs72ki6nz9p3nlr4csjddyk-manual-database.drv
   /gnu/store/0iqqr44bbny1n5qjnpwhr43h03lgfpvq-ca-certificate-bundle.drv
   /gnu/store/8w1nqglsni60xa5k18dx76iqn7c59pkw-info-dir.drv
   /gnu/store/fczh2vzzi3v3rzla6h3gnhp3hcvdbfdq-fonts-dir.drv
building CA certificate bundle...
building fonts directory...
building directory of Info manuals...
building database for manual pages...
building /gnu/store/54pckxgg3nvlg53vqlcbrffdrar2rpgk-profile.drv...
pakoj 2 en profilo
La jenaj medi-variablaj difinoj povos esti necesaj:
   export PATH="foo/bin${PATH:+:}$PATH"
   export GUILE_LOAD_PATH="foo/share/guile/site/2.2${GUILE_LOAD_PATH:+:}$GUILE_LOAD_PATH"
   export GUILE_LOAD_COMPILED_PATH="foo/lib/guile/2.2/site-ccache${GUILE_LOAD_COMPILED_PATH:+:}$GUILE_LOAD_COMPILED_PATH"
$ guix package -p foo --search-paths
export PATH="foo/bin"
export GUILE_LOAD_PATH="foo/share/guile/site/2.2"
export GUILE_LOAD_COMPILED_PATH="foo/lib/guile/2.2/site-ccache"
--8<---------------cut here---------------end--------------->8---

As you can see we do get GUILE_LOAD_PATH here.

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 10 Feb 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 75 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.