GNU bug report logs - #33962
guix pull fails on latest master

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33962 in the body.
You can then email your comments to 33962 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <brendan.tildesley <at> gmail.com>
To: bug-guix <at> gnu.org
Cc: rhelling <at> mykolab.com
Subject: guix pull fails on latest master
Date: Fri, 4 Jan 2019 01:24:22 +1100

95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
to build because it references meson-build-system without importing the
required module. I'm guessing adding  #:use-module (guix build-system
meson)   ; would fix it.

I'm curious to know how this error was made.

Message #10 received at 33962-done <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <brendan.tildesley <at> gmail.com>
To: 33962-done <at> debbugs.gnu.org
Subject: Re: bug#33962: Acknowledgement (guix pull fails on latest master)
Date: Fri, 4 Jan 2019 01:32:55 +1100

Efraim fixed it:

Message #13 received at 33962-done <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: Brendan Tildesley <brendan.tildesley <at> gmail.com>
Cc: 33962-done <at> debbugs.gnu.org
Subject: Re: guix pull fails on latest master
Date: Thu, 3 Jan 2019 15:48:08 +0100

[Message part 1 (text/plain, inline)]

Sorry, that was sloppiness on my part. I built the package on my own
Guix that already had staging merged where apparently the
meson-build-system was already added to the modules.

I was about to revert but I just noticed it's already been fixed. I'll
double check if it builds on a clean master next time.

On Fri, 4 Jan 2019 01:24:22 +1100
Brendan Tildesley <brendan.tildesley <at> gmail.com> wrote:

> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard
> fails to build because it references meson-build-system without
> importing the required module. I'm guessing adding  #:use-module
> (guix build-system meson)   ; would fix it.
> 
> I'm curious to know how this error was made.
> 

[Message part 2 (application/pgp-signature, inline)]

Message #16 received at 33962-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Brendan Tildesley <brendan.tildesley <at> gmail.com>
Cc: 33961-done <at> debbugs.gnu.org, 33962-done <at> debbugs.gnu.org,
 rhelling <at> mykolab.com
Subject: Re: bug#33962: guix pull fails on latest master
Date: Thu, 3 Jan 2019 14:33:21 -0500

[Message part 1 (text/plain, inline)]

On Fri, Jan 04, 2019 at 01:24:22AM +1100, Brendan Tildesley wrote:
> 95bf2fb637ba4abb27efe94e0b671c1e93204e4f , which adds wl-clipboard fails
> to build because it references meson-build-system without importing the
> required module. I'm guessing adding  #:use-module (guix build-system
> meson)   ; would fix it.
> 
> I'm curious to know how this error was made.

My guess is that the code contribution was tested with the
meson-build-system module imported correctly. However, the actual commit
or patch was created without the module import line.

When reviewing patches just by reading them, it's easy to miss mistakes
like this one.

This should be fixed in commit 4382cef28cb6de4b2b505788b759b0fe4f8ea603

Thanks for the reports!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.