GNU bug report logs - #33980
gnu: Add pwsafe

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33980 in the body.
You can then email your comments to 33980 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: guix-patches <at> gnu.org
Subject: gnu: Add pwsafe
Date: Fri, 4 Jan 2019 23:32:24 +0100

[Message part 1 (text/plain, inline)]

Hi,
The attached patch adds pwsafe.
Please tell me if something is wrong with the patch.

Tim.

[0001-gnu-Add-pwsafe.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 33980 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 33980 <at> debbugs.gnu.org
Subject: Re: [bug#33980] gnu: Add pwsafe
Date: Wed, 09 Jan 2019 18:00:24 +0100

Hi Tim,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

> From b85b078e18a8166231320f05e938f5f0264f5097 Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Sat, 29 Dec 2018 23:21:58 +0100
> Subject: [PATCH] gnu: Add pwsafe
>
> * gnu/packages/password-utils.scm (pwsafe): New variable

Overall LGTM.  Nitpicking:

> +    ;; TODO: The help subsystem cannot be initialized
> +    ;; TODO: pwsafe tries to download GTest which does not work in the daemon
> +    ;; environment and is not functional. Substitute CMakeLists.txt to use
> +    ;; native GTest and reenable unit tests.
> +    (arguments '(#:configure-flags (list "-DNO_GTEST=YES")))

It would be ideal if you could get the tests running.  :-)

> +    (native-inputs `(("coreutils" ,coreutils)

Coreutils is not needed, it’s an implicit input already.

> +    (synopsis "Password safe to store passwords encrypted")
> +    (description "A password manager originally designed by Bruce Schneier.
> +It offers a simple UI to manage passwords for different services.  There are
> +other programs that support the file format on different plattforms.")
                                                               ^^
Typo.

Also please make full sentences.

Could you send an updated patch?

Thank you,
Ludo’.

Message #11 received at 33980 <at> debbugs.gnu.org (full text, mbox):

From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 33980 <at> debbugs.gnu.org
Subject: Re: [bug#33980] gnu: Add pwsafe
Date: Wed, 9 Jan 2019 22:27:25 +0100

[Message part 1 (text/plain, inline)]

Hi Ludo,

>> +    ;; TODO: The help subsystem cannot be initialized
>> +    ;; TODO: pwsafe tries to download GTest which does not work in the daemon
>> +    ;; environment and is not functional. Substitute CMakeLists.txt to use
>> +    ;; native GTest and reenable unit tests.
>> +    (arguments '(#:configure-flags (list "-DNO_GTEST=YES")))
> 
> It would be ideal if you could get the tests running.  :-)

Done. It's a really ugly hack but they are running.
This uncovered the problem of the help system not initializing because
/usr/bin/file was hardcoded. So enabling unit tests was a good idea (as
always) :)


>> +    (native-inputs `(("coreutils" ,coreutils)
> 
> Coreutils is not needed, it’s an implicit input already.

Removed.

>> +    (synopsis "Password safe to store passwords encrypted")
>> +    (description "A password manager originally designed by Bruce Schneier.
>> +It offers a simple UI to manage passwords for different services.  There are
>> +other programs that support the file format on different plattforms.")
>                                                                ^^
> Typo.
> 
> Also please make full sentences.

Hope I got everything corrrect this time.
Patch is attached.

Tim.

[0001-gnu-Add-pwsafe.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #16 received at 33980-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
Cc: 33980-done <at> debbugs.gnu.org,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Re: [bug#33980] gnu: Add pwsafe
Date: Thu, 10 Jan 2019 10:22:26 +0100

Hi Tim,

Tim Gesthuizen <tim.gesthuizen <at> yahoo.de> skribis:

> From 5106465e332782896f84b4e3ff3ae03588aeca2a Mon Sep 17 00:00:00 2001
> From: Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
> Date: Sat, 29 Dec 2018 23:21:58 +0100
> Subject: [PATCH] gnu: Add pwsafe
>
> * gnu/packages/password-utils.scm (pwsafe): New variable

I made phases return #t and applied, thanks!

While building with --rounds=2, I noticed zip files were produced in a
non-deterministic way:

--8<---------------cut here---------------start------------->8---
$ diff -ru /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0{,-check}
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpDE.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpDE.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpEN.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpEN.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpES.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpES.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpFR.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpFR.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpPL.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpPL.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpRU.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpRU.zip differ
Binary files /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/helpZH.zip and /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/helpZH.zip differ
$ diffoscope /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0{,-check}/share/passwordsafe/help/
--- /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0/share/passwordsafe/help/
+++ /gnu/store/rynl3nnxy1b4l2nclb6s0lsqidzix4q9-pwsafe-3.48.0-check/share/passwordsafe/help/
├── helpDE.zip
│ ├── zipinfo /dev/stdin
│ │ @@ -1,9 +1,9 @@
│ │  Zip file size: 2850677 bytes, number of entries: 216
│ │ -drwxr-xr-x  3.0 unx        0 b- stor 19-Jan-10 08:40 html/
│ │ +drwxr-xr-x  3.0 unx        0 b- stor 19-Jan-10 08:38 html/
│ │  -r--r--r--  3.0 unx     7195 t- defN 80-Jan-01 00:00 html/filters.html
│ │  -r--r--r--  3.0 unx    11035 t- defN 80-Jan-01 00:00 html/run_command.html
│ │  -r--r--r--  3.0 unx    10533 t- defN 80-Jan-01 00:00 html/entering_pwd.html
│ │  -r--r--r--  3.0 unx     7763 t- defN 80-Jan-01 00:00 html/view_menu.html
│ │  -r--r--r--  3.0 unx     3537 t- defN 80-Jan-01 00:00 html/password_history.html
│ │  -r--r--r--  3.0 unx     6363 t- defN 80-Jan-01 00:00 html/file_menu.html
│ │  -r--r--r--  3.0 unx     2910 t- defN 80-Jan-01 00:00 html/about_pws.html
│ │ @@ -30,15 +30,15 @@
│ │  -r--r--r--  3.0 unx    11856 t- defN 80-Jan-01 00:00 html/edit_menu.html
│ │  -r--r--r--  3.0 unx     3745 t- defN 80-Jan-01 00:00 html/password_history_tab.html
│ │  -r--r--r--  3.0 unx     3850 t- defN 80-Jan-01 00:00 html/backup_and_restore.html
│ │  -r--r--r--  3.0 unx     7184 t- defN 80-Jan-01 00:00 html/autotype.html
│ │  -r--r--r--  3.0 unx     2744 t- defN 80-Jan-01 00:00 html/images.html
│ │  -r--r--r--  3.0 unx     5215 t- defN 80-Jan-01 00:00 html/failsafebackups.html
│ │  -r--r--r--  3.0 unx     3155 t- defN 80-Jan-01 00:00 html/wzselectdb.html
│ │ -drwxr-xr-x  3.0 unx        0 b- stor 19-Jan-10 08:40 html/images/
│ │ +drwxr-xr-x  3.0 unx        0 b- stor 19-Jan-10 08:38 html/images/

[...]

│ │  -r--r--r--  3.0 unx     3818 t- defN 80-Jan-01 00:00 html/entering_pwd_date.html
│ │  -r--r--r--  3.0 unx     8113 t- defN 80-Jan-01 00:00 html/manage_menu.html
│ │  -r--r--r--  3.0 unx     1984 t- defN 80-Jan-01 00:00 html/wzfinish.html
│ │ --r--r--r--  3.0 unx     7988 t- defN 19-Jan-10 08:40 pwsafeDE.hhc
│ │ --r--r--r--  3.0 unx      203 t- defN 19-Jan-10 08:40 pwsafeDE.hhk
│ │ --r--r--r--  3.0 unx     1342 t- defN 19-Jan-10 08:40 pwsafe.hhp
│ │ +-r--r--r--  3.0 unx     7988 t- defN 19-Jan-10 08:38 pwsafeDE.hhc
│ │ +-r--r--r--  3.0 unx      203 t- defN 19-Jan-10 08:38 pwsafeDE.hhk
│ │ +-r--r--r--  3.0 unx     1342 t- defN 19-Jan-10 08:38 pwsafe.hhp
--8<---------------cut here---------------end--------------->8---

I suppose this is a case where we should use Gábor’s
‘reset-zip-timestamps’.  It would be great if you could give it a try.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.