GNU bug report logs - #33986
[PATCH 1/9] gnu: Add ocaml-sexplib0.

Previous Next

Package: guix-patches;

Reported by: Gabriel Hondet <gabrielhondet <at> gmail.com>

Date: Sat, 5 Jan 2019 09:30:02 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33986 in the body.
You can then email your comments to 33986 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 09:30:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gabriel Hondet <gabrielhondet <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 05 Jan 2019 09:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Thu, 3 Jan 2019 08:18:32 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
---
 gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e4f17133d..bece14477 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional syntax for tuples and variants.
 yojson package.  The program @code{atdgen} can be used to derive OCaml-JSON
 serializers and deserializers from type definitions.")
     (license license:bsd-3)))
+
+(define-public ocaml-sexplib0
+  (package
+    (name "ocaml-sexplib0")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/sexplib0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f))
+    (synopsis "Library containing the definition of S-expressions and some
+base converters")
+    (description "Part of Jane Street's Core library The Core suite of
+libraries is an industrial strength alternative to OCaml's standard library
+that was developed by Jane Street, the largest industrial user of OCaml.")
+(license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 09:32:02 GMT) Full text and rfc822 format available.

Message #8 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 2/9] gnu: Add ocaml-parsexp.
Date: Thu, 3 Jan 2019 08:26:51 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-parsexp): New variable.
---
 gnu/packages/ocaml.scm | 46 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index bece14477..7876c69a7 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5130,3 +5130,49 @@ base converters")
 libraries is an industrial strength alternative to OCaml's standard library
 that was developed by Jane Street, the largest industrial user of OCaml.")
 (license license:expat)))
+
+(define-public ocaml-parsexp
+  (package
+    (name "ocaml-parsexp")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/parsexp")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1nyq23s5igd8cf3n4qxprjvhbmb6ighb3fy5mw7hxl0mdgsw5fvz"))))
+    (build-system dune-build-system)
+    (inputs
+     `(("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (synopsis "S-expression parsing library")
+    (description
+     "This library provides generic parsers for parsing S-expressions from
+strings or other medium.
+
+The library is focused on performances but still provide full generic
+parsers that can be used with strings, bigstrings, lexing buffers,
+character streams or any other sources effortlessly.
+
+It provides three different class of parsers:
+@itemize
+@item
+the normal parsers, producing [Sexp.t] or [Sexp.t list] values
+@item
+the parsers with positions, building compact position sequences so
+that one can recover original positions in order to report properly
+located errors at little cost
+@item
+the Concrete Syntax Tree parsers, produce values of type
+[Parsexp.Cst.t] which record the concrete layout of the s-expression
+syntax, including comments
+@end itemize
+
+This library is portable and doesn't provide IO functions.  To read
+s-expressions from files or other external sources, you should use
+parsexp_io.")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:10:01 GMT) Full text and rfc822 format available.

Message #11 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 3/9] gnu: Add ocaml-sexplib.
Date: Thu, 3 Jan 2019 08:45:36 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-sexplib): New variable.
---
 gnu/packages/ocaml.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 7876c69a7..0faab47ee 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5176,3 +5176,32 @@ This library is portable and doesn't provide IO functions.  To read
 s-expressions from files or other external sources, you should use
 parsexp_io.")
     (license license:expat)))
+
+(define-public ocaml-sexplib
+  (package
+    (name "ocaml-sexplib")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/sexplib")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1qfl0m04rpcjvc4yw1hzh6r16jpwmap0sa9ax6zjji67dz4szpyb"))))
+    (build-system dune-build-system)
+    (inputs
+     `(("ocaml-num" ,ocaml-num)
+       ("ocaml-parsexp" ,ocaml-parsexp)
+       ("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (synopsis
+     "Library for serializing OCaml values to and from S-expressions")
+    (description
+     "Part of Jane Street's Core library
+The Core suite of libraries is an industrial strength alternative to
+OCaml's standard library that was developed by Jane Street, the
+largest industrial user of OCaml.")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:12:02 GMT) Full text and rfc822 format available.

Message #14 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 4/9] gnu: Add ocaml-base.
Date: Thu, 3 Jan 2019 09:43:49 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-base): New variable.
---
 gnu/packages/ocaml.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 0faab47ee..9e2e7e09b 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5205,3 +5205,45 @@ The Core suite of libraries is an industrial strength alternative to
 OCaml's standard library that was developed by Jane Street, the
 largest industrial user of OCaml.")
     (license license:expat)))
+
+(define-public ocaml-base
+  (package
+    (name "ocaml-base")
+    (version "0.11.1")
+    (home-page "https://github.com/janestreet/base")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0j6xb4265jr41vw4fjzak6yr8s30qrnzapnc6rl1dxy8bjai0nir"))))
+    (build-system dune-build-system)
+    (inputs
+     `(("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'build
+           ;; make warnings non fatal (jbuilder behaviour)
+           (lambda _
+             (invoke "dune" "build" "@install" "--profile=release"))))))
+  (synopsis
+    "Full standard library replacement for OCaml")
+  (description
+    "Full standard library replacement for OCaml
+
+Base is a complete and portable alternative to the OCaml standard
+library.  It provides all standard functionalities one would expect
+from a language standard library.  It uses consistent conventions
+across all of its module.
+
+Base aims to be usable in any context.  As a result system dependent
+features such as I/O are not offered by Base.  They are instead
+provided by companion libraries such as
+@url{https://github.com/janestreet/stdio, stdio}.")
+  (license license:expat)))
+
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:12:02 GMT) Full text and rfc822 format available.

Message #17 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 5/9] gnu: Add ocaml-compiler-libs.
Date: Thu, 3 Jan 2019 10:13:51 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-compiler-libs): New variable.
---
 gnu/packages/ocaml.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 9e2e7e09b..6f91f5d99 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5247,3 +5247,26 @@ provided by companion libraries such as
 @url{https://github.com/janestreet/stdio, stdio}.")
   (license license:expat)))
 
+(define-public ocaml-compiler-libs
+  (package
+    (name "ocaml-compiler-libs")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/ocaml-compiler-libs")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "03jds7bszh8wwpfwxb3dg0gyr1j1872wxwx1xqhry5ir0i84bg0s"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f))
+    (synopsis "Compiler libraries repackaged")
+    (description "This packaeg simply repackages the OCaml compiler libraries
+so they don't expose everything at toplevel.  For instance, @code{Ast_helper}
+is now @code{Ocaml_common.Ast_helper}.")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:13:01 GMT) Full text and rfc822 format available.

Message #20 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 6/9] gnu: Add ocaml-migrate-parsetree.
Date: Thu, 3 Jan 2019 10:40:45 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-migrate-parsetree): New variable.
---
 gnu/packages/ocaml.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 6f91f5d99..28ae9fd04 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5270,3 +5270,33 @@ provided by companion libraries such as
 so they don't expose everything at toplevel.  For instance, @code{Ast_helper}
 is now @code{Ocaml_common.Ast_helper}.")
     (license license:expat)))
+
+(define-public ocaml-migrate-parsetree
+  (package
+    (name "ocaml-migrate-parsetree")
+    (version "1.1.0")
+    (home-page "https://github.com/ocaml-ppx/ocaml-migrate-parsetree")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1d2n349d1cqm3dr09mwy5m9rfd4bkkqvri5i94wknpsrr35vnrr1"))))
+    (build-system dune-build-system)
+    (inputs
+     `(("ocaml-compiler-libs" ,ocaml-compiler-libs)
+       ("ocaml-result" ,ocaml-result)))
+    (native-inputs
+     `(("ocamlbuild" ,ocamlbuild)))
+    (synopsis "Convert OCaml parsetrees between different major versions")
+    (description "This library converts between parsetrees of different OCaml
+version.
+
+Supported versions are 4.02, 4.03, 4.04, 4.05 and 4.06.  For each version,
+there is a snapshot of the parsetree and conversion functions to the next
+and/or previous version.")
+    (license license:lgpl2.1+)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:14:02 GMT) Full text and rfc822 format available.

Message #23 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 7/9] gnu: Add ocaml-stdio.
Date: Thu, 3 Jan 2019 10:48:28 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-stdio): New variable.
---
 gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 28ae9fd04..209aa66c3 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5300,3 +5300,31 @@ Supported versions are 4.02, 4.03, 4.04, 4.05 and 4.06.  For each version,
 there is a snapshot of the parsetree and conversion functions to the next
 and/or previous version.")
     (license license:lgpl2.1+)))
+
+(define-public ocaml-stdio
+  (package
+    (name "ocaml-stdio")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/stdio")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1facajqhvq34g2wrg368y0ajxd6lrj5b3lyzyj0jhdmraxajjcwn"))))
+    (build-system dune-build-system)
+    (inputs `(("ocaml-base" ,ocaml-base)
+              ("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (arguments
+     '(#:tests? #f))
+    (synopsis "Standard IO library for OCaml")
+    (description
+     "Stdio implements simple input/output functionalities for OCaml.
+
+It re-exports the input/output functions of the OCaml standard
+libraries using a more consistent API.")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:15:01 GMT) Full text and rfc822 format available.

Message #26 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 8/9] gnu: Add ocaml-ppx-derivers.
Date: Thu, 3 Jan 2019 10:59:52 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-ppx-derivers): New variable.
---
 gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 209aa66c3..3607dc319 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5328,3 +5328,29 @@ and/or previous version.")
 It re-exports the input/output functions of the OCaml standard
 libraries using a more consistent API.")
     (license license:expat)))
+
+(define-public ocaml-ppx-derivers
+  (package
+    (name "ocaml-ppx-derivers")
+    (version "1.2")
+    (home-page
+     "https://github.com/ocaml-ppx/ppx_derivers")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0bnhihl1w31as5w2czly1v3d6pbir9inmgsjg2cj6aaj9v1dzd85"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f))
+    (synopsis "Shared [@@deriving] plugin registry")
+    (description
+     "Ppx_derivers is a tiny package whose sole purpose is to allow
+ppx_deriving and ppx_type_conv to inter-operate gracefully when linked
+as part of the same ocaml-migrate-parsetree driver.")
+    (license license:bsd-3)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 11:15:02 GMT) Full text and rfc822 format available.

Message #29 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: 33986 <at> debbugs.gnu.org
Subject: [PATCH 9/9] gnu: Add ocaml-ppxlib.
Date: Fri, 4 Jan 2019 10:09:12 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-ppxlib): New variable.
---
 gnu/packages/ocaml.scm | 66 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index 3607dc319..70dcf1bd7 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5354,3 +5354,69 @@ libraries using a more consistent API.")
 ppx_deriving and ppx_type_conv to inter-operate gracefully when linked
 as part of the same ocaml-migrate-parsetree driver.")
     (license license:bsd-3)))
+
+(define-public ocaml-ppxlib
+  (package
+    (name "ocaml-ppxlib")
+    (version "0.4.0")
+    (home-page "https://github.com/ocaml-ppx/ppxlib")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1nr4igf5m4prvigvv470dnhfdhdw0p6hz6zw8gnm5bzcv7s2lg5l"))))
+    (build-system dune-build-system)
+    (inputs
+     `(("ocaml-base" ,ocaml-base)
+       ("ocaml-compiler-libs" ,ocaml-compiler-libs)
+       ("ocaml-migrate-parsetree" ,ocaml-migrate-parsetree)
+       ("ocaml-ppx-derivers" ,ocaml-ppx-derivers)
+       ("ocaml-stdio" ,ocaml-stdio)
+       ("ocaml-result" ,ocaml-result)
+       ("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (native-inputs
+     `(("ocaml-findlib" ,ocaml-findlib)))
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'set-topfind
+           (lambda* (#:key inputs #:allow-other-keys)
+             ;; add the line #directory ".." at the top of each file
+             ;; using #use "topfind";; to be able to find topfind
+             (let* ((findlib-path (assoc-ref inputs "ocaml-findlib"))
+                    (findlib-libdir
+                     (string-append findlib-path "/lib/ocaml/site-lib")))
+               (substitute* '("test/base/test.ml"
+                              "test/deriving/test.ml"
+                              "test/driver/attributes/test.ml"
+                              "test/driver/non-compressible-suffix/test.ml"
+                              "test/driver/transformations/test.ml")
+                 (("#use \"topfind\";;" all)
+                  (string-append "#directory \"" findlib-libdir "\"\n"
+                                 all))))
+             #t)))))
+    (synopsis
+     "Base library and tools for ppx rewriters")
+    (description
+     "A comprehensive toolbox for ppx development.  It features:
+@itemize
+@item
+a OCaml AST / parser / pretty-printer snapshot, to create a full frontend
+independent of the version of OCaml;
+@item
+a library for library for ppx rewriters in general, and type-driven code
+generators in particular;
+@item
+a feature-full driver for OCaml AST transformers;
+@item
+a quotation mechanism allowing to write values representing the
+OCaml AST in the OCaml syntax;
+@item
+a generator of open recursion classes from type definitions.
+@end itemize")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 13:23:01 GMT) Full text and rfc822 format available.

Message #32 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Gabriel Hondet <gabrielhondet <at> gmail.com>,33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 16:22:02 +0300
Le 3 janvier 2019 10:18:32 GMT+03:00, Gabriel Hondet <gabrielhondet <at> gmail.com> a écrit :
>
>* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
>---
> gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
>diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
>index e4f17133d..bece14477 100644
>--- a/gnu/packages/ocaml.scm
>+++ b/gnu/packages/ocaml.scm
>@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional
>syntax for tuples and variants.
>yojson package.  The program @code{atdgen} can be used to derive
>OCaml-JSON
> serializers and deserializers from type definitions.")
>     (license license:bsd-3)))
>+
>+(define-public ocaml-sexplib0
>+  (package
>+    (name "ocaml-sexplib0")
>+    (version "0.11.0")
>+    (home-page "https://github.com/janestreet/sexplib0")
>+    (source
>+     (origin
>+       (method git-fetch)
>+       (uri (git-reference
>+             (url (string-append home-page ".git"))
>+             (commit (string-append "v" version))))
>+       (file-name (git-file-name name version))
>+       (sha256
>+        (base32
>+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
>+    (build-system dune-build-system)
>+    (arguments
>+     '(#:tests? #f))
>+    (synopsis "Library containing the definition of S-expressions and
>some
>+base converters")
>+    (description "Part of Jane Street's Core library The Core suite of
>+libraries is an industrial strength alternative to OCaml's standard
>library
>+that was developed by Jane Street, the largest industrial user of
>OCaml.")
>+(license license:expat)))

Hi Gabriel, thank you for these patches! I'll need a bit more time to review them because I'm travelling. We already have them, but I think they are only for ocaml-4.02.

In the meantime, could you add a comment to explain why you disabled tests whenever you did? It could be as short as "; no tests". Also, do you know what happened with the versionning?




Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 16:38:01 GMT) Full text and rfc822 format available.

Message #35 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 17:36:56 +0100
[Message part 1 (text/plain, inline)]
On Sat 05 Jan 2019 at 14:22 Julien Lepiller wrote:

> We already have them, but I think they are only for ocaml-4.02.

Indeed they exist but only for ocaml-4.02, I hope doing new patches for
the current version was the right thing to do.

> In the meantime, could you add a comment to explain why you disabled tests whenever you did? It could be as short as "; no tests". Also, do you know what happened with the versionning?

Regarding the test, I only disabled them if they don't exist.  I have
added comments to clarify that.  Regarding the versioning number
(113.33.xx in 2016 to 0.9.0 in 2017...), I have no idea what happened.

Here is the first patch, the others are following.

* gnu/packages/ocaml.scm (ocaml-sexplib0): New variable.
---
 gnu/packages/ocaml.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index e4f17133d..a23f6a724 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5105,3 +5105,28 @@ speedup, polymorphic variants and optional syntax for tuples and variants.
 yojson package.  The program @code{atdgen} can be used to derive OCaml-JSON
 serializers and deserializers from type definitions.")
     (license license:bsd-3)))
+
+(define-public ocaml-sexplib0
+  (package
+    (name "ocaml-sexplib0")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/sexplib0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "07v3ggyss7xhfv14bjk1n87sr42iqwj4cgjiv2lcdfkqk49i2bmi"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Library containing the definition of S-expressions and some
+base converters")
+    (description "Part of Jane Street's Core library The Core suite of
+libraries is an industrial strength alternative to OCaml's standard library
+that was developed by Jane Street, the largest industrial user of OCaml.")
+(license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 16:39:02 GMT) Full text and rfc822 format available.

Message #38 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 5/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 17:38:15 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-compiler-libs): New variable.
---
 gnu/packages/ocaml.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index c52cd76a3..820e87f22 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5247,3 +5247,26 @@ provided by companion libraries such as
 @url{https://github.com/janestreet/stdio, stdio}.")
   (license license:expat)))
 
+(define-public ocaml-compiler-libs
+  (package
+    (name "ocaml-compiler-libs")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/ocaml-compiler-libs")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "03jds7bszh8wwpfwxb3dg0gyr1j1872wxwx1xqhry5ir0i84bg0s"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Compiler libraries repackaged")
+    (description "This packaeg simply repackages the OCaml compiler libraries
+so they don't expose everything at toplevel.  For instance, @code{Ast_helper}
+is now @code{Ocaml_common.Ast_helper}.")
+    (license license:expat)))
-- 
2.20.1

[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 16:40:02 GMT) Full text and rfc822 format available.

Message #41 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 7/9] gnu: Add ocaml-sexplib0.
Date: Sat, 05 Jan 2019 17:39:41 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-stdio): New variable.
---
 gnu/packages/ocaml.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index bce2f4f13..dddad4f33 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5300,3 +5300,31 @@ Supported versions are 4.02, 4.03, 4.04, 4.05 and 4.06.  For each version,
 there is a snapshot of the parsetree and conversion functions to the next
 and/or previous version.")
     (license license:lgpl2.1+)))
+
+(define-public ocaml-stdio
+  (package
+    (name "ocaml-stdio")
+    (version "0.11.0")
+    (home-page "https://github.com/janestreet/stdio")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1facajqhvq34g2wrg368y0ajxd6lrj5b3lyzyj0jhdmraxajjcwn"))))
+    (build-system dune-build-system)
+    (inputs `(("ocaml-base" ,ocaml-base)
+              ("ocaml-sexplib0" ,ocaml-sexplib0)))
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Standard IO library for OCaml")
+    (description
+     "Stdio implements simple input/output functionalities for OCaml.
+
+It re-exports the input/output functions of the OCaml standard
+libraries using a more consistent API.")
+    (license license:expat)))
-- 
2.20.1
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33986; Package guix-patches. (Sat, 05 Jan 2019 16:45:01 GMT) Full text and rfc822 format available.

Message #44 received at 33986 <at> debbugs.gnu.org (full text, mbox):

From: Gabriel Hondet <gabrielhondet <at> gmail.com>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 33986 <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 8/9] gnu: Add ocaml-ppx-derivers.
Date: Sat, 05 Jan 2019 17:44:30 +0100
[Message part 1 (text/plain, inline)]
* gnu/packages/ocaml.scm (ocaml-ppx-derivers): New variable.
---
 gnu/packages/ocaml.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm
index dddad4f33..04b6dea8f 100644
--- a/gnu/packages/ocaml.scm
+++ b/gnu/packages/ocaml.scm
@@ -5328,3 +5328,29 @@ and/or previous version.")
 It re-exports the input/output functions of the OCaml standard
 libraries using a more consistent API.")
     (license license:expat)))
+
+(define-public ocaml-ppx-derivers
+  (package
+    (name "ocaml-ppx-derivers")
+    (version "1.2")
+    (home-page
+     "https://github.com/ocaml-ppx/ppx_derivers")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url (string-append home-page ".git"))
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0bnhihl1w31as5w2czly1v3d6pbir9inmgsjg2cj6aaj9v1dzd85"))))
+    (build-system dune-build-system)
+    (arguments
+     '(#:tests? #f)) ;no tests
+    (synopsis "Shared [@@deriving] plugin registry")
+    (description
+     "Ppx_derivers is a tiny package whose sole purpose is to allow
+ppx_deriving and ppx_type_conv to inter-operate gracefully when linked
+as part of the same ocaml-migrate-parsetree driver.")
+    (license license:bsd-3)))
-- 
2.20.1

This is the last one.  And forgive me for the misleading subjects of the
previous patches, it should have been
+ Re: [bug#33986] [PATCH 5/9] gnu: Add ocaml-compiler-libs
+ Re: [bug#33986] [PATCH 7/9] gnu: Add ocaml-stdio
  
Thank you!
Gabriel
[signature.asc (application/pgp-signature, inline)]

Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Wed, 16 Jan 2019 19:12:01 GMT) Full text and rfc822 format available.

Notification sent to Gabriel Hondet <gabrielhondet <at> gmail.com>:
bug acknowledged by developer. (Wed, 16 Jan 2019 19:12:02 GMT) Full text and rfc822 format available.

Message #49 received at 33986-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 33986-done <at> debbugs.gnu.org
Subject: Re: [bug#33986] [PATCH 1/9] gnu: Add ocaml-sexplib0.
Date: Wed, 16 Jan 2019 20:11:29 +0100
[Message part 1 (text/plain, inline)]
Finally pushed as a41bca08e27da0d4db176c8fadf21e278af4a2b6 -
4d390cad2510797a68f473db347699e748c92e42.

Sorry for taking so long! I've removed ocaml-parsetree-migrate because
it was already present in guix. I've also slightly modified the
descriptions (adding a dot or making the first sentence a full sentence
in some packages). Otherwise, they were very good, thank you!
[Message part 2 (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 14 Feb 2019 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 66 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.