GNU bug report logs -
#33989
27.0.50; master: Tcl indentation broken
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33989 in the body.
You can then email your comments to 33989 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Sat, 05 Jan 2019 17:20:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Sat, 05 Jan 2019 17:20:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
indentation of Tcl code for me outside of procs. Consider:
fooBaz {
|
}
Where the | indicates the expected indentation. But on current master
pressing TAB instead goes to the beginning of the line. Given that it
is common in Tcl to have code on the global level of a script, this is
not what I expect and want.
Reproduced with current master and "emacs -Q".
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Sat, 05 Jan 2019 18:12:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 33989 <at> debbugs.gnu.org (full text, mbox):
> From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
> Date: Sat, 05 Jan 2019 18:19:11 +0100
>
> Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> indentation of Tcl code for me outside of procs. Consider:
>
> fooBaz {
> |
> }
>
> Where the | indicates the expected indentation. But on current master
> pressing TAB instead goes to the beginning of the line. Given that it
> is common in Tcl to have code on the global level of a script, this is
> not what I expect and want.
>
> Reproduced with current master and "emacs -Q".
Thanks, I'm CC'ing Tom who made those changes.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Sat, 12 Jan 2019 11:45:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 33989 <at> debbugs.gnu.org (full text, mbox):
> Date: Sat, 05 Jan 2019 20:10:40 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 33989 <at> debbugs.gnu.org
Ping! Tom, could you please look at this issue?
> > From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
> > Date: Sat, 05 Jan 2019 18:19:11 +0100
> >
> > Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> > indentation of Tcl code for me outside of procs. Consider:
> >
> > fooBaz {
> > |
> > }
> >
> > Where the | indicates the expected indentation. But on current master
> > pressing TAB instead goes to the beginning of the line. Given that it
> > is common in Tcl to have code on the global level of a script, this is
> > not what I expect and want.
> >
> > Reproduced with current master and "emacs -Q".
>
> Thanks, I'm CC'ing Tom who made those changes.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Tue, 15 Jan 2019 21:43:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 33989 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Attaching a patch with a simple test-case.
[0001-tcl-mode-Add-a-test-for-top-level-indentation.patch (text/x-diff, inline)]
From 65e830aa45fc61536c3aec4af70cb0a58538519a Mon Sep 17 00:00:00 2001
From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
Date: Sat, 12 Jan 2019 15:42:35 +0100
Subject: [PATCH] tcl-mode: Add a test for top level indentation
* test/lisp/progmodes/tcl-tests.el (tcl-mode-global-indent): Add.
---
test/lisp/progmodes/tcl-tests.el | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/test/lisp/progmodes/tcl-tests.el b/test/lisp/progmodes/tcl-tests.el
index 50c3eba75d..b145244a63 100644
--- a/test/lisp/progmodes/tcl-tests.el
+++ b/test/lisp/progmodes/tcl-tests.el
@@ -72,6 +72,15 @@
(indent-region (point-min) (point-max))
(should (equal (buffer-string) text)))))
+;; Reproduce bug#33989
+(ert-deftest tcl-mode-global-indent ()
+ (with-temp-buffer
+ (tcl-mode)
+ (let ((text "fooBar {\n inside\n}\n"))
+ (insert text)
+ (indent-region (point-min) (point-max))
+ (should (equal (buffer-string) text)))))
+
(provide 'tcl-tests)
;;; tcl-tests.el ends here
--
2.11.0
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Sat, 19 Jan 2019 07:35:01 GMT)
Full text and
rfc822 format available.
Message #17 received at 33989 <at> debbugs.gnu.org (full text, mbox):
Ping! Ping! Thom, could you please look at this?
> Date: Sat, 12 Jan 2019 13:43:57 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
>
> > Date: Sat, 05 Jan 2019 20:10:40 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Cc: 33989 <at> debbugs.gnu.org
>
> Ping! Tom, could you please look at this issue?
>
> > > From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
> > > Date: Sat, 05 Jan 2019 18:19:11 +0100
> > >
> > > Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> > > indentation of Tcl code for me outside of procs. Consider:
> > >
> > > fooBaz {
> > > |
> > > }
> > >
> > > Where the | indicates the expected indentation. But on current master
> > > pressing TAB instead goes to the beginning of the line. Given that it
> > > is common in Tcl to have code on the global level of a script, this is
> > > not what I expect and want.
> > >
> > > Reproduced with current master and "emacs -Q".
> >
> > Thanks, I'm CC'ing Tom who made those changes.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Fri, 25 Jan 2019 08:11:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 33989 <at> debbugs.gnu.org (full text, mbox):
Ping! Ping! Ping! Tom, please look into this problem.
> Date: Sat, 19 Jan 2019 09:34:17 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
>
> Ping! Ping! Thom, could you please look at this?
>
> > Date: Sat, 12 Jan 2019 13:43:57 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
> >
> > > Date: Sat, 05 Jan 2019 20:10:40 +0200
> > > From: Eli Zaretskii <eliz <at> gnu.org>
> > > Cc: 33989 <at> debbugs.gnu.org
> >
> > Ping! Tom, could you please look at this issue?
> >
> > > > From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
> > > > Date: Sat, 05 Jan 2019 18:19:11 +0100
> > > >
> > > > Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> > > > indentation of Tcl code for me outside of procs. Consider:
> > > >
> > > > fooBaz {
> > > > |
> > > > }
> > > >
> > > > Where the | indicates the expected indentation. But on current master
> > > > pressing TAB instead goes to the beginning of the line. Given that it
> > > > is common in Tcl to have code on the global level of a script, this is
> > > > not what I expect and want.
> > > >
> > > > Reproduced with current master and "emacs -Q".
> > >
> > > Thanks, I'm CC'ing Tom who made those changes.
>
>
>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Fri, 01 Feb 2019 09:31:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 33989 <at> debbugs.gnu.org (full text, mbox):
Ping! Ping! Ping! Ping! Tom, could you please look at this issue?
> Date: Fri, 25 Jan 2019 10:10:09 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
>
> Ping! Ping! Ping! Tom, please look into this problem.
>
> > Date: Sat, 19 Jan 2019 09:34:17 +0200
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
> >
> > Ping! Ping! Thom, could you please look at this?
> >
> > > Date: Sat, 12 Jan 2019 13:43:57 +0200
> > > From: Eli Zaretskii <eliz <at> gnu.org>
> > > Cc: 33989 <at> debbugs.gnu.org, b.riefenstahl <at> turtle-trading.net
> > >
> > > > Date: Sat, 05 Jan 2019 20:10:40 +0200
> > > > From: Eli Zaretskii <eliz <at> gnu.org>
> > > > Cc: 33989 <at> debbugs.gnu.org
> > >
> > > Ping! Tom, could you please look at this issue?
> > >
> > > > > From: Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
> > > > > Date: Sat, 05 Jan 2019 18:19:11 +0100
> > > > >
> > > > > Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> > > > > indentation of Tcl code for me outside of procs. Consider:
> > > > >
> > > > > fooBaz {
> > > > > |
> > > > > }
> > > > >
> > > > > Where the | indicates the expected indentation. But on current master
> > > > > pressing TAB instead goes to the beginning of the line. Given that it
> > > > > is common in Tcl to have code on the global level of a script, this is
> > > > > not what I expect and want.
> > > > >
> > > > > Reproduced with current master and "emacs -Q".
> > > >
> > > > Thanks, I'm CC'ing Tom who made those changes.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Wed, 26 Aug 2020 11:35:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 33989 <at> debbugs.gnu.org (full text, mbox):
Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net> writes:
> Commit cd5bb4bf3d "Fix two tcl-mode defun-related bugs" breaks
> indentation of Tcl code for me outside of procs. Consider:
>
> fooBaz {
> |
> }
This was apparently fixed by:
commit 518ff50f7a245f437576c5f7e716be9cba336287
Author: Rolf Ade <rolf <at> pointsman.de>
AuthorDate: Sun Oct 13 05:18:36 2019 +0200
Commit: Lars Ingebrigtsen <larsi <at> gnus.org>
CommitDate: Sun Oct 13 05:18:36 2019 +0200
TCL indentation fix outside functions
* lisp/progmodes/tcl.el (tcl-calculate-indent): Indent code
correctly outside of function definitions (bug#23565).
I'm unable to reproduce the bug in the included test case, at least, so
I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug closed, send any further explanations to
33989 <at> debbugs.gnu.org and Benjamin Riefenstahl <b.riefenstahl <at> turtle-trading.net>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Wed, 26 Aug 2020 11:35:03 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#33989
; Package
emacs
.
(Sun, 30 Aug 2020 12:21:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 33989 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen writes:
> This was apparently fixed by:
Thanks, looks good.
benny
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 28 Sep 2020 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 210 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.