GNU bug report logs - #34000
[PATCH] gnu: Separate youtube-viewer-cli from youtube-viewer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34000 in the body.
You can then email your comments to 34000 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <at> riseup.net
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Separate youtube-viewer-cli from youtube-viewer
Date: Sun, 06 Jan 2019 13:29:19 -0800

[Message part 1 (text/plain, inline)]

-- 
Cheers 
Swedebugia

[0001-gnu-Separate-youtube-viewer-cli-from-youtube-viewer.patch (text/x-diff, attachment)]

[0002-gnu-youtube-viewer-Rename-to-youtube-viewer-gtk.patch (text/x-diff, attachment)]

Message #8 received at 34000 <at> debbugs.gnu.org (full text, mbox):

From: swedebugia <at> riseup.net
To: 34000 <at> debbugs.gnu.org
Cc: Guix-patches <guix-patches-bounces+swedebugia=riseup.net <at> gnu.org>
Subject: Re: [bug#34000] [PATCH] gnu: Separate youtube-viewer-cli from
 youtube-viewer
Date: Sun, 06 Jan 2019 13:43:10 -0800

[Message part 1 (text/plain, inline)]

On 2019-01-06 21:29, swedebugia <at> riseup.net wrote:
> 

This is updated to fix a parens error.

-- 
Cheers 
Swedebugia

[0001-gnu-Separate-youtube-viewer-cli-from-youtube-viewer.patch (text/x-diff, attachment)]

[0002-gnu-youtube-viewer-Rename-to-youtube-viewer-gtk.patch (text/x-diff, attachment)]

Message #11 received at 34000 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: swedebugia <at> riseup.net
Cc: 34000 <at> debbugs.gnu.org
Subject: Re: [bug#34000] [PATCH] gnu: Separate youtube-viewer-cli from
 youtube-viewer
Date: Mon, 7 Jan 2019 09:16:28 -0600

[Message part 1 (text/plain, inline)]

On Sun, 06 Jan 2019 13:29:19 -0800
swedebugia <at> riseup.net wrote:

> * gnu/packages/video.scm (youtube-viewer-cli): New variable.
> ---
>  gnu/packages/video.scm | 62 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
...
> Subject: [PATCH 2/2] gnu: youtube-viewer: Rename to youtube-viewer-gtk
> 
> * gnu/packages/video.scm (youtube-viewer):
>   [name] Rename it.
>   [arguments] Add phase to rename the binary.

I think renaming binaries is too much of a divergence from upstream.
This can only cause confusion to users coming to Guix from another
distro that use the upstream binary names, and is unlikely to be
adopted upstream:

  https://github.com/trizen/youtube-viewer/issues/230

If the desire is to create a slimmer cli-only package, would creating
another output not work?

`~Eric

[Message part 2 (application/pgp-signature, inline)]

Message #14 received at 34000 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: swedebugia <at> riseup.net
Cc: 34000 <at> debbugs.gnu.org
Subject: Re: [bug#34000] [PATCH] gnu: Separate youtube-viewer-cli from
 youtube-viewer, [PATCH 1/2] gnu: Separate youtube-viewer-cli from
 youtube-viewer., [PATCH 2/2] gnu: youtube-viewer: Rename to
 youtube-viewer-gtk
Date: Mon, 01 Sep 2025 17:24:13 +0200

Hi,

On Sun, 06 Jan 2019 at 13:29, swedebugia <at> riseup.net wrote:

> +(define-public youtube-viewer-cli

Duplicate with 6f45e45d4daf1d336b22ecef8b1d304fe46ba586, I guess.

> +  (package
> +    (name "youtube-viewer-cli")
> +    (version "3.4.1")

BTW, master contains 3.8.1.

Therefore, closing.

Feel free to reopen if I’m missing something.


Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.