GNU bug report logs - #34025
[PATCH] Update meson to 0.49.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34025 in the body.
You can then email your comments to 34025 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stuart Dilts <stuart.dilts <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] Update meson to 0.49.0
Date: Wed, 9 Jan 2019 15:50:58 -0700

[Message part 1 (text/plain, inline)]

* gnu/packages/build-tools.scm: update the version and sha256 hash
---
 gnu/packages/build-tools.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index a34e7eb..628b36f 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -158,7 +158,7 @@ files and generates build instructions for the Ninja
build system.")
 (define-public meson
   (package
     (name "meson")
-    (version "0.47.2")
+    (version "0.49.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/mesonbuild/meson/"
@@ -166,7 +166,7 @@ files and generates build instructions for the Ninja
build system.")
                                   version ".tar.gz"))
               (sha256
                (base32
-                "1swmycf6p9p0ag6yiywyyri42ffkxxj38r2ic7in24km47cszn4j"))))
+                "0l8m1v7cl5ybm7psfqmmdqbvmnsbb1qhb8ni3hwap3i0mk29a0zv"))))
     (build-system python-build-system)
     (arguments
      `(;; FIXME: Tests require many additional inputs, a fix for the
RUNPATH
-- 
2.20.1

[Message part 2 (text/html, inline)]

Message #10 received at 34025-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Stuart Dilts <stuart.dilts <at> gmail.com>
Cc: 34025-done <at> debbugs.gnu.org
Subject: Re: [bug#34025] [PATCH] Update meson to 0.49.0
Date: Wed, 9 Jan 2019 20:02:47 -0500

[Message part 1 (text/plain, inline)]

On Wed, Jan 09, 2019 at 03:50:58PM -0700, Stuart Dilts wrote:
> * gnu/packages/build-tools.scm: update the version and sha256 hash

Thank you for sending this patch!

We actually already have this change on the 'staging' branch [0], in commit
f06fdbae8d6318fdabf9c1eb686e2bfa2b9ff18a.

Updating meson will trigger a rebuild of all the packages that use the
meson-build-system.

I'm not sure how to find out exactly how many packages directly and
indirectly depend on the meson-build-system, but since the change was
pushed to the staging branch, it's probably more than 300, which is the
limit for changes on the master branch.

The manual section Submitting Patches describes the guidelines for how
many rebuilds are acceptable on the master, staging, and core-updates
branches:

https://www.gnu.org/software/guix/manual/en/html_node/Submitting-Patches.html

[0] https://git.savannah.gnu.org/cgit/guix.git/log/?h=staging

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 34025 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 34025 <at> debbugs.gnu.org, leo <at> famulari.name, stuart.dilts <at> gmail.com
Subject: Re: bug#34025: [PATCH] Update meson to 0.49.0
Date: Thu, 10 Jan 2019 09:24:27 +0200

[Message part 1 (text/plain, inline)]

On Wed, Jan 09, 2019 at 08:02:47PM -0500, Leo Famulari wrote:
> On Wed, Jan 09, 2019 at 03:50:58PM -0700, Stuart Dilts wrote:
> > * gnu/packages/build-tools.scm: update the version and sha256 hash
> 
> Thank you for sending this patch!
> 
> We actually already have this change on the 'staging' branch [0], in commit
> f06fdbae8d6318fdabf9c1eb686e2bfa2b9ff18a.
> 
> Updating meson will trigger a rebuild of all the packages that use the
> meson-build-system.
> 
> I'm not sure how to find out exactly how many packages directly and
> indirectly depend on the meson-build-system, but since the change was
> pushed to the staging branch, it's probably more than 300, which is the
> limit for changes on the master branch.
> 

guix refresh -l -e '(@@ (gnu packages build-tools) meson-for-build)'

another one that I've triggered accidentally is libva


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 34025 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: stuart.dilts <at> gmail.com, 34025 <at> debbugs.gnu.org
Subject: Re: bug#34025: [PATCH] Update meson to 0.49.0
Date: Thu, 10 Jan 2019 15:22:02 -0500

[Message part 1 (text/plain, inline)]

On Thu, Jan 10, 2019 at 09:24:27AM +0200, Efraim Flashner wrote:
> On Wed, Jan 09, 2019 at 08:02:47PM -0500, Leo Famulari wrote:
> > On Wed, Jan 09, 2019 at 03:50:58PM -0700, Stuart Dilts wrote:
> > > * gnu/packages/build-tools.scm: update the version and sha256 hash
> > 
> > Thank you for sending this patch!
> > 
> > We actually already have this change on the 'staging' branch [0], in commit
> > f06fdbae8d6318fdabf9c1eb686e2bfa2b9ff18a.
> > 
> > Updating meson will trigger a rebuild of all the packages that use the
> > meson-build-system.
> > 
> > I'm not sure how to find out exactly how many packages directly and
> > indirectly depend on the meson-build-system, but since the change was
> > pushed to the staging branch, it's probably more than 300, which is the
> > limit for changes on the master branch.
> > 
> 
> guix refresh -l -e '(@@ (gnu packages build-tools) meson-for-build)'
> 
> another one that I've triggered accidentally is libva

Oh... I missed this package :)

So, Stuart, can you send a revised patch that updates the 'meson'
package while keeping 'meson-for-build' at 0.47.2?

The trick is to make the new meson available without having to rebuild
the Guix packages that use meson-for-build.

Concretely, you'd need to add a 'version' field to meson-for-build to
keep it at 0.47.2, and to add 'uri', and 'sha256' fields so that it
uses the correct source code.

You can check that meson-for-build is unchanged by comparing the
derivations before and after your modifications:

$ ./pre-inst-env guix build -d -e '(@@ (gnu packages build-tools) meson-for-build)'
/gnu/store/l5vlmc040fz2zmnb45vhbqhs6pi7iw6v-meson-for-build-0.47.2.drv

Because meson-for-build is a hidden package, you need to specify it with
that Scheme expression.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.