GNU bug report logs - #34065
26.1; Make edebug-eval-expression support code completion

Previous Next

Package: emacs;

Reported by: Xu Chunyang <mail <at> xuchunyang.me>

Date: Mon, 14 Jan 2019 09:12:02 UTC

Severity: wishlist

Tags: patch

Found in version 26.1

Fixed in version 27.1

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 34065 in the body.
You can then email your comments to 34065 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#34065; Package emacs. (Mon, 14 Jan 2019 09:12:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Xu Chunyang <mail <at> xuchunyang.me>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 14 Jan 2019 09:12:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xu Chunyang <mail <at> xuchunyang.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; Make edebug-eval-expression support code completion
Date: Mon, 14 Jan 2019 17:08:50 +0800
When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike
M-: (eval-expression). So I wonder if edebug-eval-expression can behave
like eval-expression, I guess simply replacing read-from-minibuffer with
read--expression should work, though I've not tried.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34065; Package emacs. (Sun, 20 Jan 2019 02:16:02 GMT) Full text and rfc822 format available.

Message #8 received at 34065 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: Xu Chunyang <mail <at> xuchunyang.me>, 34065 <at> debbugs.gnu.org
Subject: Re: bug#34065: 26.1;
 Make edebug-eval-expression support code completion
Date: Sat, 19 Jan 2019 23:14:55 -0300
[Message part 1 (text/plain, inline)]
Xu Chunyang <mail <at> xuchunyang.me> writes:

> When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike
> M-: (eval-expression). So I wonder if edebug-eval-expression can behave
> like eval-expression, I guess simply replacing read-from-minibuffer with
> read--expression should work, though I've not tried.

I've created a small patch which replaces `read-from-minibuffer' for
`read--expression' in `edebug-eval-expression'. I would appreciate it if
a maintainer could take a quick look.

[edebug.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34065; Package emacs. (Wed, 20 Feb 2019 04:39:01 GMT) Full text and rfc822 format available.

Message #11 received at 34065 <at> debbugs.gnu.org (full text, mbox):

From: mail <at> xuchunyang.me
To: Federico Tedin <federicotedin <at> gmail.com>,
 "34065 <at> debbugs.gnu.org" <34065 <at> debbugs.gnu.org>
Subject: Re: bug#34065: 26.1;
 Make edebug-eval-expression support code completion
Date: Wed, 20 Feb 2019 12:37:53 +0800

20.01.2019, 10:15, "Federico Tedin" <federicotedin <at> gmail.com>:
> Xu Chunyang <mail <at> xuchunyang.me> writes:
>
>>  When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike
>>  M-: (eval-expression). So I wonder if edebug-eval-expression can behave
>>  like eval-expression, I guess simply replacing read-from-minibuffer with
>>  read--expression should work, though I've not tried.
>
> I've created a small patch which replaces `read-from-minibuffer' for
> `read--expression' in `edebug-eval-expression'. I would appreciate it if
> a maintainer could take a quick look.

I'm not a maintainer. Your patch looks good to me. Today I notice it's possible to change the interactive form via Advising Functions, so I plan to put the following to my init file until the patch is applied.

(define-advice edebug-eval-expression (:before (_expr) better-interactive-form)
  "Fix the original interactive form."
  (interactive (list (read--expression "Edebug Eval: "))))




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34065; Package emacs. (Tue, 12 Mar 2019 23:15:02 GMT) Full text and rfc822 format available.

Message #14 received at 34065 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: mail <at> xuchunyang.me
Cc: "34065 <at> debbugs.gnu.org" <34065 <at> debbugs.gnu.org>
Subject: Re: bug#34065: 26.1;
 Make edebug-eval-expression support code completion
Date: Tue, 12 Mar 2019 20:14:46 -0300
[Message part 1 (text/plain, inline)]
> I'm not a maintainer. Your patch looks good to me. Today I notice it's
> possible to change the interactive form via Advising Functions, so I
> plan to put the following to my init file until the patch is applied.
>
> (define-advice edebug-eval-expression (:before (_expr) better-interactive-form)
>   "Fix the original interactive form."
>   (interactive (list (read--expression "Edebug Eval: "))))

Great! I'm attaching a more complete patch with a ChangeLog-style
message. If a maintainer doesn't pick it up after some days, I'll try
messaging emacs-devel.

[edebug.patch (text/x-diff, attachment)]

Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Fri, 22 Mar 2019 04:03:01 GMT) Full text and rfc822 format available.

Notification sent to Xu Chunyang <mail <at> xuchunyang.me>:
bug acknowledged by developer. (Fri, 22 Mar 2019 04:03:01 GMT) Full text and rfc822 format available.

Message #19 received at 34065-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Federico Tedin <federicotedin <at> gmail.com>
Cc: mail <at> xuchunyang.me, monnier <at> iro.umontreal.ca
Subject: Re: bug#34065: 26.1;
 Make edebug-eval-expression support code completion
Date: Fri, 22 Mar 2019 00:02:38 -0400
Version:27.1

> Great! I'm attaching a more complete patch with a ChangeLog-style
> message.

¡Che!  ¡Gracias!
Pushed to `master`,


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#34065; Package emacs. (Fri, 22 Mar 2019 21:26:02 GMT) Full text and rfc822 format available.

Message #22 received at 34065 <at> debbugs.gnu.org (full text, mbox):

From: Federico Tedin <federicotedin <at> gmail.com>
To: 34065 <at> debbugs.gnu.org
Cc: monnier <at> iro.umontreal.ca
Subject: Re: bug#34065: 26.1;
 Make edebug-eval-expression support code completion
Date: Fri, 22 Mar 2019 18:25:12 -0300
Thank you for merging this, Stefan! (and the other patch as well)




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 20 Apr 2019 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 344 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.