GNU logs - #34076, boring messages

Message sent to bug-libtool@HIDDEN:

Subject: bug#34076: Patch to libtool for solaris 11.4 link-editor which rejects -pthread option
Resent-From: "Stacey Marshall" <stacey.marshall@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-libtool@HIDDEN
Resent-Date: Mon, 14 Jan 2019 15:02:02 +0000
Resent-Message-ID: <handler.34076.B.154747809924404 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 34076 <at> debbugs.gnu.org
From: "Stacey Marshall" <stacey.marshall@HIDDEN>
Date: Mon, 14 Jan 2019 14:35:44 +0000
Message-ID: <9BCD209C-EB5D-4E1D-B8F9-0A20D8991D79@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="=_MailMate_436AD6D0-D11D-4D3E-ADEE-414BE32F2109_="
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>


--=_MailMate_436AD6D0-D11D-4D3E-ADEE-414BE32F2109_=
Content-Type: text/plain; format=flowed; markup=markdown

Solaris 11.4 link-editor, ld(1), has been updated to reject options 
'-thread' and '-pthread'.

Details from Oracle Bug 22985199

> The GNU configuration process has been known to pass the
> options -thread and -pthread to ld(1), or to the compiler
> driver which will try and pass them to ld(1).
>
> ld(1) uses getopt(3c) processing.  The compilers take the
> options they know about and pass the others to ld(1).
>
> These options, which are specific to gcc, can result in
> silent errors:
>
> % ld -o null.so -G -thread null.o
> % elfdump -d null.so | fgrep SONAME
>     [0]  SONAME          0x5c    read
>
> The -t option is peeled off, being a valid ld(1) option,
> and the rest, '-h read' gets interpreted as an SONAME, which
> is probably not what the user expected.  If you tried to
> create an executable, you'd get an error, but it's not
> immediately obvious where the -h came from:
>
> % ld -o main -thread null.o
> ld: fatal: option '-h read' is incompatible with building \\
>     a dynamic executable
>
> With -pthread we get the same result when building a shared
> object or an executable:
>
> % ld -o null.so -G -pthread null.o
> % elfdump -d null.so | fgrep AUDIT
>      [0]  AUDIT           0x5c    thread
>
> The -p is peeled off, and its optarg used to define an auditor.
> Again, probably not what the user wanted.
>
> The Studio compilers can behave slightly differently in that
> they can affect the options passed to ld(1):  For example
>
> % cc -o null.so -G -thread null.o
>
> results in ld(1) seeing distinct options '-t -hread'.
>
> Given these are "bad" options to ld(1), it would be helpful
> to our Userland developers if ld(1) could recognize them
> rather than falling through to getopt() processing, where the
> options are mis-interpreted and "might" result in an error
> depending on the output file being produced.

Following patch prevents '-pthread' from being passed to ld on solaris2 
hosts.

     libtool should not pass option '-pthread' to Solaris link-editor.
     diff --git a/build-aux/ltmain.sh b/build-aux/ltmain.sh
     index 0f0a2da3f9..7c8bcfd9d2 100644
     --- a/build-aux/ltmain.sh
     +++ b/build-aux/ltmain.sh
     @@ -7070,7 +7070,21 @@ func_mode_link ()
     	continue
     	;;

     -      
-mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe \
     +      # Solaris ld rejects as of 11.4.  Refer to Oracle bug 
22985199.
     +      -pthread)
     +	  case $host in
     +              *solaris2*) ;;
     +              *)
     +		  case "$new_inherited_linker_flags " in
     +                      *" $arg "*) ;;
     +                      * ) func_append new_inherited_linker_flags " 
$arg" ;;
     +		  esac
     + 		  ;;
     +	  esac
     + 	  continue
     +	  ;;
     +
     +      -mt|-mthreads|-kthread|-Kthread|-pthreads|--thread-safe \
            |-threads|-fopenmp|-openmp|-mp|-xopenmp|-omp|-qsmp=*)
     	func_append compiler_flags " $arg"
     	func_append compile_command " $arg"



Mr. Stacey Marshall - Principal Software Engineer - Oracle UK
Oracle Systems, SPARC & Solaris System Software Engineering.
stacey.marshall@HIDDEN


--=_MailMate_436AD6D0-D11D-4D3E-ADEE-414BE32F2109_=
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"=
>
<style>
div.markdown { white-space: normal; }
body { font-family: sans-serif; }
h1 { font-size: 1.4em; }
h2 { font-size: 1.2em; }
h3 { font-size: 1.1em; }
blockquote { margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #=
3983C4; color: #3983C4; }
blockquote blockquote { border-left-color: #7CBF0C; color: #7CBF0C; }
@media (prefers-color-scheme: dark) { a { color: #136BCE; }
}
pre { margin-left: 15px; margin-right: 15px; padding: 5px; border: thin s=
olid gray; overflow-x: auto; max-width: 90vw; }
div.footnotes li p { margin: 0.2em 0; }
</style>
</head>
<body>
<div class=3D"markdown">
<p dir=3D"auto">Solaris 11.4 link-editor, ld(1), has been updated to reje=
ct options '-thread' and '-pthread'.</p>

<p dir=3D"auto">Details from Oracle Bug 22985199</p>

<blockquote>
<p dir=3D"auto">The GNU configuration process has been known to pass the<=
br>
options -thread and -pthread to ld(1), or to the compiler<br>
driver which will try and pass them to ld(1).</p>

<p dir=3D"auto">ld(1) uses getopt(3c) processing.  The compilers take the=
<br>
options they know about and pass the others to ld(1).</p>

<p dir=3D"auto">These options, which are specific to gcc, can result in<b=
r>
silent errors:</p>

<p dir=3D"auto">% ld -o null.so -G -thread null.o<br>
% elfdump -d null.so | fgrep SONAME<br>
    [0]  SONAME          0x5c    read</p>

<p dir=3D"auto">The -t option is peeled off, being a valid ld(1) option,<=
br>
and the rest, '-h read' gets interpreted as an SONAME, which<br>
is probably not what the user expected.  If you tried to<br>
create an executable, you'd get an error, but it's not<br>
immediately obvious where the -h came from:</p>

<p dir=3D"auto">% ld -o main -thread null.o<br>
ld: fatal: option '-h read' is incompatible with building \<br>
    a dynamic executable</p>

<p dir=3D"auto">With -pthread we get the same result when building a shar=
ed<br>
object or an executable:</p>

<p dir=3D"auto">% ld -o null.so -G -pthread null.o<br>
% elfdump -d null.so | fgrep AUDIT<br>
     [0]  AUDIT           0x5c    thread</p>

<p dir=3D"auto">The -p is peeled off, and its optarg used to define an au=
ditor.<br>
Again, probably not what the user wanted.</p>

<p dir=3D"auto">The Studio compilers can behave slightly differently in t=
hat<br>
they can affect the options passed to ld(1):  For example</p>

<p dir=3D"auto">% cc -o null.so -G -thread null.o</p>

<p dir=3D"auto">results in ld(1) seeing distinct options '-t -hread'.</p>=


<p dir=3D"auto">Given these are "bad" options to ld(1), it would be helpf=
ul<br>
to our Userland developers if ld(1) could recognize them<br>
rather than falling through to getopt() processing, where the<br>
options are mis-interpreted and "might" result in an error<br>
depending on the output file being produced.</p>
</blockquote>

<p dir=3D"auto">Following patch prevents '-pthread' from being passed to =
ld on solaris2 hosts.</p>

<pre><code>libtool should not pass option '-pthread' to Solaris link-edit=
or.
diff --git a/build-aux/ltmain.sh b/build-aux/ltmain.sh
index 0f0a2da3f9..7c8bcfd9d2 100644
--- a/build-aux/ltmain.sh
+++ b/build-aux/ltmain.sh
@@ -7070,7 +7070,21 @@ func_mode_link ()
    continue
    ;;

-      -mt|-mthreads|-kthread|-Kthread|-pthread|-pthreads|--thread-safe \=

+      # Solaris ld rejects as of 11.4.  Refer to Oracle bug 22985199.
+      -pthread)
+      case $host in
+              *solaris2*) ;;
+              *)
+          case "$new_inherited_linker_flags " in
+                      *" $arg "*) ;;
+                      * ) func_append new_inherited_linker_flags " $arg"=
 ;;
+          esac
+           ;;
+      esac
+       continue
+      ;;
+
+      -mt|-mthreads|-kthread|-Kthread|-pthreads|--thread-safe \
       |-threads|-fopenmp|-openmp|-mp|-xopenmp|-omp|-qsmp=3D*)
    func_append compiler_flags " $arg"
    func_append compile_command " $arg"
</code></pre>

<p dir=3D"auto">Mr. Stacey Marshall - Principal Software Engineer - Oracl=
e UK<br>
Oracle Systems, SPARC &amp; Solaris System Software Engineering.<br>
<a href=3D"mailto:stacey.marshall@HIDDEN">stacey.marshall@HIDDEN<=
/a></p>
</div>

</body>
</html>

--=_MailMate_436AD6D0-D11D-4D3E-ADEE-414BE32F2109_=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: "Stacey Marshall" <stacey.marshall@HIDDEN>
Subject: bug#34076: Acknowledgement (Patch to libtool for solaris 11.4
 link-editor which rejects -pthread option)
Message-ID: <handler.34076.B.154747809924404.ack <at> debbugs.gnu.org>
References: <9BCD209C-EB5D-4E1D-B8F9-0A20D8991D79@HIDDEN>
X-Gnu-PR-Message: ack 34076
X-Gnu-PR-Package: libtool
Reply-To: 34076 <at> debbugs.gnu.org
Date: Mon, 14 Jan 2019 15:02:04 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-libtool@HIDDEN

If you wish to submit further information on this problem, please
send it to 34076 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
34076: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D34076
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Last modified: Mon, 25 Nov 2019 12:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.