Received: (at 34080) by debbugs.gnu.org; 9 Jul 2025 10:40:20 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jul 09 06:40:20 2025 Received: from localhost ([127.0.0.1]:49080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uZSDr-0007lR-Sa for submit <at> debbugs.gnu.org; Wed, 09 Jul 2025 06:40:20 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:47932) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1uZSDn-0007hM-M3 for 34080 <at> debbugs.gnu.org; Wed, 09 Jul 2025 06:40:17 -0400 DKIM-Signature: a=rsa-sha256; b=k9hQDcowN/SsDFT0gC1vHcKgDJDbKQkbActfPHesAQ3vCVDCraA285frjuJaslhqV8pKOy+fg19UKhkQuCesTyO0vYo/VwzT6ZLVk+QzN+hbkiXyd4nsJH4cKkI8jWJ5Z5vESIPetubjyvHWWVzHVKC9BA1I9whdo2+Ytxg4YbbCMwUPaTfxJ9Y6AyBbAYCch9rgKGylqgnRF/Z0nhxfXB+3YSNN9/ATWcYbS81MnZ+gILMWpHrJiFk2NBkN2Hf4Cfx1cfLPBt9U76unLmGvk5n6jpZR/JtcqJ4Ln8HNIB/u8JuTKZK7+l78O0ourIGzmVYmw7r+qsvTFLr0fU/+3Q==; s=purelymail3; d=spwhitton.name; v=1; bh=WhYCl2pQsJF69owfC4Xvx6FLFlzz0bEW16jjt/YXdf0=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=mJFcVvjZ8OUyC5XT7Lsgdma/fX4TJOllpRed5NXGrQRvbchISh3sdhho9BXycXuEjIdJOBvrPHUOjMP/4zfboG7QX+jLvVvMoq+jP+c08jMkQ5i+Bjn6H1hBGhMTEBvFm5dOabSjynW64yn/xQIgIvJkavgXRLKBVK3P2GhlSjmsxLSero48xvKFKmXhGDJ6aNsOz00muZVok1RuqqKZL7GS+moZ48X2CsADG23vsxwryHOSuTimrRe6QDqC3o2sIhZV+mYroKX/GsFFJfZb9GC52DQovDY1HUyr+5sHqktVrHp1dud6SCDZXjF7Cte1NGbhz78m9ZvMl5/8N2BXhA==; s=purelymail3; d=purelymail.com; v=1; bh=WhYCl2pQsJF69owfC4Xvx6FLFlzz0bEW16jjt/YXdf0=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 34080 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 937849202; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 09 Jul 2025 10:40:08 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id CBC03941E0A; Wed, 09 Jul 2025 11:40:07 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* In-Reply-To: <jwvldoysgwf.fsf-monnier+emacs@HIDDEN> References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> <87o8luoxls.fsf@HIDDEN> <87sej6haay.fsf@HIDDEN> <jwvldoysgwf.fsf-monnier+emacs@HIDDEN> Date: Wed, 09 Jul 2025 11:40:07 +0100 Message-ID: <874ivlhcl4.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: Van L <van@HIDDEN>, 34080 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, On Tue 08 Jul 2025 at 02:08pm -04, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >> The reason for this is, I think, simple: C-h m describes the major >> mode's own map, diff-mode-map, but the TAB binding does not appear in >> that map. It's only in diff-mode-shared-map, the parent of >> diff-mode-map. > > `diff-mode-shared-map` is not a parent of `diff-mode-map`. > It's a parent of the ESC submap of `diff-mode-map`, and its bindings > appear just fine, e.g.: > > C-M-i diff-hunk-next > > `C-M-i` is another name for `M-TAB`. > >> We probably don't want C-h m to include bindings from the parents of >> major mode maps. > > We do, and AFAIK, it does. > >> But there is something about diff-mode-shared-map that I can't figure >> out. How do its bindings get overridden/deactivated in the case that >> the buffer is not read-only? > > `diff-mode-shared-map` is used as a minor-mode map, (de)activated > according to ``diff-mode-read-only`: > > (or (assq 'diff-mode-read-only minor-mode-map-alist) > (nconc minor-mode-map-alist > (list (cons 'diff-mode-read-only > (make-composed-keymap diff-mode-shared-map > special-mode-map))))) Thanks. I had missed - that diff-mode-shared-map is the parent of diff-minor-mode-map, not diff-mode-map, d'oh - that diff-minor-mode is the mechanism by which the keys are made available when the buffer is read only. What do you think about replacing activating a minor mode with just switching the major mode map? So far as I can tell the disadvantage would be repeating keymap definitions, and the advantage would be more standardised *Help* output. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 8 Jul 2025 18:51:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 08 14:51:16 2025
Received: from localhost ([127.0.0.1]:44811 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uZDPP-0006CO-3n
for submit <at> debbugs.gnu.org; Tue, 08 Jul 2025 14:51:16 -0400
Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:24904)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <monnier@HIDDEN>)
id 1uZCjx-0002lo-Fa
for 34080 <at> debbugs.gnu.org; Tue, 08 Jul 2025 14:08:26 -0400
Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5DC69808F6;
Tue, 8 Jul 2025 14:08:17 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca;
s=mail; t=1751998096;
bh=Nx1ylXPW8EaE0KyjRF6ZymBOGgYI1ALWAG/l7ju6VPw=;
h=From:To:Cc:Subject:In-Reply-To:References:Date:From;
b=ldWZQy3fY3GMuk54CbRrN5m4HUxalAyhY2mgPvRlYdxrpGltZcZIBQ5yPEDdHoqSd
XyT1ebFZuMx49uIC1ZdzP7PrZHqjIha7lY1dmAqDm8khB+A2OP940BjkUERJ2iAn38
ahjwEihwM6WcNVYdOM1VKnwGo/BPtiLtU83+uGYOA3sFlBY1605gFd6syQKtagJq78
7Y31Ouq0ntnmMGiQIwZqm2TLl3RZNQMrIGqZGyHHAchj0xZjhdlqQjBWFly/9Zpl3U
vSGf2i3GAAPV00N4uDYhiIaIY2xZ+anoBO19kMy3DWf9Py0+qC/pPb/Miawa1Pm39e
JQMXpFHJrpUtg==
Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1])
by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 85BD880977;
Tue, 8 Jul 2025 14:08:16 -0400 (EDT)
Received: from alfajor (unknown [23.233.149.155])
by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5805C12033F;
Tue, 8 Jul 2025 14:08:16 -0400 (EDT)
From: Stefan Monnier <monnier@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
In-Reply-To: <87sej6haay.fsf@HIDDEN>
Message-ID: <jwvldoysgwf.fsf-monnier+emacs@HIDDEN>
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
<87o8luoxls.fsf@HIDDEN> <87sej6haay.fsf@HIDDEN>
Date: Tue, 08 Jul 2025 14:08:15 -0400
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-SPAM-INFO: Spam detection results: 0
ALL_TRUSTED -1 Passed through trusted hosts only via SMTP
AWL -0.195 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DKIM_SIGNED 0.1 Message has a DKIM or DK signature,
not necessarily valid
DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature
DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's
domain
DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from
domain
X-SPAM-LEVEL:
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 34080
Cc: Van L <van@HIDDEN>, 34080 <at> debbugs.gnu.org,
Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> The reason for this is, I think, simple: C-h m describes the major
> mode's own map, diff-mode-map, but the TAB binding does not appear in
> that map. It's only in diff-mode-shared-map, the parent of
> diff-mode-map.
`diff-mode-shared-map` is not a parent of `diff-mode-map`.
It's a parent of the ESC submap of `diff-mode-map`, and its bindings
appear just fine, e.g.:
C-M-i diff-hunk-next
`C-M-i` is another name for `M-TAB`.
> We probably don't want C-h m to include bindings from the parents of
> major mode maps.
We do, and AFAIK, it does.
> But there is something about diff-mode-shared-map that I can't figure
> out. How do its bindings get overridden/deactivated in the case that
> the buffer is not read-only?
`diff-mode-shared-map` is used as a minor-mode map, (de)activated
according to ``diff-mode-read-only`:
(or (assq 'diff-mode-read-only minor-mode-map-alist)
(nconc minor-mode-map-alist
(list (cons 'diff-mode-read-only
(make-composed-keymap diff-mode-shared-map
special-mode-map)))))
- Stefan
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 8 Jul 2025 17:43:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jul 08 13:43:51 2025 Received: from localhost ([127.0.0.1]:44672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uZCM7-0000mX-4B for submit <at> debbugs.gnu.org; Tue, 08 Jul 2025 13:43:51 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:44592) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1uZBwV-00079o-HH for 34080 <at> debbugs.gnu.org; Tue, 08 Jul 2025 13:17:23 -0400 DKIM-Signature: a=rsa-sha256; b=s9DPoissSM3eEtJyn6bzZZsPjU+38k+VEq34N88H1TrzxO1fevKBaPKStAh+57xA1Mu6Y4t2z1NV/sL3W5e5bB3/3cncDQjD9xs0FxR2HJT63CjlMMSatjd8rl0TkkhV7tn7XO7ebmI/Jp7auvKAP46R5rxDhWsois9zfRlo7hQ5bkYY+gCN4VCS84rmleYuIr0743h0z0etGdQ4yVvMhloKXI6Mu6oeEpd0R21acJFAQt7JRttON99pH6KYddODrxtKQY70TlMbZXAWy8x95bef4QZyWhZ3yDc+3GUk+tqMUBX1foKghR6GJ+FOTeeYthBHdcwbha9sEFYQH3pHbw==; s=purelymail3; d=spwhitton.name; v=1; bh=l0BMAVH6pdL7QeljXhgleRWnnXefltLhtkkh9yhpQxI=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=JBzcCF4WVkl3wMuWi+SprD4XcG9qSU8Oc+AQE+dhvRowrJyjybzQGXthU4HZmp2RLepv9bXf7zuKl46uKmtgMH3G1Lue72PR2xTYZRHrzQgwbkHKzUOoTGX2VTdeOFxGQLvOkjeTwR5AJQE2fy1VhyyLkbdr3jMo7ZacOacQBKMAm6flXv4GMWDsoRLLUT/MU2MK+BJzFxH7o/4MSVytNPOuEJrUgIYis2e2kpXjqpChEjlnuYFNfkGQbssfDOByjGA9hECvZx1rNBU2OkA7CgqMl06Fj2jO0siBtl2GQO/8ffk4vZTYJ/5GHJvp6GQSLjtH1STZXbPWjSf4CFOcRQ==; s=purelymail3; d=purelymail.com; v=1; bh=l0BMAVH6pdL7QeljXhgleRWnnXefltLhtkkh9yhpQxI=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 34080 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 24776808; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Jul 2025 17:17:10 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 90F9494058B; Tue, 08 Jul 2025 18:17:09 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Van L <van@HIDDEN>, 34080 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>, Stefan Monnier <monnier@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* In-Reply-To: <87o8luoxls.fsf@HIDDEN> References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> <87o8luoxls.fsf@HIDDEN> Date: Tue, 08 Jul 2025 18:17:09 +0100 Message-ID: <87sej6haay.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34080 X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Putting aside the possible bug in where-is-internal, the basic issue in this report is how the TAB and <backtab> bindings don't appear in C-h m for *vc-diff* buffers. The reason for this is, I think, simple: C-h m describes the major mode's own map, diff-mode-map, but the TAB binding does not appear in that map. It's only in diff-mode-shared-map, the parent of diff-mode-map. We probably don't want C-h m to include bindings from the parents of major mode maps. Right? It seems like that would mean including too much. So I am wondering whether we should consider copying the bindings from diff-mode-shared-map into the maps that share it. It means more repetition in our definitions but better *Help* output. Usually we write these maps out longform even if it means duplication. But there is something about diff-mode-shared-map that I can't figure out. How do its bindings get overridden/deactivated in the case that the buffer is not read-only? Adding Stefan to the CC -- can you point me to what I'm missing about how diff-mode-shared-map is meant to work? Thanks. -- Sean Whitton
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 19 May 2025 17:51:03 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 19 13:51:03 2025 Received: from localhost ([127.0.0.1]:44079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uH4dj-0007ew-D9 for submit <at> debbugs.gnu.org; Mon, 19 May 2025 13:51:03 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35847) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uH4dg-0007dm-66 for 34080 <at> debbugs.gnu.org; Mon, 19 May 2025 13:51:01 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 89BA743D65; Mon, 19 May 2025 17:50:52 +0000 (UTC) From: Juri Linkov <juri@HIDDEN> To: Sean Whitton <spwhitton@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* In-Reply-To: <87ldqt2eb0.fsf@HIDDEN> Organization: LINKOV.NET References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> <87o8luoxls.fsf@HIDDEN> <871pspg9la.fsf@HIDDEN> <87h61lke66.fsf@HIDDEN> <87msba5jrt.fsf@HIDDEN> <87cyc53ysj.fsf@HIDDEN> <87ldqt2eb0.fsf@HIDDEN> Date: Mon, 19 May 2025 20:41:49 +0300 Message-ID: <874ixg1p8a.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefvddvtddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepieffteejgeehffejuedtiefhudekgeejteekiefgveeuheetvdefgeekkeevkedunecukfhppeeluddruddvledruddthedruddujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddthedruddujedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepfeegtdektdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-GND-Sasl: juri@HIDDEN X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >> The Info node (info "(elisp) Standard Properties") says: >> >> ‘:advertised-binding’ >> This property value specifies the preferred key binding, when >> showing documentation, for the named function. *Note Keys in >> Documentation::. >> >> Then the referred node (info "(elisp) Keys in Documentation") >> mentions 'substitute-command-keys' that I used in my example. >> OTOH, I can't find any reference to 'where-is-internal'. > > The only place in the code that makes reference to :advertised-binding > other than calls to `put' is in where-is-internal. I.e., > where-is-internal is where :advertised-binding is implemented. > > Do a 'C-x p g' for QCadvertised_binding. Indeed, I can't find more functions that use :advertised-binding.
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 19 May 2025 08:30:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 19 04:30:24 2025 Received: from localhost ([127.0.0.1]:37195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1uGvt9-0006bO-Vq for submit <at> debbugs.gnu.org; Mon, 19 May 2025 04:30:24 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:44840) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>) id 1uGvt7-0006Yv-Ii for 34080 <at> debbugs.gnu.org; Mon, 19 May 2025 04:30:22 -0400 DKIM-Signature: a=rsa-sha256; b=c/CJQvTgE10jWcA5XlyKjciH48ndorXhq51JpnaX8FyE+/GqA18axY8tShU0FU1rjog+WtSXH9x//Va92jEZoergFefvHN0BW5EfoetD4hQmmTEqgv9YkmmEfjSkNIH8S3SD/1vkwAdJHhfP/Z1xHDGlVhInfLN2mZG1WWtGnWcN3E8aPGGvvlJJBy69ymjjFaKB6Nn94CRMPqweNxPXCU9glNnR4VwX3dD88h3SO+wSy8ykX/pkNnSOT0PVI99OipWU1LsPc5z3a/078B0eqmpkZnbeHkkkFE2Shz3DVtz3pimrXSXXNgI+IWlInswYuyJaerWqoUkNlRHj0rkrIQ==; s=purelymail1; d=spwhitton.name; v=1; bh=4nC6cLutKC/x4CxaM82iOyB6pwOZBSqu1vube8s3zWc=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Y4W4aHhngIAdYwfjL4VXjQbVisb/Fzt5NwKb1HZ1csjXPlL+LCpqtWjqO3QtktRd4HRSAf9Rw9SmRdIlScUXtTlHGAdciPDo8MHoB36FRgwq8umVVQGT1g3Cwg0/5/82rsC8DEjspTH9KYSMUj5m/DPZTrXfwGcqIa3Pj51FWCVIaOY5gRf21ThAt2TySxzdIngk2CbeXCtTnH8aMiKLjEL+lrcS4Ueffu3aEuefYXHOpJnrk2qb6Ft0bMYzHOjH1JuDGvV3sXJCr+Gchoo+tCHOHy+NxC7FEzoNVtZcQBJZVzkohjSoY0p0MnnjdyJANUMQb4QlOBd+52ZBfUHFyg==; s=purelymail1; d=purelymail.com; v=1; bh=4nC6cLutKC/x4CxaM82iOyB6pwOZBSqu1vube8s3zWc=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 34080 <at> debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -638753374; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 19 May 2025 08:30:13 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id E6D8E9418A7; Mon, 19 May 2025 09:30:11 +0100 (BST) From: Sean Whitton <spwhitton@HIDDEN> To: Juri Linkov <juri@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* In-Reply-To: <87cyc53ysj.fsf@HIDDEN> References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> <87o8luoxls.fsf@HIDDEN> <871pspg9la.fsf@HIDDEN> <87h61lke66.fsf@HIDDEN> <87msba5jrt.fsf@HIDDEN> <87cyc53ysj.fsf@HIDDEN> Date: Mon, 19 May 2025 09:30:11 +0100 Message-ID: <87ldqt2eb0.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, On Mon 19 May 2025 at 09:30am +03, Juri Linkov wrote: > The Info node (info "(elisp) Standard Properties") says: > > =E2=80=98:advertised-binding=E2=80=99 > This property value specifies the preferred key binding, when > showing documentation, for the named function. *Note Keys in > Documentation::. > > Then the referred node (info "(elisp) Keys in Documentation") > mentions 'substitute-command-keys' that I used in my example. > OTOH, I can't find any reference to 'where-is-internal'. The only place in the code that makes reference to :advertised-binding other than calls to `put' is in where-is-internal. I.e., where-is-internal is where :advertised-binding is implemented. Do a 'C-x p g' for QCadvertised_binding. --=20 Sean Whitton
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 19 May 2025 06:49:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon May 19 02:49:00 2025
Received: from localhost ([127.0.0.1]:36387 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uGuJ1-00088M-LJ
for submit <at> debbugs.gnu.org; Mon, 19 May 2025 02:49:00 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55871)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uGuIy-000880-Ai
for 34080 <at> debbugs.gnu.org; Mon, 19 May 2025 02:48:57 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id E749243B82;
Mon, 19 May 2025 06:48:48 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
In-Reply-To: <87msba5jrt.fsf@HIDDEN>
Organization: LINKOV.NET
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
<87o8luoxls.fsf@HIDDEN> <871pspg9la.fsf@HIDDEN>
<87h61lke66.fsf@HIDDEN>
<87msba5jrt.fsf@HIDDEN>
Date: Mon, 19 May 2025 09:30:20 +0300
Message-ID: <87cyc53ysj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefvddtjedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepieffteejgeehffejuedtiefhudekgeejteekiefgveeuheetvdefgeekkeevkedunecukfhppeeluddruddvledruddthedruddujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddthedruddujedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepfeegtdektdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34080
Cc: 34080 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> Searching the code base, :advertised-binding is meant to affect
>>> where-is-internal, and only that function, I think.
>>> But it does seem to be broken:
>>>
>>> (progn (put 'diff-hunk-next :advertised-binding "n") ; or '("n")
>>> (with-current-buffer "*vc-diff*"
>>> (mapcar #'key-description
>>> (where-is-internal 'diff-hunk-next))))
>>>
>>> => ("TAB" "n" "C-M-i" "M-n" "<menu-bar> <diff> <Next Hunk>")
>>>
>>> i.e. there is no prioritisation for the "n" binding.
>>> Indeed, TAB comes first.
>>>
>>> Then it seems like a separate issue why the "TAB" binding is not
>>> appearing in 'M-x describe-mode'. So there are two problems here.
>>
>> There is no 'n' binding in 'diff-mode-map'. 'n' inherited
>> from 'diff-mode-shared-map' becomes 'M-n' (via the ESC prefix).
>> And its advertised-binding works correctly:
>>
>> (put 'diff-hunk-next :advertised-binding "\M-n")
>> (substitute-command-keys "Type `\\<diff-mode-map>\\[diff-hunk-next]'.")
>> => #("Type ‘M-n’." 6 9 (font-lock-face help-key-binding face help-key-binding))
>
> If you change "n" and "\M-n" in my example the return value of
> where-is-internal does not change. Therefore I think your example is
> working accidentally and there is still a problem here.
The Info node (info "(elisp) Standard Properties") says:
‘:advertised-binding’
This property value specifies the preferred key binding, when
showing documentation, for the named function. *Note Keys in
Documentation::.
Then the referred node (info "(elisp) Keys in Documentation")
mentions 'substitute-command-keys' that I used in my example.
OTOH, I can't find any reference to 'where-is-internal'.
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 18 May 2025 09:51:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 18 05:51:47 2025
Received: from localhost ([127.0.0.1]:55649 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uGagN-0007hy-08
for submit <at> debbugs.gnu.org; Sun, 18 May 2025 05:51:47 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:56084)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
id 1uGagK-0007hT-4n
for 34080 <at> debbugs.gnu.org; Sun, 18 May 2025 05:51:45 -0400
DKIM-Signature: a=rsa-sha256;
b=tjg2n+vPpiVPxOoOlZjTOykjlQ9wXIWz2XU4l1AUV9fT6vtNscSmE5QQ2XLuZvbmMG2NWUZ2WzHpye5Ms19JrEh2gAg4WsJJnPMmI0K+6VpLKVvOtEVYvUVdmvrwUo1zZQ6QVNkMc0AR4wFtxPFYx7ycU5IDqOcH00bc9tgs1ZwnH7F/IkTlCzIA1XyMVmYgYsHu31ydA2Zqx5vVWDZ0wgQrYUPlMAyepaJ/R6sta5lRu766PtKq/cWi3zX/c3Pp3zmy60iqFQfutthvmdJb+bUdzM7VDZeKslj5JsTnEB++FbsiVjfTuSZ7Nbdf2MTI9UseU2VKOv1Mk4kplBh+JQ==;
s=purelymail1; d=spwhitton.name; v=1;
bh=hdx6qQLME1/hgFV3QOg2k98IKWKyrcJ49fMIHWAHUwc=;
h=Received:Received:From:To:Subject:Date;
DKIM-Signature: a=rsa-sha256;
b=G5AMDLIXYGDrCJyti12gKd2GzC7CZeL70ZzsOL/KfXXW0tENZ6sPxQYM9zteVxye4NA4i3HqBKtfc5BlAknEBPljW4NP4wTw+yTT1nyCRHkZlcAgw1q/Zcu5rAp9VZgkRBoMAJKYAAVnimaY0uYzD/KVQchj0jyeJDqsde7PESAX3Aw87MybhrqUaqNi4KJxWtkXZrbEVWwAjOwtqG/HLtge8T7eNpIBfe9ptPVz4MHQGaSzS4DowMzZaRPJUWPTEUUA6hGdOCGxsAbqFw4bT6KOJQHzDWuQzOFYoDztLddBG9P7L6Ot1Mm0xmWvy+z9ckXGwKisSMs0xG6wLdi/FA==;
s=purelymail1; d=purelymail.com; v=1;
bh=hdx6qQLME1/hgFV3QOg2k98IKWKyrcJ49fMIHWAHUwc=;
h=Feedback-ID:Received:Received:From:To:Subject:Date;
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 34080 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 632226469;
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Sun, 18 May 2025 09:51:37 +0000 (UTC)
Received: by zephyr.silentflame.com (Postfix, from userid 1000)
id 8928794200C; Sun, 18 May 2025 10:51:34 +0100 (BST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
In-Reply-To: <87h61lke66.fsf@HIDDEN>
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
<87o8luoxls.fsf@HIDDEN> <871pspg9la.fsf@HIDDEN>
<87h61lke66.fsf@HIDDEN>
Date: Sun, 18 May 2025 10:51:34 +0100
Message-ID: <87msba5jrt.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34080
Cc: 34080 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
On Thu 15 May 2025 at 07:54pm +03, Juri Linkov wrote:
>> Searching the code base, :advertised-binding is meant to affect
>> where-is-internal, and only that function, I think.
>> But it does seem to be broken:
>>
>> (progn (put 'diff-hunk-next :advertised-binding "n") ; or '("n")
>> (with-current-buffer "*vc-diff*"
>> (mapcar #'key-description
>> (where-is-internal 'diff-hunk-next))))
>>
>> =3D> ("TAB" "n" "C-M-i" "M-n" "<menu-bar> <diff> <Next Hunk>")
>>
>> i.e. there is no prioritisation for the "n" binding.
>> Indeed, TAB comes first.
>>
>> Then it seems like a separate issue why the "TAB" binding is not
>> appearing in 'M-x describe-mode'. So there are two problems here.
>
> There is no 'n' binding in 'diff-mode-map'. 'n' inherited
> from 'diff-mode-shared-map' becomes 'M-n' (via the ESC prefix).
> And its advertised-binding works correctly:
>
> (put 'diff-hunk-next :advertised-binding "\M-n")
> (substitute-command-keys "Type `\\<diff-mode-map>\\[diff-hunk-next]'.")
> =3D> #("Type =E2=80=98M-n=E2=80=99." 6 9 (font-lock-face help-key-bindi=
ng face help-key-binding))
If you change "n" and "\M-n" in my example the return value of
where-is-internal does not change. Therefore I think your example is
working accidentally and there is still a problem here.
--=20
Sean Whitton
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 15 May 2025 16:55:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 15 12:55:44 2025
Received: from localhost ([127.0.0.1]:55516 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uFbs0-00038Q-8L
for submit <at> debbugs.gnu.org; Thu, 15 May 2025 12:55:44 -0400
Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:58473)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1uFbrw-00037J-VT
for 34080 <at> debbugs.gnu.org; Thu, 15 May 2025 12:55:42 -0400
Received: by mail.gandi.net (Postfix) with ESMTPSA id BD18943B35;
Thu, 15 May 2025 16:55:31 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
In-Reply-To: <871pspg9la.fsf@HIDDEN>
Organization: LINKOV.NET
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
<87o8luoxls.fsf@HIDDEN> <871pspg9la.fsf@HIDDEN>
Date: Thu, 15 May 2025 19:54:25 +0300
Message-ID: <87h61lke66.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-GND-State: clean
X-GND-Score: -100
X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdefuddtgeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepieffteejgeehffejuedtiefhudekgeejteekiefgveeuheetvdefgeekkeevkedunecukfhppeeluddruddvledruddthedruddujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeluddruddvledruddthedruddujedphhgvlhhopehmrghilhdrghgrnhguihdrnhgvthdpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepfeegtdektdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg
X-GND-Sasl: juri@HIDDEN
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34080
Cc: 34080 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
>>> +;; List key bindings for describe-mode
>>> +(put 'diff-hunk-next :advertised-binding [tab])
>>> +(put 'diff-hunk-prev :advertised-binding [(shift tab)])
>>> +
>>
>> I tried this patch, but `M-x describe-mode' in a *vc-diff* buffer did
>> not seem to care that much -- it listed diff-hunk-prev on M-p and ESC
>> <backtab> and -next on C-M-i/M-n only, with or without this patch.
>>
>> Is :advertised-binding not working here, or is ... er ... something else
>> wrong? The actual bindings are:
>>
>> ("\t" . diff-hunk-next)
>> ([backtab] . diff-hunk-prev)
>
> Searching the code base, :advertised-binding is meant to affect
> where-is-internal, and only that function, I think.
> But it does seem to be broken:
>
> (progn (put 'diff-hunk-next :advertised-binding "n") ; or '("n")
> (with-current-buffer "*vc-diff*"
> (mapcar #'key-description
> (where-is-internal 'diff-hunk-next))))
>
> => ("TAB" "n" "C-M-i" "M-n" "<menu-bar> <diff> <Next Hunk>")
>
> i.e. there is no prioritisation for the "n" binding.
> Indeed, TAB comes first.
>
> Then it seems like a separate issue why the "TAB" binding is not
> appearing in 'M-x describe-mode'. So there are two problems here.
There is no 'n' binding in 'diff-mode-map'. 'n' inherited
from 'diff-mode-shared-map' becomes 'M-n' (via the ESC prefix).
And its advertised-binding works correctly:
(put 'diff-hunk-next :advertised-binding "\M-n")
(substitute-command-keys "Type `\\<diff-mode-map>\\[diff-hunk-next]'.")
=> #("Type ‘M-n’." 6 9 (font-lock-face help-key-binding face help-key-binding))
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 15 May 2025 15:47:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu May 15 11:47:16 2025
Received: from localhost ([127.0.0.1]:55269 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uFanj-000369-NT
for submit <at> debbugs.gnu.org; Thu, 15 May 2025 11:47:16 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:33274)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
id 1uFanY-00034h-K2
for 34080 <at> debbugs.gnu.org; Thu, 15 May 2025 11:47:09 -0400
DKIM-Signature: a=rsa-sha256;
b=axVXwYqw0z1YY9dKB5AZFAIZ9qjQfsZnFwGB4A/aFpj2yd/a1LBrSqMm6nRLHAS7py3VqRLY9ZuguVooMu8JvwkVa5B8HF20xsRoIC6TEvx48q/nj/g8pUdA5DKdRWyTejVjh/kEBL8BYVmL9zTs4rbCYXuLM7TmEMrwMbexisGmAIJoNKIf56bNjR5MvDBrV2UlBaLRnJyPrCNZCevMJkqXKTnuhlPmoo/nnYIwh/Aqg9LjQtjsjzK7ysz9zoIkWiPfjwig8kxatwFkobGJA4BIIKJy8sef7aIg24ZSJJzvmB9oHlAneR160PlrAs86o5E5We8U3bGvrkjO2D8QiQ==;
s=purelymail1; d=spwhitton.name; v=1;
bh=Desa1HBieuRIRrOQWcclWQ42EIBvKhLSsTysDq9htlY=;
h=Received:Received:From:To:Subject:Date;
DKIM-Signature: a=rsa-sha256;
b=jjGtrs+saTO09xYAXxm8PhTSdz/pDx9XL0x9ciCiQmz3cb5evsX7bAuMuJS4/KkHYOe/e+LjRGxY/g+y6oyQD00IPkEdPk6t0CTGJC8jGrkODqPRz8mifq+cMd/Ap3ZkwG/UKKlhN3NDNnyo9rorWUH3ozoMnXap8O72nTXX979vvZ0Da65rAIovEl7i62ox/utJUXHhaD68RYQ/ljpjW+Fkx2zTLckFmJzQht/XnsB/CNioiHIXL64L+N5CfqXKheXz8zScDOPQ/K2Re+zqXIWp39bgbnPZl2tERE5NkMF2aqYRmR9O6JcjfuBNXxxk7hjvLvABL1YzA1yDhtGZRA==;
s=purelymail1; d=purelymail.com; v=1;
bh=Desa1HBieuRIRrOQWcclWQ42EIBvKhLSsTysDq9htlY=;
h=Feedback-ID:Received:Received:From:To:Subject:Date;
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 34080 <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -46290191;
(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
Thu, 15 May 2025 15:46:58 +0000 (UTC)
Received: by zephyr.silentflame.com (Postfix, from userid 1000)
id 6DB709403C3; Thu, 15 May 2025 16:46:57 +0100 (BST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Van L <van@HIDDEN>, 34080 <at> debbugs.gnu.org, Juri Linkov
<juri@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
In-Reply-To: <87o8luoxls.fsf@HIDDEN>
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
<87o8luoxls.fsf@HIDDEN>
Date: Thu, 15 May 2025 16:46:57 +0100
Message-ID: <871pspg9la.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34080
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello,
On Fri 25 Sep 2020 at 02:21pm +02, Lars Ingebrigtsen wrote:
> Van L <van@HIDDEN> writes:
>
>> +;; List key bindings for describe-mode
>> +(put 'diff-hunk-next :advertised-binding [tab])
>> +(put 'diff-hunk-prev :advertised-binding [(shift tab)])
>> +
>
> I tried this patch, but `M-x describe-mode' in a *vc-diff* buffer did
> not seem to care that much -- it listed diff-hunk-prev on M-p and ESC
> <backtab> and -next on C-M-i/M-n only, with or without this patch.
>
> Is :advertised-binding not working here, or is ... er ... something else
> wrong? The actual bindings are:
>
> ("\t" . diff-hunk-next)
> ([backtab] . diff-hunk-prev)
Searching the code base, :advertised-binding is meant to affect
where-is-internal, and only that function, I think.
But it does seem to be broken:
(progn (put 'diff-hunk-next :advertised-binding "n") ; or '("n")
(with-current-buffer "*vc-diff*"
(mapcar #'key-description
(where-is-internal 'diff-hunk-next))))
=> ("TAB" "n" "C-M-i" "M-n" "<menu-bar> <diff> <Next Hunk>")
i.e. there is no prioritisation for the "n" binding.
Indeed, TAB comes first.
Then it seems like a separate issue why the "TAB" binding is not
appearing in 'M-x describe-mode'. So there are two problems here.
--
Sean Whitton
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 25 Sep 2020 12:22:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Sep 25 08:22:04 2020
Received: from localhost ([127.0.0.1]:42983 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1kLmjk-0007DS-HT
for submit <at> debbugs.gnu.org; Fri, 25 Sep 2020 08:22:04 -0400
Received: from quimby.gnus.org ([95.216.78.240]:39514)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <larsi@HIDDEN>) id 1kLmji-0007Cz-Ii
for 34080 <at> debbugs.gnu.org; Fri, 25 Sep 2020 08:22:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:
References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=EUZ0RBAw75bN5LasROo5XAIF20ef2dCS/cekvabT3fs=; b=JVpY3tKova3f2B5bAsxisoZEjD
W19vwOTdZAPNMaeOTJp2cCN9knuMaMHtaR3sRzP5Ul8gbKJtrchLM3FOIbdxSSe5b8TmXgK6hnTT0
Xat9PvoRQ1oeRFQ3JwdXj8hsctQGLGYtWiemy4XJTB/yxrHq0FjJEXBhXhjlxYfxcCYE=;
Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo)
by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.92) (envelope-from <larsi@HIDDEN>)
id 1kLmjZ-0002Ad-EW; Fri, 25 Sep 2020 14:21:56 +0200
From: Lars Ingebrigtsen <larsi@HIDDEN>
To: Van L <van@HIDDEN>
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
<0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
X-Now-Playing: The Human League's _Original Remixes & Rarities_: "Non-Stop"
Date: Fri, 25 Sep 2020 14:21:51 +0200
In-Reply-To: <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> (Van L.'s
message of "Mon, 21 Jan 2019 09:28:05 +1100")
Message-ID: <87o8luoxls.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
@@CONTACT_ADDRESS@@ for details.
Content preview: Van L <van@HIDDEN> writes: > +;; List key bindings
for describe-mode > +(put 'diff-hunk-next :advertised-binding [tab]) > +(put
'diff-hunk-prev :advertised-binding [(shift tab)]) > + I tried this patch,
but `M-x describe-mode' in a *vc-diff* buffer did not seem to care that much
-- it listed diff-hunk-prev on M-p and ESC <backtab> and -next on C-M-i/M-n
only, with or without this [...]
Content analysis details: (-2.9 points, 5.0 required)
pts rule name description
---- ---------------------- --------------------------------------------------
-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%
[score: 0.0000]
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 34080
Cc: 34080 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Van L <van@HIDDEN> writes:
> +;; List key bindings for describe-mode
> +(put 'diff-hunk-next :advertised-binding [tab])
> +(put 'diff-hunk-prev :advertised-binding [(shift tab)])
> +
I tried this patch, but `M-x describe-mode' in a *vc-diff* buffer did
not seem to care that much -- it listed diff-hunk-prev on M-p and ESC
<backtab> and -next on C-M-i/M-n only, with or without this patch.
Is :advertised-binding not working here, or is ... er ... something else
wrong? The actual bindings are:
("\t" . diff-hunk-next)
([backtab] . diff-hunk-prev)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 12 Oct 2019 23:05:41 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 12 19:05:41 2019 Received: from localhost ([127.0.0.1]:34467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1iJQSD-0007Ea-6p for submit <at> debbugs.gnu.org; Sat, 12 Oct 2019 19:05:41 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1iJQSB-0007ER-Or for 34080 <at> debbugs.gnu.org; Sat, 12 Oct 2019 19:05:40 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1iJQS7-00016X-6q; Sun, 13 Oct 2019 01:05:38 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Van L <van@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87mue5h8jq.fsf@HIDDEN> Date: Sun, 13 Oct 2019 01:05:34 +0200 In-Reply-To: <87mue5h8jq.fsf@HIDDEN> (Lars Ingebrigtsen's message of "Sun, 13 Oct 2019 01:02:17 +0200") Message-ID: <87imoth8e9.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen <larsi@HIDDEN> writes: > Van L <van@HIDDEN> writes: > >> The *Help* buffer for diff-mode.el is better >> if the following key bindings are documented >> >> #+NAME: undocumented-key-bindings >> | key | binding | >> >> [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Lars Ingebrigtsen <larsi@HIDDEN> writes: > Van L <van@HIDDEN> writes: > >> The *Help* buffer for diff-mode.el is better >> if the following key bindings are documented >> >> #+NAME: undocumented-key-bindings >> | key | binding | >> >> |-------+----------------| >> | TAB | diff-hunk-next | >> | S-TAB | diff-hunk-prev | > > There are several modes defined in diff-mode.el. > > Do you mean `diff-mode' itself? TAB is not bound in `diff-mode', as far > as I can tell. It wasn't bound if I said `M-x diff-mode', but it is bound in *vc-diff* buffers... And if I `C-h b' in that buffer, I get key binding --- ------- TAB diff-hunk-next [...] <backtab> diff-hunk-prev But it's right that they are not listed in `C-h m'. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 12 Oct 2019 23:02:25 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Oct 12 19:02:25 2019 Received: from localhost ([127.0.0.1]:34463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1iJQP2-00076d-Mk for submit <at> debbugs.gnu.org; Sat, 12 Oct 2019 19:02:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:42150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <larsi@HIDDEN>) id 1iJQP0-000750-Uv for 34080 <at> debbugs.gnu.org; Sat, 12 Oct 2019 19:02:23 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from <larsi@HIDDEN>) id 1iJQOw-00015S-DL; Sun, 13 Oct 2019 01:02:20 +0200 From: Lars Ingebrigtsen <larsi@HIDDEN> To: Van L <van@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> Date: Sun, 13 Oct 2019 01:02:17 +0200 In-Reply-To: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> (Van L.'s message of "Tue, 15 Jan 2019 16:29:56 +1100") Message-ID: <87mue5h8jq.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Van L <van@HIDDEN> writes: > The *Help* buffer for diff-mode.el is better > if the following key bindings are documented > > #+NAME: undocumented-key-bindings > | key | binding | > > |-------+| > | TAB | diff-hu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Van L <van@HIDDEN> writes: > The *Help* buffer for diff-mode.el is better > if the following key bindings are documented > > #+NAME: undocumented-key-bindings > | key | binding | > > |-------+----------------| > | TAB | diff-hunk-next | > | S-TAB | diff-hunk-prev | There are several modes defined in diff-mode.el. Do you mean `diff-mode' itself? TAB is not bound in `diff-mode', as far as I can tell. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 22 Jan 2019 02:59:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 21 21:59:47 2019 Received: from localhost ([127.0.0.1]:40690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1glmHy-00049v-RK for submit <at> debbugs.gnu.org; Mon, 21 Jan 2019 21:59:47 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:54817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <van@HIDDEN>) id 1glmHx-00049m-1b for 34080 <at> debbugs.gnu.org; Mon, 21 Jan 2019 21:59:46 -0500 X-Originating-IP: 193.119.71.194 Received: from epi.local (193-119-71-194.tpgi.com.au [193.119.71.194]) (Authenticated sender: van@HIDDEN) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id D5666240003; Tue, 22 Jan 2019 02:59:41 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* From: Van L <van@HIDDEN> In-Reply-To: <878szdzs1h.fsf@HIDDEN> Date: Tue, 22 Jan 2019 13:59:36 +1100 Content-Transfer-Encoding: quoted-printable Message-Id: <B032C13D-956D-48D5-AD33-79CD33B2D272@HIDDEN> References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> <878szdzs1h.fsf@HIDDEN> To: Juri Linkov <juri@HIDDEN> X-Mailer: Apple Mail (2.3124) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) >>> (put 'diff-hunk-next :advertised-binding [tab]) >>> (put 'diff-hunk-prev :advertised-binding [(shift tab)]) >>=20 >> The above, I've put in a patch for emacs-mac port, see below. >=20 > Please attach the output after this change. I would be interesting > to see how it is formatted on emacs-mac port. =E2=80=94 quote Compiling = /Applications/MacPorts/EmacsMac.app/Contents/Resources/lisp/vc/diff-mode.e= l.gz...done Wrote = /Applications/MacPorts/EmacsMac.app/Contents/Resources/lisp/vc/diff-mode.e= lc =E2=80=94 quote ends The change has had no desired effect. : ESC <backtab> diff-hunk-prev There is that, from describe-mode by searching for 'tab.=
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 21 Jan 2019 21:00:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Jan 21 16:00:37 2019 Received: from localhost ([127.0.0.1]:40566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1glggN-0001vJ-82 for submit <at> debbugs.gnu.org; Mon, 21 Jan 2019 16:00:37 -0500 Received: from ostrich.birch.relay.mailchannels.net ([23.83.209.138]:1668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1glggK-0001v8-9D for 34080 <at> debbugs.gnu.org; Mon, 21 Jan 2019 16:00:33 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1D91F124F4E; Mon, 21 Jan 2019 21:00:29 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 574AF125139; Mon, 21 Jan 2019 21:00:24 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from pdx1-sub0-mail-a6.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Mon, 21 Jan 2019 21:00:25 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Versed-Bottle: 18bfc4142255c002_1548104424920_370601990 X-MC-Loop-Signature: 1548104424919:23902013 X-MC-Ingress-Time: 1548104424919 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 9A08480722; Mon, 21 Jan 2019 13:00:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=9K1NzZaQLEBuUBf7gJasTJIUxYk=; b= FNP7S6iBL8aXWbP2fjHIednYobLO+1LrEpimJ3s2EooYeJDx/WYiCQhCsniu2rwu ybQqJUq1L0Ve9GR9B1aV46+F8XnLrHnaSOu3Sogqyg22dvBRWkPBlinb9ldpe7FT b+ugXU+TKdS7kVbzFQgewa00AP6aSv8qzgpvbSNNIWA= Received: from mail.jurta.org (m91-129-101-91.cust.tele2.ee [91.129.101.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@HIDDEN) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 088E08071E; Mon, 21 Jan 2019 13:00:21 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov <juri@HIDDEN> To: Van L <van@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* Organization: LINKOV.NET References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> Date: Mon, 21 Jan 2019 22:35:06 +0200 In-Reply-To: <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN> (Van L.'s message of "Mon, 21 Jan 2019 09:28:05 +1100") Message-ID: <878szdzs1h.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrheeigddugeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtuddrledunecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtuddrledupdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvhgrnhesshgtrhgrthgthhdrshhprggtvgenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) >> (put 'diff-hunk-next :advertised-binding [tab]) >> (put 'diff-hunk-prev :advertised-binding [(shift tab)]) > > The above, I've put in a patch for emacs-mac port, see below. Please attach the output after this change. I would be interesting to see how it is formatted on emacs-mac port.
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
Received: (at 34080) by debbugs.gnu.org; 20 Jan 2019 22:28:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 20 17:28:18 2019
Received: from localhost ([127.0.0.1]:39253 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1glLZi-0006aI-Ba
for submit <at> debbugs.gnu.org; Sun, 20 Jan 2019 17:28:18 -0500
Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35775)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <van@HIDDEN>) id 1glLZd-0006a4-Oo
for 34080 <at> debbugs.gnu.org; Sun, 20 Jan 2019 17:28:14 -0500
X-Originating-IP: 193.119.71.194
Received: from epi.local (193-119-71-194.tpgi.com.au [193.119.71.194])
(Authenticated sender: van@HIDDEN)
by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 03D70C0002;
Sun, 20 Jan 2019 22:28:10 +0000 (UTC)
Content-Type: multipart/mixed;
boundary="Apple-Mail=_DD756449-535D-4C37-8849-012DD2C21B13"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff*
From: Van L <van@HIDDEN>
In-Reply-To: <87k1j0fhlo.fsf@HIDDEN>
Date: Mon, 21 Jan 2019 09:28:05 +1100
Message-Id: <0D591EDD-EF52-494D-9C99-4AEFE1214B28@HIDDEN>
References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN>
<87k1j0fhlo.fsf@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
X-Mailer: Apple Mail (2.3124)
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 34080
Cc: 34080 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
--Apple-Mail=_DD756449-535D-4C37-8849-012DD2C21B13
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
> (put 'diff-hunk-next :advertised-binding [tab])
> (put 'diff-hunk-prev :advertised-binding [(shift tab)])
The above, I've put in a patch for emacs-mac port, see below.
The development master as of now has
=E2=80=94 quote
(easy-mmode-defmap diff-mode-shared-map
'(("n" . diff-hunk-next)
("N" . diff-file-next)
("p" . diff-hunk-prev)
("P" . diff-file-prev)
("\t" . diff-hunk-next)
([backtab] . diff-hunk-prev)
=E2=80=94 quote ends
--Apple-Mail=_DD756449-535D-4C37-8849-012DD2C21B13
Content-Disposition: attachment;
filename=0005-List-key-bindings-for-describe-mode.patch
Content-Type: application/octet-stream;
name="0005-List-key-bindings-for-describe-mode.patch"
Content-Transfer-Encoding: quoted-printable
=46rom=2067b38816cf2cb81655adeb5b0d941141a8872dcd=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Van=20L=20<van@HIDDEN>=0ADate:=20Mon,=20=
21=20Jan=202019=2009:02:49=20+1100=0ASubject:=20[PATCH=205/5]=20List=20=
key=20bindings=20for=20describe-mode=0A=0ADocuments=20the=20TAB,=20=
SHIFT-TAB=20behavior=20for=20stepping=20through=20hunks.=0A---=0A=20=
lisp/vc/diff-mode.el=20|=204=20++++=0A=201=20file=20changed,=204=20=
insertions(+)=0A=0Adiff=20--git=20a/lisp/vc/diff-mode.el=20=
b/lisp/vc/diff-mode.el=0Aindex=207db5ca9b25..ce3277adf5=20100644=0A---=20=
a/lisp/vc/diff-mode.el=0A+++=20b/lisp/vc/diff-mode.el=0A@@=20-587,6=20=
+587,10=20@@=20diff-end-of-file=0A=20=0A=20(defvar=20=
diff--auto-refine-data=20nil)=0A=20=0A+;;=20List=20key=20bindings=20for=20=
describe-mode=0A+(put=20'diff-hunk-next=20:advertised-binding=20[tab])=0A=
+(put=20'diff-hunk-prev=20:advertised-binding=20[(shift=20tab)])=0A+=0A=20=
;;=20Define=20diff-{hunk,file}-{prev,next}=0A=20=
(easy-mmode-define-navigation=0A=20=20diff-hunk=20diff-hunk-header-re=20=
"hunk"=20diff-end-of-hunk=20diff-restrict-view=0A--=20=0A2.20.1=0A=0A=
--Apple-Mail=_DD756449-535D-4C37-8849-012DD2C21B13--
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 20 Jan 2019 13:25:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Jan 20 08:25:33 2019 Received: from localhost ([127.0.0.1]:38387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1glD6S-0000g5-SQ for submit <at> debbugs.gnu.org; Sun, 20 Jan 2019 08:25:33 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <van@HIDDEN>) id 1glD6P-0000fv-Pr for 34080 <at> debbugs.gnu.org; Sun, 20 Jan 2019 08:25:30 -0500 X-Originating-IP: 193.119.71.194 Received: from epi.local (193-119-71-194.tpgi.com.au [193.119.71.194]) (Authenticated sender: van@HIDDEN) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id B126DFF803; Sun, 20 Jan 2019 13:25:26 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* From: Van L <van@HIDDEN> In-Reply-To: <87k1j0fhlo.fsf@HIDDEN> Date: Mon, 21 Jan 2019 00:25:21 +1100 Content-Transfer-Encoding: quoted-printable Message-Id: <63590A5E-C434-4C48-A20A-23D5F9D414D5@HIDDEN> References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> <87k1j0fhlo.fsf@HIDDEN> To: Juri Linkov <juri@HIDDEN> X-Mailer: Apple Mail (2.3124) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) > Juri Linkov wrote: >=20 >> And, for the word "hunk" to link to a Glossary's >> entry like for example >>=20 >> http://www-history.mcs.st-and.ac.uk/Glossary/oblong_number.html >>=20 >> is a feature to have unless it is already therein. >=20 > Better to link to the Info manual (info "(diffutils) Hunks=E2=80=9D) The Emacs=E2=80=99s Concept Index leads to (info =E2=80=9C(emacs) Diff = Mode=E2=80=9D) paragraph two, where hunk is explained. I was hoping for a Glossary at the same level as Concept Index in the = Info navigation.=20 It would collect single paragraph explanations for easy finding, = perhaps, the top-100 most frequently used jargonwords. My plain Emacs and Slime installation doesn=E2=80=99t have diffutils in = Info docs, but *vc-diff* works.
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at 34080) by debbugs.gnu.org; 19 Jan 2019 21:55:49 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Jan 19 16:55:49 2019 Received: from localhost ([127.0.0.1]:38121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gkyaj-0004tq-0R for submit <at> debbugs.gnu.org; Sat, 19 Jan 2019 16:55:49 -0500 Received: from purple.birch.relay.mailchannels.net ([23.83.209.150]:15357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <juri@HIDDEN>) id 1gkyag-0004tf-L9 for 34080 <at> debbugs.gnu.org; Sat, 19 Jan 2019 16:55:48 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 15D6D1244F1; Sat, 19 Jan 2019 21:55:45 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (unknown [100.96.35.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C30CD123996; Sat, 19 Jan 2019 21:55:44 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@HIDDEN Received: from pdx1-sub0-mail-a6.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 19 Jan 2019 21:55:45 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@HIDDEN X-MailChannels-Auth-Id: dreamhost X-Decisive-Turn: 66e8cee257b12e57_1547934944884_3179194543 X-MC-Loop-Signature: 1547934944884:268352029 X-MC-Ingress-Time: 1547934944884 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 88F5480B31; Sat, 19 Jan 2019 13:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=zJX4uwHbrINNfZ8RIS6xWttMpGQ=; b= 05If2VFD9hgOHSkPUZJt5c45gNr2dTOFZM9S9pn/TyOJVR0CDK2ZN59onGT2s78u S7pboQ5An5moM4dMPD7SMVoABxXZEqHhjwjaolKqCPvSIvLv9oU6rP8x04HsOL93 UId6zctkPWoSVC2ko0zAIHbdUKlDEVlkSylzgvp8CfA= Received: from mail.jurta.org (m91-129-101-91.cust.tele2.ee [91.129.101.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@HIDDEN) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 2900480B10; Sat, 19 Jan 2019 13:55:41 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov <juri@HIDDEN> To: Van L <van@HIDDEN> Subject: Re: bug#34080: 27.0.50, 26.1; undocumented key bindings for *vc-diff* Organization: LINKOV.NET References: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> Date: Sat, 19 Jan 2019 23:24:03 +0200 In-Reply-To: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> (Van L.'s message of "Tue, 15 Jan 2019 16:29:56 +1100") Message-ID: <87k1j0fhlo.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtledrhedvgdduheejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuffhomhgrihhnpehsthdqrghnugdrrggtrdhukhenucfkphepledurdduvdelrddutddurdeludenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutddurdeluddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehvrghnsehstghrrghttghhrdhsphgrtggvnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 34080 Cc: 34080 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) > The *Help* buffer for diff-mode.el is better > if the following key bindings are documented > > #+NAME: undocumented-key-bindings > | key | binding | > > |-------+----------------| > | TAB | diff-hunk-next | > | S-TAB | diff-hunk-prev | > > the above make more sense than the following > > #+NAME: existing-key-bindings-documented > | key | binding | > > |-------+----------------| > | C-M-i | diff-hunk-next | > | M-n | | > |-------+----------------| > | M-p | diff-hunk-prev | It seems what you want is: (put 'diff-hunk-next :advertised-binding [tab]) (put 'diff-hunk-prev :advertised-binding [(shift tab)]) > And, for the word "hunk" to link to a Glossary's > entry like for example > > http://www-history.mcs.st-and.ac.uk/Glossary/oblong_number.html > > is a feature to have unless it is already therein. Better to link to the Info manual (info "(diffutils) Hunks")
bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 15 Jan 2019 05:30:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jan 15 00:30:24 2019 Received: from localhost ([127.0.0.1]:59482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1gjHIu-00041k-3x for submit <at> debbugs.gnu.org; Tue, 15 Jan 2019 00:30:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <van@HIDDEN>) id 1gjHIr-00041U-SP for submit <at> debbugs.gnu.org; Tue, 15 Jan 2019 00:30:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:34103) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <van@HIDDEN>) id 1gjHIl-0006wF-6J for submit <at> debbugs.gnu.org; Tue, 15 Jan 2019 00:30:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <van@HIDDEN>) id 1gjHIk-00029N-AO for bug-gnu-emacs@HIDDEN; Tue, 15 Jan 2019 00:30:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <van@HIDDEN>) id 1gjHIi-0006uI-8c for bug-gnu-emacs@HIDDEN; Tue, 15 Jan 2019 00:30:14 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43753) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <van@HIDDEN>) id 1gjHIe-0006oj-F0 for bug-gnu-emacs@HIDDEN; Tue, 15 Jan 2019 00:30:10 -0500 X-Originating-IP: 193.82.248.193 Received: from epi.local (193-82-248-193.tpgi.com.au [193.82.248.193]) (Authenticated sender: van@HIDDEN) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id ADBF720008 for <bug-gnu-emacs@HIDDEN>; Tue, 15 Jan 2019 05:30:01 +0000 (UTC) From: Van L <van@HIDDEN> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: 27.0.50, 26.1; undocumented key bindings for *vc-diff* Message-Id: <F8AB512C-A05B-4C42-A34F-0CC5AD56B9BB@HIDDEN> Date: Tue, 15 Jan 2019 16:29:56 +1100 To: bug-gnu-emacs@HIDDEN Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.70.183.200 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -0.3 (/) Hello, The *Help* buffer for diff-mode.el is better if the following key bindings are documented #+NAME: undocumented-key-bindings | key | binding | |-------+----------------| | TAB | diff-hunk-next | | S-TAB | diff-hunk-prev | the above make more sense than the following #+NAME: existing-key-bindings-documented | key | binding | |-------+----------------| | C-M-i | diff-hunk-next | | M-n | | |-------+----------------| | M-p | diff-hunk-prev | And, for the word "hunk" to link to a Glossary's entry like for example http://www-history.mcs.st-and.ac.uk/Glossary/oblong_number.html is a feature to have unless it is already therein.
Van L <van@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#34080; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.